#metabrainz

/

      • alastairp
      • 2021-05-27 14734, 2021

      • alastairp
        listenbrainz is still up!
      • 2021-05-27 14754, 2021

      • ruaok
        zas: entry for kiss added to metabrainz.org domain records.
      • 2021-05-27 14707, 2021

      • alastairp updates .ssh/config
      • 2021-05-27 14718, 2021

      • zas
        ruaok: ok, thanks. Server not visible yet in hetzner interface
      • 2021-05-27 14750, 2021

      • alastairp
      • 2021-05-27 14720, 2021

      • ruaok
        zas: we got pings!
      • 2021-05-27 14709, 2021

      • zas
        yup
      • 2021-05-27 14736, 2021

      • ruaok
        I can't login yet. I wonder if they are rescue mode
      • 2021-05-27 14734, 2021

      • ruaok
        looks like it is rebooting now.
      • 2021-05-27 14704, 2021

      • ruaok
        its back, but I still can't login.
      • 2021-05-27 14721, 2021

      • alastairp
        lucifer: can you double-check kiss.sh versions on https://github.com/metabrainz/docker-server-confi… ?
      • 2021-05-27 14727, 2021

      • ruaok
        zas: root passwd in mail
      • 2021-05-27 14732, 2021

      • zas
        yup
      • 2021-05-27 14756, 2021

      • ruaok
        ok, go for it, zas. let us know when its done.
      • 2021-05-27 14706, 2021

      • ruaok
        I'll stay out of your way.
      • 2021-05-27 14744, 2021

      • ruaok
        fuck, you're right we didn't order the extra nic
      • 2021-05-27 14754, 2021

      • lucifer
        alastairp: reviewed.
      • 2021-05-27 14701, 2021

      • lucifer
        ruaok, we also need the policy on beta and test so let's remember to update those when kiss comes up.
      • 2021-05-27 14720, 2021

      • ruaok
        k
      • 2021-05-27 14731, 2021

      • BrainzGit
        [listenbrainz-server] 14alastair opened pull request #1487 (03master…dumps-no-mount-check): Remove check for mounted dumps location https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14756, 2021

      • ruaok
        zas: I've opened the request to have the second nic installed.
      • 2021-05-27 14712, 2021

      • alastairp
        lucifer: 27.0 is the current latest?
      • 2021-05-27 14716, 2021

      • lucifer
        yes
      • 2021-05-27 14720, 2021

      • zas
        ruaok: ooops ;)
      • 2021-05-27 14721, 2021

      • ruaok
        we'll need to shut it down again, once they come back to me on that.
      • 2021-05-27 14739, 2021

      • alastairp
        oh wait. I thought I set that to 27.0 werid
      • 2021-05-27 14702, 2021

      • alastairp
        ohh, I set cron to 27.0 and skipped web. that's it
      • 2021-05-27 14712, 2021

      • lucifer
        yup
      • 2021-05-27 14727, 2021

      • alastairp
        we need to deploy 1487 anyway
      • 2021-05-27 14742, 2021

      • lucifer
        right
      • 2021-05-27 14750, 2021

      • alastairp
        so let me just update all containers to 27.1 now
      • 2021-05-27 14717, 2021

      • lucifer
        i am hoping for blitz build because no dependency changed 🤞
      • 2021-05-27 14731, 2021

      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #1418 (03master…importer-progress-bar): Importer Progress Bar https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14752, 2021

      • monkey
        Sneaking another PR in
      • 2021-05-27 14710, 2021

      • BrainzGit
        [listenbrainz-server] 14alastair merged pull request #1487 (03master…dumps-no-mount-check): Remove check for mounted dumps location https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14733, 2021

      • alastairp
        lucifer: want to try and make the release?
      • 2021-05-27 14756, 2021

      • lucifer
        alastairp: sure, i think we can get another two PRs in. 1479 and 1480, should we get those in first?
      • 2021-05-27 14713, 2021

      • alastairp
        looking
      • 2021-05-27 14722, 2021

      • Freso
        Anyone want to volunteer as test subject?
      • 2021-05-27 14716, 2021

      • alastairp
        what does it ban on? name or ip?
      • 2021-05-27 14735, 2021

      • Freso
        alastairp: Your account, for the purpose of this test.
      • 2021-05-27 14756, 2021

      • lucifer
        🙋‍♂️
      • 2021-05-27 14709, 2021

      • alastairp
        what's an account? nickserv?
      • 2021-05-27 14721, 2021

      • kartik joined the channel
      • 2021-05-27 14741, 2021

      • kartik
        nickserv it is :D
      • 2021-05-27 14750, 2021

      • Freso
        alastairp: Yeah. :)
      • 2021-05-27 14757, 2021

      • lucifer joined the channel
      • 2021-05-27 14707, 2021

      • Freso
        Alright, looks like it’s working. Great. :)
      • 2021-05-27 14707, 2021

      • kartik has left the channel
      • 2021-05-27 14719, 2021

      • Freso
        Thanks lucifer!
      • 2021-05-27 14717, 2021

      • alastairp
      • 2021-05-27 14736, 2021

      • alastairp
        I'm currently running tests locally to check https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14742, 2021

      • alastairp
        but looks ok
      • 2021-05-27 14711, 2021

      • lucifer
        cool, should work. i had checked the CI logs and its fine there. msb tests still run as expected.
      • 2021-05-27 14743, 2021

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1480 (03master…do-not-sanitise): LB-767: stop 'sanitising' docker compose container names https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14733, 2021

      • lucifer
        alastairp: https://github.com/metabrainz/listenbrainz-server… i agree we should be consistent. but can we consistently start using f-strings instead, % seems like python2 way of formatting?
      • 2021-05-27 14749, 2021

      • alastairp
        in short, no.
      • 2021-05-27 14730, 2021

      • alastairp
        this is what I was commenting in the previous PR, we should decide how we want to do logging. either we do their recommendation and don't do string interpolation and let the log function do it. in that case we have to use %, because that's all that's supported
      • 2021-05-27 14743, 2021

      • alastairp
        otherwise we interpolate it ourselves and use .format or f-string
      • 2021-05-27 14757, 2021

      • yvanzo
        Updating beta.mb.o
      • 2021-05-27 14702, 2021

      • alastairp
        as I mentioned, I don't really mind what way we do it, but we should be consistent
      • 2021-05-27 14727, 2021

      • alastairp
        (the reason that you do the `debug("some % string % here", param1, param2)` is so that you _don't_ have to do the interpolation if your debug level is such that you're not going to output anything - in the bad old days when string interpolation was expensive this made your code run faster)
      • 2021-05-27 14756, 2021

      • alastairp
        oh - maybe I'm wrong. just looking into this in more detail now. it seems that you might be able to use {} placeholders in logging functions
      • 2021-05-27 14708, 2021

      • alastairp
      • 2021-05-27 14703, 2021

      • lucifer
        alastairp: sorry. i had confused your % formatting comment with something else. debug("Hello %s", " World!") is fine. i meant to use f-string in cases outside logging, at a few places we do stuff like "%s %s" % (a, b). i was wanting to suggest using f-strings there.
      • 2021-05-27 14740, 2021

      • alastairp
        yes, right. there's _another_ question to open about how we do string interpolation in general :)
      • 2021-05-27 14751, 2021

      • alastairp
        sorry, my comment on that PR was specifically about formatting in logging calls
      • 2021-05-27 14710, 2021

      • atj
        ruaok: During this connection process ListenBrainz will request permissions to view your YouTube profile data. During the connection process ListenBrainz will request permissions to view your YouTube profile data.
      • 2021-05-27 14740, 2021

      • ruaok
        fun.
      • 2021-05-27 14737, 2021

      • ruaok
        lucifer: ^^ 🤦 fixed in master now.
      • 2021-05-27 14753, 2021

      • lucifer
        just in time for the next release :D
      • 2021-05-27 14747, 2021

      • ruaok
        sigh, hetzner.
      • 2021-05-27 14748, 2021

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1479 (03master…lower-log-level): Log recommendations without users to debug only https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14714, 2021

      • ruaok
        you didn't rub your tummy before spinning around waving the dead chicken in the air.
      • 2021-05-27 14724, 2021

      • ruaok
        your request is DENIED.
      • 2021-05-27 14726, 2021

      • BrainzGit
        [listenbrainz-server] release 03v-2021-05-27.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2021-05-27 14753, 2021

      • nelgin
        yvanzo? Did you see the issues I mentioned yesterday?
      • 2021-05-27 14745, 2021

      • ruaok
        hetzner> If you require this as well on the new one, you may please submit a separate support request.
      • 2021-05-27 14755, 2021

      • ruaok
        what in the actual fuck is going on now?
      • 2021-05-27 14712, 2021

      • alastairp
      • 2021-05-27 14720, 2021

      • lucifer
        built in ~3m45s, js was recompiled and that took almost ~1.5min so ~2min if only python code changes without dep changes.
      • 2021-05-27 14747, 2021

      • alastairp
        well done lucifer, this looks like it'll work great for us
      • 2021-05-27 14707, 2021

      • alastairp
        let's try and get an irc bot next that lets us make a release automatically :)
      • 2021-05-27 14704, 2021

      • lucifer
        yup, that's up next :D
      • 2021-05-27 14738, 2021

      • lucifer
        i'll wait for another couple of releases to be safe and then add the action to all other PythonBrainz
      • 2021-05-27 14728, 2021

      • alastairp
        ruaok: where are we at?
      • 2021-05-27 14739, 2021

      • alastairp
        30k items in listen queue, maybe we should start up the writer after all
      • 2021-05-27 14741, 2021

      • ruaok
        waiting on hetzner.
      • 2021-05-27 14749, 2021

      • alastairp
        ok, going for it
      • 2021-05-27 14737, 2021

      • ruaok
        zas: pings!
      • 2021-05-27 14723, 2021

      • Guest7322 has quit
      • 2021-05-27 14727, 2021

      • ruaok
        the machine is up, eth1 not configured. I supposed that is expected.
      • 2021-05-27 14712, 2021

      • ruaok
        are the nics behaving, zas?
      • 2021-05-27 14754, 2021

      • zas
        yes, I'm on it, that will take some time, I need to update a bunch of things
      • 2021-05-27 14740, 2021

      • lucifer
        alastairp: available for discussing on making request consumer a daemon
      • 2021-05-27 14748, 2021

      • lucifer
        ?
      • 2021-05-27 14700, 2021

      • alastairp
        what's the request consumer?
      • 2021-05-27 14719, 2021

      • alastairp
        (yes)
      • 2021-05-27 14720, 2021

      • lucifer
        the LB entrypoint to spark cluster
      • 2021-05-27 14723, 2021

      • ruaok
        the spark side that takes requests
      • 2021-05-27 14712, 2021

      • lucifer
      • 2021-05-27 14733, 2021

      • alastairp
        which machine does it live on, and how do we currently run it?
      • 2021-05-27 14736, 2021

      • lucifer
      • 2021-05-27 14745, 2021

      • ruaok
        with nohup and &
      • 2021-05-27 14751, 2021

      • lucifer
      • 2021-05-27 14702, 2021

      • alastairp
        nice
      • 2021-05-27 14707, 2021

      • ruaok
      • 2021-05-27 14727, 2021

      • alastairp
        I'd be tempted to just make a systemd file
      • 2021-05-27 14728, 2021

      • lucifer
        acc to my recently gained understanding of runit, we can just use runit like we do in other service
      • 2021-05-27 14732, 2021

      • ruaok
        lucifer: that code looks legit. just copypasta that.
      • 2021-05-27 14716, 2021

      • ruaok
        alastairp: systemd is for starting it, but the python program itself needs to daemonize.
      • 2021-05-27 14734, 2021

      • alastairp
        systemd can handle processes that stay running in the foreground
      • 2021-05-27 14745, 2021

      • lucifer
        how is the request consumer different from spark reader or timescale writer (except the docker part)?
      • 2021-05-27 14713, 2021

      • ruaok
        lucifer: it doesn't run inside docker.
      • 2021-05-27 14726, 2021

      • ruaok
        where we have runit that automatically starts and monitors services.
      • 2021-05-27 14703, 2021

      • lucifer
        right makes sense.
      • 2021-05-27 14725, 2021

      • alastairp
        runit expects that the thing that you start stays running in the foreground
      • 2021-05-27 14702, 2021

      • alastairp
        other init tools can handle processes which daemonise
      • 2021-05-27 14731, 2021

      • alastairp
        ruaok: mm, what consumes playing now messages?
      • 2021-05-27 14732, 2021

      • alastairp
      • 2021-05-27 14743, 2021

      • alastairp
        I'm not sure we've been reporting them properly
      • 2021-05-27 14743, 2021

      • lucifer
        makes sense. request consumer should be a background processs methinks
      • 2021-05-27 14700, 2021

      • ruaok
        redis_listenstore
      • 2021-05-27 14735, 2021

      • lucifer
        ultimately which goes into websockets
      • 2021-05-27 14715, 2021

      • lucifer
      • 2021-05-27 14757, 2021

      • ruaok
        lucifer: agreed, it should be background,
      • 2021-05-27 14707, 2021

      • alastairp
        see the first few paragraphs of this answer, lucifer: https://unix.stackexchange.com/a/308394
      • 2021-05-27 14709, 2021

      • ruaok
        if you copy the code that I linked and use that for startup, you're sorted.
      • 2021-05-27 14728, 2021

      • kepstin joined the channel
      • 2021-05-27 14720, 2021

      • alastairp
      • 2021-05-27 14728, 2021

      • alastairp
        are we missing a websockets server?
      • 2021-05-27 14749, 2021

      • ruaok
        quite possibly.
      • 2021-05-27 14757, 2021

      • ruaok
        did you start it on boing?
      • 2021-05-27 14759, 2021

      • lucifer
        i do not see any websockets srever on boingo
      • 2021-05-27 14700, 2021

      • ruaok
        +o
      • 2021-05-27 14716, 2021

      • Guest7326 joined the channel
      • 2021-05-27 14730, 2021

      • lucifer
        should i start it?
      • 2021-05-27 14740, 2021

      • Guest7326
        I missed some of the conversation.. alastairp, do you have or recommend that mug?
      • 2021-05-27 14748, 2021

      • alastairp
        lucifer: go ahead
      • 2021-05-27 14751, 2021

      • lucifer
        up now
      • 2021-05-27 14715, 2021

      • alastairp
        that was a miscommunication, ruaok thought that I started it, and I didn't know that it had to be started. no problem
      • 2021-05-27 14755, 2021

      • lucifer
      • 2021-05-27 14703, 2021

      • lucifer
        quite a steep fall :D
      • 2021-05-27 14704, 2021

      • alastairp
        that queue went down quite quiclly
      • 2021-05-27 14752, 2021

      • Guest7326 has quit
      • 2021-05-27 14723, 2021

      • trevk joined the channel
      • 2021-05-27 14705, 2021

      • trevk has quit
      • 2021-05-27 14739, 2021

      • lucifer
        alastairp: i read that answer so foreground processes are simple.
      • 2021-05-27 14748, 2021

      • lucifer
        acc to systemd