14:01 PM
alastairp
2021-05-27 14734, 2021
14:01 PM
alastairp
listenbrainz is still up!
2021-05-27 14754, 2021
14:05 PM
ruaok
2021-05-27 14707, 2021
14:06 PM
alastairp updates .ssh/config
2021-05-27 14718, 2021
14:07 PM
zas
ruaok: ok, thanks. Server not visible yet in hetzner interface
2021-05-27 14750, 2021
14:07 PM
alastairp
2021-05-27 14720, 2021
14:08 PM
ruaok
zas: we got pings!
2021-05-27 14709, 2021
14:09 PM
zas
yup
2021-05-27 14736, 2021
14:09 PM
ruaok
I can't login yet. I wonder if they are rescue mode
2021-05-27 14734, 2021
14:12 PM
ruaok
looks like it is rebooting now.
2021-05-27 14704, 2021
14:14 PM
ruaok
its back, but I still can't login.
2021-05-27 14721, 2021
14:14 PM
alastairp
2021-05-27 14727, 2021
14:14 PM
ruaok
zas: root passwd in mail
2021-05-27 14732, 2021
14:14 PM
zas
yup
2021-05-27 14756, 2021
14:14 PM
ruaok
ok, go for it, zas. let us know when its done.
2021-05-27 14706, 2021
14:15 PM
ruaok
I'll stay out of your way.
2021-05-27 14744, 2021
14:16 PM
ruaok
fuck, you're right we didn't order the extra nic
2021-05-27 14754, 2021
14:16 PM
lucifer
alastairp: reviewed.
2021-05-27 14701, 2021
14:18 PM
lucifer
ruaok, we also need the policy on beta and test so let's remember to update those when kiss comes up.
2021-05-27 14720, 2021
14:18 PM
ruaok
k
2021-05-27 14731, 2021
14:18 PM
BrainzGit
2021-05-27 14756, 2021
14:18 PM
ruaok
zas: I've opened the request to have the second nic installed.
2021-05-27 14712, 2021
14:19 PM
alastairp
lucifer: 27.0 is the current latest?
2021-05-27 14716, 2021
14:19 PM
lucifer
yes
2021-05-27 14720, 2021
14:19 PM
zas
ruaok: ooops ;)
2021-05-27 14721, 2021
14:19 PM
ruaok
we'll need to shut it down again, once they come back to me on that.
2021-05-27 14739, 2021
14:19 PM
alastairp
oh wait. I thought I set that to 27.0 werid
2021-05-27 14702, 2021
14:20 PM
alastairp
ohh, I set cron to 27.0 and skipped web. that's it
2021-05-27 14712, 2021
14:20 PM
lucifer
yup
2021-05-27 14727, 2021
14:20 PM
alastairp
we need to deploy 1487 anyway
2021-05-27 14742, 2021
14:20 PM
lucifer
right
2021-05-27 14750, 2021
14:20 PM
alastairp
so let me just update all containers to 27.1 now
2021-05-27 14717, 2021
14:21 PM
lucifer
i am hoping for blitz build because no dependency changed 🤞
2021-05-27 14731, 2021
14:21 PM
BrainzGit
2021-05-27 14752, 2021
14:21 PM
monkey
Sneaking another PR in
2021-05-27 14710, 2021
14:22 PM
BrainzGit
2021-05-27 14733, 2021
14:22 PM
alastairp
lucifer: want to try and make the release?
2021-05-27 14756, 2021
14:23 PM
lucifer
alastairp: sure, i think we can get another two PRs in. 1479 and 1480, should we get those in first?
2021-05-27 14713, 2021
14:24 PM
alastairp
looking
2021-05-27 14722, 2021
14:25 PM
Freso
Anyone want to volunteer as test subject?
2021-05-27 14716, 2021
14:26 PM
alastairp
what does it ban on? name or ip?
2021-05-27 14735, 2021
14:26 PM
Freso
alastairp: Your account, for the purpose of this test.
2021-05-27 14756, 2021
14:26 PM
lucifer
🙋♂️
2021-05-27 14709, 2021
14:27 PM
alastairp
what's an account? nickserv?
2021-05-27 14721, 2021
14:27 PM
kartik joined the channel
2021-05-27 14741, 2021
14:27 PM
kartik
nickserv it is :D
2021-05-27 14750, 2021
14:27 PM
Freso
alastairp: Yeah. :)
2021-05-27 14757, 2021
14:27 PM
lucifer joined the channel
2021-05-27 14707, 2021
14:28 PM
Freso
Alright, looks like it’s working. Great. :)
2021-05-27 14707, 2021
14:28 PM
kartik has left the channel
2021-05-27 14719, 2021
14:28 PM
Freso
Thanks lucifer!
2021-05-27 14717, 2021
14:30 PM
alastairp
2021-05-27 14736, 2021
14:30 PM
alastairp
2021-05-27 14742, 2021
14:30 PM
alastairp
but looks ok
2021-05-27 14711, 2021
14:35 PM
lucifer
cool, should work. i had checked the CI logs and its fine there. msb tests still run as expected.
2021-05-27 14743, 2021
14:35 PM
BrainzGit
2021-05-27 14733, 2021
14:37 PM
lucifer
2021-05-27 14749, 2021
14:37 PM
alastairp
in short, no.
2021-05-27 14730, 2021
14:38 PM
alastairp
this is what I was commenting in the previous PR, we should decide how we want to do logging. either we do their recommendation and don't do string interpolation and let the log function do it. in that case we have to use %, because that's all that's supported
2021-05-27 14743, 2021
14:38 PM
alastairp
otherwise we interpolate it ourselves and use .format or f-string
2021-05-27 14757, 2021
14:38 PM
yvanzo
Updating beta.mb.o
2021-05-27 14702, 2021
14:39 PM
alastairp
as I mentioned, I don't really mind what way we do it, but we should be consistent
2021-05-27 14727, 2021
14:40 PM
alastairp
(the reason that you do the `debug("some % string % here", param1, param2)` is so that you _don't_ have to do the interpolation if your debug level is such that you're not going to output anything - in the bad old days when string interpolation was expensive this made your code run faster)
2021-05-27 14756, 2021
14:41 PM
alastairp
oh - maybe I'm wrong. just looking into this in more detail now. it seems that you might be able to use {} placeholders in logging functions
2021-05-27 14708, 2021
14:43 PM
alastairp
2021-05-27 14703, 2021
14:44 PM
lucifer
alastairp: sorry. i had confused your % formatting comment with something else. debug("Hello %s", " World!") is fine. i meant to use f-string in cases outside logging, at a few places we do stuff like "%s %s" % (a, b). i was wanting to suggest using f-strings there.
2021-05-27 14740, 2021
14:45 PM
alastairp
yes, right. there's _another_ question to open about how we do string interpolation in general :)
2021-05-27 14751, 2021
14:45 PM
alastairp
sorry, my comment on that PR was specifically about formatting in logging calls
2021-05-27 14710, 2021
14:55 PM
atj
ruaok: During this connection process ListenBrainz will request permissions to view your YouTube profile data. During the connection process ListenBrainz will request permissions to view your YouTube profile data.
2021-05-27 14740, 2021
14:55 PM
ruaok
fun.
2021-05-27 14737, 2021
14:58 PM
ruaok
lucifer: ^^ 🤦 fixed in master now.
2021-05-27 14753, 2021
14:58 PM
lucifer
just in time for the next release :D
2021-05-27 14747, 2021
15:00 PM
ruaok
sigh, hetzner.
2021-05-27 14748, 2021
15:00 PM
BrainzGit
2021-05-27 14714, 2021
15:01 PM
ruaok
you didn't rub your tummy before spinning around waving the dead chicken in the air.
2021-05-27 14724, 2021
15:01 PM
ruaok
your request is DENIED.
2021-05-27 14726, 2021
15:02 PM
BrainzGit
2021-05-27 14753, 2021
15:03 PM
nelgin
yvanzo? Did you see the issues I mentioned yesterday?
2021-05-27 14745, 2021
15:04 PM
ruaok
hetzner> If you require this as well on the new one, you may please submit a separate support request.
2021-05-27 14755, 2021
15:04 PM
ruaok
what in the actual fuck is going on now?
2021-05-27 14712, 2021
15:05 PM
alastairp
2021-05-27 14720, 2021
15:07 PM
lucifer
built in ~3m45s, js was recompiled and that took almost ~1.5min so ~2min if only python code changes without dep changes.
2021-05-27 14747, 2021
15:07 PM
alastairp
well done lucifer, this looks like it'll work great for us
2021-05-27 14707, 2021
15:08 PM
alastairp
let's try and get an irc bot next that lets us make a release automatically :)
2021-05-27 14704, 2021
15:09 PM
lucifer
yup, that's up next :D
2021-05-27 14738, 2021
15:09 PM
lucifer
i'll wait for another couple of releases to be safe and then add the action to all other PythonBrainz
2021-05-27 14728, 2021
15:33 PM
alastairp
ruaok: where are we at?
2021-05-27 14739, 2021
15:33 PM
alastairp
30k items in listen queue, maybe we should start up the writer after all
2021-05-27 14741, 2021
15:33 PM
ruaok
waiting on hetzner.
2021-05-27 14749, 2021
15:33 PM
alastairp
ok, going for it
2021-05-27 14737, 2021
15:35 PM
ruaok
zas: pings!
2021-05-27 14723, 2021
15:36 PM
Guest7322 has quit
2021-05-27 14727, 2021
15:36 PM
ruaok
the machine is up, eth1 not configured. I supposed that is expected.
2021-05-27 14712, 2021
15:44 PM
ruaok
are the nics behaving, zas?
2021-05-27 14754, 2021
15:45 PM
zas
yes, I'm on it, that will take some time, I need to update a bunch of things
2021-05-27 14740, 2021
15:48 PM
lucifer
alastairp: available for discussing on making request consumer a daemon
2021-05-27 14748, 2021
15:48 PM
lucifer
?
2021-05-27 14700, 2021
15:49 PM
alastairp
what's the request consumer?
2021-05-27 14719, 2021
15:49 PM
alastairp
(yes)
2021-05-27 14720, 2021
15:49 PM
lucifer
the LB entrypoint to spark cluster
2021-05-27 14723, 2021
15:49 PM
ruaok
the spark side that takes requests
2021-05-27 14712, 2021
15:50 PM
lucifer
2021-05-27 14733, 2021
15:50 PM
alastairp
which machine does it live on, and how do we currently run it?
2021-05-27 14736, 2021
15:50 PM
lucifer
2021-05-27 14745, 2021
15:50 PM
ruaok
with nohup and &
2021-05-27 14751, 2021
15:50 PM
lucifer
2021-05-27 14702, 2021
15:51 PM
alastairp
nice
2021-05-27 14707, 2021
15:51 PM
ruaok
2021-05-27 14727, 2021
15:51 PM
alastairp
I'd be tempted to just make a systemd file
2021-05-27 14728, 2021
15:51 PM
lucifer
acc to my recently gained understanding of runit, we can just use runit like we do in other service
2021-05-27 14732, 2021
15:51 PM
ruaok
lucifer: that code looks legit. just copypasta that.
2021-05-27 14716, 2021
15:52 PM
ruaok
alastairp: systemd is for starting it, but the python program itself needs to daemonize.
2021-05-27 14734, 2021
15:53 PM
alastairp
systemd can handle processes that stay running in the foreground
2021-05-27 14745, 2021
15:53 PM
lucifer
how is the request consumer different from spark reader or timescale writer (except the docker part)?
2021-05-27 14713, 2021
15:54 PM
ruaok
lucifer: it doesn't run inside docker.
2021-05-27 14726, 2021
15:54 PM
ruaok
where we have runit that automatically starts and monitors services.
2021-05-27 14703, 2021
15:55 PM
lucifer
right makes sense.
2021-05-27 14725, 2021
15:55 PM
alastairp
runit expects that the thing that you start stays running in the foreground
2021-05-27 14702, 2021
15:56 PM
alastairp
other init tools can handle processes which daemonise
2021-05-27 14731, 2021
15:56 PM
alastairp
ruaok: mm, what consumes playing now messages?
2021-05-27 14732, 2021
15:56 PM
alastairp
2021-05-27 14743, 2021
15:56 PM
alastairp
I'm not sure we've been reporting them properly
2021-05-27 14743, 2021
15:56 PM
lucifer
makes sense. request consumer should be a background processs methinks
2021-05-27 14700, 2021
15:57 PM
ruaok
redis_listenstore
2021-05-27 14735, 2021
15:57 PM
lucifer
ultimately which goes into websockets
2021-05-27 14715, 2021
15:58 PM
lucifer
2021-05-27 14757, 2021
15:58 PM
ruaok
lucifer: agreed, it should be background,
2021-05-27 14707, 2021
15:59 PM
alastairp
2021-05-27 14709, 2021
15:59 PM
ruaok
if you copy the code that I linked and use that for startup, you're sorted.
2021-05-27 14728, 2021
15:59 PM
kepstin joined the channel
2021-05-27 14720, 2021
16:01 PM
alastairp
2021-05-27 14728, 2021
16:01 PM
alastairp
are we missing a websockets server?
2021-05-27 14749, 2021
16:01 PM
ruaok
quite possibly.
2021-05-27 14757, 2021
16:01 PM
ruaok
did you start it on boing?
2021-05-27 14759, 2021
16:01 PM
lucifer
i do not see any websockets srever on boingo
2021-05-27 14700, 2021
16:02 PM
ruaok
+o
2021-05-27 14716, 2021
16:02 PM
Guest7326 joined the channel
2021-05-27 14730, 2021
16:02 PM
lucifer
should i start it?
2021-05-27 14740, 2021
16:02 PM
Guest7326
I missed some of the conversation.. alastairp, do you have or recommend that mug?
2021-05-27 14748, 2021
16:02 PM
alastairp
lucifer: go ahead
2021-05-27 14751, 2021
16:03 PM
lucifer
up now
2021-05-27 14715, 2021
16:04 PM
alastairp
that was a miscommunication, ruaok thought that I started it, and I didn't know that it had to be started. no problem
2021-05-27 14755, 2021
16:04 PM
lucifer
2021-05-27 14703, 2021
16:05 PM
lucifer
quite a steep fall :D
2021-05-27 14704, 2021
16:05 PM
alastairp
that queue went down quite quiclly
2021-05-27 14752, 2021
16:05 PM
Guest7326 has quit
2021-05-27 14723, 2021
16:06 PM
trevk joined the channel
2021-05-27 14705, 2021
16:07 PM
trevk has quit
2021-05-27 14739, 2021
16:08 PM
lucifer
alastairp: i read that answer so foreground processes are simple.
2021-05-27 14748, 2021
16:08 PM
lucifer
acc to systemd