akshaaatt: Hi! I have reviewed 73 and 68. Regarding 70, reosarevok had expressed some concerns regarding using artist images from WikiPedia. Let's confirm if we can do that before working ahead on that.
2021-05-31 15136, 2021
lucifer
ruaok: command to open door using POST request should replace this right?
moin, yes the entire thing can go and be replaced with a requests call
2021-05-31 15114, 2021
lucifer
moin!
2021-05-31 15116, 2021
lucifer
đź‘Ť
2021-05-31 15103, 2021
CatQuest
yea I don't think we can use wikipedia/commons/wikimedia images
2021-05-31 15145, 2021
akshaaatt
@lucifer: Great! Cool
2021-05-31 15108, 2021
ruaok
lucifer: I've added you to the guest list for the office. you should be able to try it the door buzzer.
2021-05-31 15120, 2021
ruaok
it will only work from production machines
2021-05-31 15136, 2021
zas
moiiin
2021-05-31 15146, 2021
ruaok
moin!
2021-05-31 15134, 2021
zas
ruaok: how do we do for backup machine?
2021-05-31 15119, 2021
ruaok
I've set a port forward for port 2022, but I couldn't get it to work. I'll have to look at it again.
2021-05-31 15149, 2021
ruaok
I do have a port forward to the office door buzzer RPi which is one the same network. so, that could be a route in if you need access right this second.
2021-05-31 15110, 2021
zas
ok
2021-05-31 15119, 2021
Toasty joined the channel
2021-05-31 15121, 2021
ruaok
hmm, the back up server isn't answering pings. I'll have to check it once I get to the office.
2021-05-31 15128, 2021
alastairp
morning
2021-05-31 15104, 2021
akshaaatt
@lucifer: #68 has been resolved :)
2021-05-31 15104, 2021
lucifer
ruaok: i have updated prod. i see the open option here https://officebrainz.org/door/. is someone at the office to see if it works?
2021-05-31 15127, 2021
ruaok
hang on. I can see if the request comes into the RPi.
2021-05-31 15119, 2021
ruaok
try it now, lucifer
2021-05-31 15141, 2021
lucifer
clicked it. do you see anything?
2021-05-31 15157, 2021
ruaok
no.
2021-05-31 15107, 2021
ruaok
did it delay by 5/10 seconds?
2021-05-31 15133, 2021
ruaok
no, something is still not working right -- the call seems to return right away.
tried again. this time i don't see any error in the logs. did it work?
2021-05-31 15146, 2021
ruaok
looks like it!
2021-05-31 15148, 2021
ruaok
!m lucifer
2021-05-31 15148, 2021
BrainzBot
You're doing good work, lucifer!
2021-05-31 15109, 2021
lucifer
awesome :D
2021-05-31 15126, 2021
ruaok
I'll head to the the office soon to check things out and poke at the backups.
2021-05-31 15159, 2021
lucifer
akshaaatt: thanks for working on it. i made one more change and merged the PR.
2021-05-31 15114, 2021
akshaaatt
Cool
2021-05-31 15128, 2021
akshaaatt
Any uodates regarding #70 @lucifer ?
2021-05-31 15131, 2021
akshaaatt
Updates*
2021-05-31 15117, 2021
lucifer
akshaaatt: no not yet. i'll wait for reo's answer to know if we can add the feature. i'll review it after that.
2021-05-31 15106, 2021
akshaaatt
Great! Cool once we have that PR dealt with I'll work on some more massive updates.
2021-05-31 15120, 2021
lucifer
nice, let's discuss the further work later today if you are available?
2021-05-31 15108, 2021
akshaaatt
I'll just go get lunch rn. We can schedule a meeting around 3:30pm rn if that works?
2021-05-31 15128, 2021
lucifer
sure, works for me.
2021-05-31 15135, 2021
akshaaatt
Cool
2021-05-31 15121, 2021
ruaok
lucifer: did I ever add you to the LB-exceptions emails?
2021-05-31 15123, 2021
ruaok
"Incremental dump 448 is more than 26 hours old: 4 days, 2:00:00.370655"
2021-05-31 15125, 2021
ruaok
:(
2021-05-31 15148, 2021
alastairp
I'm just responding to some emails then I'll take a look at lucifer's PR that he opened last week
2021-05-31 15102, 2021
alastairp
that should get us in a position where we can fix dumps (again)
2021-05-31 15125, 2021
lucifer
ruaok: yes i have been receiving those :). the dumps are failing because of permission issues. the PR to get rid of the lbdumps user is open which should fix it.
2021-05-31 15144, 2021
ruaok
ok.
2021-05-31 15111, 2021
ruaok
this feels like our own personal "never ending war" from 1984
2021-05-31 15123, 2021
alastairp
lucifer: I saw a lot of startup errors over the weekend. I'll take a look and see if we can characterise what happened and why
2021-05-31 15113, 2021
lucifer
alastairp: right, i had seen those. many of those are related to when consul restarts services.
2021-05-31 15103, 2021
lucifer
thanks! i wanted to take a look but i dont know much about how/when consul decides to restart.
2021-05-31 15106, 2021
alastairp
yeah, so as we discussed on friday(?) we should try and get some more info into the messages about which services are missing at each stage
2021-05-31 15101, 2021
alastairp
yeah, I think the big thing is that no one knows when or why things restart. So adding a bit more to the logging here should tell us
2021-05-31 15118, 2021
alastairp
I'm not sure what exit code 14 is
2021-05-31 15111, 2021
lucifer
yes, right we decided to grep the info in `finish` files as well
2021-05-31 15154, 2021
lucifer
alastairp, also i see in some consul tutorials that consul agent logs details about reload at info level. we could probably run one or two of our containers with log-level info or debug to get more detailed insight.
2021-05-31 15115, 2021
texke joined the channel
2021-05-31 15107, 2021
alastairp
lucifer: cool, I didn't know about that. let's try it
2021-05-31 15117, 2021
alastairp
however - this is the agent, not consul-template?
2021-05-31 15140, 2021
lucifer
alastairp, ah yes. right. this is about consul agent. i just checked our consulagent container already has info level logs. for consul template, there's so we can probably get some info from it as well. https://github.com/hashicorp/consul-template/blob…
2021-05-31 15120, 2021
alastairp
right. debug might be a bit too much, if it prints something for every key it gets
2021-05-31 15154, 2021
lucifer
yeah, let's start with info and see what we get.
2021-05-31 15112, 2021
ruaok
wooo, I waltzed into the office as normal. just with HTTPS this time. :) :)
2021-05-31 15149, 2021
akshaaatt
@lucifer: while deploying the Android app on playstore, we can do the version naming on a scale of 3 I feel that would look much clean. Like for versionCode we can do 2.2.9 version name instead of 4.5 and this really doesn't affect anything since it's just the naming scheme. If we don't make this change then we'll be on version 10 soon enough
2021-05-31 15112, 2021
akshaaatt
versionCode 39*
2021-05-31 15103, 2021
akshaaatt
And yeah btw I'm here and ready for the meet :)
2021-05-31 15101, 2021
lucifer
akshaaatt: sure, i don't have any preference for the version name and we don't have a fixed policy on deciding that. in our other projects, we just use the current date as the version but Play Store already shows the release date so its redundant.
2021-05-31 15105, 2021
lucifer
let's discuss the tasks ahead then.
2021-05-31 15109, 2021
akshaaatt
Yaas
2021-05-31 15135, 2021
lucifer
i see there are 3 open PRs atm, i know #70 is ready for review. what's the status of other two and do you need any help or want to discuss anything about those?
2021-05-31 15151, 2021
akshaaatt
The tagger update can be merged if you want to.
2021-05-31 15104, 2021
akshaaatt
But I'll be working on it anyway for the next 2 weeks
2021-05-31 15119, 2021
akshaaatt
Will finish the tagger implementation with the lookup songs and a few fixes
2021-05-31 15133, 2021
akshaaatt
Other than that the PR can be merged at any time.
2021-05-31 15156, 2021
akshaaatt
I did need some help with the Tests PR #67
2021-05-31 15123, 2021
lucifer
I think merging incrementally smaller changes is nicer, I'll take a look at and review it today.
2021-05-31 15131, 2021
akshaaatt
Coool
2021-05-31 15100, 2021
akshaaatt
I'll just open up the codebase to discuss #67 more clearly
2021-05-31 15105, 2021
lucifer
sure
2021-05-31 15110, 2021
akshaaatt
So you asked me to write tests for the collectionrepo
2021-05-31 15124, 2021
akshaaatt
And I created a fake class for it
2021-05-31 15142, 2021
akshaaatt
Downloaded my collections json both public and private
2021-05-31 15156, 2021
akshaaatt
Could you check if the downloaded json are correct?
this is how we do it for LookupRepository, we bind the prod implementation to the interface.
2021-05-31 15137, 2021
akshaaatt
Makes sense
2021-05-31 15157, 2021
akshaaatt
Got it. I can make this change.
2021-05-31 15115, 2021
lucifer
so whenever Hilt creates a component it will insert LookupRepositoryImpl where LookupRepository is required, which works because in production Hilt manages all components. in tests we create the components manually, so we put the FakeLookupRepository ourself.
2021-05-31 15134, 2021
akshaaatt
Yeaaah I get it now! That's cool
2021-05-31 15102, 2021
lucifer
i have reviewed the tagger PR, will test it later.
2021-05-31 15119, 2021
akshaaatt
Great!
2021-05-31 15120, 2021
lucifer
Do you have any other queries regarding these PRs?
2021-05-31 15131, 2021
akshaaatt
Yeah continuing on the tests PR,
2021-05-31 15131, 2021
akshaaatt
While writing the tests, the CollectionRepositoryTest basically fetches the data from our resources right?
2021-05-31 15156, 2021
akshaaatt
And we use the MockServer to do that
2021-05-31 15102, 2021
lucifer
yes right, the MockWebServer serves the test json files.
2021-05-31 15143, 2021
akshaaatt
I think I didn't understand the dispather part
2021-05-31 15116, 2021
akshaaatt
How do we serve the json file to it?
2021-05-31 15158, 2021
akshaaatt
It's just that one line of endpoint I couldn't wrap my head around
But how we fetch that data is what I need to understand
2021-05-31 15103, 2021
lucifer
yeah, so that is a shortcut. we extract the entity name from the url. and and then load the json file named "{entity}_lookup.json". i have named the files as artist_lookup.json and release_lookup.json so on.
2021-05-31 15138, 2021
akshaaatt
Ohhh
2021-05-31 15129, 2021
lucifer
if i had done it properly it would be a switch case which maps the url to name of the file that should be served
2021-05-31 15146, 2021
akshaaatt
Right right all cool then
2021-05-31 15152, 2021
akshaaatt
I have 2 files to fetch though
2021-05-31 15100, 2021
akshaaatt
One for public and the other for private
2021-05-31 15149, 2021
lucifer
right, so you'll need to an if case in the dispatcher to check for which file to serve. the `request` variable will container the url and stuff.
2021-05-31 15100, 2021
akshaaatt
Coool
2021-05-31 15105, 2021
lucifer
you can check it and see which file should be served.
2021-05-31 15113, 2021
akshaaatt
Right
2021-05-31 15128, 2021
akshaaatt
Thanks a lot @lucifer ! đź’Ż
2021-05-31 15154, 2021
lucifer
it might also have some convenience methods but i don't remember offhand so will need to check its .
2021-05-31 15156, 2021
lucifer
*docs
2021-05-31 15126, 2021
akshaaatt
I'll work on finalizing these 2 PRs in a day or two. The tagger one is final for when you wanna merge. This tests one is what I'll complete in a while I guess.
2021-05-31 15141, 2021
akshaaatt
Right now even I'll try to go through the docs of Wikimedia
