an easier way to do that might be to not have that, but simply consider the lastest track to be pinned.
2021-06-01 15237, 2021
ruaok
that would mean that a user could not ever not have a pinned track.
2021-06-01 15252, 2021
ruaok
but the schema is easier.
2021-06-01 15219, 2021
lucifer
i think it would be nice for users to be able to pin tracks.
2021-06-01 15233, 2021
ruaok
you mean to unpin tracks?
2021-06-01 15213, 2021
alastairp
so you need to perform the action of pinning something for it to arrive in this table?
2021-06-01 15226, 2021
alastairp
do we want (need) to keep a history of pinned tracks?
2021-06-01 15231, 2021
ruaok
yes.
2021-06-01 15246, 2021
ruaok
need no. want, probably. another source of data for recs.
2021-06-01 15216, 2021
lucifer
yeah i think the user should be able to pin and unpin tracks.
2021-06-01 15217, 2021
alastairp
when does something unpin? after a perioid of time or only when something else is added?
2021-06-01 15233, 2021
alastairp
I can't remember if jam let you un-jam something
2021-06-01 15235, 2021
lucifer
can we only have a single pinned track at a time?
2021-06-01 15254, 2021
alastairp
lucifer: I'd think so, that's how I think of it
2021-06-01 15257, 2021
ruaok
alastairp: undefined right now, I think. lets define this behaviour.
2021-06-01 15211, 2021
ruaok
yeah, one track at a time with capability to unpin it.
2021-06-01 15215, 2021
lucifer
yeah, i am unclear as to what we want exactly.
2021-06-01 15236, 2021
ruaok
lets clear that up then. :)
2021-06-01 15245, 2021
lucifer
so when we pin a new track the previous one gets unpinned?
2021-06-01 15200, 2021
ruaok
that was my impression.
2021-06-01 15209, 2021
alastairp
agreed
2021-06-01 15215, 2021
ruaok
I dont think I ike the auto-unpinning of tracks, but then data gets stale.
2021-06-01 15216, 2021
lucifer
then we can do without currently_pinned column.
2021-06-01 15259, 2021
ruaok
but then a user can never unpin tracks. unless we give the power to delete the history.
2021-06-01 15204, 2021
ruaok
hmmm.
2021-06-01 15214, 2021
ruaok
I'm starting to wonder about keeping history.
2021-06-01 15218, 2021
alastairp
ruaok: could we have some kind of "currently pinned" (valid for a week) and "last thing they pinned"
2021-06-01 15229, 2021
ruaok
oh, I like that.
2021-06-01 15230, 2021
alastairp
it's the same row, but just depends on now()-when_pinned
2021-06-01 15237, 2021
ruaok
yearp.
2021-06-01 15200, 2021
ruaok
what do you think about keeping history? more data, which is a double edged sword.
2021-06-01 15225, 2021
alastairp
jam kept history, and I liked it. I think it's useful
2021-06-01 15251, 2021
akshaaatt
Hi @lucifer I'm up for any PR reviews when you're available :)
2021-06-01 15254, 2021
ruaok
ok, then we only have the question if a user should be able to unpin a track.
2021-06-01 15210, 2021
ruaok
but I think that can fall away with your 1 week timeout.
2021-06-01 15232, 2021
lucifer
i think it would be nice to be able to unpin.
2021-06-01 15235, 2021
alastairp
yes right. either wait a week or pin something else
2021-06-01 15248, 2021
alastairp
what about delete?
2021-06-01 15205, 2021
ruaok
I suspect that users will want that.
2021-06-01 15206, 2021
shivam-kapila
I agree with lucifer
2021-06-01 15216, 2021
ruaok
when they become embarrased of their furry past.
2021-06-01 15221, 2021
ruaok
🙄
2021-06-01 15229, 2021
alastairp
so I don't know if unpin and delete are the same thing
2021-06-01 15237, 2021
ruaok
not in my book.
2021-06-01 15245, 2021
lucifer
we allow to delete listens so makes sense to delete previous pins as well.
2021-06-01 15203, 2021
lucifer
delete and unpin are different acc to my understanding.
2021-06-01 15212, 2021
ruaok
agree with lucifer
2021-06-01 15240, 2021
alastairp
yeah, I didn't want to imply that they were the same - just that if it really comes to it a user could "unpin" by deleting
2021-06-01 15241, 2021
shivam-kapila
But are previous pins to be shown anywhere?
2021-06-01 15243, 2021
ruaok
summary: keep history. allow unpinning. unpin after a week. allow delete.
2021-06-01 15258, 2021
lucifer
sounds good.
2021-06-01 15259, 2021
ruaok
shivam-kapila: yes.
2021-06-01 15212, 2021
lucifer
we could add a tab or page to show history of pins.
2021-06-01 15216, 2021
ruaok
alastairp: ok with that summary?
2021-06-01 15221, 2021
lucifer
and they could always show up on the feed.
2021-06-01 15228, 2021
alastairp
one problem with allowing unpinning (need a column for it as in the current PR?) is that we would need to decide what to do after a week
2021-06-01 15236, 2021
alastairp
how do you unpin? cron job?
2021-06-01 15244, 2021
lucifer
a trigger?
2021-06-01 15259, 2021
shivam-kapila
ruaok: cool cool. I got the idea now.
2021-06-01 15202, 2021
ruaok
update on read?
2021-06-01 15218, 2021
ruaok
meaning that if the view reads the data and the pin is older than a week, we unpin it?
2021-06-01 15227, 2021
ruaok
I want to avoid creating more cron jobs to track.
2021-06-01 15240, 2021
alastairp
sure. would mean an extra db query, but not big in the grand scheme of things
2021-06-01 15206, 2021
lucifer
or we add a pinned_till column instead of currently_pinned?
2021-06-01 15218, 2021
alastairp
oh, that's handy
2021-06-01 15220, 2021
ruaok
oh! I like that lucifer
2021-06-01 15229, 2021
ruaok
!m lucifer
2021-06-01 15229, 2021
BrainzBot
You're doing good work, lucifer!
2021-06-01 15230, 2021
alastairp
perfect, all my problems are resolved
2021-06-01 15235, 2021
ruaok
thanks chaps.
2021-06-01 15239, 2021
yyoung
Hi alastairp, I had an idea yesterday: Would it be better to show the number of data submitted by an user on AcousticBrainz? That would give them a sense of achievement
2021-06-01 15201, 2021
alastairp
yyoung: we intentionally don't track users in AB submissions
2021-06-01 15244, 2021
yyoung
I mean just a number of how many data they've submitted :)
2021-06-01 15214, 2021
alastairp
submissions don't even require a login at the moment, so unfortunately we can't
2021-06-01 15215, 2021
lucifer
akshaaatt: sure, i'll be testing it soon today and will let you know.
2021-06-01 15239, 2021
alastairp
I think that tracking other things could be useful (e.g. datasets, feedback on algorithms/similarity)
2021-06-01 15257, 2021
yyoung
I see, thank you
2021-06-01 15257, 2021
akshaaatt
@lucifer: great! I worked on the tests PR as well and have made the necessary DI changes. Had a slight issue with the tests though. Let me know if we could discuss that after dinner. Probably after 8pm I'm ready to discuss that PR. Thanks!
2021-06-01 15232, 2021
lucifer
akshaaatt: sure, ping me when you're available later.
ruaok, alastairp: should a user be able to pin same thing multiple times (i think yes) and do they count as separate or same pins in history?
2021-06-01 15240, 2021
ruaok
yes, separate, IMHO
2021-06-01 15244, 2021
lucifer
(the UNIQUE might need to be dropped accordingly)
2021-06-01 15259, 2021
ruaok
oh, good catch! let me comment.
2021-06-01 15204, 2021
lucifer
yeah, separate makes sense.
2021-06-01 15205, 2021
lucifer
another thing, why is playlist stored in timescale and pinned tracks in just postgres?
2021-06-01 15254, 2021
alastairp
lucifer: that's a very good question, we started to make this split between "user profile" data and "content", but it's not very clearly defined
2021-06-01 15217, 2021
alastairp
lucifer: sorry, just rememebred you asked about the PR too, will look again
2021-06-01 15227, 2021
alastairp
lucifer: another question - how did dumps go yesterday?
2021-06-01 15252, 2021
lucifer
its a full dump day :D, still ongoing most probably.
2021-06-01 15220, 2021
lucifer
(at least they were not when i checked last, 4 hrs ago)
2021-06-01 15241, 2021
lucifer
currently dumping listens for July 2019.
2021-06-01 15229, 2021
lucifer
after dumping completely, it will also transform the dump format for spark which will take many hours again.
2021-06-01 15208, 2021
wargreen
outsidecontext, hi ! do you know why, in the AB tonal-rythm Picard's plugin, 0.5 is added to the bmp ? (line 93)
2021-06-01 15201, 2021
wargreen
(i integrate this function in the new AB plugin without call it for now)
2021-06-01 15207, 2021
akshaaatt[m] joined the channel
2021-06-01 15223, 2021
akshaaatt has left the channel
2021-06-01 15214, 2021
akshaaatt[m]
The matrix bridge is here Freso :)
2021-06-01 15210, 2021
akshaaatt[m]
lucifer hola
2021-06-01 15229, 2021
lucifer
hi!
2021-06-01 15251, 2021
akshaaatt[m]
Yup I'm ready!
2021-06-01 15218, 2021
lucifer
yes, what issue were you having with the tests PR/
2021-06-01 15220, 2021
lucifer
?
2021-06-01 15244, 2021
akshaaatt[m]
I think CollectionRepositoryTest is good?
2021-06-01 15201, 2021
akshaaatt[m]
Had some issue with CollectionViewModelTest
2021-06-01 15222, 2021
akshaaatt[m]
No and yeah again with the CollectionRepositoryTest, I wanted to understand what recorded request provides us with and where does it fetch it form?
2021-06-01 15250, 2021
lucifer
on a quick look Repository Test looks good. View Model test, as you see the comment are flaky currently i'll take a look at those again and see if the situation has improved now.
2021-06-01 15206, 2021
akshaaatt[m]
Like we just initialized the MockWebServer and then with the dispatcher we now have the endpoints?
2021-06-01 15222, 2021
akshaaatt[m]
<lucifer "on a quick look Repository Test "> Cool
2021-06-01 15233, 2021
lucifer
we don't have endpoints perse, all the requests will invoke the disptcher method. and then we can decide what to return as response.
> Algorithms run our lives these days, from Netflix binges to predictive policing. And that includes algorithmic recommenders––like Spotify’s Discover Weekly and Pandora––that shape how we consume music. How does algorithmic music recommendation work and, perhaps more importantly, who makes it work? After all, algorithms are made and tweaked by people, who work at tech companies and have their own ideas and values.
2021-06-01 15214, 2021
akshaaatt[m]
Cool after this PR, I'll make another tests branch which would deal with the tests more exhaustively.
2021-06-01 15257, 2021
lucifer
its a simple wrapper around getResourceAsStream. getResourceAsStream is used to load static resources which are stored alongside classes.
2021-06-01 15223, 2021
lucifer
we should make tests more exhaustive but I would prefer adding tests for tagger first because that is more brittle.
2021-06-01 15245, 2021
akshaaatt[m]
<lucifer "we should make tests more exhaus"> Right
2021-06-01 15202, 2021
akshaaatt[m]
<alastairp "> Algorithms run our lives these"> I personally prefer the human touch over algorithms for monitoring day to day stuff like policy checks, and even support required because humans are prone to mistakes at times.
2021-06-01 15228, 2021
akshaaatt[m]
Algorithms are obviously great for every other task though :)
2021-06-01 15230, 2021
akshaaatt[m]
lucifer let's close these PRs and discuss the further work?
2021-06-01 15203, 2021
lucifer
akshaaatt[m]: yes, i am testing #70 currently. will test let you know once both are tested and reviewed.
2021-06-01 15222, 2021
akshaaatt[m]
Thank you! lucifer
2021-06-01 15250, 2021
ROpdebee
reosarevok: I was wrong. CAA-133 wasn't because of an NSFW filter, it was a temporary mistake at the IA that left some items in a wrong state
akshaaatt[m]: Ugh. Looks like the ugly Matrix replies haven’t been fixed yet. :| Are you using the #metabrainz:libera.chat Matrix room or somehing else?
2021-06-01 15216, 2021
akshaaatt[m]
Yup I'm using the #metabrainz:libera.chat Matrix room Freso !
2021-06-01 15209, 2021
reosarevok
ROpdebee: oh, good to hear
2021-06-01 15217, 2021
Freso
Alright, thanks. I’ll go poke Matrix people then. :)
2021-06-01 15249, 2021
Toasty joined the channel
2021-06-01 15223, 2021
yvanzo joined the channel
2021-06-01 15259, 2021
lucifer
akshaaatt[m]: i tested 70. everything works fine. can you please remove the nested constraint layout as it is only there for grouping purposes? other than that is ready to merge.
2021-06-01 15259, 2021
lucifer
also, can you link me the source to animations used. i need to verify the attribution and license requirements if any.
