ruaok: alastairp: both full dump and incremental dump happened correctly.
2021-06-02 15331, 2021
akashgp09_ joined the channel
2021-06-02 15321, 2021
JuniorJPDJ joined the channel
2021-06-02 15315, 2021
lucifer
alastairp: the service restarts happened again yesterday, web-test logs have some info plus our service improvements provide more detailed output. its due to `pgbouncer-master` service. something in pgbouncer (probably it restarts?) changes which triggers consul to reload all templates that use it. it looks like the reload interval for lb templates is less than the time in which pgbouncer becomes available again.
yvanzo: I'm not quite sure about where we are going, can you explain a bit for me? Are we going to reuse the relationship editor for display?
2021-06-02 15353, 2021
yvanzo
yyoung: That is already the case when editing relationships from an URL editing page.
2021-06-02 15313, 2021
yyoung
yvanzo: So will we do the same from another perspective, i.e. from edit release page?
2021-06-02 15301, 2021
yyoung
IMO a different UI is better, since the links should be grouped by url instead of relationship like in the relationship editor
2021-06-02 15312, 2021
yvanzo
The relationship editor has some limitations indeed: doesn't handle multiple relationships, doesn't have a dynamic options tree.
2021-06-02 15329, 2021
yvanzo
But having a similar UI would make it easier to use.
2021-06-02 15319, 2021
yyoung
yvanzo: So you're talking about the editing dialog? I agree with that part, but what about the display part?
2021-06-02 15356, 2021
yvanzo
Yes, the dialog only. The list can be different indeed, and grouping by URL rather than relationship type would make sense.
2021-06-02 15319, 2021
yyoung
And does the UI I proposed last week still need any improvement?
2021-06-02 15353, 2021
yvanzo
It needs to be more compact eventually.
2021-06-02 15319, 2021
yyoung
I wonder whether it still need discussion or we just let it pending until multiple relationship is supported.
2021-06-02 15305, 2021
yvanzo
do you mean multiple relationships auto-select?
2021-06-02 15303, 2021
yyoung
No necessarily auto-select, just allow users to add multiple rels under one link I think? :)
2021-06-02 15330, 2021
yvanzo
Ok because that is already supported, it's just not grouped by URL.
2021-06-02 15353, 2021
yvanzo
What is not supported is auto-select and validation of multiple relationships from the same entity and to the same URL.
2021-06-02 15343, 2021
yyoung
So I guess I need to change my schedule? I formerly believed it was a new feature to implement
2021-06-02 15317, 2021
yyoung
And what about a separate field for clean URL, that ought to be the task after UI change
2021-06-02 15305, 2021
yvanzo
Well it is not supported either for all external websites that are handled by auto-select and validation.
2021-06-02 15332, 2021
yvanzo
That is the vast majority of external links.
2021-06-02 15318, 2021
yvanzo
yyoung: Would a dialog box to edit raw URL/clean URL helps with keeping the list compact?
2021-06-02 15314, 2021
yyoung
I don't get it, isn't the URL input independent of validation and auto-select?
2021-06-02 15329, 2021
yvanzo
Instead of displaying an input field for the URL, it could be a link with (edit) link.
2021-06-02 15359, 2021
yvanzo
yyoung: yes it is, I was replying to your previous sentence.
2021-06-02 15349, 2021
yvanzo
To clarify: Selecting multiple relationships is supported only for URLs that are not handled by auto-select and validation.
2021-06-02 15309, 2021
yyoung
Got it :)
2021-06-02 15338, 2021
yvanzo
The most popular domain names are handled by auto-select and validation.
2021-06-02 15303, 2021
yvanzo
So there is a very limited support for multiple relationships in fact.
2021-06-02 15323, 2021
yyoung
I personally don't think a dialog for URL input would help compact the UI, what is your point?
2021-06-02 15336, 2021
yvanzo
Instead of displaying (raw? clean?) URL in an input field, we could display it as a link with an (edit) link to pop-up an editing dialog box that would allow to edit raw URL, and possibly amend clean URL.
2021-06-02 15356, 2021
yyoung
Or do you mean we should hide the relationships in a dialog and only show the links outside?
2021-06-02 15317, 2021
yvanzo
So there would be no need to display both raw URL and clean URL in the list.
2021-06-02 15330, 2021
yvanzo
yyoung: no
2021-06-02 15342, 2021
yyoung
IMO we always need a line to display URL whether it is clean or not
2021-06-02 15357, 2021
yvanzo
that would rather hide the input fields in a dialog.
2021-06-02 15303, 2021
yyoung
And previouly we decided to use a bubble on the right for clean URL
2021-06-02 15320, 2021
yvanzo
yyoung: yes but editors can only edit the raw URL whereas we want to show them the clean URL.
2021-06-02 15346, 2021
yvanzo
The bubble is not ideal either: it shows the clean URL only on rollover.
2021-06-02 15359, 2021
yyoung
Yeah that's a problem :)
2021-06-02 15330, 2021
yyoung is thinking about the idea of a new dialog
2021-06-02 15331, 2021
yvanzo
Reminder: currently the input raw URL is overridden with clean URL.
2021-06-02 15305, 2021
yvanzo
So we currently display the clean URL, but make it impossible to still see the raw URL.
2021-06-02 15314, 2021
yyoung
So we intend to keep the raw URL on editing, use clean URL for submitting and storing?
2021-06-02 15351, 2021
yvanzo
Yes, and we might want to allow bypassing clean URL in the future too.
2021-06-02 15304, 2021
yyoung
A small dialog for URL input might be reasonable
2021-06-02 15308, 2021
yyoung
I had an idea before, to add a button allowing users to replace row URL with the clean one
2021-06-02 15353, 2021
yyoung
<it shows the clean URL only on rollover> but a dialog still requires you to click to open
2021-06-02 15301, 2021
Toasty joined the channel
2021-06-02 15316, 2021
yvanzo
yyoung: the clean URL would be displayed in the list, not the raw URL.
2021-06-02 15301, 2021
yyoung
yvanzo: Agree
2021-06-02 15354, 2021
yyoung
Oh therefore a dialog may be better since it keeps both raw and clean URL
2021-06-02 15315, 2021
yvanzo
yyoung: Did you start documenting real use cases for multiple relationships, options (video), date period, ended flag?
2021-06-02 15334, 2021
yyoung
To sum up, we need a small dialog displaying both raw and clean URL, and only clean URL is displayed in the list outside?
2021-06-02 15349, 2021
yvanzo
yyoung: right, that is the suggestion :)
2021-06-02 15305, 2021
yyoung
yvanzo: Not yet, can't we use database statistics to figure it out?
2021-06-02 15309, 2021
yvanzo
Sure but you can start with the most obvious: platforms for digital releases.
yyoung: sure, these are the different places to display an error.
2021-06-02 15333, 2021
yyoung
yvanzo: I didn't get the conclusion clear in the last discussion, maybe I'll take some time to read the logs
2021-06-02 15307, 2021
yvanzo
moin ruaok: it will remain secret apparently: moderators removed the content of that post.
2021-06-02 15306, 2021
yvanzo
yyoung: these are the targets reosarevok required you to add in the PR: errors for URL field, errors for relationships (currently only one)
2021-06-02 15324, 2021
yvanzo
yyoung: in the future, there can also be one error for each relationship
2021-06-02 15304, 2021
yvanzo
yyoung: and possibly a catch-all error for both URL and relationships.
2021-06-02 15324, 2021
ruaok
oh that's lame. it was something useful that people appreciated, for once. oh right. it wasn't toxic enough for reddit.
2021-06-02 15351, 2021
yyoung
yvanzo: And what about the error of incompatible entity type? Should it target link or relationship type?
2021-06-02 15315, 2021
yvanzo
yyoung: relationship type I guess.
2021-06-02 15303, 2021
yyoung
yvanzo: So I'll try to implement it this week by adding an extra property, is that OK?
2021-06-02 15305, 2021
yvanzo
yyoung: actually could target link... good question :)
2021-06-02 15335, 2021
yvanzo
yyoung: yes :)
2021-06-02 15354, 2021
yyoung
yvanzo: This is indeed the controversial point of our last discussion, isn't it :)
2021-06-02 15306, 2021
yyoung
Anyway we can change it on PR review :)
2021-06-02 15317, 2021
yvanzo
yyoung: for incompatible entity type, maybe have a specific target, and decide where to display it later on.
2021-06-02 15344, 2021
yvanzo
Right :)
2021-06-02 15311, 2021
akshaaatt[m]
lucifer: Hola!
2021-06-02 15331, 2021
lucifer
Hi akshaaatt[m]!
2021-06-02 15348, 2021
akshaaatt[m]
Let's discuss the work then 😇
2021-06-02 15329, 2021
lucifer
yup sure. i was thinking we should work on fixing tagger bugs next. what say?
2021-06-02 15336, 2021
akshaaatt[m]
Sure! I see bugs around the cases where the user doesn't select a folder and discards the idea of selecting one
2021-06-02 15340, 2021
akshaaatt[m]
Basically we need to handle more use cases
2021-06-02 15343, 2021
akshaaatt[m]
One bug there
2021-06-02 15310, 2021
akshaaatt[m]
Other than that you mentioned one about what Shivam was facing. The naming scheme
2021-06-02 15339, 2021
lucifer
right, also as we discussed earlier, errors in the repository are not propogated to the UI.
2021-06-02 15351, 2021
lucifer
so UI remains stuck on loading if there's an error.
2021-06-02 15357, 2021
akshaaatt[m]
Right. I am noting all this down then
2021-06-02 15303, 2021
akshaaatt[m]
What else?
2021-06-02 15307, 2021
lucifer
also, some fields are not read correctly i think. yesterday, i opened a Picard tagged file in the app and some fields didn't show up.
2021-06-02 15325, 2021
akshaaatt[m]
Okaay! I'll explore that
2021-06-02 15350, 2021
lucifer
i think is a good starting point. let's fix these issues and then retouch base.
2021-06-02 15302, 2021
akshaaatt[m]
Great!
2021-06-02 15313, 2021
akshaaatt[m]
Can we add a media player to the app for the already downloaded songs on the app?
2021-06-02 15320, 2021
akshaaatt[m]
I think we can add this after GSoC
2021-06-02 15326, 2021
akshaaatt[m]
But it'll be really cool
2021-06-02 15315, 2021
akshaaatt[m]
I've previously worked on a media player so won't be too hard to add
2021-06-02 15330, 2021
lucifer
i don't think that's a good idea. a media player is difficult to write and maintain. i would prefer just redirecting to installed media players.
2021-06-02 15345, 2021
akshaaatt[m]
Right that's also cool
2021-06-02 15302, 2021
akshaaatt[m]
And for future purposes again, do you think adding the youtube api to the app would be a good choice to directly link the users to the music videos of the releases?
2021-06-02 15353, 2021
lucifer
how you would that work?
2021-06-02 15330, 2021
lucifer
currently, if a track has a youtube link associated and you click that from the links tab it opens that in Youtube.
2021-06-02 15321, 2021
akshaaatt[m]
Wait give me a while to jot down the resources for it. I'll ping you maybe in an hour so please feel free to work on your stuff until then.
akshaaatt[m] posted a file: (5067KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/QRNyeCGchzorpBtpAKdnOTzp/app-debug.apk >
2021-06-02 15316, 2021
lucifer
that's fine but this approach will only work for tracks with youtube key right?
2021-06-02 15325, 2021
akshaaatt[m]
Yup.
2021-06-02 15301, 2021
akshaaatt[m]
So we used the themoviedb api here and added the youtubeplayerview to showcase the movie trailers
2021-06-02 15303, 2021
lucifer
and for those tracks we can directly open them in youtube instead?
2021-06-02 15332, 2021
akshaaatt[m]
We can open them in youtube directly as well
2021-06-02 15316, 2021
lucifer
yes, and that seems much better to me.
2021-06-02 15336, 2021
akshaaatt[m]
cool
2021-06-02 15304, 2021
lucifer
we have the BrainzPlayer on LB to play tracks from differents sources. i see that is useful in LB context and in web but in android case youtube is always installed on phone.
