#metabrainz

ruaok: alastairp: both full dump and incremental dump happened correctly.

alastairp: the service restarts happened again yesterday, web-test logs have some info plus our service improvements provide more detailed output. its due to `pgbouncer-master` service. something in pgbouncer (probably it restarts?) changes which triggers consul to reload all templates that use it. it looks like the reload interval for lb templates is less than the time in which pgbouncer becomes available again.

yvanzo: Good morning

yyoung: Good afternoon

alastairp: around the same time of service restarts, there were also https://sentry.metabrainz.org/metabrainz/listen... errors. these are also related to pgbouncer methinks.

yvanzo: I'm not quite sure about where we are going, can you explain a bit for me? Are we going to reuse the relationship editor for display?

yyoung: That is already the case when editing relationships from an URL editing page.

yvanzo: So will we do the same from another perspective, i.e. from edit release page?

IMO a different UI is better, since the links should be grouped by url instead of relationship like in the relationship editor

The relationship editor has some limitations indeed: doesn't handle multiple relationships, doesn't have a dynamic options tree.

But having a similar UI would make it easier to use.

yvanzo: So you're talking about the editing dialog? I agree with that part, but what about the display part?

Yes, the dialog only. The list can be different indeed, and grouping by URL rather than relationship type would make sense.

And does the UI I proposed last week still need any improvement?

It needs to be more compact eventually.

I wonder whether it still need discussion or we just let it pending until multiple relationship is supported.

do you mean multiple relationships auto-select?

No necessarily auto-select, just allow users to add multiple rels under one link I think? :)

Ok because that is already supported, it's just not grouped by URL.

What is not supported is auto-select and validation of multiple relationships from the same entity and to the same URL.

So I guess I need to change my schedule? I formerly believed it was a new feature to implement

And what about a separate field for clean URL, that ought to be the task after UI change

Well it is not supported either for all external websites that are handled by auto-select and validation.

That is the vast majority of external links.

yyoung: Would a dialog box to edit raw URL/clean URL helps with keeping the list compact?

I don't get it, isn't the URL input independent of validation and auto-select?

Instead of displaying an input field for the URL, it could be a link with (edit) link.

yyoung: yes it is, I was replying to your previous sentence.

To clarify: Selecting multiple relationships is supported only for URLs that are not handled by auto-select and validation.

Got it :)

The most popular domain names are handled by auto-select and validation.

So there is a very limited support for multiple relationships in fact.

I personally don't think a dialog for URL input would help compact the UI, what is your point?

Instead of displaying (raw? clean?) URL in an input field, we could display it as a link with an (edit) link to pop-up an editing dialog box that would allow to edit raw URL, and possibly amend clean URL.

Or do you mean we should hide the relationships in a dialog and only show the links outside?

So there would be no need to display both raw URL and clean URL in the list.

yyoung: no

IMO we always need a line to display URL whether it is clean or not

that would rather hide the input fields in a dialog.

And previouly we decided to use a bubble on the right for clean URL

yyoung: yes but editors can only edit the raw URL whereas we want to show them the clean URL.

The bubble is not ideal either: it shows the clean URL only on rollover.

Yeah that's a problem :)

Reminder: currently the input raw URL is overridden with clean URL.

So we currently display the clean URL, but make it impossible to still see the raw URL.

So we intend to keep the raw URL on editing, use clean URL for submitting and storing?

Yes, and we might want to allow bypassing clean URL in the future too.

A small dialog for URL input might be reasonable

I had an idea before, to add a button allowing users to replace row URL with the clean one

<it shows the clean URL only on rollover> but a dialog still requires you to click to open

yyoung: the clean URL would be displayed in the list, not the raw URL.

yvanzo: Agree

Oh therefore a dialog may be better since it keeps both raw and clean URL

To sum up, we need a small dialog displaying both raw and clean URL, and only clean URL is displayed in the list outside?

yyoung: right, that is the suggestion :)

yvanzo: Not yet, can't we use database statistics to figure it out?

Sure but you can start with the most obvious: platforms for digital releases.

OK, a way to start is indeed what I want :)

[listenbrainz-server] 14amCap1712 opened pull request #1493 (03master…permissions-set): Use sets to represent Spotify Permissions in backend https://github.com/metabrainz/listenbrainz-serv...

yvanzo: But there's still a problem: how can I filter links with more than one relationships?

how filter?

Do I need to investigate usages on MusicBrainz or just go to external sites to see how they works?

yyoung: See tickets linked to https://tickets.metabrainz.org/browse/MBS-9902

MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links

Amazon, iTunes/Apple Music, Mainly Norfolk are currently not allowed to link through multiple relationships.

And I need to document their possible cases of relationships?

Yes, and there are certainly more online platforms.

I doubt we will find a lot of needs for multiple relationships but to get the music.

yvanzo: Also is the new dialog for URL input finalized? Can I start implementing it this week?

yyoung: Having others input would be nice too.

yyoung: Did you look into adding support for errors target too?

yvanzo: I think adding a property to the validation result object would be enough

But have we finished the discussion last week?

About errors handling, I think so.

The decision of target is not so clear in some circumstances

Ok, any example?

OK I guess I'll have to read the backlog to get it straight

See https://chatlogs.metabrainz.org/libera/metabrai...

Yes, but are we clear about the targets of errors?

moin!

alastairp: monkey : https://www.reddit.com/r/Barcelona/comments/npw...

and then this is also great:

using the GDPR to stop spam callers. good plan!

yyoung: sure, these are the different places to display an error.

yvanzo: I didn't get the conclusion clear in the last discussion, maybe I'll take some time to read the logs

moin ruaok: it will remain secret apparently: moderators removed the content of that post.

yyoung: these are the targets reosarevok required you to add in the PR: errors for URL field, errors for relationships (currently only one)

yyoung: in the future, there can also be one error for each relationship

yyoung: and possibly a catch-all error for both URL and relationships.

oh that's lame. it was something useful that people appreciated, for once. oh right. it wasn't toxic enough for reddit.

yvanzo: And what about the error of incompatible entity type? Should it target link or relationship type?

yyoung: relationship type I guess.

yvanzo: So I'll try to implement it this week by adding an extra property, is that OK?

yyoung: actually could target link... good question :)

yyoung: yes :)

yvanzo: This is indeed the controversial point of our last discussion, isn't it :)

Anyway we can change it on PR review :)

yyoung: for incompatible entity type, maybe have a specific target, and decide where to display it later on.

Right :)

lucifer: Hola!

Hi akshaaatt[m]!

Let's discuss the work then 😇

yup sure. i was thinking we should work on fixing tagger bugs next. what say?

Sure! I see bugs around the cases where the user doesn't select a folder and discards the idea of selecting one

Basically we need to handle more use cases

One bug there

Other than that you mentioned one about what Shivam was facing. The naming scheme

right, also as we discussed earlier, errors in the repository are not propogated to the UI.

so UI remains stuck on loading if there's an error.

Right. I am noting all this down then

What else?

also, some fields are not read correctly i think. yesterday, i opened a Picard tagged file in the app and some fields didn't show up.

Okaay! I'll explore that

i think is a good starting point. let's fix these issues and then retouch base.

Great!

Can we add a media player to the app for the already downloaded songs on the app?

I think we can add this after GSoC

But it'll be really cool

I've previously worked on a media player so won't be too hard to add

i don't think that's a good idea. a media player is difficult to write and maintain. i would prefer just redirecting to installed media players.

Right that's also cool

And for future purposes again, do you think adding the youtube api to the app would be a good choice to directly link the users to the music videos of the releases?

how you would that work?

currently, if a track has a youtube link associated and you click that from the links tab it opens that in Youtube.

Wait give me a while to jot down the resources for it. I'll ping you maybe in an hour so please feel free to work on your stuff until then.

👍

whoops! its LB PR merge day but Github is down.

lucifer: https://guides.codepath.com/android/Streaming-Y...

We just need the youtube video key

that's fine but this approach will only work for tracks with youtube key right?

Yup.

So we used the themoviedb api here and added the youtubeplayerview to showcase the movie trailers

and for those tracks we can directly open them in youtube instead?

We can open them in youtube directly as well

yes, and that seems much better to me.

cool

we have the BrainzPlayer on LB to play tracks from differents sources. i see that is useful in LB context and in web but in android case youtube is always installed on phone.

[listenbrainz-server] 14amCap1712 opened pull request #1494 (03master…youtube-revoke): Add retrying to revoking Youtube access tokens https://github.com/metabrainz/listenbrainz-serv...

we can try to approximate BP but instead of adding an actual media player use intents to play the music.

That sounds cool

lucifer: hi, great to see that we can find the reason for the outage!