lucifer: ^ dataset counts. so we can definitely keep it low. 10k maximum, even down to 5k if we want. we can double-check how long a ~4-5k dataset takes to dump
2021-06-03 15457, 2021
lucifer
nice, +1
2021-06-03 15404, 2021
Toasty joined the channel
2021-06-03 15418, 2021
CatQuest has quit
2021-06-03 15406, 2021
CatQuest joined the channel
2021-06-03 15406, 2021
CatQuest has quit
2021-06-03 15406, 2021
CatQuest joined the channel
2021-06-03 15442, 2021
zas
bitmap, yvanzo, reosarevok: I got "Internal Server Error: 500" multiple times when submitting a release, it usually works when pressing the button again, are you aware of this issue (it appeared few days ago, likely with last prod release).
2021-06-03 15426, 2021
reosarevok
I am not, at least
2021-06-03 15413, 2021
zas
It doesn't seem number of 500s significantly increased over last month though
2021-06-03 15440, 2021
alastairp
monkey: ruaok: with lucifer we just had a chat about how we can keep track of PRs a little bit better, including knowing which ones we want to review/merge next and which ones someone wants someone else to look at with a higher priority
2021-06-03 15459, 2021
alastairp
this is coming back to my previous comments about how sometimes I don't know what to work on next, or that I intentionally choose something easier rather than the "big" thing that we should merge next
2021-06-03 15416, 2021
alastairp
as a trial, we opened a github project at https://github.com/orgs/metabrainz/projects/1, the idea is that we can add PRs to it and order them based on when we want to merge them next
2021-06-03 15430, 2021
alastairp
it's an org-level project, so we can add PRs from multiple repos.
2021-06-03 15410, 2021
alastairp
lucifer and I are going to try it for a while and see if it helps us keep track of work better, and maybe we can revisit it soon to see if it's working or not
2021-06-03 15404, 2021
monkey
All right, I can see this helping indeed
2021-06-03 15431, 2021
lucifer
alastairp: should we add a column for high priority, low priority or consider the top to down order as priority?
2021-06-03 15434, 2021
SaintHime joined the channel
2021-06-03 15442, 2021
SaintHime
IDK if this is the correct channel for this question, but does anyone know why I am unable to import my last.fm scrobbles into listenbrainz? Am I just missing something obvious? This box is grayed out for me as seen in this screen cap: https://s.saint.moe/5voh4. Thanks in advanced!
2021-06-03 15458, 2021
alastairp
lucifer: I think that the order in the column should be priority
2021-06-03 15406, 2021
alastairp
SaintHime: this is indeed the correct place to ask
2021-06-03 15439, 2021
alastairp
monkey: bug due to the props update?
2021-06-03 15400, 2021
lucifer
SaintHime: yeah, its greyed out for me as well. probably a bug. Thanks for reporting.
2021-06-03 15402, 2021
alastairp
Error: No global props element found on the page
2021-06-03 15402, 2021
alastairp
TypeError: Cannot read property 'name' of undefined
2021-06-03 15430, 2021
kepstin has quit
2021-06-03 15402, 2021
monkey
Thanks for reporting SaintHime, I'll look at it right away
2021-06-03 15422, 2021
JuniorJPDJ has quit
2021-06-03 15423, 2021
yyoung[m] has quit
2021-06-03 15423, 2021
elomatreb[m] has quit
2021-06-03 15433, 2021
SaintHime
lucifer glad to know it's not just me. Just made an account and it was driving me insane. I thought I was just dumb and missing something obvious LOL
2021-06-03 15424, 2021
lucifer
:D
2021-06-03 15451, 2021
lucifer
We should look into imporving the error catching in React pages. this didn't show up in sentry.
2021-06-03 15427, 2021
alastairp
lucifer: but this is the chicken and egg problem - no global props == no sentry dsn
2021-06-03 15449, 2021
lucifer
ah, right! 🤦
2021-06-03 15407, 2021
SaintHime
I'm not very technically inclined, so I apologize if this is a dumb question. Can I manually import my last.fm scrobbles with an api call?
2021-06-03 15416, 2021
SaintHime
or something of the sort
2021-06-03 15452, 2021
alastairp
SaintHime: in fact, that's all that the lastfm importer does. it uses the lastfm api to get your scrobbles, converts them to the format required by listenbrainz, and then uses the listenbrainz api to add them
2021-06-03 15430, 2021
alastairp
however I don't know if we have any standalone demo code which does this
2021-06-03 15408, 2021
SaintHime
I see... is there any rate limiting that you know of? I have about 100k scrobbles. Even when the webui gets fixed do you think it will take a while to import?
I get this modal floating and am not able to get past it in local dev. Anyone having an idea of what might be causing it
2021-06-03 15422, 2021
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #1495 (03master…monkey-global-props-lastfm-template): Use base-react.html template in LastFM importer page https://github.com/metabrainz/listenbrainz-server…
MBS-9356: Remove existing editors with no confirmed email and no OAuth tokens/edits/votes
2021-06-03 15408, 2021
lucifer
monkey: oh! makes sense now. approved.
2021-06-03 15423, 2021
reosarevok
Updated the query to add place_rating_raw, not sure any other change requires modifications there? :)
2021-06-03 15444, 2021
shivam-kapila
lucifer: ever seen the above dialog?
2021-06-03 15435, 2021
SaintHime
shivam-kapila, just made an account today and didnt ever see that dialog
2021-06-03 15437, 2021
lucifer
shivam-kapila: no, i haven;t. i am bringing up a dev instance to see if i also get that. you are on the latest master, right?
2021-06-03 15402, 2021
shivam-kapila
SaintHime: this is happening in local dev only. prod works fine
2021-06-03 15406, 2021
shivam-kapila
lucifer: yep
2021-06-03 15428, 2021
SaintHime
shivam-kapila, how do I switch to production?
2021-06-03 15440, 2021
SaintHime
oh you mean that pop up you have
2021-06-03 15447, 2021
SaintHime
sorry I understand what you mean
2021-06-03 15416, 2021
shivam-kapila
yeah SaintHime
2021-06-03 15457, 2021
alastairp
shivam-kapila: that either looks like the anti-spam request when editing the wiki, or maybe you're trying to access the MB oauth login page and you don't have your key and secret configured
2021-06-03 15431, 2021
BrainzGit
[listenbrainz-server] 14MonkeyDo merged pull request #1495 (03master…monkey-global-props-lastfm-template): Use base-react.html template in LastFM importer page https://github.com/metabrainz/listenbrainz-server…
2021-06-03 15421, 2021
alastairp
lucifer: what's the story with LB redis? should we upgrade it along with ^ this PR?
2021-06-03 15412, 2021
alastairp
let me start up the latest version of redis with the copy of the db file that I had. I think that all we'll need to do is 1) take down web, 2) save redis db, 3) take down redis, 4) start up new version of redis
2021-06-03 15434, 2021
alastairp
and ideally we should double-check redis configuration because it's possible that 2 isn't even needed (if we can configure it to always serialise db to disk)
Well thankfully it was an easy one to fix, and we broke it just yesterday so it's all still fresh in memory.
2021-06-03 15439, 2021
alastairp
lucifer: right - although theoretically taking down redis will cause the service to go away in consul so everything should shut down and wait until it comes back
2021-06-03 15405, 2021
SaintHime
You have no clue how long I spent on trying to get it work
2021-06-03 15423, 2021
SaintHime
I didnt see any bug reports online so I assumed it was on my end
2021-06-03 15427, 2021
SaintHime
lmfao
2021-06-03 15410, 2021
lucifer
alastairp: right, consul will bring it down and then keep retrying to bring up the service. the only upside to manually taking down is less spam from sentry i guess :p
2021-06-03 15422, 2021
alastairp
yes right
2021-06-03 15443, 2021
dseomn_ joined the channel
2021-06-03 15450, 2021
dseomn has quit
2021-06-03 15451, 2021
dseomn_ is now known as dseomn
2021-06-03 15458, 2021
SaintHime has quit
2021-06-03 15411, 2021
SaintHime joined the channel
2021-06-03 15425, 2021
alastairp
lucifer: "1:M 03 Jun 2021 10:23:35.396 * Loading RDB produced by version 5.0.3"
2021-06-03 15435, 2021
alastairp
yeah, new redis just happily loads an old version
2021-06-03 15453, 2021
lucifer
nice! :D
2021-06-03 15436, 2021
alastairp
yep, and then it re-saves it as the new version and when you next load it, it's fine
