Not sure whether to just add streaming to that report
2021-06-08 15915, 2021
reosarevok
Or to have a separate one
2021-06-08 15925, 2021
ZaphodBeeblebrox
wait does it include release with physical media and "streaming" url?
2021-06-08 15947, 2021
reosarevok
No, just download at the moment, I think
2021-06-08 15950, 2021
reosarevok
But it could be changed
2021-06-08 15955, 2021
ZaphodBeeblebrox
also there should be a report for releases with "purchase for mailorder" + "dl or streaming"
2021-06-08 15916, 2021
yvanzo
yyoung: looks good to me
2021-06-08 15920, 2021
ZaphodBeeblebrox
and visa versa. digital media with "purchase for mailorder"
2021-06-08 15932, 2021
ZaphodBeeblebrox
might be huge overlap here but
2021-06-08 15912, 2021
yyoung
yvanzo: And what about my PR on enhancing error targets?
2021-06-08 15924, 2021
yvanzo
yyoung: to sum up: depending on the external website, multiple relationships can be either combined together or be allowed separately only.
2021-06-08 15933, 2021
yvanzo
yyoung, reosarevok, ZaphodBeeblebrox: There is no other combinations than download+streaming?
2021-06-08 15940, 2021
yyoung
yvanzo: Under 'get the music' category, I think so
2021-06-08 15904, 2021
reosarevok
That's certainly the most common one. There might be free+paid screaming, if they offer higher quality for a price, but that seems unlikely to matter right now
2021-06-08 15913, 2021
reosarevok
eh. streaming. Although, hey, free screaming sounds fun
2021-06-08 15914, 2021
yvanzo
paid screaming? :D
2021-06-08 15949, 2021
yyoung
reosarevok: Good point, thought about that before
2021-06-08 15926, 2021
yyoung
But currently we don't treat trial streaming as free streaming, right?
2021-06-08 15934, 2021
reosarevok
No, not trial :)
2021-06-08 15951, 2021
ZaphodBeeblebrox
yes we do! like beatport and spotify with 30 seconds
2021-06-08 15908, 2021
ZaphodBeeblebrox
I think the majority of these mailorder+ streaming/dl will be bandcamp ones
2021-06-08 15904, 2021
yvanzo
yyoung: It looks good overall but it's huge, I did not read it all yet :)
2021-06-08 15949, 2021
reosarevok
ZaphodBeeblebrox: we don't generally link to spotify 30 seconds, spotify is AFAICT still free (with ads) full length with an account, no?
2021-06-08 15905, 2021
yyoung
yvanzo: It certainly has some trivial points that may need discussion :)
i wouldn't know becase i fogot my password and you need faceboo kand genders to create a new ccount
2021-06-08 15929, 2021
yyoung
yvanzo: And about the new URL input dialog, seems we haven't recived any other input, should I start implementing it?
2021-06-08 15920, 2021
ZaphodBeeblebrox
yyoung: new url dialogue?
2021-06-08 15943, 2021
yyoung
The coding period starts today, I'm worrying if I'm getting a good start :)
2021-06-08 15906, 2021
yyoung
ZaphodBeeblebrox: yvanzo suggested a separate dialog for URL input last week
2021-06-08 15944, 2021
ZaphodBeeblebrox
ok? wher in the release editor?
2021-06-08 15927, 2021
shivam-kapila
Congrats LB team on 1500 PRs 🎉
2021-06-08 15938, 2021
yyoung
Just for URL input, excluding relationships, it contains a raw URL and a clean URL
2021-06-08 15951, 2021
ZaphodBeeblebrox
uh
2021-06-08 15910, 2021
ZaphodBeeblebrox
but i don't get it, does it mean there is a dialogue nstead of fields in the release editor
2021-06-08 15953, 2021
ZaphodBeeblebrox
i like the fields. it makes it simple to paste many links if there are
2021-06-08 15957, 2021
yvanzo
yyoung: answered reosarevok's comments at least :)
2021-06-08 15959, 2021
yyoung
It is just URL text in release editor with a button to open the editing dialog
2021-06-08 15920, 2021
yvanzo
lucifer: there is a page about it in sysadmin wiki )
2021-06-08 15922, 2021
yvanzo
:)
2021-06-08 15934, 2021
ZaphodBeeblebrox
i like the idea of being able to edit url attributes (ended etc)
2021-06-08 15938, 2021
yyoung
yvanzo: Thanks then
2021-06-08 15940, 2021
ZaphodBeeblebrox
but still
2021-06-08 15948, 2021
lucifer
yvanzo: ah! let me check that. thanks!
2021-06-08 15903, 2021
ZaphodBeeblebrox
is this "a box you must dialogue open" or is it still "can i paste 5 links in fields like before"
2021-06-08 15910, 2021
yyoung
That's a good question, adding URL would be different if there's no input box outside
2021-06-08 15945, 2021
ZaphodBeeblebrox
:|
2021-06-08 15952, 2021
ZaphodBeeblebrox
it needs to stil lwork as before
2021-06-08 15906, 2021
ZaphodBeeblebrox
but having an aditional "edit this url" type thing is very good
2021-06-08 15906, 2021
yvanzo
ZaphodBeeblebrox: it should be both
2021-06-08 15919, 2021
ZaphodBeeblebrox
yvanzo: sounds good. is it up on test?
2021-06-08 15923, 2021
yvanzo
no
2021-06-08 15932, 2021
ZaphodBeeblebrox will happily test it on test
2021-06-08 15917, 2021
yyoung
yvanzo: So we still keep an input box outside but with a dialog to view the clean URL?
2021-06-08 15943, 2021
ZaphodBeeblebrox
yyoung: i'm confused what you mean with "outside" tbh
2021-06-08 15902, 2021
ZaphodBeeblebrox
you mean *in* the relationship editor right?
2021-06-08 15920, 2021
yyoung
I mean in the editor but outside the dialog :)
2021-06-08 15929, 2021
ZaphodBeeblebrox
yes but the dialogue isn't a thing yet
2021-06-08 15940, 2021
ZaphodBeeblebrox
and the dialogue itself is *in* the release editor
2021-06-08 15902, 2021
yyoung
OK then :D
2021-06-08 15903, 2021
yvanzo
ZaphodBeeblebrox: it's work in progress, even for the design part, but the plan is to gradually release changes, not to wait for the end of GSoC project.
2021-06-08 15903, 2021
ZaphodBeeblebrox
you're working fro m"within" this dialogue
2021-06-08 15920, 2021
ZaphodBeeblebrox
yvanzo: that soudns like a great idea
2021-06-08 15948, 2021
ZaphodBeeblebrox
yyoung: but remember that us who don't evne know the details will think of it as "within the (thing we already know)"
2021-06-08 15916, 2021
yyoung
Sorry for no deliverable feature so far :)
2021-06-08 15923, 2021
ZaphodBeeblebrox
by all means. don't worry
2021-06-08 15925, 2021
ZaphodBeeblebrox
yyoung: the only thin ki really care about is that already excisting features aren't subplanted or changed in such a way that usecases are radically changed
2021-06-08 15930, 2021
reosarevok
yyoung: hey, you've fixed several bugs and issues by now :)
2021-06-08 15937, 2021
ZaphodBeeblebrox
indeed
2021-06-08 15948, 2021
yvanzo
yyoung: yes you're getting a good start :)
2021-06-08 15948, 2021
yyoung
ZaphodBeeblebrox: We're trying for that :)
2021-06-08 15905, 2021
ZaphodBeeblebrox
yyoung: ace!
2021-06-08 15948, 2021
yyoung
reosarevok, yvanzo: Thank you, just hoping to start early for GSoC project :)
2021-06-08 15947, 2021
yvanzo
yyoung: Maybe the input after "Add another link" could create a new item in the list (with link to a dialog box) instead of being an item like others?
2021-06-08 15933, 2021
yvanzo
I mean it should probably not share the same code as items having URL entered.
2021-06-08 15950, 2021
yvanzo
(Just an idea)
2021-06-08 15939, 2021
yvanzo
So that editors can still paste new URLs in an input field, and URLs can still be edited with a rich dialog box.
2021-06-08 15902, 2021
yyoung
So how will the appearance differ?
2021-06-08 15931, 2021
yyoung
Are we displaying input boxes both in the editor and the dialog?
2021-06-08 15911, 2021
yvanzo
input box only in dialog box and the last item for adding extra URL
2021-06-08 15922, 2021
yvanzo
s/input box/input field/
2021-06-08 15933, 2021
ritiek joined the channel
2021-06-08 15901, 2021
yyoung
So users cannot edit existing links without opening the dialog?
So users can edit existing links by knowing what they do thanks to details in dialog box (the goal is not to complicate their workflow).
2021-06-08 15943, 2021
ZaphodBeeblebrox
[11:52] <yvanzo> input box only in dialog box <-- :|
2021-06-08 15957, 2021
ZaphodBeeblebrox
[11:53] <yyoung> So users cannot edit existing links without opening the dialog?
2021-06-08 15957, 2021
ZaphodBeeblebrox
no good
2021-06-08 15918, 2021
ZaphodBeeblebrox
ok
2021-06-08 15929, 2021
ZaphodBeeblebrox
tbh i have to see it in action before i actually say
2021-06-08 15945, 2021
yvanzo
Right, it's very abstract right now.
2021-06-08 15950, 2021
ZaphodBeeblebrox nods
2021-06-08 15924, 2021
yyoung
So do I need to make a UI prototype for this? would take some time though
2021-06-08 15950, 2021
yvanzo
yyoung: maybe fix the label position in your current PR first :)
2021-06-08 15905, 2021
yvanzo
it might require to update Selenium tests too (?)
2021-06-08 15935, 2021
yyoung
yvanzo: Sure, what about the default option?
2021-06-08 15946, 2021
yvanzo
reosarevok: does the answer seem reasonable? having a default that catch all options: either url or relationship, so to prevent error type mismatch if type is missing?
2021-06-08 15952, 2021
yyoung
About the selenium tests, I put the target in another div so it isn't selected now
2021-06-08 15902, 2021
reosarevok
yvanzo: sure, I guess :)
2021-06-08 15925, 2021
yyoung
Since the target is only displayed temporarily, I guess no selenium test is needed for that?
