TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MBS-11750 (reo)
2021-06-28 17952, 2021
lucifer
alastairp: LB email PR is updated. also opened a docker-server-configs PR to log out all users. to be merged only after we deploy the email PR.
2021-06-28 17936, 2021
alastairp
nice, looking at it now
2021-06-28 17932, 2021
lucifer
thanks!
2021-06-28 17908, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MBS-11750 (reo), MBBE-40 (reo)
2021-06-28 17956, 2021
BrainzGit
[musicbrainz-server] 14reosarevok opened pull request #2152 (03master…MBS-11732): MBS-11732 / MBS-11733: Remove LYRICSnMUSIC / WikiaParoles from lyrics whitelist https://github.com/metabrainz/musicbrainz-server/…
a 400 is raised when iterating using map but its returned as a 500.
2021-06-28 17946, 2021
alastairp
lucifer: no, I'm not sure. can you reproduce it clearly by just changing the way that you iterate?
2021-06-28 17932, 2021
alastairp
my gut feel for it being a 500 is that the code that maps an exception to a specific status code isn't working properly (because this is a custom exception)
2021-06-28 17901, 2021
lucifer
possible. i am trying to iterate using a loop now, let's see if tests pass.
2021-06-28 17940, 2021
ruaok
we also need to record a new youtube video. I made the first one -- who wants to make the next one? alastairp monkey lucifer ?
2021-06-28 17917, 2021
lucifer
right, i forgot about that email. i'll try to do that.
2021-06-28 17925, 2021
ruaok
sweet, thanks!
2021-06-28 17948, 2021
lucifer
these connection closed errors are becoming more frequent and annoying in tests. do we have any idea why they occur?
2021-06-28 17908, 2021
ruaok
I've been wondering the same, but have no clue.
2021-06-28 17911, 2021
lucifer
yeah, i don't have any idea either. i'll open a ticket for further investigation.
2021-06-28 17925, 2021
lucifer
alastairp, tests passes after changing map to a loop.
2021-06-28 17959, 2021
alastairp
that's... odd
2021-06-28 17947, 2021
wargreen joined the channel
2021-06-28 17918, 2021
MRiddickW joined the channel
2021-06-28 17921, 2021
lucifer
yup, right. i am merging the loop version. will try to understand why this happened later.
2021-06-28 17953, 2021
lucifer
thanks for taking care of 1518, alastairp. i'll try to fix the failing test and then merge.
2021-06-28 17919, 2021
alastairp
lucifer: btw, I almost always use list comprehensions instead of map in python
2021-06-28 17949, 2021
lucifer
oh. thinking of it, comprehension looks better than loop as well. changing to it.
alastairp: regarding troi PR, i didn't reply to the user because i wasn't sure that similarity.ab is up anyways. i think it used to be the bono AB instance which now use for testing other PRs.
2021-06-28 17953, 2021
alastairp
right. this might be the same person I had a chat to on the forums who was using it
2021-06-28 17908, 2021
alastairp
after that discussion I started it up again, but who knows, maybe we replaced it again ;)
2021-06-28 17942, 2021
alastairp
I need to work out a better way of doing email. I filter meb stuff to a folder and then forget about it
2021-06-28 17944, 2021
lucifer
yeah probably. should we merge the relevant PR into master?
2021-06-28 17901, 2021
alastairp
which relevant PR?
2021-06-28 17915, 2021
zas
yvanzo: ping
2021-06-28 17930, 2021
lucifer
the PR which contains the endpoints that troi needs.
2021-06-28 17945, 2021
zas
yvanzo: SIR prod is stuck, usual cmp error
2021-06-28 17944, 2021
alastairp
right. that's definitely something I should do. after all of our testing I think it's probably good to merge
[listenbrainz-server] 14amCap1712 merged pull request #1422 (03master…require-email): LB-849: Require users to have a confirmed email before creating an LB account https://github.com/metabrainz/listenbrainz-server…
2021-06-28 17913, 2021
lucifer
\o/
2021-06-28 17919, 2021
lucifer
finally
2021-06-28 17933, 2021
lucifer
alastairp: ruaok: let's deploy this :D
2021-06-28 17934, 2021
ruaok
go for it. I have nothing else that needs deploying -- unless you want to try the user similarity stuff.
2021-06-28 17906, 2021
lucifer
we'll need to do 3 things. 1) post the blog post 2) deploy this PR 3) merge docker-server-configs and restart web containers if they don't automatically
2021-06-28 17934, 2021
lucifer
user similarity only needs changes on spark side so that can be tested irrespective of this.
2021-06-28 17908, 2021
ruaok
agreed, I can try the spark side of things and am happy to post the blog post.
2021-06-28 17915, 2021
lucifer
+1
2021-06-28 17923, 2021
ruaok
mind if go ahead and test the similarity stuff now?
"This way you are free to change the user’s alternative id to a new randomly generated value when the user changes their password, which would ensure their old authentication sessions will cease to be valid."
2021-06-28 17954, 2021
alastairp
so yes, I'm 99% sure that to log everyone out we should just give everyone a new login_id (then the login_id that they have in their cookie will become invalid and they'll be forced to re-login)
2021-06-28 17951, 2021
lucifer
alastairp: i see. makes sense. i had looked that at it earlier but didn't understand it correctly.
