0:01 AM
akashgp09 has quit
2021-06-30 18124, 2021
0:33 AM
HenryG has quit
2021-06-30 18126, 2021
0:35 AM
HenryG joined the channel
2021-06-30 18117, 2021
1:36 AM
wargreen has quit
2021-06-30 18126, 2021
1:43 AM
wargreen joined the channel
2021-06-30 18113, 2021
2:31 AM
MRiddickW joined the channel
2021-06-30 18109, 2021
4:30 AM
yyoung
yvanzo: Good morning
2021-06-30 18106, 2021
4:31 AM
yvanzo
mo’’in’
2021-06-30 18140, 2021
4:31 AM
yyoung
Have you read my PR? :)
2021-06-30 18121, 2021
4:35 AM
yvanzo
Yes and also tested it, it works nicely.
2021-06-30 18125, 2021
4:36 AM
yyoung
Thanks! Do you mean #2151 or #2114 ?
2021-06-30 18156, 2021
4:37 AM
yvanzo
2151
2021-06-30 18155, 2021
4:39 AM
yyoung
I see, any suggestions on the code?
2021-06-30 18107, 2021
4:42 AM
yvanzo
yyoung: yes, the "raw url" and "clean url" labels refer to the code and will probably not be explicit enough to editors.
2021-06-30 18124, 2021
4:44 AM
yyoung
Maybe change it to "URL" and "Cleaned up to" ?
2021-06-30 18145, 2021
4:44 AM
yvanzo
That looks better indeed.
2021-06-30 18126, 2021
4:45 AM
yyoung
OK, and the variable names remain unchanged in the code, right?
2021-06-30 18144, 2021
4:45 AM
yvanzo
yes
2021-06-30 18155, 2021
4:45 AM
yyoung
OK
2021-06-30 18103, 2021
4:48 AM
yyoung
Any other suggestion? :)
2021-06-30 18116, 2021
4:50 AM
yvanzo
It lacks tests.
2021-06-30 18116, 2021
4:51 AM
yyoung
I know, just want to have your review first, to ensure I'm on the right way :)
2021-06-30 18146, 2021
4:51 AM
yyoung
If so I'll start working on the tests
2021-06-30 18119, 2021
5:06 AM
yyoung
2021-06-30 18140, 2021
5:07 AM
yvanzo
Probably not, the full URL text must be shown for editors to visually check.
2021-06-30 18157, 2021
5:07 AM
yyoung
Alright.
2021-06-30 18119, 2021
5:08 AM
yvanzo
When in doubt, ask bitmap and reosarevok too :)
2021-06-30 18142, 2021
5:08 AM
yyoung
Then should I disable text wrap?
2021-06-30 18146, 2021
5:08 AM
yyoung
OK :)
2021-06-30 18101, 2021
5:09 AM
yvanzo
Do not hesitate to ask MB editors for feedback from UI changes, either on #musicbrainz channel or on community forums.
2021-06-30 18100, 2021
5:11 AM
yvanzo
(They will be able to test it in beta, but if you want earlier feedback send them screenshots/screencasts.)
2021-06-30 18104, 2021
5:12 AM
yyoung
Roger.
2021-06-30 18127, 2021
5:12 AM
yvanzo
yyoung: Anything else before I go?
2021-06-30 18100, 2021
5:14 AM
yyoung
2021-06-30 18133, 2021
5:14 AM
yyoung
It occurs to me that the error targets still need to be enhanced
2021-06-30 18112, 2021
5:15 AM
yvanzo
Yes
2021-06-30 18146, 2021
5:15 AM
yyoung
This is the default message for ERROR_TARGETS.URL
2021-06-30 18129, 2021
5:16 AM
yyoung
And the corresponding URLCleanup rule is indeed a regexp check for URL
2021-06-30 18156, 2021
5:16 AM
yyoung
But in this case it shouldn't target URL
2021-06-30 18144, 2021
5:18 AM
yyoung
I haven't figure out a reasonable solution though, so maybe deal with it later
2021-06-30 18153, 2021
5:18 AM
yyoung
yvanzo: That's all for now, thanks!
2021-06-30 18108, 2021
5:19 AM
yvanzo
It should target the discography entry.
2021-06-30 18154, 2021
5:19 AM
yyoung
Yes but the problem is URLCleanup did not provide enough information
2021-06-30 18116, 2021
5:20 AM
yvanzo
Right, the 'validate' function for 'amazon' should be enhanced.
2021-06-30 18107, 2021
5:21 AM
yvanzo
Not only the URLCleanup stuff actually.
2021-06-30 18151, 2021
5:21 AM
yvanzo
When it validates one relationship and not the other for the same URL, the target should probably be the second relationship.
2021-06-30 18100, 2021
5:22 AM
yyoung
Hmmm maybe we can check whether there're multiple relationships under this URL and react accordingly
2021-06-30 18131, 2021
5:22 AM
yvanzo
Yes
2021-06-30 18152, 2021
5:22 AM
yyoung
My current mechanism is to display URL-targeted message under the input box
2021-06-30 18115, 2021
5:23 AM
yyoung
But the validation is carried out for each relationship
2021-06-30 18147, 2021
5:23 AM
yyoung
OK then, I'll try to fix it later
2021-06-30 18155, 2021
5:24 AM
yyoung
I'll start working on the tests, and ask editors for their opinions on the UI change the other day
2021-06-30 18132, 2021
5:27 AM
yvanzo
yyoung: OK, keep up the good work! :)
2021-06-30 18115, 2021
5:35 AM
yvanzo
zas: Some search index updates from Monday were missing, I resent them.
2021-06-30 18151, 2021
5:36 AM
yvanzo
But a full rebuild of search indexes will probably be needed for earlier missing items.
2021-06-30 18133, 2021
6:03 AM
yvanzo
If search.index queue is messing up again, just stop sir-prod on pink to stop it writing unneeded large logs.
2021-06-30 18155, 2021
6:16 AM
akashgp09 joined the channel
2021-06-30 18119, 2021
6:47 AM
lucifer
zas: hi! ssh connections to bono are timing out. can you please help?
2021-06-30 18117, 2021
6:48 AM
lucifer
2021-06-30 18138, 2021
7:02 AM
MRiddickW has quit
2021-06-30 18114, 2021
7:12 AM
zas
timeout for me too
2021-06-30 18147, 2021
7:13 AM
zas
it doesn't answer to ping either, I reset it
2021-06-30 18145, 2021
7:16 AM
zas
lucifer: server is back
2021-06-30 18127, 2021
7:24 AM
lucifer
zas: thanks! able to login now.
2021-06-30 18116, 2021
7:55 AM
okno_ joined the channel
2021-06-30 18105, 2021
7:56 AM
BrainzGit
2021-06-30 18103, 2021
8:28 AM
lucifer
2021-06-30 18120, 2021
8:28 AM
lucifer
alastairp: ^ trying to train dataset on bono raises the above exception
2021-06-30 18146, 2021
8:53 AM
alastairp
lucifer: yeah, it can be temperamental. how big is the dataset you were evaluating?
2021-06-30 18104, 2021
8:54 AM
lucifer
2 classes, ~150 recordings each.
2021-06-30 18101, 2021
8:55 AM
alastairp
that _should_ be enough to prevent the usual errors
2021-06-30 18134, 2021
8:55 AM
alastairp
at a guess from the error message, one of the preprocessing tries to delete the ['metadata'] block from the ll json, but maybe AB has filtered that out before?
2021-06-30 18109, 2021
8:56 AM
alastairp
2021-06-30 18119, 2021
8:56 AM
alastairp
maybe this failOnUnmatched could help?
2021-06-30 18141, 2021
8:56 AM
alastairp
2021-06-30 18139, 2021
9:06 AM
lucifer
i see makes sense.
2021-06-30 18159, 2021
9:11 AM
lucifer
2021-06-30 18137, 2021
9:12 AM
lucifer
so passing failOnUnmatched=False here should be enough?
2021-06-30 18136, 2021
9:13 AM
alastairp
unsure - I don't know if our project template file allows this parameter to be changed
2021-06-30 18137, 2021
9:14 AM
loujine
2021-06-30 18104, 2021
9:18 AM
lucifer
2021-06-30 18140, 2021
9:22 AM
alastairp
lucifer: yes, that's probably better. however - 1) double-check the git tag that we check out when compiling gaia, that feature may not be present in the version that we're using
2021-06-30 18135, 2021
9:23 AM
alastairp
and 2) this process did work, so I'm a bit interested in working out why we're running into problems with it - I suspect that there's a solution to this problem that means we don't need to make such a drastic change
2021-06-30 18142, 2021
9:24 AM
BrainzGit
2021-06-30 18134, 2021
9:26 AM
lucifer
yeah, you're right, we're checking out 2.4.5. the failOnUnmatched is only present in latest master.
2021-06-30 18102, 2021
9:27 AM
lucifer
2 makes sense as well.
2021-06-30 18108, 2021
9:28 AM
alastairp
unfortunately we may have to dig into the gaia code, but I'm a bit surprised that it's buggy
2021-06-30 18112, 2021
9:28 AM
alastairp
which branch are you running this on?
2021-06-30 18146, 2021
9:28 AM
lucifer
2021-06-30 18127, 2021
9:29 AM
lucifer is scared of diagnosing c++ code
2021-06-30 18154, 2021
9:30 AM
lucifer
on the bright side, sklearn eval completed successfully
2021-06-30 18131, 2021
9:31 AM
lucifer
2021-06-30 18107, 2021
9:32 AM
alastairp
ok great, nice to confirm that the end-to-end works there
2021-06-30 18146, 2021
9:32 AM
alastairp
I wonder if there's some changed code that accidentally runs during the gaia flow that shouldn't
2021-06-30 18109, 2021
9:33 AM
lucifer
yeah, i would want to try out the dataset on AB prod and see if it works there.
2021-06-30 18121, 2021
9:33 AM
lucifer
should we do a release first?
2021-06-30 18148, 2021
9:33 AM
alastairp
yeah, sure!
2021-06-30 18127, 2021
9:34 AM
lucifer
nice! :D
2021-06-30 18148, 2021
9:34 AM
lucifer
any PRs ready to merge or should I create the release?
2021-06-30 18127, 2021
9:35 AM
alastairp
no, everything merged for now
2021-06-30 18135, 2021
9:35 AM
lucifer
👍
2021-06-30 18102, 2021
9:36 AM
BrainzGit
2021-06-30 18144, 2021
9:43 AM
outsidecontext
loujine: thanks for sharing that link
2021-06-30 18106, 2021
9:53 AM
lucifer
updating AB prod.
2021-06-30 18148, 2021
9:55 AM
loujine
outsidecontext: np
2021-06-30 18154, 2021
9:55 AM
lucifer
alastairp: AB didn't start as expected.
2021-06-30 18101, 2021
9:56 AM
alastairp
looking
2021-06-30 18134, 2021
9:56 AM
lucifer
i have reverted to previous image.
2021-06-30 18102, 2021
9:57 AM
lucifer
2021-06-30 18126, 2021
9:57 AM
lucifer
this was the log before i shut down container from today's image.
2021-06-30 18150, 2021
9:57 AM
lucifer
uwsgi didn't start up or exited with some errors proabably?
2021-06-30 18104, 2021
9:58 AM
alastairp
there was nothing after the enabling syslog message?
2021-06-30 18109, 2021
9:58 AM
lucifer
oh my bad 🤦
2021-06-30 18120, 2021
9:58 AM
alastairp
seems like consul was waiting for config items that don't exist?
2021-06-30 18123, 2021
9:58 AM
lucifer
2021-06-30 18128, 2021
9:58 AM
lucifer
yes right
2021-06-30 18133, 2021
9:58 AM
lucifer
this is not merged yet
2021-06-30 18137, 2021
9:58 AM
alastairp
sure
2021-06-30 18139, 2021
9:58 AM
alastairp
go ahead with that one
2021-06-30 18145, 2021
9:58 AM
lucifer
👍
2021-06-30 18104, 2021
10:00 AM
lucifer
up now.
2021-06-30 18108, 2021
10:03 AM
alastairp
nice
2021-06-30 18139, 2021
10:05 AM
lucifer
all AB containers updated.
2021-06-30 18133, 2021
10:08 AM
lucifer
2021-06-30 18113, 2021
10:10 AM
lucifer
did something related to AB volumes change recently?
2021-06-30 18151, 2021
10:13 AM
alastairp
we moved servers
2021-06-30 18106, 2021
10:14 AM
alastairp
I guess we didn't copy the contents/permission of that volume
2021-06-30 18157, 2021
10:14 AM
lucifer
but that should be in the docker-server-configs scripts?
2021-06-30 18118, 2021
10:15 AM
alastairp
what should be? the definition of the volume, yes
2021-06-30 18154, 2021
10:15 AM
alastairp
but given the problems we've had with permissions on dumps on LB, I'm not surprised that AB volumes don't start up properly either :)
2021-06-30 18127, 2021
10:17 AM
lucifer
ah right the definitions are there.
2021-06-30 18153, 2021
10:17 AM
lucifer
yeah, indedd.
2021-06-30 18132, 2021
10:18 AM
lucifer
well, good thing boingo isn't decommissioned yet :)
2021-06-30 18140, 2021
10:18 AM
alastairp
so we can fix the definitions of the volumes in the Dockerfile, but we should also copy the contents of the volume from boingo
2021-06-30 18143, 2021
10:18 AM
alastairp
yeah. I'll do that now
2021-06-30 18157, 2021
10:18 AM
alastairp
we should set up backup to create backups from clash too
2021-06-30 18103, 2021
10:19 AM
alastairp
(and disable boingo)
2021-06-30 18114, 2021
10:19 AM
lucifer
+1
2021-06-30 18150, 2021
10:21 AM
alastairp
lol, suddenly my list for today got really big
2021-06-30 18126, 2021
10:22 AM
lucifer
lol XD
2021-06-30 18144, 2021
10:24 AM
lucifer
let me if I can help with some of it? :)
2021-06-30 18148, 2021
10:24 AM
lucifer
*let me know
2021-06-30 18131, 2021
10:25 AM
alastairp
thanks, but I think I'm good
2021-06-30 18159, 2021
10:25 AM
alastairp
2021-06-30 18111, 2021
10:26 AM
alastairp
something to keep in mind in a possible future
2021-06-30 18134, 2021
10:27 AM
lucifer
yes indeed. might be useful to us.
2021-06-30 18135, 2021
10:29 AM
BrainzGit
2021-06-30 18108, 2021
11:17 AM
BrainzGit
2021-06-30 18129, 2021
12:07 PM
lucifer
rdswift: should i merge 1536?
2021-06-30 18137, 2021
12:07 PM
lucifer
ah, sorry. ruaok ^
