the delete callback is added in the connect_to_rabbitmq method. delete_callback method is also wrapped by a action_wrapper decorator which contains another call to connect_to_rabbitmq, https://github.com/metabrainz/sir/blob/master/sir…
2021-08-06 21853, 2021
yvanzo
lucifer: also added instructions to rabbitmq PR for docker server configs
2021-08-06 21848, 2021
lucifer
so if the connection to rabbitmq fails it could lead to recursing infinitely.
2021-08-06 21846, 2021
lucifer
thanks again for the rabbitmq instructions! :D
2021-08-06 21805, 2021
bitmap
reosarevok: re: MBS-11852 - should it? I see we call load_for_edits, but that doesn't appear to load editors
maybe 48 hours would be an okay compromise, given your last comment there. I was just wanted the behavior to match the "few days" language we already use
ruaok: i increased the timeout temporarily with help of yvanzo's instructions, and deployed 1546. i have requested an entire batch of stats, working well currently half of stats processed and no timeouts :D
2021-08-06 21816, 2021
lucifer
one job recordings all time stats took 40 mins to run 🤯, its probably the longest one we have currently methinks.
2021-08-06 21817, 2021
ruaok
reosarevok: yvanzo bitmap can one of you please kick the mb website container on .42? See telegram for details.
2021-08-06 21843, 2021
bitmap
ruaok: sure
2021-08-06 21810, 2021
bitmap
kicked (it was on pink ftr)
2021-08-06 21838, 2021
yvanzo
Search has been completely updated with edits since yesterday.
2021-08-06 21824, 2021
Etua has quit
2021-08-06 21823, 2021
peterhil has quit
2021-08-06 21845, 2021
lucifer
ruaok: entire batch of stats processed without any delivery timeout :D
2021-08-06 21814, 2021
ruaok
!m lucifer
2021-08-06 21814, 2021
BrainzBot
You're doing good work, lucifer!
2021-08-06 21824, 2021
lucifer
:-D
2021-08-06 21826, 2021
akshaaatt[m]
Hi lucifer !
2021-08-06 21833, 2021
lucifer
hi!
2021-08-06 21856, 2021
akshaaatt[m]
In the mb android app's manifest, we have defined a few things
2021-08-06 21813, 2021
akshaaatt[m]
Like the instant play experience tag and the Google backup api key
2021-08-06 21819, 2021
akshaaatt[m]
I would like to understand if we use them?
2021-08-06 21851, 2021
lucifer
those are remanants of the past. i don't recall them being used in the current version of the app.
2021-08-06 21804, 2021
akshaaatt[m]
Yup
2021-08-06 21820, 2021
akshaaatt[m]
I was documenting the things so I'll be removing them then.
2021-08-06 21836, 2021
akshaaatt[m]
And after having a quick overview of the permission our app needs
2021-08-06 21806, 2021
akshaaatt[m]
I don't think we need READ_PHONE_STATE and ACCESS_WIFI_STATE
2021-08-06 21835, 2021
akshaaatt[m]
We are able to check whether the phone is connected to the internet using the ACCESS_NETWORK_STATE alone
2021-08-06 21850, 2021
lucifer
cool let's remove those then, but be sure to check if an older version has some permission differences
2021-08-06 21804, 2021
akshaaatt[m]
Yup
2021-08-06 21832, 2021
akshaaatt[m]
Since our minSdk version is 21, we are at par with the latest and best needs
