#metabrainz

[musicbrainz-server] 14y-young opened pull request #2219 (03master…MBS-3774): MBS-3774: Add URL with begin and end dates https://github.com/metabrainz/musicbrainz-serve...

mo’’in’

moin!

bitmap: almost done with flow for guess case handlers, but:

(that's from your recent fix and it works nicely I think, but flow doesn't like it)

[musicbrainz-server] 14reosarevok opened pull request #2220 (03master…guess-case-refactoring-part-2): MBS-11805 (II): More guess case refactoring and flow types https://github.com/metabrainz/musicbrainz-serve...

Pushed the branch in case you want to play with it ^

yvanzo: Good morning! I've finished most of MBS-3774 implementation, rebased MBS-9902 and roughly finished refactoring, now testing.

MBS-3774: Add URL relationship with begin and end dates https://tickets.metabrainz.org/browse/MBS-3774

MBS-9902: Support auto-select/cleanup/validation of more than one relationship type for external links https://tickets.metabrainz.org/browse/MBS-9902

I'm thinking whether we can remove the 'Type:' label, because text will overflow when relationship name is too long, since we have date period next to it; or we may display date period in the next line.

yyoung[m]: Using 'display' attribute (inline-block or something) should keep it on the same line if possible, and automatically move it to the next line if needed.

Good job with opening PR for begin/end date :)

yvanzo: Yes that's what it already is, but auto wrap doesn't look good to me.

There should be a way to prevent breaking lines in the middle of dates.

OK so here is 'white-space: nowrap' ^

Looks good now, thank you.

Should work here since column’s width here is much larger than date range. :)

(Otherwise we would need a React version of formatUserDate)

What do you mean?

If we wanted the line break to occur in between begin date and end date (which is not what we want because of column’s width is large enough for a date range), we would need formatUserDate to include HTML tags (as React elements).

So is the image above the intentional effect?

Yes :)

OK then :)

That was not my initial thought, but it’s much better actually. :)

Same to me :)

reosarevok: I spotted a few issues with localization messages, do you have time to discuss them?

It's nice that we don't need another row or grid layout

mooooooin!

yvanzo: sure

reosarevok: Ok, I did not translate server resources for a few releases.

First issue is with added curly quotes in root/search/error/General.js

It seems it has the same role as existing parenthesis.

So parenthesis look like being part of the query.

Let me see

Oh, so you think we should have just one or the other

Seems sensible to me - which one do you prefer?

Actually, it's older than current beta: https://github.com/metabrainz/musicbrainz-serve...

Yeah, that's quite old

Actually, you changed straight quotes with curly quotes in https://github.com/metabrainz/musicbrainz-serve...

So the previous version was even worse :D

Oh

Yeah, some had no quotes at all, some had straight quotes

Query may include either parenthesis or (straight quotes), so I’m not sure what would be the best delimiter.

The <code> tag could be moved into the query placeholder too.

reosarevok: curly quotes are probably the best delimiter as they should look different enough from potential straight quotes in monospace.

I'm fine with that - wanna send a PR?

I can also do it myself I guess if you prefer

May I ask why MB is using curly quotes instead of straight quotes? In my memory English uses straight ones :)

yyoung[m]: no, typewriters do :)

Proper English uses curly

reosarevok: Ok, will do. There are 4 messages with similar quoted query. Will apply the same changes.

Thanks <3

Did you have more strings that seemed weird?

OK so let must be the old school thing we learnt :D

https://wiki.musicbrainz.org/User:Jacobbrett/En... is something I've always found useful :)

In most cases it doesn't matter, really, but since we prefer the unicode punctuation on titles and names, it makes sense to try to use it elsewhere too

(we aren't super consistent with it rn)

Yes I ran into that days before and did some research :)

reosarevok: Yes, other one is “Cleaned up to”. When reading it as a translator, it seemed weird, probably not clear enough.

But curly quotes will cause problems under certain font, since it's wider

Many people got confused with “raw”, “clean”, “old”, “new” URLs.

Hmm. Not sure what would be better. Original: vs Cleaned up version:? But it's still not too obvious for translators, so maybe specify a context

It looks like these terms are not self-explanatory and were originally used in code (where there is a context).

+1 For translator problems, some expressions just don't make sense in other languages

This “clean-up” is actually formatting/normalizing URLs. Would that be more telling to non-coders? (Or the opposite? :/ )

yvanzo: is "processed" better? Or "normalized", yeah

“processed” doesn’t explain the goal of the process

yvanzo: yyoung[m]: actually I still think it would be beneficiary if the box didn't turn into a link but insteadstayed a box. then the pencilbox or whatever with he "pasted" and "normalised" could both be links/text instead

that's consistent with how it already works and doesn't break workflow that depends on pasting from two sources (eg how i do instrument statickbrainz image links)

furtherore i invite you to try this aproach and to ask users wich they prefer

CatQuest: Do you mean the raw URL is displayed as link in the popover instead of the editor?

yyoung[m]: Yes indeed!

Our main concerns about this before are related to highlights

prod right now https://usercontent.irccloud-cdn.com/file/jNeBF...

and this is what happens if itry adding static brainz image links https://usercontent.irccloud-cdn.com/file/AblTb...

CatQuest: Please be more specific about how it does “break workflow”.

because I do this by copying the first part from a text/stick and the second part (the one that varies) from typed text to reosarevok

so i'll have to click pencils every time instead

as a result i'm using prod right now

CatQuest: I'm sorry about the icons in your browser, I can't reproduce that here, I'll try Firefox some day

First part? second part?

of the url

Please give all the details.

It would be great if you can provide some details, e.g. using element inspector

what?

No need of element inspector

Bring a full example please.

yvanzo: IIUC he means he'll paste all the links of the same site, and change the path later

look I've been trying to be constructive here but you're bulldozing your way. this "nitpick" thing is osmething you're doing in order totake up my time and i orker ikke. talk to reosarevok

And I was talking about the display issues :)

yyoung[m]: I understood that, but we need a full example to reproduce the issue.

yyoung[m]: forget the dispaly issues

and yyoung[m] is right

Asking for example is not nitpicking.

i copy one part of the static url https://staticbrainz.org/irombook/ for ma stick or text box and the variable (for example bullhorn/bullhorn.png) from text pasted to reosarevok

so i am sure i use the exact name i uploads it in

he uploads it as*

reosarevok: would it be easy for you to pass the full URL to CatQuest instead?

I fukcing knew that your responce woudl be "do it differntly" I've ha enough of this

reosarevok, yyoung[m]: Do you want to pause now?

I wasn't actively doing anything so I don't need to pause it, but :)

Pause what? :)

Anyway, I'm not copying the URLs to catcat. He's telling me "upload this file as x/x.png", then he copies the string he told me to his link

(since the way that works is that I follow the folder structure he asks for when uploading to https://github.com/metabrainz/irombook-instrume...)

*they, sorry :)

The idea being, IIRC, that then the URL can be added even before staticbrainz has started serving it and it will just work as soon as it's ready

look the reason it doesn't work for him to "pass me the full url" is because i edit or add the instrument at the same tyme i type the "upload the image as " text to reosarevok, and he is not always there, sometimes he is absent and then uploads that image hours from then

To be fair, I *could* just link the images myself once they are added if that's the main issue :)

the main issue is that a text box tunring into a lin kis unintuitive, uneccasary and annoying

Right now I kind of agree with that, I do want to see how I feel once the whole thing is put together though, with highlights and all. Rn I'd still prefer the text box myself, but I'm giving it a chance

yvanzo: I could follow CatQuest’s example. Please try and take a step back and re-read what was said to try and understand. If there's a specific part you don’t understand, ask for clarification about that. "Bring a full example please." is vague as it was already provided.

Freso: Getting stressed like that is not a way to engage a constructive conversation.

So if in the meantime it helps, I can put those image links up myself :) If we figure out the link thing is still not really working once the whole tool is finished, then we can also change that post gsoc, since it's not set in stone

(Not you of course)

the thing is that you aren't really gettig who is the casue of my stress! :

We had another conversation when CatQuest hijacked it.

:|

well excuuse me for "hijacking" 🙄

CatQuest: please try to relax, even if this is annoying

*this* kind of attitude is the reason im stressed

CatQuest: yvanzo and yyoung[m] are trying to improve the workflow. Sometimes this means having to adapt to a new workflow. If it turns out new workflow is worse than the previous one, then it can be reverted. But a change of workflow is not necessarily bad. Please remember to treat yvanzo and others as them being in good faith. https://xkcd.com/1172/

yvanzo: please try to understand that changes that break people's workflow *will* annoy them :)

but see above

I'm accused of higjacking and "typing to much"

Freso: remember you wheren't her for the first conversation we had

Freso: I just asked for clarifications, tried to resolve the issue, and received a "fucking" rage-quit in response.

yea I'm sorry about that. I'm having other problems

"blub"?

i'm also really nevous about talking liek this

yvanzo: If you feel like CatQuest’s comments are not relevant to what you’re currently discussing, tell them you’ll come back to them later, but you’re currently trying to do something else.

So don’t

I already suggested you to not talk like this, but rather make a summary.