outsidecontext: much later, but thanks for the feedback!!
2021-08-26 23818, 2021
riksucks joined the channel
2021-08-26 23838, 2021
opal has quit
2021-08-26 23827, 2021
opal joined the channel
2021-08-26 23825, 2021
MRiddickW has quit
2021-08-26 23826, 2021
bitmap
reosarevok: sorry I forgot to reply re MBS-11602 -- I haven't seen those on sentry at least, and a search doesn't find any. so looks like a transient issue
reosarevok: Yes, thanks for the type definition of type options. I'm not sure about the ordering of properties though, my ESLint doesn't throw an error for that, and you left an unneeded console.log in the code. :)
2021-08-26 23816, 2021
reosarevok
Oh, whoops, I keep doing the console.logs
2021-08-26 23851, 2021
reosarevok
It's not an eslint error, it's a warning, but we try to avoid warnings too
2021-08-26 23857, 2021
reosarevok
There's more here, but some were already there earlier
2021-08-26 23831, 2021
reosarevok
Got rid of the console.log
2021-08-26 23803, 2021
reosarevok
There's one eslint error on that file, but it's years old, so I guess it doesn't affect this patch :)
2021-08-26 23810, 2021
yyoung[m]
I don't have those warnings here, they'll appear only in type definitions but not variable values. And what is that eslint error?
(since we only fully enforce the eslint issues we have fixed over the whole codebase, so we have two different eslint files)
2021-08-26 23826, 2021
yyoung[m]
And they didn't appear in CI tests, through we have set max_warnings to 0
2021-08-26 23839, 2021
reosarevok
Yeah, same reason :)
2021-08-26 23856, 2021
yyoung[m]
Yeah I guess that's the reason
2021-08-26 23817, 2021
reosarevok
The .unfixed file is ignored by the CI tests, because we know it has issues - we slowly try to fix them all, then move them to the standard file :)
2021-08-26 23805, 2021
yyoung[m]
The ordering warnings could be fixed automatically I guess
2021-08-26 23810, 2021
reosarevok
(I'm surprised the one about import groupings is still unfixed, but I guess there's some issues)
2021-08-26 23819, 2021
reosarevok
(I fixed that for these files, anyway)
2021-08-26 23846, 2021
reosarevok
Yeah, they could, but for example in URLCleanup IIRC yvanzo wants to keep them in the custom order, so we should probably just disable that rule there, heh
2021-08-26 23818, 2021
reosarevok
It's just useful to make sure each actual block is in the correct order (so, applemusic is before wikipedia), but annoying inside blocks
2021-08-26 23836, 2021
reosarevok
But it feels stupid to have 143 disable/enable lines, so maybe we'll just disable it for the whole object
2021-08-26 23845, 2021
reosarevok
Ignore those, in any case :)
2021-08-26 23849, 2021
yyoung[m]
BTW, I might have to squash your commit within the original 5 commits, but it contains fixes that are not in the scope of this PR, so I'm not sure now :)
2021-08-26 23850, 2021
MrClon has quit
2021-08-26 23805, 2021
MrClon joined the channel
2021-08-26 23842, 2021
reosarevok
Did I fix stuff that was already there? Maybe I did
2021-08-26 23849, 2021
yyoung[m]
We can set eslint-ignore at file level so we don't need 143 disable lines
2021-08-26 23849, 2021
reosarevok
Just put it with the flow bits I guess :D
2021-08-26 23815, 2021
reosarevok
Sure, or just have one disable line, it's just then it won't check the order of the link type blocks either, as I said
2021-08-26 23824, 2021
reosarevok
But that'd probably be the smart choice either way
2021-08-26 23832, 2021
yyoung[m]
OK so I'll squash LinkTypeOptionT into the last commit and merge the rest with the flow support commit
2021-08-26 23856, 2021
yyoung[m]
Sorting imports could be set in IDE configuration, auto-formatting rules also
sqlalchemy.exc.InvalidRequestError: When initializing mapper Mapper|CustomRecording|recording, expression 'RecordingFirstReleaseDate' failed to locate a name ("name 'RecordingFirstReleaseDate' is not defined"). If this is a class name, consider adding this relationship() to the <class 'sir.schema.modelext.CustomRecording'> class after both dependent classes have been defined.
2021-08-26 23854, 2021
reosarevok
Maybe I just have something outdated :)
2021-08-26 23855, 2021
lucifer
indeed, i do not like pydantic very much due its lack of validation. given the number of bugs we have had in the listen submission api, i think we may very well benefit from using a dedicated library that does validation.
Wait, actually none of those docker_whatever sound like "I'm a website"
2021-08-26 23859, 2021
reosarevok
Am I missing a container?
2021-08-26 23835, 2021
reosarevok
Maybe I should try a build again
2021-08-26 23811, 2021
reosarevok
Doing that
2021-08-26 23824, 2021
yvanzo
reosarevok: 'musicbrainz' is the MB website/webservice container
2021-08-26 23833, 2021
yvanzo
s/container/service/
2021-08-26 23858, 2021
yvanzo
(container's name is likely musicbrainz-docker_musicbrainz_1)
2021-08-26 23805, 2021
reosarevok
Yeah, probably removed it and never rebuilt it. Smart
2021-08-26 23815, 2021
reosarevok
Because sudo docker-compose build is doing a lot of stuff
2021-08-26 23833, 2021
reosarevok
I'll get used to this docker thing one day. Getting there.
2021-08-26 23847, 2021
reosarevok
btw, yvanzo, akshaaatt[m], bitmap: what do you think about slightly increasing our basic font size? From the forum, seems I'm not the only one consistently using MB at 110% or larger
2021-08-26 23848, 2021
yvanzo
Probably the most disturbing thing is that docker(-compose) is not building files were you run it, but under its data directory.
2021-08-26 23849, 2021
yvanzo
So when running the same project again from another place or with a more recent version, previous images, containers, and volumes may produce unexpected issues.
2021-08-26 23801, 2021
reosarevok
Ok, there's a musicbrainz-docker_musicbrainz_1 now, at least
2021-08-26 23804, 2021
reosarevok
Still not working though
2021-08-26 23811, 2021
reosarevok
Now for those logs
2021-08-26 23826, 2021
yvanzo
+where
2021-08-26 23840, 2021
reosarevok
That'd be then docker logs -f musicbrainz-docker_musicbrainz_1 ?
That said, it seems sensible to allow it and then trust that people who care about it will police it a bit if they get weird shit in their easy listening
2021-08-26 23804, 2021
CatQuest
I guess like "lounge music" ? would richard cheese and lounge agaisnt the machine be "easy listening" ??
2021-08-26 23809, 2021
reosarevok
We should have per-genre playlists or something, then people would be more likely to grumble and fix stuff :D
2021-08-26 23824, 2021
CatQuest
hopefully
2021-08-26 23824, 2021
reosarevok
"Easy listening music is often confused with lounge music, but while it was popular in some of the same venues it was meant to be listened to for enjoyment rather than as background sound." says enwiki
2021-08-26 23834, 2021
CatQuest
(tho i want a "sillyname" playlist too ofc)
2021-08-26 23855, 2021
reosarevok
lounge seems to be a subgenre of easy listening, to some degree?
2021-08-26 23804, 2021
reosarevok
I want a "fix-me" playlist :D
2021-08-26 23810, 2021
reosarevok
Then if I like something in it, I can go fix it
2021-08-26 23817, 2021
CatQuest
:D
2021-08-26 23833, 2021
CatQuest
not a bad idea actulaly
2021-08-26 23835, 2021
CatQuest
actually
2021-08-26 23852, 2021
reosarevok
So I'll add "easy listening" then, but feel free to downvote anything that doesn't seem to match the general idea :)
2021-08-26 23858, 2021
akshaaatt[m]
reosarevok We'll definitely have to re-adjust the font size
2021-08-26 23842, 2021
yvanzo
reosarevok: just an idea: sudo docker-compose rm --stop musicbrainz; rm /media/data/musicbrainz-docker/musicbrainz-server/lib/DBDefs.pm ; sudo docker-compose up musicbrainz
