#metabrainz

/

      • CatQuest is now known as ZaphodBeeblebrox
      • ZaphodBeeblebrox is now known as CatQuest
      • CatQuest
        sorry for that everyone
      • Etua has quit
      • d4rk-ph0enix joined the channel
      • d4rkie has quit
      • yvanzo
        reosarevok: Thanks for having updated beta!
      • reosarevok
        haha
      • I haven't yet, but I can now
      • yvanzo
        Oh sorry, that's right, I did merge that PR in beta :P but did not deploy it.
      • reosarevok
        Ok. I'm happy to do so
      • Nothing else to deploy, right? Translations and this?
      • yvanzo
        yyoung[m]: I’m not sure we are looking at the same version or at the same file.
      • reosarevok: Well, updating translations is always nice.
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1604 (03master…websockets-new-url): Add authentication to websockets server https://github.com/metabrainz/listenbrainz-serv...
      • yyoung[m]
        yvanzo: I mean https://github.com/metabrainz/musicbrainz-serve... , should be isNewOrChangedLink || linkTypeChanged
      • Etua joined the channel
      • reosarevok
        yyoung[m]: are you expecting to have something else to put in beta soon? I can wait a bit if so :)
      • yyoung[m]
        reosarevok: Only the regression issue above, still not sure though
      • What do you think?
      • reosarevok
        Checking the validation when a different type is selected sounds sensible
      • alastairp
      • metadata is hard
      • yyoung[m]
        reosarevok: Maybe we'll deal with it another day, it'll take some time to review, nothing else for beta now
      • reosarevok
        Ok :)
      • yvanzo
        Yes, it doesn’t look like a regression, and the lack of tests coverage here does not help with short beta period.
      • reosarevok
        Beta out :)
      • Let's release this next release I guess, if it's not a regression
      • yyoung[m]
        yvanzo: Have you created a ticket for it?
      • It looks like an existing bug
      • It's just because these new features make it more obvious
      • akshaaatt[m]
        aerozol CatQuest try out the search button at https://musicbrainz-web.web.app/
      • yyoung[m]
        akshaaatt: Looks good, but I would prefer less animation, e.g. no entering effect for the search form
      • akshaaatt[m]
        aerozol regarding your suggestion for keeping the search bar available around the middle of the page, I like it. We can house the icon and the search bar on the bottomish of the first page in the landing setup
      • yyoung why no animations though? Our man likes living in the 90s
      • Icon as well as^^
      • yyoung[m]
        akshaaatt: It just seems slow and ineffective to me :D
      • like I'll have to wait for it to appear after waiting for the drawer to slide in
      • akshaaatt[m]
        😂😂 nice. Seems fair though
      • atj
        nice design akshaaatt[m]
      • yvanzo
        yyoung[m]: Not yet, not sure how to word it. Please create one if you identified clearly what should be the correct behavior.
      • akshaaatt[m]
        Thanks atj ! 😃
      • yyoung[m]
        yvanzo: In my view it just when the type of existing link changes, the validation is not executed at all due to a logical error
      • s/it/it's
      • lucifer
        alastairp: hi! can you review the sql parts of https://github.com/metabrainz/listenbrainz-serv... ? i want to deploy the new tables to test the refactoring in prod.
      • Etua has quit
      • FichteFoll has quit
      • FichteFoll joined the channel
      • zas
        bitmap: mbws container misbehaved on pink early, and it had a very bad effect on the node: https://stats.metabrainz.org/d/000000048/hetzne...
      • basically huge load, disk I/O, cpu, swap use etc...
      • I manually restarted it, and everything came back to normal
      • prabaaaaal has quit
      • bitmap
        zas: thanks, I'm looking into the errors
      • hrm...I'll send you details in PM
      • zas
        ok, thanks
      • BrainzGit
        [musicbrainz-server] 14mwiencek opened pull request #2251 (03master…dbdefs-disable-template-renderer): Allow disabling the template renderer https://github.com/metabrainz/musicbrainz-serve...
      • aerozol
        akshaaatt[m] really sorry but too much animation for me too! Looks nice but if I'm using that 100x a week it will get old :(
      • Love the big spacious search popout <3 but it does add clicks vs the current search?
      • bitmap was amazing and got those stats so we know that search is by far the most used feature, so you can spend twice as long on that as anything else tbh > <
      • I think my ideal would be a search box next to the magnifying glass, which brings us to a unified search results/everything, with a click, some typing, and enter. And then next to the magnifying glass an advanced search button that pops out (animated but much faster?) as you've done now? Off the top of my head
      • Sounds like that unified search is way off though :(
      • CatQuest
        akshaaatt[m]: yes, but there is no simple "just start typing and then press enter" style searc like there is now. also eccoing yyoung[m] in the amount of animations nd such
      • ight now I can just type somehing and chose the dropdown. it'd be cool if there was a fold out or something with the ore options ( method and *especially* the results per page (which I really like to have a choice of indeed))
      • but that default search worked just like now
      • ie, don't remove functionality, add functionality
      • it's really really confusing to have to press the "search" icon *before* typing my search query. I would not have known tha was the way forward when I usually except the search field right there and search icon is "start searching"
      • ok so lets talk about other things on this page. is it just dummy daa?
      • why should i be buying a "curled up Remixes"? and why does it take up the entire page :D
      • I think having a "about" section first would make more sense. also the text must be smaller.. the text is nthis purchase screen thing is literally huger thna everything else. it's too big
      • the footer should be more like the other projects too
      • the "useful links" seem more like footer stuff
      • peterhil joined the channel
      • akshaaatt[m]
        aerozol Noted! Makes sense. The animations will be off now. The daily use feature will wear out with unnecessary animations. We can have the search box, let's try that today.
      • CatQuest let's get the simple search then! 😃 The point about not removing functionality but adding is great. Let's do it then.
      • Regarding the dummy data, I'll get that functional soon. Was caught up with designs and thinking lol
      • Btw everyone can surely voice their opinions. I'm personally in no hurry and not adamant about anything that I propose. I'm exploring the options myself as well. We'll surely boost up the speed now but I would want the end result to be loved by all.
      • prabaaaaal joined the channel
      • Toasty has quit