not sure if I should interpret "oh finally" as "you took way too long to do that" or "great, new toys!"
2021-09-06 24929, 2021
reosarevok
Por qué no los dos
2021-09-06 24930, 2021
lucifer
the latter :)
2021-09-06 24906, 2021
bitmap
alastairp: cool. I looked at doing that semi-recently but ran into some problems with the upgrade scripts, iirc, and thought it might be safer to do the upgrades release-by-release
2021-09-06 24953, 2021
alastairp
bitmap: recent versions (and the version that I'm upgrading to) come with `install.sh` which appears to do everything. The only trick was using a custom docker-compose.prod.yml and sentry config file that points to the other db
2021-09-06 24954, 2021
bitmap
looks like you already tested the upgrade process though, so I was possible doing something wrong or it got fixed
2021-09-06 24940, 2021
alastairp
given that it's late in the day, I'll do the upgrade tomorrow. perhaps we can get through all of these "stopper releases" - should require 3 separate updates and then we'll be up to date
2021-09-06 24934, 2021
alastairp
and then we can check out the new github bot after that. I've set up this version of sentry + github at MTG, I believe that we need to create our own github app for self-hosted sentry. I have instructions on how to do that
2021-09-06 24937, 2021
reosarevok
bitmap: I expected it to be solvable with delete(%$post_params{'delete-users.submit'}); but seems not
2021-09-06 24959, 2021
lucifer
alastairp: how about update the master branch of the repo to that tag. so that PR contains only meb specific commits to make it easier to review?
2021-09-06 24918, 2021
reosarevok
Ooooh
2021-09-06 24943, 2021
reosarevok
It's because I have FormCsrfToken but also the parameters in postParameters, I assume
2021-09-06 24955, 2021
alastairp
lucifer: yeah, that's a bit messy. Note that the PR is to merge it into `metabrainz`. I believe that the idea is that "master" matches the upstream, and `metabrainz` matches what we deploy
2021-09-06 24958, 2021
bitmap
reosarevok: yeah that would make sense
2021-09-06 24908, 2021
bitmap
I was wondering if you were sending multiple 'submit' values somehow
2021-09-06 24913, 2021
reosarevok
Should I drop them from postParams, or drop FormCsrfToken ?
2021-09-06 24917, 2021
alastairp
so to make it avoid the large PR we'd have to push that tag into "metabrainz"
2021-09-06 24951, 2021
reosarevok
yvanzo, bitmap: should we release prod, btw?
2021-09-06 24905, 2021
reosarevok
I can do that, I guess, if we are finally ready :)
2021-09-06 24908, 2021
lucifer
ah right, my suggestion is to change the base just for the review and then later change back to meb branch when ready
2021-09-06 24920, 2021
alastairp
oh sure, I guess we can do that
2021-09-06 24952, 2021
bitmap
reosarevok: what's postParams? are those in the component_props?
2021-09-06 24902, 2021
bitmap
'cause that error comes from FormHandler
2021-09-06 24908, 2021
reosarevok
That's my $post_params = $c->req->body_params;
2021-09-06 24926, 2021
reosarevok
And they are passed to component_props and then to PostParameters
2021-09-06 24948, 2021
reosarevok
(sorry, it's "postParameters" when passed :) )
2021-09-06 24955, 2021
alastairp
zas: hi, currently sentry (automatic bug reports) has its own exim container for sending mails: https://github.com/metabrainz/sentry-onpremise/bl…, in your opinion is this OK to continue with, or do you think it'd be good to set up the MeB exim_relay container?
2021-09-06 24942, 2021
alastairp
one slight issue with this is that sentry is deployed with docker-compose (as it's based on the upstream project). I can convert start_exim_relay() to a docker-compose service configuration
2021-09-06 24950, 2021
bitmap
reosarevok: and you're passing $post_params to form_submitted_and_valid, right? there must be a duplicate parameter in there somewhere
I just dunno whether I should just not have <FormCsrfToken form={form} /> on that second file since PostParameters has them already or what
2021-09-06 24950, 2021
bitmap
sorry I missed that
2021-09-06 24902, 2021
reosarevok
np
2021-09-06 24903, 2021
bitmap
I'd remove csrf_session_key & csrf_token from postParams
2021-09-06 24944, 2021
alastairp
bitmap: lucifer: ah - one other thing I came across - latest latest sentry uses docker-compose "Compose specification", which requires newer docker-compose binary and possibly docker server. Maybe for now we can just upgrade to the last release that supports the tools that we currently have on serge (I'll double-check what the latest we can upgrade to is)
2021-09-06 24903, 2021
lucifer
makes sense
2021-09-06 24927, 2021
reosarevok
Ok, let's test
2021-09-06 24933, 2021
alastairp
(on the other hand, if sentry is the only thing on serge that uses docker-compose I guess we can just upgrade that too)
2021-09-06 24922, 2021
bitmap
that's the only thing I know of that uses it on serge, but
2021-09-06 24953, 2021
bitmap
I guess the docker server version would be the limiting factor
2021-09-06 24917, 2021
bitmap
reosarevok: if there's no further blockers with the external links editor I think we probably should
I saw zas posted some UI improvements on the forums and I agree a lot with those but I guess we shouldn't delay the release any further
2021-09-06 24915, 2021
alastairp
serge has engine version 18.09.5, from https://docs.docker.com/compose/compose-file/ it looks like we can use compose version 3.7 with that. I'll check what the last supported version of sentry is, then. Looks like we won't be able to upgrade to latest-latest, but at least some 2021 release would be good
2021-09-06 24932, 2021
reosarevok
bitmap: hmm. It seems that this is making a mess because the newline-separated usernames are somehow getting mangled into one line :D
bitmap: each entity knows its components. for eg: instead of passing artist_links.artist.gid as a path, we can directly hardcode and access the required property. like {'targetid': row.artist_links.artist.gid}
2021-09-06 24907, 2021
lucifer
alastairp: yes.
2021-09-06 24944, 2021
yvanzo
bitmap: should we move away from git2consul as we release next MBS?
People up for reviews today: zas, monkey, alastairp, Freso, yvanzo, lucifer, akshaaatt[m], bitmap, reosarevok, ruaok, CatQuest - and maybe akashgp09, ritiek, yyoung, jasondk? Please let me know ASAP if you want to give review (or if you’re listed and you don’t :))
2021-09-06 24909, 2021
Freso
zas: Go!
2021-09-06 24910, 2021
reosarevok
Oh, if we do that, then I think I'll let you two release today ;)
2021-09-06 24916, 2021
zas
Hey
2021-09-06 24934, 2021
zas
I did usual stuff, maintenance, supervision, upgrades
2021-09-06 24954, 2021
zas
but most notably I migrated influxdb + grafana to new server moroder
2021-09-06 24909, 2021
zas
it cuts a lot of cost of having those on gcloud
2021-09-06 24909, 2021
alastairp
one does not simply migrate influxdb
2021-09-06 24941, 2021
zas
I also configured a bunch of new servers (we keep upgrading machines)
2021-09-06 24944, 2021
monkey
alastairp: 👏
2021-09-06 24915, 2021
zas
I also configured prometheus
2021-09-06 24931, 2021
zas
the idea is to replace nagios with it (and its alert system)
2021-09-06 24944, 2021
peterhil has quit
2021-09-06 24914, 2021
zas
for now, everything works, but I didn't deploy widely yet (so only few nodes are providing metrics to it)
2021-09-06 24923, 2021
zas
I continue on this very soon
2021-09-06 24945, 2021
zas
plus usual Picard PR reviews and merge
2021-09-06 24951, 2021
zas
fin. alastairp ?
2021-09-06 24955, 2021
alastairp
hi
2021-09-06 24922, 2021
alastairp
I was on vacation for 2.5 weeks, it was very nice, although very warm in Barcelona
2021-09-06 24954, 2021
alastairp
last week I slowly got back into the swing of things - checking emails, reviewing PRs. With lucifer we released some new versions of CB, including some long-time pending translations
2021-09-06 24907, 2021
alastairp
I blogged about the AB similarity feature, nice to see people excited about that!
2021-09-06 24933, 2021
alastairp
I worked on a translation of AB javascript code to typescript (thanks monkey for laying the groundwork for this with LB's configuration files)
2021-09-06 24958, 2021
alastairp
I reported a bug in MB's oauth code to bitmap and fixed AB/LB/CB in some specific cases
2021-09-06 24937, 2021
bitmap
(there's an MBS pr open for that too. thanks!)
2021-09-06 24942, 2021
alastairp
I set up a PR to upgrade sentry to a newer version (this should go out tomorrow)
2021-09-06 24919, 2021
alastairp
that's it. monkey next?
2021-09-06 24926, 2021
monkey
Hello everyone !
2021-09-06 24944, 2021
monkey
I too was on vacation most of August, and so didn’t get around to doing much work. That was quite nice.
2021-09-06 24959, 2021
monkey
I did keep a close eye on akashgp09[m]’s project as he successfully finished the GSoC coding period.
2021-09-06 24959, 2021
monkey
After some thorough testing, the last fixes are being implemented now and the project should be ready for beta this week. Congrats !
2021-09-06 24929, 2021
monkey
Since I came back, I started slow with catching up with the many PR reviews that were awaiting.
2021-09-06 24954, 2021
monkey
This includes a new major feature: a notifications system for BookBrainz that prabal —last year’s GSoC student working with BB— started working on.
2021-09-06 24918, 2021
monkey
I also worked on a few small and self-contained tickets for LB and BB to warm up my coding muscles while improving some details, and started thinking about how to scrobble listens when using the ListenBrainz player.
2021-09-06 24939, 2021
monkey
That’s it for me! yyoung[m] go !
2021-09-06 24925, 2021
Freso
Not sure if yyoung / yyoung[m] is still around for reviews. They used to always mail them in. :)
2021-09-06 24930, 2021
yvanzo
yyoung[m] probably forgot to send a review by mail, go Freso!
