> Moreover, we should add some relevance of the features available on the homepage. This is something which could be general because currently the users will not have a clue of how to use/where to look for such features.
2021-09-07 25052, 2021
jasondk
by this do you mean just adding like a block to the front page explaining how listens are used & the features associated with them?
2021-09-07 25011, 2021
akshaaatt[m]
Hi jasondk ! I think for now we can leave out updating the homepage because that would require some thinking as to how we introduce the features. I think updating the docs as of now is the best we can do
2021-09-07 25033, 2021
yyoung[m]
Sorry I forgot the dev meeting.(have been focusing on course project recently, our new term is about to start)
2021-09-07 25000, 2021
yyoung[m]
Last week I fixed 3 issues of beta: MBS-11931, MBS-11929, MBS-11927 and tried to optimize the UI according to suggestions on the forum
reosarevok, yvanzo : I'm considering removing the numbers and placing an anchor link in duplicate notice, so that users can jump to the item by clicking the link, but how can I use React components in translation strings?
i think its checking for the column whether we have reached the last column in the "path" and hence should return the value or should we keep on traversing
reosarevok: do you remember if any other entity was failing?
2021-09-07 25033, 2021
reosarevok
lucifer: wait, if all we care about is whether the element is the last in path, splitting on the dots - why are we not just checking what's the last element in path.split('.') ?
2021-09-07 25044, 2021
reosarevok is confused
2021-09-07 25001, 2021
reosarevok
Mineo: maybe you can help us here? :)
2021-09-07 25003, 2021
lucifer
because of the relationship checks
2021-09-07 25035, 2021
reosarevok
Ok, hold my hand through this, please :)
2021-09-07 25002, 2021
reosarevok
So, isinstance(column, InstrumentedAttribute) is meant to be "it's not the last"?
2021-09-07 25015, 2021
lucifer
yes right
2021-09-07 25026, 2021
lucifer
if the column is not last, then first check if its a value of a relationship to another entity
yes indeed. maybe it wasn't in 1.0 or something changed since then.
2021-09-07 25036, 2021
reosarevok
So, basically, if it's not the last, it checks for the relationship(s) and collects the values, or if it's not a relationship, it does... the same it would have done if it's not InstrumentedAttribute
2021-09-07 25005, 2021
lucifer
also, this is when we use the new `inspect` API, using getattr directly may be perilious...
2021-09-07 25006, 2021
reosarevok
Would it help to check if column.property exists and is a relationship instead?
2021-09-07 25028, 2021
reosarevok
And skip the InstrumentedAttribute check entirely?
2021-09-07 25029, 2021
lucifer
possibly.
2021-09-07 25000, 2021
reosarevok
Ain't reverse engineering fun
2021-09-07 25001, 2021
lucifer
the issue is we don't have tests so it may break another entity, worse silently.
2021-09-07 25026, 2021
lucifer
once we have a way to test the output is correct we can go on simpifying this
2021-09-07 25041, 2021
reosarevok
So, what I'm hearing is "we should drop this, write proper tests, then come back to it"
2021-09-07 25007, 2021
reosarevok
(or, if master fails, fix the bare minimum, then do that?)
2021-09-07 25013, 2021
lucifer
slightly different, make it work put on test. hope that the bugs break SOLR and we can fix them then
2021-09-07 25007, 2021
reosarevok
Can't we write actual tests based on a real test DB and then compare the results of the indexing with what we know should happen?
2021-09-07 25011, 2021
reosarevok
(... assuming we know what should happen)
2021-09-07 25055, 2021
lucifer
that's my question!
2021-09-07 25009, 2021
reosarevok
I mean, that's what we do for most MB tests, anyway :)
2021-09-07 25016, 2021
lucifer
yvanzo: do you know how we can get the correct results that should be sent to SOLR? maybe a partial dump of solr's current indices or what sir prod is currently sending to SOLR?
Yeah, I guess we only need one sample, really - then the tests should just be kept updated when intentional changes are made to sir's output but that's about it
2021-09-07 25006, 2021
lucifer
riksucks: yes, sure. i'll check and let know the fields that should be used for deleting. in the meantime, you can look at other usages in the codebase.
Hello all. Long time no see :) A few suggestions for yvanzo irt fetch-dump.sh 1) It doesn't check to see if the target dump directory exists. It should either error out and tell the user to create them or specify a dump dir or create whatever paths are needed 2) It doesn't seem like DB_DUMP_DIR and SEARCH_DUMP_DIR can be overwritten without changing the script. It would be nice if these
2021-09-07 25034, 2021
nelgin
could be configured in .env 3) It would be nice to have options to only fetch files which haven't changed or are missing without having to poke around for wget options to achieve it - since I guess those are the most needed possiblities if a transfer is interrupted, you don't want to start from scartch. 4) if a download fails for some reason after fetching part of the file, try again with
2021-09-07 25034, 2021
nelgin
a reget option. 5) consider using rsync (if available). It will likely cut down on bandwidth, though maybe that's been tried and it takes longer with larger files?
2021-09-07 25051, 2021
MrClon
Continue submitting tags, but API return 500 error code. What can it mean?
2021-09-07 25000, 2021
reosarevok
"Never Gonna Give You Up has a lot of energy, which makes it the perfect workout song. Though, it might not give you a strong dance vibe. So, this may not be something that you would want to play at a dance-off." so wrong :D
2021-09-07 25016, 2021
riksucks
lucifer:
2021-09-07 25016, 2021
riksucks
>look at other usages in the codebase
2021-09-07 25016, 2021
riksucks
You mean other tickets?
2021-09-07 25032, 2021
ruaok
reosarevok: can you look to see what is causing the 500s that MrClon is seeing?
2021-09-07 25035, 2021
reosarevok
MrClon: any more info?
2021-09-07 25026, 2021
lucifer
riksucks: no, i mean how other db functions work. like deleting a pinning recording, unfollow/follow so on
I think & needs to be escaped, but this can be improved on our side too
2021-09-07 25016, 2021
lucifer
yes, it should be & instead
2021-09-07 25018, 2021
reosarevok
"Because the ampersand here tells the parser that the following characters are used to represent another character, which in this case would be an ampersand. An ampersand isn't "illegal" in XML-- it just has a special meaning. It means "all of the characters after this until you hit a semicolon should be translated to something else". When you have an ampersand normally, without the descriptive characters and trailing
