lucifer: no but seen this before with annotations (fixed since then)
2021-09-09 25230, 2021
yvanzo
Done with MBS reviews for today, will switch to SIR.
2021-09-09 25247, 2021
Etua has quit
2021-09-09 25248, 2021
riksucks
lucifer: btw I have an idea for the recommendation events deletion thing. I was wondering, that why don't we also serve the client with id field (the primary key) of user_timeline_event table. And then let the client delete recommendation events with the id column
<ruaok> who here listens to full albums and records listens on LB? I usually do. Just checked my last 1000 listens and it was pretty much spot on identifying the albums.
2021-09-09 25234, 2021
rdswift
Listening locally and the files are all properly tagged with MBIDs.
2021-09-09 25206, 2021
Etua joined the channel
2021-09-09 25220, 2021
MRiddickW has quit
2021-09-09 25225, 2021
atj
reosarevok: thanks <3
2021-09-09 25233, 2021
lucifer
riksucks: yes, that is the intent. the GET/create apis will return the id and the delete api will accept it to allow delete an item.
2021-09-09 25207, 2021
riksucks
lucifer: do you want me to modify the controller in get to return the id of recommendation events and notification events. Because without them I will only be able to implement deletion of pins
2021-09-09 25237, 2021
lucifer
riksucks: yes, sure. the id should be returned for both those events. "deletion" of pins i.e. unpinning has already implemented.
2021-09-09 25216, 2021
riksucks
Alright I will submit a PR soon with modified get route and delete route implemented. I would post updates soon
this was an old issue but afaict this kind of request was rare until now
2021-09-09 25231, 2021
bitmap
I added some logging into the WS containers yesterday to log every request by PID, so that when another process went to 99% I could see what the last request that process made was
2021-09-09 25240, 2021
bitmap
& it was the exact same request across 3 hosts
2021-09-09 25257, 2021
Etua has quit
2021-09-09 25212, 2021
Etua joined the channel
2021-09-09 25223, 2021
bitmap
(so probably the same person retrying it)
2021-09-09 25224, 2021
bitmap
I think we should make this kind of logging standard actually, since it didn't appear to add any noticeable latency
