- Last week I worked on MBS-11901, it is now basically complete, but thetests are blocked by MBS-11990, so I started fixing that and submitted a patch.
2021-09-27 27053, 2021
Freso
- Also did regular editing on MB, added several releases.
Other for reviews: lucifer, Freso, zas, yvanzo, bitmap, monkey, ruaok, reosarevok, akshaaatt[m] , alastairp, CatQuest
2021-09-27 27055, 2021
Freso
lucifer: Go!
2021-09-27 27000, 2021
lucifer
hi all!
2021-09-27 27004, 2021
lucifer
i worked last on doing misc stats improvements. monkey had discovered some bugs in stats, which caused dupes. i fixed them temporarily. ruaok is working on getting better data in dumps for a permanent fix.
2021-09-27 27003, 2021
lucifer
i also refactored some of stats code and worked on better aligning various stats with each other. plus also worked on de-duplicating some code in LB and spark to make adding newer stats easier.
2021-09-27 27011, 2021
lucifer
also reviewed a few LB PRs.
2021-09-27 27018, 2021
lucifer
that's it for me.
2021-09-27 27021, 2021
lucifer
monkey: next?
2021-09-27 27025, 2021
monkey
Heyo !
2021-09-27 27041, 2021
monkey
Last week I finished three big PRs I was working on for ListenBrainz: user's Loved/Hated tracks page, refactoring the main component we use to display tracks, and submitting listens from BrainzPlayer when listen to music on LB.
2021-09-27 27052, 2021
monkey
The first two are deployed, the third one is in testing.
2021-09-27 27003, 2021
monkey
I also reviewed some PRs for LB and BB.
2021-09-27 27045, 2021
monkey
I took Friday mostly off but did find a bit of time to start working on the summit t-shirt. Apologies in advance if you don't get yours by summit time !
2021-09-27 27058, 2021
monkey
That was it for me last week! bitmap go !
2021-09-27 27005, 2021
bitmap
hey
2021-09-27 27030, 2021
bitmap
last week I worked on MBS-11985 and MBS-11974 - the former is a pre-requisite to the newer relationship editor code
I also picked my PR for the rewritten timeline graph (https://github.com/metabrainz/musicbrainz-server/…) back up. started rebasing it and fixing issues + updating it to d3 7.0 which was released in the meantime. hope to push the changes there this week since I've neglected it for a while
2021-09-27 27048, 2021
bitmap
other than that I mostly did code review for MBS
2021-09-27 27056, 2021
bitmap
fin, go zas!
2021-09-27 27037, 2021
Freso
zas: Ping?
2021-09-27 27050, 2021
Freso
yvanzo: Go! in the meantime
2021-09-27 27003, 2021
yvanzo
Hi!
2021-09-27 27017, 2021
Freso
Others still up: Freso, zas, ruaok, reosarevok, akshaaatt[m] / akshat, alastairp, CatQuest – anyone else who want to give review, let me know. :)
While addressing small issues, found a larger issue with errors in external links editor, the fix is under review.
2021-09-27 27003, 2021
yvanzo
Tried to limit disk I/O usage of MB dump containers to address disk latency alerts on aretha, didn’t change anything.
2021-09-27 27015, 2021
yvanzo
Then I worked on improving MB logs with timestamps to allow determining the exact cause of these alerts.
2021-09-27 27019, 2021
reosarevok
:(
2021-09-27 27031, 2021
yvanzo
(Spent time discussing logs handling with alastairp by the way.)
2021-09-27 27025, 2021
yvanzo
Also reviewed more PRs for next week’s release. (Decided to keep allowing music video links to either or release for now.)
2021-09-27 27036, 2021
yvanzo
(with reosarevok ^)
2021-09-27 27049, 2021
yvanzo
Fin, go reosarevok :)
2021-09-27 27053, 2021
reosarevok
Hi!
2021-09-27 27052, 2021
reosarevok
I worked on improving the style and clarity of our Perl code, plus a lot of small URL fixes, and looked into putting together an SQL style guide (first draft is at https://gist.github.com/reosarevok/2d8a2fa6310cc0…)
2021-09-27 27008, 2021
reosarevok
CatQuest: what about you?
2021-09-27 27012, 2021
CatQuest
Meow! `😺`
2021-09-27 27045, 2021
yvanzo
(oops, either +recording or release)
2021-09-27 27053, 2021
alastairp
!m reosarevok (and others) for the style guide!
2021-09-27 27053, 2021
BrainzBot
You're doing good work, reosarevok (and others) for the style guide!!
did some testing of series on BB (will do more of this)
2021-09-27 27001, 2021
CatQuest
currently trying to figure out how to prepair herring (sild)
2021-09-27 27001, 2021
CatQuest
will be working on instruments later this week too
2021-09-27 27020, 2021
CatQuest
♍
2021-09-27 27020, 2021
CatQuest
fin, go alastairp ?
2021-09-27 27025, 2021
alastairp
hullo
2021-09-27 27055, 2021
alastairp
last week I was a few days in the office, which tends to turn into a lot of discussions, most of it useful
2021-09-27 27056, 2021
alastairp
I spoke with monkey about brainzplayer listens reporting, ruaok about some data management and processing stuff, and with yvanzo about docker container logging once he arrived at the office too
2021-09-27 27023, 2021
alastairp
I also continued work on upgrading the JS/TS/React in AB
2021-09-27 27037, 2021
alastairp
one thing I didn't finish is reviews for lucifer, sorry lucifer :(
2021-09-27 27048, 2021
lucifer
no hurry :)
2021-09-27 27055, 2021
alastairp
Freso: up next?
2021-09-27 27059, 2021
Freso
o/
2021-09-27 27023, 2021
Freso
(Only zas, ruaok, and akshaaatt[m]/akshat left on my list. Last call for anyone else who want to give review!)
2021-09-27 27035, 2021
Freso
So.
2021-09-27 27021, 2021
Freso
I updated the staff on the forums, so I think everyone on https://metabrainz.org/team should have their title reflected there now.
2021-09-27 27048, 2021
Freso
I filed a couple of MBS spam related tickets (more on that later).
2021-09-27 27009, 2021
Freso
And other than that, dealt with various reports etc. and was around and about.
2021-09-27 27012, 2021
Freso
fin.
2021-09-27 27022, 2021
Freso
Still no sign of zas? :\
2021-09-27 27025, 2021
Freso
ruaok: Go!
2021-09-27 27030, 2021
ruaok
hey
2021-09-27 27040, 2021
Freso
CatQuest: I didn’t change yours. :)
2021-09-27 27052, 2021
yvanzo
(zas is probably fine, he restarted sir earlier today)
2021-09-27 27054, 2021
ruaok
last week was another week in the mbid mapping gulag, trying to make some minor improvements that are a lot of work.
2021-09-27 27030, 2021
ruaok
I can hopefully finish that tomorrow, then return to the other task in the mapping.
2021-09-27 27055, 2021
ruaok
and I took care of the usual background tasks, taking care of the foundation and stuff.
2021-09-27 27027, 2021
ruaok
We've accepted into a short project with The ODI about open data stuff and we may end up getting paid 15k GBP, which is nice.
2021-09-27 27035, 2021
alastairp
\=
2021-09-27 27037, 2021
CatQuest
:O
2021-09-27 27041, 2021
alastairp
(that wasn't me)
2021-09-27 27046, 2021
CatQuest
was it a cat?
2021-09-27 27051, 2021
ruaok
I'm kinda thinking about what we could do with that money, so if someone has a clear idea, let me know.
2021-09-27 27003, 2021
ruaok
akshat: go!
2021-09-27 27009, 2021
akshat
Hi everyone!
2021-09-27 27019, 2021
akshat
This was an exciting week for me since I was focusing on making contributions.
2021-09-27 27036, 2021
akshat
I have done the proper setup for the dark mode of the MB interface and have quite a few major components ready. I love the design from my end so far.
2021-09-27 27046, 2021
Freso
(If no zas shows up, this is the last review, so last-last-last call for others who may want to give review!)
2021-09-27 27052, 2021
akshat
Thinking about a few more things and trying to follow the best practices as always.
2021-09-27 27052, 2021
zas
I'm stuck in traffic, usual upgrades, maintenance, user support, Picard pr reviews, fin
2021-09-27 27000, 2021
ruaok
lol
2021-09-27 27002, 2021
CatQuest
lol
2021-09-27 27013, 2021
ruaok
don't text and drive, kids. :)
2021-09-27 27017, 2021
akshat
I also targeted some parts of LB this week and the design system for meb is also on its way for nice and clean usage.
2021-09-27 27019, 2021
CatQuest
XD
2021-09-27 27034, 2021
akshat
My college is finally slowing down with many things sorted and not much left in the semester to bug me. Hoping for refreshing work ahead!
2021-09-27 27046, 2021
akshat
Also, I will be available on IRC as akshat moving forward.
2021-09-27 27050, 2021
akshat
fin!
2021-09-27 27013, 2021
Freso
Already. zas phoned their review in, so I think that’s it for reviews. Thank you everyone who gave one!
I’ve pretty much written my reasoning on the ticket, so I’m just going to copy/paste here.
2021-09-27 27059, 2021
Freso
I’m currently not deleting spam accounts since I’m hoping to feed them to SpamBrainz once SpamBrainz actually materialises. This means that currently I mark spam with "Editing/voting disabled", "Edit notes disabled", and "Untrusted" – the two former being dangerously close to "Banner message editor" (which probably deserves its own ticket, actually), so I’m wary of accidentally one day giving that permission to a
2021-09-27 27059, 2021
Freso
spammer.
2021-09-27 27059, 2021
Freso
Additionally, this approach means that the profile will still be viewable by users and search engines and they get to still use the account to log into forums, LB, CB, BB, or other sites using MB authentication.
2021-09-27 27000, 2021
Freso
This flag would ideally freeze a marked account so that only account admins are able to see the profile (I don’t know if we should return a 404 and pretend like it doesn’t exist, or a 403 and acknowledge it exists and just isn’t available currently; possibly greying out potential edit note links?) and that the account wouldn’t be able to log in (possibly giving an error message that their profile has been flagged as spam
2021-09-27 27000, 2021
Freso
and to mail support@ if they think this is a mistake?).
2021-09-27 27019, 2021
Freso
---
2021-09-27 27043, 2021
Freso
Does this seem reasonable to others or are there strong objections against this? Not sure how invasive new account flags are.
2021-09-27 27059, 2021
reosarevok
The idea sounds good to me, but not sure how we'd pass it further to LB, CB and whatnot too
2021-09-27 27005, 2021
CatQuest
it would probably need soem coding (making a n account invisible/etc?)
2021-09-27 27008, 2021
reosarevok
(since otherwise they'd still be logged in there, no?)
2021-09-27 27008, 2021
ruaok
not a bad plan to collect training data for spambrainz. now we just nee someone to work on spambrainz
2021-09-27 27031, 2021
reosarevok
New flags are not necessarily hard IIRC. Making the code do different things for different flags, a bit more so, but should be doable
2021-09-27 27043, 2021
ruaok
reosarevok: send the other projects a delete user message?
2021-09-27 27044, 2021
CatQuest
yes
2021-09-27 27057, 2021
reosarevok
ruaok: if we want to delete them from elsewhere, sure, why not
2021-09-27 27005, 2021
Freso
reosarevok: Yeah, but once logged out, they’d be prevented from logging back in. What I’m currently doing anyway is manually looking up whether the accounts exist on other sites and delete them there. I’d presumably still do this until we have a way to signal the other sites.
