#metabrainz

/

      • wargreen has quit
      • MRiddickW_ has quit
      • opal has quit
      • opal joined the channel
      • Lotheric_ joined the channel
      • Lotheric has quit
      • outsidecontext
      • alastairp: you told me I should use v2.1_beta2 for AB compatibility. How essential is that, and could I use a later tag? I had to apply some patches to fix build bugs, and I think this would not be possible with beta3. And there are even beta4 and 5.
      • *not be necessary
      • zas
        hey, outsidecontext, I'll have more time starting next week, would you be available for Picard releases?
      • outsidecontext
        zas, yes, I think so. I had not much time for MB stuff the last weeks. Still don't know if it really will get better, but I'll take some time
      • Getting a running macOS streaming extractor for macOS would be something I'd like to have finished for the release, so we can ship it with the macOS builds
      • But actually it looks good now
      • zas
        good timing :)
      • so we target both 2.6.4 and 2.7b1 perhaps first one on tuesday, second one on thursday ? or?
      • outsidecontext
        yes, I'd say something like that. I would not do them exactly on same day
      • and Tuesday and Thursday are the best days for me
      • tandy[m]
        <outsidecontext> "alastairp: hurray, macOS build..." <- woah
      • is anyone here working on the acousticbrainz extractor?
      • i see theres a bunch of nice prs that could be merged
      • outsidecontext
        zas: let me know if you would add anything else in https://github.com/metabrainz/picard/tree/2.6.4 , but as we discussed let's keep it minimal and save :)
      • tandy[m]: I'm only working on getting a more up-to-date build for it for macOS, because the old one is build with very old SDK and we cannot ship it with Picard (which we'd like to do in the upcoming 2.7 release). Apart from that I basically know nothing about the code :D
      • tandy[m]
        ohh i see
      • zas
        outsidecontext: yes, 2.6.4 tree looks good, only fixes, nothing to add
      • outsidecontext
        tandy[m]: yes, that's actually a very nice PR that should be merged IMHO. What we do with Picard is actually an alternative approach, were we make Picard a submission client, so with that there will also be a cross-platform GUI.
      • The Picard implementation was also done by gabrielcarvfer (who did the PR you linked)
      • tandy[m]
        outsidecontext: coool that makes sense
      • im just waiting on an ARM build so i can submit acousticbrainz features from my music server
      • outsidecontext
        the essential thing for this is to get that essentia extractor binary compiled. From my side there will likely be no ARM build for now, but maybe later
      • tandy[m]
        outsidecontext: i see, maybe il have a look into it one day
      • outsidecontext
        for now I just want to have automated builds for (x86) macOS at https://github.com/phw/essentia-extractor-builds/, because that's what we need to ship the current Picard package. But ideally this would end up to produce builds for different platforms and architectures
      • tandy[m]
        outsidecontext: starred :)
      • ruaok
        oh, I found a video of early MB UI development: https://www.youtube.com/watch?v=9nSQs0Gr9FA
      • I'm sooo glad that we have UI experienced people on our team now!
      • also, mooooin!
      • zas
        mooin ruaok
      • ruaok
        zas: I've pretty much stopped paying attention to the wall of notifications that are coming. that is really less than ideal.
      • how soon can that be improved so that we split them into two channels: critical and non-ciritcal alerts?
      • zas
        well, most alerts are critical, like disk space < 10%, but I will tune them to not trigger when those are meant to be transient. The /boot alert is due to the small separate partition, so it happens when upgrading kernels, I think I'll just make a separate alert for those, with longer delay to trigger
      • unusual disk write latency alerts are due to uncontrolled processes, and I already tuned them, I'd say that's the core problem that needs a fix, not the alert
      • ruaok
        ok, let me put it in another way: the current setup is broken and I turned off notifications.
      • zas
        ?
      • broken? how?
      • ruaok
        every time I look at a notification, and there are many many, I look at the impacted service and everything is fine from an outsider perspective. if the public facing services are not impacted, I dont feel that I should get a notification. You, yes. But me? I'm looking for critical things, not diskwrite latency issues on our FTP server. so, I stop notifications.
      • for me the current setup is broken. and you telling me it isn't broken doesn't improve things for me.
      • zas
        actually disk latency issues have a very significant impact on FTP service, it takes up to 1 minute to connect to server when it happens...
      • ruaok
        ok, in that case, what is my course of action to react to the notification and stop this from happening?
      • zas
        well, I asked to move the concerned processes elsewhere, or to ensure they don't eat all resources, changes were made for that, but for now, without enough impact
      • ruaok
        ok, so there is nothing I can do in the short term? I must put up with spammy messages until this problem is resolved?
      • zas
        we can silence alerts for some time
      • I'll tune some (like clock skew alerts we got recently)
      • ruaok
        and how do I stop getting spammed when this happens in the middle of the night?
      • exactly. clock skew is not something worth sending me a message at 4 in the morning.
      • zas
        for that, you have do not disturb mode
      • ruaok
        ok, we're clearly not communicating. lets leave this be -- in the meantime I've disabled all notifications for all time.
      • zas
        I tuned some alerts, they'll not trigger if the problem doesn't persist long enough
      • it's up to you, I'm also annoyed by alerts, but those trigger when an actual problem appears
      • ruaok
        the thing is, I want to help you monitor our site, but if this is the way to do it, then I'm really not interested in helping.
      • zas
        you can help tuning them
      • (you do, actually, by complaining loud enough) ;)
      • updated, this should reduce occurences
      • strider has quit
      • akshat
        @lucifer: Should we merge the username search functionality now?
      • lucifer
        akshat: sure, once ruaok has re-reviewed the PR.
      • ruaok
        I can do that in a bit.
      • lucifer
        great, thanks!
      • akshat
        Cool
      • ruaok restarts tests on that PR
      • zas
        yvanzo: I'm thinking about upgrading solr cloud VMs, likely by creating a new set of VMs with upgraded system & apps, it would be a good time to upgrade solr itself, can we discuss this matter this week? It will require few changes in installation scripts to adapt to netplan & new versions of apps used in the (complex) setup
      • also we need to ensure dns names are used on mb side (if IPs are used, we'll likely need to change this first)
      • ruaok
        lucifer: "Oh sorry. I should have added more context. I have implemented actual user search in a different PR. Let me finish that up and see how we can fix this up."
      • is that still relevant on #1627?
      • lucifer
        that's fixed up now.
      • search box has now been added to 1628.
      • ruaok
        the conversation with monkey on listenbrainz/webserver/templates/user/base.html hasn't been resolved it seems.
      • lucifer
        i think we are not on the same page. we were talking about 1628. that's the PR to be re-reviewed.
      • ruaok
        oh, that makes more sense.
      • lucifer
        you had approved it earlier, but i wanted another look since i added similarity user bits later.
      • ruaok
        approved again. great addition! thanks!
      • lucifer
        awesome
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1628 (03master…user-name-search): Add user name search https://github.com/metabrainz/listenbrainz-serv...
      • ruaok
        monkey: do you need a RPI case printed?
      • pick out a model or two you'd like on Thingiverse and I'll print it.
      • monkey
        "Need" is a big word, but I talked about it with Laza
      • ruaok
        offer is good if you'd like one too
      • lucifer
        anyone has PRs ready to merge? i'll do a release otherwise.
      • monkey
        lucifer: Perhaps the websockets PR?
      • ruaok
        nothing here.
      • monkey
        Along with that we could merge the BrainzPlayer submitting listens PR too
      • ruaok
        monkey: you shoudl request a review for 1608 from someone else. I'm not the right person for that one.
      • yes, I
      • lucifer
        ruaok: can you take a look the websockets PR since alastairp is away
      • ruaok
        yes, I'd love both of those merged.
      • ok, fair deal. on it.
      • #1604 to be clear?
      • lucifer
        yes
      • ruaok
        k
      • looks good -- I skimmed the react bits, but looks to be nothing earth shattering
      • what about #1569 ? looks ready to merge, no?
      • lucifer
        given that it has broken ts writer at least 3 times till now, I wanted alastairp to look over it as well.
      • i can test it on beta once again and if all goes well, merge?
      • ruaok
        might be best to wait for alastairp, tbh
      • lucifer
        sure, sounds good.
      • monkey: BP PR lgtm. don't understand all details but in general everything looks fine and it also worked fine last time on beta.
      • monkey
        Yeah, I've been using beta and finding everything working as expected
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1604 (03master…websockets-new-url): Add authentication to websockets server https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] 14MonkeyDo merged pull request #1608 (03master…monkey-brainzplayer-scrobble): LB-606: Submit listens when playing music with BrainzPlayer https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        time to release :D
      • uh, i forgot the thing about websockets PR.
      • it needs zas to update LB nginx prod config.
      • zas: could you please apply the socket.io mapping you made on LB beta to LB prod as well?
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo opened pull request #1634 (03master…monkey-fix-long-track-names): LB-952: Improve ListenCard layout with long track names https://github.com/metabrainz/listenbrainz-serv...
      • zas
        Ok
      • lucifer
        thanks.
      • zas
        lucifer: done, check if it works
      • lucifer
        on it
      • BrainzGit
        [listenbrainz-server] release 03v-2021-09-30.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • ruaok goes to tweet the release
      • monkey
        🎉
      • lucifer
        zas: yes, seems to be working
      • thanks
      • monkey
        Eek.
      • ruaok
        user search search gives 500. :(
      • lucifer
        i am applying the db changes currently for user search
      • ruaok
        ah, ok.
      • lucifer
        applied.
      • sorry, should have done that before 😓
      • ruaok
        all good.
      • lucifer
        similarity score is unavailable for all. seems wrong :/
      • ruaok
        who is thus guy? https://listenbrainz.org/user/_rob_/ ?? lol
      • lucifer
        lol
      • ruaok
      • the people who have no similarity, haven't listened in a while.
      • lucifer
        can you take a screenshot?
      • oh nvm, we limit number of similar users.
      • ruaok
      • lucifer
        i guess time to include less similar users as well?
      • ruaok
        for this, yeah, sure
      • if you're going to muck about this, I think the "Find it!" button should be "Search again"
      • lucifer
      • currently its 25. what do you think is a better number?
      • sure will fix
      • akshat
        This release is huge
      • LB is finally coming to life
      • - akshat goes to tweet as well
      • Wait how do we do this I love the way ruaok reacts to stuff😂🙌