Hi bitmap yvanzo reosarevok ! I have sorta completed the design for the mb homepage with the major functionalities. I would really like your opinion on it before I go further. Please once try https://musicbrainz-web.web.app on your mobile and desktop.
2021-10-19 29215, 2021
akshat
I am not firm on the drop-downs or the major content present and would be flexible to update that based on your expertise and thoughts but I think the general Skelton for the page works with even the dark mode!
2021-10-19 29209, 2021
akshat
You can just provide small comments here or for detailed overview, you can visit https://community.metabrainz.org/t/musicbrainz-we… Please omit the starting comments on the forum since the page has evolved since then, haha!
akshat: that mock-up is looking really quite nice -- thanks!
2021-10-19 29217, 2021
ruaok
a few more comments: "* Brainz Projects" -> "Other MetaBrainz Foundation Projects"
2021-10-19 29257, 2021
ruaok
that section looks lovely, but it is still too larger. esp. the picard logo is much larger than the others, or at least it appears that way.
2021-10-19 29228, 2021
ruaok
I think overall the logos should be shrunk a bit and sized so they more or less appear to be the same size
2021-10-19 29240, 2021
outsidecontext
oh yes, that picard logo is a monster :D The actual logo sizes vary, I think because of different text lengths and because of the logo images all scaled to same width. I think the logo itself should have same size, even if it means different image width
the spark reader side of things should all be fast right -- read data, write to disk. no real processing done, yes?
2021-10-19 29224, 2021
lucifer
yes, each message should be 2 or 3 db queries at most. the issue is that each stat for each user is 1 message so thousands of those pile up just after the results are received.
2021-10-19 29201, 2021
ruaok
ok, lets try it.
2021-10-19 29251, 2021
BrainzGit
[listenbrainz-server] 14amCap1712 merged pull request #1663 (03master…missing-all-time-releases): LB-968: All time release stats are not being updated for some users https://github.com/metabrainz/listenbrainz-server…
alastairp: ruaok: monkey: the performance monitoring stuff is also deployed now (in prod the value is set to 0, beta and test to 1 so effectively disabled in prod). if you browse LB on beta, the stats here will update and we'll have a better understanding of what's slow/fast. https://sentry.metabrainz.org/organizations/metab…
2021-10-19 29219, 2021
lucifer
(exception is test-lb container which is not yet updated because its running huesound)
cache would be useful, i have hit ratelimit a couple of times when testing huesound. issue will probably become worse when we move this to prod and more people start using
2021-10-19 29213, 2021
MrClon
ruaok indeed interesting. But i am not sure that node.js is good for non-web-dev cli tool
2021-10-19 29222, 2021
ruaok
MrClon: agreed.
2021-10-19 29235, 2021
ruaok
lucifer: also agreed. just not certain that we can operate a cache.
2021-10-19 29258, 2021
monkey
There's a couple of 'issues' though; sometimes there is cover art available for another release of the same release-group, but not for the release matched, so I'm seeing much fewer cover arts than I'd expect.
i think we could setup an endpoint for this. send a release mbid, LB resolves a link - coverart of that release mbid if available or query db for another release of that release group that a covert art attached.
2021-10-19 29259, 2021
monkey
But see the matched listens at the top with no cover art… I'm sure there's cover art somewhere for Alan Parson's "Eye in the sky", but apparently not for this specific release
2021-10-19 29256, 2021
monkey
Yeah, I guess that would be ideal. I'm guessing we'll have the same issues for genres and other tags, URL relationships, etc.
2021-10-19 29217, 2021
lucifer
indeed
2021-10-19 29246, 2021
monkey
It would almost makes more sense to match to a release_group rather than a release, no?
2021-10-19 29205, 2021
monkey ducks before ruaok throws something
2021-10-19 29239, 2021
ruaok
in a way, yes.
2021-10-19 29249, 2021
ruaok
a possible future improvement
2021-10-19 29257, 2021
monkey
Or is there any way to get that sort of information from the MB webservice using a recording MBID? i.e. query for recording, with included cover art ?
2021-10-19 29253, 2021
reosarevok
ruaok: answered re: your last email(s), do let me know what you think
2021-10-19 29256, 2021
reosarevok
I'm confused tbh
2021-10-19 29218, 2021
CatQuest
[11:27] <outsidecontext> the more features, the bigger the icon :D It'll grow with each release
that's.. evne a differnt iamge thna the last one :o
2021-10-19 29222, 2021
CatQuest
that's.. evne a differnt image than the last one :o
2021-10-19 29227, 2021
tandy
monkey: finally got round to working on that PR again :)
2021-10-19 29220, 2021
tandy
i also managed to use high level types across my listenbrainz-nim library, except for the Timeline endpoints, which require type unions, so im figuring out a way to make that work in nim
2021-10-19 29201, 2021
lucifer
zas: hi! does something in the monitoring system query lb.org/internal/metric/stats repeatedly? i see a bunch of failures for that url in sentry.
2021-10-19 29215, 2021
antlarr has quit
2021-10-19 29229, 2021
alastairp
hola
2021-10-19 29204, 2021
alastairp
monkey: that's a nice can'o'worms
2021-10-19 29210, 2021
alastairp
lucifer: that url sounds like my first attempt at stats in LB, in which case there might be a telegraf ingester still hitting that endpoint
but if that's the guideline I suppose it should be consistent
2021-10-19 29206, 2021
reosarevok
Well, they have the reasoning for columns that "Column aliases should always use the keyword AS This becomes significant when a query has several columns selected with columns aliased. Without the AS keyword, a dropped comma makes two columns become a single aliased column."
2021-10-19 29211, 2021
reosarevok
Not sure if that risk exists for tables
2021-10-19 29237, 2021
bitmap
I see. I don't think it's very important, we could make it optional for tables
2021-10-19 29203, 2021
zas
lucifer: nothing I'm aware of. ruaok ?
2021-10-19 29245, 2021
bitmap
akshat: the mockup looks pretty nice to me. how come the logo in the top left doesn't contain the (hexagon) logo anymore?
2021-10-19 29226, 2021
bitmap
the sheet music stock photo feels a bit cheesy :) dunno what else to put there though
2021-10-19 29250, 2021
alastairp
zas: see my comment above, I think it was due to our experiments with LB monitoring.
2021-10-19 29243, 2021
bitmap
'The Music Database' being the h1 felt a bit werid to me at first since it's not the name of the project, but maybe it's fine
2021-10-19 29228, 2021
monkey
tandy: Thanks! I'll have a look at that PR
2021-10-19 29243, 2021
ruaok
lucifer: remind me please, which PR contains the fragement that fixes the expired LE cert issue? monkey needs it for BB
2021-10-19 29212, 2021
ruaok
reosarevok: yeah, no ideas either on those spam reports
2021-10-19 29230, 2021
reosarevok
yvanzo ^ what do you think re: AS for tables? Mandatory or optional?
2021-10-19 29247, 2021
ruaok
zas: what was the last question in response to?
2021-10-19 29251, 2021
reosarevok
I kinda would rather we always did it or always did not, tbh
2021-10-19 29207, 2021
reosarevok
(I'm ok with it being different for columns and tables, but I'd want to be consistent for each one)
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (summit weekend!; next meeting: 2021-10-25): Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo)
2021-10-19 29210, 2021
ruaok
zas: can you tell if lidarr has sent us less traffic in the last 5 days?
2021-10-19 29251, 2021
zas
I'll check and tell you
2021-10-19 29206, 2021
reosarevok
yvanzo: huh, Root is not on my local install, wonder if it isn't exposed except on some specific version of DateTime::Locale
2021-10-19 29209, 2021
akshat
Thank you for your review bitmap! I do agree we should add the hexagon logo with the name on the navbar. Will do so! But I'll want to add the final logo with it.
2021-10-19 29243, 2021
akshat
monkey alastairp lucifer CatQuest your takes on the mb design mockup?
2021-10-19 29259, 2021
CatQuest
akshat: busy right now. ask me later
2021-10-19 29205, 2021
akshat
Sure!
2021-10-19 29237, 2021
akshat
Freso will give the final take :)
2021-10-19 29200, 2021
akshat
ruaok I would like to add the footer section to all meb projects in the same format as this mockup if that looks good to you. Content will be relevant for each project. Any thoughts?
2021-10-19 29218, 2021
akshat
We had good review regarding that on the forum
2021-10-19 29248, 2021
ruaok
might be nice, but you need to really ask all the team leads what they think about that. lucifer, bitmap, alastairp?
2021-10-19 29245, 2021
Freso
akshat: Not sure why I’m the one to give final take. :x
2021-10-19 29221, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda (summit weekend!; next meeting: 2021-10-25): Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo), Allow account admins to see editor-editor subscript
2021-10-19 29239, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Follow up on Summit Notes -> Tickets, Allow test editing without verification (Freso/reo), Allow account admins to see editor-editor subscriptions? (Freso)
2021-10-19 29244, 2021
akshat
Freso I believe you could do a sanity check as to all the important things which should be relevant, present and abide by our guidelines. 😇
