#metabrainz

lucifer: https://github.com/metabrainz/syswiki/wiki/Stri...

awesome, thanks!

sooooo, when you take apart an airplane engine it is not allowable to have any screws leftover. cool.

how about when you take apart and reassemble a fridge? Is two screws permissible? asking for a friend.

I think that means you screwed up somewhere, but :p

lol

Lol

I think its permissible as long as it doesnt start flying :p

ruaok: https://test.metabrainz.org/donate try it. use card `4242 4242 4242 4242`. other details don't matter.

one bug i found the transaction got marked as anonymous even though i didn't check that box. will fix.

hehe, nope its a stripe test card. stripe won't accept it in live envirnoment

The background donate with credit card button turns blue when I toggle from USD to EUR. Is that desired?

yeah, that's the current behaviour on prod too.

not sure about that restriction, maybe stripe didn't have eur when it was first integrated in MeB.

lucifer: the Donate with Credit Card button does not enable for me.

trying EUR or USD?

clicking paypal, then back and now it works.

USD

is flakey.

huh interesting, it worked for me all the times i tried. will try to reproduce the issue and fix it.

this is on chrome/mac

let me try ff

sorry, that was FF. let me try chrome

i tried on chrome/windows.

ah ok. i have FF, will try on that too

fine on chrome. got donation receipt.

👍, will fix for FF.

zas: do you know if there's a way to mark them as not 404s? I don't see anything on https://developers.google.com/search/docs/advan...

Rebuilding and redeploying to test with a fix

bitmap: I don't think so, it seems a pretty stupid algorithm, triggering on small pages with "error" word in them...

ok. guess we have to ignore it then :\

lucifer: I fixed the playlist sorting, thanks for the help :)

I stumbled upon something in the meantime: Trying to visit the page of a user that doesn't seem to exist anymore: https://listenbrainz.org/user/NcOaujs/

However I can query the API and get a response: https://api.listenbrainz.org/1/user/NcOaujs/lis...

Same goes for random string of characters as user name, I get a 200 response back instead of a 404.

LB-978

LB-978: API returns 200 for non existing user https://tickets.metabrainz.org/browse/LB-978

monkey: i see the issue and cause. will fix. thanks!

lucifer: it seems that listen ingestion from spotify has come to a halt: https://stats.metabrainz.org/d/OGg5QUCGz/listen...

doesn't appear to be our problem, I think.

our script is still running, but imports nothing/

should I restart it just in case?

sure.

i'll query the API manually to cross check meanwhile.

log is totally quiet after the restart.

i see this so its still processing but importing nothing.

yes, same here.

doesn't really seem like our problem, does it?

no, doesn't look it.

different topic: any tips for how to debug a python test that uses ServerTestCase and DatabaseTestCase, but that just hangs when running the test?

i remember this having happened a few times in the past that spotify went quite.

i'd start by putting logs everywhere to see which particular statement hung.

ruaok: btw one tip i have seen is if a button doesnt "undisable" is yo ucna go in elements and delete the 'disabled=""' bith (not jsut the bit inside "" but including the "disabled=" part) that will enabel button

CatQuest: true that.

:)

lucifer: k

let me try that test locally and see if i can figure it.

thanks, but I just wanted to see if there was a common simple thing I might be overlooking

oh heh. I can't add debug statements since nothing is ever output. it just hangs. ^C doesn't even work and I have to kill the container to stop the test

cool that stripe thing actually works for me too (tried with the test card number given by lucifer) :D

ah ok. i don't recall any particular reason for such issue.

nice :)

don't think it should be the reason but that paste is missing an import for url_for, ruaok

(but yes, I had to delete the "disabled" on the "pay with blup")

yeah, incomplete paste, sorry

ah ok, no worry.

btw the script is importing again but now it errs with rabbitmq errors.

gaaah.

those occur occasionally so nothing out of blue though.

it'll retry and if those still fail, it'll pick it up in the next iteration.

right. the universe just told me to stop working and enjoy the weekend. too many things broken, lol.

lol XD

docker is just way too slow locally. 15 mins to build despite cache. welp

reosarevok: I don't think adding indexes for that will help overall, it really depends on what other conditions are in the edit search re if PG can make use of them

if you have an example where something like 'before yesterday' is ultra slow I can take a look at the query plan

ruaok: i get this error `werkzeug.routing.BuildError: Could not build url for endpoint 'color_api_v1.huesound' with values ['color']. Did you mean 'color_api_v1.color_releases' instead?`

lucifer: how did you get that error message? didn't your container just lock up?

no it didn't.

is your config.py updated?

(uses lb_db instead of db)

yes.

strange. some docker issue maybe?

I'm guessing. I'll blow away everything and start with a fresh copy of docker.

don't worry about it -- thanks. I'll dig into it on monday.

👍

however, we still are missing front-end tests for huesound. if you have capacity for that, it would be helpful to get those done so we can submit the PR.

i am not good at jest tests, but i'll give it try and see if i can up something useful.

should we ask akshat instead?

monkey gave me evil looks when I suggested that tests were missing.

yes, sounds good. he'll definitely do a better job than me. happy to assist him if needed.

hehe lol

you're getting good at this, lucifer.

;D

https://test.metabrainz.org/donors , name issue fixed :D. i tried https://test.metabrainz.org/payment also, and i received the mail. onto the FF issue now

I am soo tempted to remove the paypal donation option. I really don't want to continue working with paypal. such a pain in the ass!

that'll come a bit later. the current PR will just update stripe checkout. next steps are enable stripe for EUR and recurring. then plan to discontinue paypal and finally remove it.

ok, good.

I wonder if that is doing ourselves a disservice. I wish there was a clear thing to replace it with to give people options

we can try to enable more options with stripe checkout or look for another alternative to add. but i don't think there's going to be a way to let people use paypal without us dealing with them.

heh, khan academy uses the same donate options as us. their stripe checkout is also same old one as us. https://www.khanacademy.org/donate

ruaok: what's your FF version and any plugins that might be interfering? because it works fine for me on FF as well.

FF 93

linux.

load page.

tick, recurring, email me and the donate greys out.

happened on FF mac too

i an on FF 93 windows currently no extension. let me try on linux.

works on ff linux too.

the extension probably then? can you try again without it and share a link for me to install it and test?

I have a lot of extensions installed -- is there a master switch to turn them all off?

private window?

happens there too.

uhh weird.

ok, just to double check, I am on: https://test.metabrainz.org/donate

in chromium, no extension installed at all.

linux

load page. tick, recurring. tick email.

donate disabled.

oh sorry! i misunderstood you.

recurring is disabled for stripe.

I think they support it now, don't they?

yes, they do but i haven't updated our side to support it yet.

ah.

I wasn't aware of that.

yeah, makes sense. i should have made that clear earlier. apologies.

sorry to waste your time. :(

the good part is that this works now on both ff and chrome. time to update tests and the pr should be ready.

no worries

Yup I would look to do it!

<3 akshat

as long as you're not on your way to burn out and fuck off.

take care of yourself, akshat

Need to catch up to your level ruaok