#metabrainz

/

      • peterhil has quit
      • 2021-10-22 29511, 2021

      • ruaok
      • 2021-10-22 29529, 2021

      • lucifer
        awesome, thanks!
      • 2021-10-22 29537, 2021

      • ruaok
        sooooo, when you take apart an airplane engine it is not allowable to have any screws leftover. cool.
      • 2021-10-22 29558, 2021

      • ruaok
        how about when you take apart and reassemble a fridge? Is two screws permissible? asking for a friend.
      • 2021-10-22 29519, 2021

      • reosarevok
        I think that means you screwed up somewhere, but :p
      • 2021-10-22 29519, 2021

      • lucifer
        lol
      • 2021-10-22 29530, 2021

      • shivam-kapila
        Lol
      • 2021-10-22 29542, 2021

      • shivam-kapila
        I think its permissible as long as it doesnt start flying :p
      • 2021-10-22 29504, 2021

      • lucifer
        ruaok: https://test.metabrainz.org/donate try it. use card `4242 4242 4242 4242`. other details don't matter.
      • 2021-10-22 29557, 2021

      • lucifer
        one bug i found the transaction got marked as anonymous even though i didn't check that box. will fix.
      • 2021-10-22 29520, 2021

      • lucifer
        hehe, nope its a stripe test card. stripe won't accept it in live envirnoment
      • 2021-10-22 29546, 2021

      • shivam-kapila
        The background donate with credit card button turns blue when I toggle from USD to EUR. Is that desired?
      • 2021-10-22 29508, 2021

      • lucifer
        yeah, that's the current behaviour on prod too.
      • 2021-10-22 29533, 2021

      • lucifer
        not sure about that restriction, maybe stripe didn't have eur when it was first integrated in MeB.
      • 2021-10-22 29525, 2021

      • lucifer
      • 2021-10-22 29550, 2021

      • ruaok
        lucifer: the Donate with Credit Card button does not enable for me.
      • 2021-10-22 29503, 2021

      • lucifer
        trying EUR or USD?
      • 2021-10-22 29521, 2021

      • ruaok
        clicking paypal, then back and now it works.
      • 2021-10-22 29534, 2021

      • ruaok
        USD
      • 2021-10-22 29502, 2021

      • ruaok
        is flakey.
      • 2021-10-22 29504, 2021

      • lucifer
        huh interesting, it worked for me all the times i tried. will try to reproduce the issue and fix it.
      • 2021-10-22 29546, 2021

      • ruaok
        this is on chrome/mac
      • 2021-10-22 29550, 2021

      • ruaok
        let me try ff
      • 2021-10-22 29501, 2021

      • ruaok
        sorry, that was FF. let me try chrome
      • 2021-10-22 29503, 2021

      • lucifer
        i tried on chrome/windows.
      • 2021-10-22 29518, 2021

      • lucifer
        ah ok. i have FF, will try on that too
      • 2021-10-22 29525, 2021

      • ruaok
        fine on chrome. got donation receipt.
      • 2021-10-22 29559, 2021

      • lucifer
        👍, will fix for FF.
      • 2021-10-22 29535, 2021

      • Etua has quit
      • 2021-10-22 29548, 2021

      • peterhil joined the channel
      • 2021-10-22 29543, 2021

      • bitmap
        zas: do you know if there's a way to mark them as not 404s? I don't see anything on https://developers.google.com/search/docs/advance…
      • 2021-10-22 29538, 2021

      • monkey
        Rebuilding and redeploying to test with a fix
      • 2021-10-22 29533, 2021

      • peterhil has quit
      • 2021-10-22 29550, 2021

      • zas
        bitmap: I don't think so, it seems a pretty stupid algorithm, triggering on small pages with "error" word in them...
      • 2021-10-22 29559, 2021

      • bitmap
        ok. guess we have to ignore it then :\
      • 2021-10-22 29531, 2021

      • monkey
        lucifer: I fixed the playlist sorting, thanks for the help :)
      • 2021-10-22 29534, 2021

      • monkey
        I stumbled upon something in the meantime: Trying to visit the page of a user that doesn't seem to exist anymore: https://listenbrainz.org/user/NcOaujs/
      • 2021-10-22 29534, 2021

      • monkey
        However I can query the API and get a response: https://api.listenbrainz.org/1/user/NcOaujs/liste…
      • 2021-10-22 29534, 2021

      • monkey
        Same goes for random string of characters as user name, I get a 200 response back instead of a 404.
      • 2021-10-22 29559, 2021

      • monkey
      • 2021-10-22 29516, 2021

      • monkey opens a ticket
      • 2021-10-22 29548, 2021

      • monkey
        LB-978
      • 2021-10-22 29549, 2021

      • BrainzBot
        LB-978: API returns 200 for non existing user https://tickets.metabrainz.org/browse/LB-978
      • 2021-10-22 29514, 2021

      • lucifer
        monkey: i see the issue and cause. will fix. thanks!
      • 2021-10-22 29557, 2021

      • peterhil joined the channel
      • 2021-10-22 29548, 2021

      • ruaok
        lucifer: it seems that listen ingestion from spotify has come to a halt: https://stats.metabrainz.org/d/OGg5QUCGz/listenbr…
      • 2021-10-22 29557, 2021

      • ruaok
        doesn't appear to be our problem, I think.
      • 2021-10-22 29506, 2021

      • ruaok
        our script is still running, but imports nothing/
      • 2021-10-22 29511, 2021

      • ruaok
        should I restart it just in case?
      • 2021-10-22 29520, 2021

      • lucifer
        sure.
      • 2021-10-22 29539, 2021

      • lucifer
        i'll query the API manually to cross check meanwhile.
      • 2021-10-22 29511, 2021

      • ruaok
        log is totally quiet after the restart.
      • 2021-10-22 29527, 2021

      • lucifer
      • 2021-10-22 29547, 2021

      • lucifer
        i see this so its still processing but importing nothing.
      • 2021-10-22 29558, 2021

      • ruaok
        yes, same here.
      • 2021-10-22 29515, 2021

      • ruaok
        doesn't really seem like our problem, does it?
      • 2021-10-22 29548, 2021

      • lucifer
        no, doesn't look it.
      • 2021-10-22 29558, 2021

      • ruaok
        different topic: any tips for how to debug a python test that uses ServerTestCase and DatabaseTestCase, but that just hangs when running the test?
      • 2021-10-22 29522, 2021

      • ruaok
      • 2021-10-22 29529, 2021

      • lucifer
        i remember this having happened a few times in the past that spotify went quite.
      • 2021-10-22 29546, 2021

      • lucifer
        i'd start by putting logs everywhere to see which particular statement hung.
      • 2021-10-22 29517, 2021

      • CatQuest
        ruaok: btw one tip i have seen is if a button doesnt "undisable" is yo ucna go in elements and delete the 'disabled=""' bith (not jsut the bit inside "" but including the "disabled=" part) that will enabel button
      • 2021-10-22 29535, 2021

      • ruaok
        CatQuest: true that.
      • 2021-10-22 29542, 2021

      • CatQuest
        :)
      • 2021-10-22 29546, 2021

      • ruaok
        lucifer: k
      • 2021-10-22 29547, 2021

      • lucifer
        let me try that test locally and see if i can figure it.
      • 2021-10-22 29543, 2021

      • ruaok
        thanks, but I just wanted to see if there was a common simple thing I might be overlooking
      • 2021-10-22 29528, 2021

      • ruaok
        oh heh. I can't add debug statements since nothing is ever output. it just hangs. ^C doesn't even work and I have to kill the container to stop the test
      • 2021-10-22 29511, 2021

      • CatQuest
        cool that stripe thing actually works for me too (tried with the test card number given by lucifer) :D
      • 2021-10-22 29514, 2021

      • lucifer
        ah ok. i don't recall any particular reason for such issue.
      • 2021-10-22 29529, 2021

      • lucifer
        nice :)
      • 2021-10-22 29550, 2021

      • lucifer
        don't think it should be the reason but that paste is missing an import for url_for, ruaok
      • 2021-10-22 29500, 2021

      • CatQuest
        (but yes, I had to delete the "disabled" on the "pay with blup")
      • 2021-10-22 29511, 2021

      • ruaok
        yeah, incomplete paste, sorry
      • 2021-10-22 29535, 2021

      • lucifer
        ah ok, no worry.
      • 2021-10-22 29502, 2021

      • lucifer
        btw the script is importing again but now it errs with rabbitmq errors.
      • 2021-10-22 29530, 2021

      • ruaok
        gaaah.
      • 2021-10-22 29542, 2021

      • lucifer
        those occur occasionally so nothing out of blue though.
      • 2021-10-22 29514, 2021

      • lucifer
        it'll retry and if those still fail, it'll pick it up in the next iteration.
      • 2021-10-22 29519, 2021

      • ruaok
        right. the universe just told me to stop working and enjoy the weekend. too many things broken, lol.
      • 2021-10-22 29540, 2021

      • lucifer
        lol XD
      • 2021-10-22 29519, 2021

      • lucifer
        docker is just way too slow locally. 15 mins to build despite cache. welp
      • 2021-10-22 29541, 2021

      • bitmap
        reosarevok: I don't think adding indexes for that will help overall, it really depends on what other conditions are in the edit search re if PG can make use of them
      • 2021-10-22 29535, 2021

      • peterhil has quit
      • 2021-10-22 29543, 2021

      • bitmap
        if you have an example where something like 'before yesterday' is ultra slow I can take a look at the query plan
      • 2021-10-22 29544, 2021

      • lucifer
        ruaok: i get this error `werkzeug.routing.BuildError: Could not build url for endpoint 'color_api_v1.huesound' with values ['color']. Did you mean 'color_api_v1.color_releases' instead?`
      • 2021-10-22 29524, 2021

      • ruaok
        lucifer: how did you get that error message? didn't your container just lock up?
      • 2021-10-22 29543, 2021

      • lucifer
        no it didn't.
      • 2021-10-22 29510, 2021

      • lucifer
        is your config.py updated?
      • 2021-10-22 29532, 2021

      • lucifer
        (uses lb_db instead of db)
      • 2021-10-22 29538, 2021

      • ruaok
        yes.
      • 2021-10-22 29502, 2021

      • lucifer
        strange. some docker issue maybe?
      • 2021-10-22 29533, 2021

      • lucifer
        i'll push the test to github and lets see it run in CI?
      • 2021-10-22 29535, 2021

      • ruaok
        I'm guessing. I'll blow away everything and start with a fresh copy of docker.
      • 2021-10-22 29501, 2021

      • ruaok
        don't worry about it -- thanks. I'll dig into it on monday.
      • 2021-10-22 29513, 2021

      • lucifer
        👍
      • 2021-10-22 29528, 2021

      • ruaok
        however, we still are missing front-end tests for huesound. if you have capacity for that, it would be helpful to get those done so we can submit the PR.
      • 2021-10-22 29529, 2021

      • lucifer
        i am not good at jest tests, but i'll give it try and see if i can up something useful.
      • 2021-10-22 29515, 2021

      • ruaok
        should we ask akshat instead?
      • 2021-10-22 29532, 2021

      • ruaok
        monkey gave me evil looks when I suggested that tests were missing.
      • 2021-10-22 29520, 2021

      • lucifer
        yes, sounds good. he'll definitely do a better job than me. happy to assist him if needed.
      • 2021-10-22 29524, 2021

      • lucifer
        hehe lol
      • 2021-10-22 29538, 2021

      • ruaok
        you're getting good at this, lucifer.
      • 2021-10-22 29505, 2021

      • lucifer
        ;D
      • 2021-10-22 29521, 2021

      • peterhil joined the channel
      • 2021-10-22 29550, 2021

      • lucifer
        https://test.metabrainz.org/donors , name issue fixed :D. i tried https://test.metabrainz.org/payment also, and i received the mail. onto the FF issue now
      • 2021-10-22 29543, 2021

      • ruaok
        I am soo tempted to remove the paypal donation option. I really don't want to continue working with paypal. such a pain in the ass!
      • 2021-10-22 29545, 2021

      • lucifer
        that'll come a bit later. the current PR will just update stripe checkout. next steps are enable stripe for EUR and recurring. then plan to discontinue paypal and finally remove it.
      • 2021-10-22 29525, 2021

      • ruaok
        ok, good.
      • 2021-10-22 29559, 2021

      • ruaok
        I wonder if that is doing ourselves a disservice. I wish there was a clear thing to replace it with to give people options
      • 2021-10-22 29536, 2021

      • antlarr has quit
      • 2021-10-22 29541, 2021

      • lucifer
        we can try to enable more options with stripe checkout or look for another alternative to add. but i don't think there's going to be a way to let people use paypal without us dealing with them.
      • 2021-10-22 29550, 2021

      • lucifer
        heh, khan academy uses the same donate options as us. their stripe checkout is also same old one as us. https://www.khanacademy.org/donate
      • 2021-10-22 29502, 2021

      • lucifer
        ruaok: what's your FF version and any plugins that might be interfering? because it works fine for me on FF as well.
      • 2021-10-22 29505, 2021

      • ruaok
        FF 93
      • 2021-10-22 29515, 2021

      • ruaok
        linux.
      • 2021-10-22 29520, 2021

      • ruaok
        load page.
      • 2021-10-22 29542, 2021

      • ruaok
        tick, recurring, email me and the donate greys out.
      • 2021-10-22 29547, 2021

      • peterhil has quit
      • 2021-10-22 29549, 2021

      • ruaok
        happened on FF mac too
      • 2021-10-22 29530, 2021

      • lucifer
        i an on FF 93 windows currently no extension. let me try on linux.
      • 2021-10-22 29542, 2021

      • lucifer
        works on ff linux too.
      • 2021-10-22 29536, 2021

      • lucifer
        the extension probably then? can you try again without it and share a link for me to install it and test?
      • 2021-10-22 29557, 2021

      • ruaok
        I have a lot of extensions installed -- is there a master switch to turn them all off?
      • 2021-10-22 29541, 2021

      • lucifer
        private window?
      • 2021-10-22 29519, 2021

      • ruaok
        happens there too.
      • 2021-10-22 29559, 2021

      • lucifer
        uhh weird.
      • 2021-10-22 29506, 2021

      • ruaok
        ok, just to double check, I am on: https://test.metabrainz.org/donate
      • 2021-10-22 29516, 2021

      • ruaok
        in chromium, no extension installed at all.
      • 2021-10-22 29520, 2021

      • ruaok
        linux
      • 2021-10-22 29541, 2021

      • ruaok
        load page. tick, recurring. tick email.
      • 2021-10-22 29544, 2021

      • ruaok
        donate disabled.
      • 2021-10-22 29503, 2021

      • lucifer
        oh sorry! i misunderstood you.
      • 2021-10-22 29511, 2021

      • lucifer
        recurring is disabled for stripe.
      • 2021-10-22 29524, 2021

      • peterhil joined the channel
      • 2021-10-22 29536, 2021

      • ruaok
        I think they support it now, don't they?
      • 2021-10-22 29551, 2021

      • lucifer
        yes, they do but i haven't updated our side to support it yet.
      • 2021-10-22 29528, 2021

      • ruaok
        ah.
      • 2021-10-22 29537, 2021

      • ruaok
        I wasn't aware of that.
      • 2021-10-22 29543, 2021

      • lucifer
        yeah, makes sense. i should have made that clear earlier. apologies.
      • 2021-10-22 29556, 2021

      • ruaok
        sorry to waste your time. :(
      • 2021-10-22 29528, 2021

      • lucifer
        the good part is that this works now on both ff and chrome. time to update tests and the pr should be ready.
      • 2021-10-22 29534, 2021

      • lucifer
        no worries
      • 2021-10-22 29543, 2021

      • akshat
        Yup I would look to do it!
      • 2021-10-22 29556, 2021

      • ruaok
        <3 akshat
      • 2021-10-22 29547, 2021

      • akshat is on his way to learn and deliver
      • 2021-10-22 29509, 2021

      • ruaok
        as long as you're not on your way to burn out and fuck off.
      • 2021-10-22 29515, 2021

      • ruaok
        take care of yourself, akshat
      • 2021-10-22 29545, 2021

      • akshat
        Need to catch up to your level ruaok