we haven't started throwing you down that rabbit hole, akshat. it will take more time than a short convo to get you bootstrapped int our production setup
2021-10-26 29921, 2021
akshat
Hahah okayy
2021-10-26 29949, 2021
akshat
lucifer we are about to reach 10k downloads on mb android app soon. I would like to have a blog and some additional features out by then. We have around a month before that happens. Would you suggest any major updates for it? Currently we have the theme changes and some basic stuff
2021-10-26 29954, 2021
monkey
Well, it's not that tricky now that githug builds the images for us. Once the action is finished, SSH into the kiss server and you're two commands away: sudo su and once logged in as root: `~/docker-server-configs/scripts/update_services.sh test listenbrainz-web`
2021-10-26 29914, 2021
monkey
Or alternatively, for today, you can ask me to deploy :p
2021-10-26 29951, 2021
akshat
Great monkey. But I do feel that currently I don't have the use case to deploy on test because that would mean I commit everything and have things done to test.
2021-10-26 29921, 2021
akshat
But for things like testing frontend stuff maybe after making a tweak, I just want to test the functionality and for that bono has been great
2021-10-26 29953, 2021
monkey
I hear you
2021-10-26 29959, 2021
akshat
Yuss
2021-10-26 29933, 2021
ruaok
lucifer: I can't get the tests on this to pass, ever.
2021-10-26 29950, 2021
ruaok
same BS connection is closed error. is this an oppotunity for us to test something?
sounds good. i'll get back to you on the timeline once I get my schedule for rest of session.
2021-10-26 29903, 2021
ruaok
k
2021-10-26 29958, 2021
lucifer
ruaok: lgtm but acc to me this will probably eat up the original stack trace. if this is just for that resource is closed error, then its probably fine. because the stack trace is not useful for that anyways.
2021-10-26 29909, 2021
ruaok
if it gets in the way, we can always remove it.
2021-10-26 29917, 2021
alastairp
it re-raises the error though, and str(err) is just going to be the final item in the stacktrace anyway. what's the motivation for adding the extra log line?
2021-10-26 29918, 2021
ruaok
but this has made debugging tests very frustrating.
2021-10-26 29922, 2021
lucifer
👍
2021-10-26 29932, 2021
alastairp
or did you intend to not include the `raise`?
2021-10-26 29953, 2021
ruaok
alastairp: something about the tests eats the error message and I get no meaningful error.
2021-10-26 29910, 2021
ruaok
this way I get a message in the test debugging when code in this block fails.
2021-10-26 29936, 2021
alastairp
ah, interesting. sure, if this helps you get a notification about the error then that's fine
2021-10-26 29956, 2021
ruaok
ok, then that PR is ready.
2021-10-26 29905, 2021
alastairp
as lucifer says, you won't get a specific traceback, perhaps you could use the traceback module to get it if you need it
2021-10-26 29930, 2021
ruaok
lucifer: once we merge that we'll need to dump a full dump to catch up. or we could be lazy about it and just wait a few days.
2021-10-26 29938, 2021
ruaok
🦥
2021-10-26 29939, 2021
alastairp
I wonder if we need a sentinel that we can add to comments indicating our various hacks so that we can go back and re-address them in the future to see if they've fixed
2021-10-26 29913, 2021
lucifer
some time ago, i faced this issue. full traces not showing up. i setup a personal account on sentry.io and configured sentry in my test runs. turned out to be useful some times.
2021-10-26 29926, 2021
lucifer
ruaok: fine with waiting. less than a week left.
2021-10-26 29958, 2021
ruaok
k. a lot less hassle.
2021-10-26 29904, 2021
ruaok
sorry rak.
2021-10-26 29918, 2021
ruaok
Nov 1/2 everything should be better.
2021-10-26 29912, 2021
reosarevok
> or did you intend to not include the `raise`?
2021-10-26 29922, 2021
reosarevok
No takebacks, we were promised a `raise`
2021-10-26 29932, 2021
reosarevok hides
2021-10-26 29937, 2021
lucifer
🤣
2021-10-26 29951, 2021
alastairp
it's in the context of an exception, and you're clearly an exceptional case, reosarevok
2021-10-26 29918, 2021
reosarevok
That's me. An exceptional error.
2021-10-26 29947, 2021
monkey
Exquisite
2021-10-26 29902, 2021
alastairp
exceptions: things that shouldn't happen in normal day-to-day situations
2021-10-26 29912, 2021
ruaok
finally! the office fibre connection has finally been changed into my name. took 4 months.
2021-10-26 29922, 2021
ruaok
now to see how long it take for them to start billing the right account.
2021-10-26 29934, 2021
lucifer
ruaok: btw the stripe PR is ready for review.
2021-10-26 29958, 2021
ruaok
ah yes. thanks for the nudge.
2021-10-26 29957, 2021
ruaok
how about the two TODO items without a check?
2021-10-26 29910, 2021
rak
ruaok: Yeah, I use https://beets.io/ to tag my music, so the tags should be equivalent to what picard would give. And sure, I can wait until early November for stats to catch up.
2021-10-26 29923, 2021
lucifer
yes one is once you take a look, let me know if somewhere docs could be improved.
2021-10-26 29913, 2021
ruaok
rak: really? those listens come from tagged tracks? remind me you LB user name again, something is amiss.
2021-10-26 29900, 2021
lucifer
the other one is that stripe advises to return a HTTP 200 response as soon as possible. currently what we do is , return HTTP 200 after inserting in db. is that fine or should we respond before even inserting?
2021-10-26 29932, 2021
alastairp
lucifer: is this the response of MeB to stripe in a webhook?
2021-10-26 29936, 2021
ruaok
that sounds fine to me. I am guessing they don't want you to wait minutes or hours.
2021-10-26 29942, 2021
lucifer
alastairp: yes
2021-10-26 29952, 2021
alastairp
I think that "as soon as possible" in this context also includes "as soon as you've actually done something useful with the data"
2021-10-26 29959, 2021
ruaok
that
2021-10-26 29909, 2021
lucifer
ah yes, makes sense.
2021-10-26 29933, 2021
rak
ruaok: ryanakca . I'm scrobbling with mpdscribble via the proxy interface
