these were the logs an hour or so ago. its iterating continously but finding nothing to import
2021-11-09 31310, 2021
monkey
Hence "Encountered errors while processing 0 users" ?
2021-11-09 31317, 2021
monkey
I get mixed messages there :D
2021-11-09 31337, 2021
lucifer
uh yeah, that message needs to be improved.
2021-11-09 31329, 2021
lucifer
sloppy error message from me instead of no errors, errors for 0. i'll open a PR to improve it.
2021-11-09 31311, 2021
alastairp
we should work out why we're logging to console twice too, that's been bothering me for a while :)
2021-11-09 31337, 2021
lucifer
me too
2021-11-09 31343, 2021
lucifer
that's probably because we set up both flask logger and a normal python logger for listenbrainz package. i had tried a few suggested solutions but nothing worked.
[musicbrainz-server] 14reosarevok merged pull request #2024 (03master…MBS-11537): MBS-11537: Collapse work attributes when there are too many (but for edits) https://github.com/metabrainz/musicbrainz-server/…
2021-11-09 31318, 2021
v6lur joined the channel
2021-11-09 31323, 2021
BrainzGit
[listenbrainz-server] 14MonkeyDo opened pull request #1725 (03master…monkey-fetch-covertart-LB-904): LB-904: Best effort to show cover art in ListenCard https://github.com/metabrainz/listenbrainz-server…
lucifer: still around? just throwing around ideas for these schema numbers. should I swap your change and increase the correct value? (it has been a while since you made it, but perhaps better now than never)
2021-11-09 31303, 2021
lucifer
alastairp: yes makes sense to do it.
2021-11-09 31335, 2021
alastairp
great. will increase the correct one - leave the one that you chaged, as we don't want to go backwards
2021-11-09 31351, 2021
alastairp
and will also rename them and add some clearer documentation about when to update
2021-11-09 31352, 2021
lucifer
i don't think we use that one anywhere though so shouldn't matter
2021-11-09 31307, 2021
alastairp
we will as of this PR :)
2021-11-09 31308, 2021
lucifer
+1
2021-11-09 31315, 2021
lucifer
ah right
2021-11-09 31329, 2021
alastairp
lucifer: fyi, I've been commenting on a bunch of your PRs today
2021-11-09 31341, 2021
alastairp
if you've not seen them yet
2021-11-09 31312, 2021
lucifer
oh! i only saw one mail and replied to that.
2021-11-09 31355, 2021
lucifer
ah i see the others now. will look
2021-11-09 31357, 2021
lucifer
thanks!
2021-11-09 31316, 2021
alastairp
no problem!
2021-11-09 31343, 2021
alastairp
hopefully more tomorrow
2021-11-09 31319, 2021
alastairp
finishing up here, I'll try and get another push to the dumps tonight, but still some things to do. if you want to pick it up tomorrow then no prob from me
2021-11-09 31310, 2021
lucifer
sure sounds good. most of it looks ready already to me!
reosarevok: I think the perlcritic one is still ok to merge
2021-11-09 31312, 2021
reosarevok
Have you actually rechecked? :)
2021-11-09 31315, 2021
reosarevok
If so, I'm happy to
2021-11-09 31326, 2021
lucifer
sounds good. i'll test the import and upload tomorro
2021-11-09 31344, 2021
bitmap
reosarevok: I did a while ago whenever you added the new commits, dunno how recently you changed it besides rebasing
2021-11-09 31319, 2021
humhumxx has quit
2021-11-09 31327, 2021
reosarevok
I didn't, AFAICT
2021-11-09 31334, 2021
reosarevok
I guess I should rebase again, make sure it still passes
2021-11-09 31343, 2021
bitmap
reosarevok: re the other PR, I guess I was waiting to test it against test.mb...but I didn't want to update test.mb yet because I had dbmirror2 stuff running there
2021-11-09 31303, 2021
bitmap
which was patched into the running container
2021-11-09 31355, 2021
bitmap
I'll skim the perlcritic one again while you rebase
finished re-skimming the perlcritic one and it looks fine, though stuff like $foo->{"bar"} can just be $foo->{bar} instead of changing to single quotes
2021-11-09 31328, 2021
reosarevok
Wanna send a quick extra commit? ;)
2021-11-09 31345, 2021
bitmap
sure
2021-11-09 31334, 2021
bitmap
but just in the one file it was being changed in, not the whole codebase :)
alastairp: ruaok: i think we should trigger full dumps as is now. the listens dump is going to take a lot of time. we can patch cron once that is done to dump everything else but listens.
2021-11-09 31301, 2021
bitmap
I didn't re-test it but the code looks good
2021-11-09 31346, 2021
bitmap
and yeah, the script is executed multiple times, but webpack only runs the module definition part once
2021-11-09 31330, 2021
bitmap
(so it works but it's a minor waste of time and space)
2021-11-09 31346, 2021
IndianaBones has quit
2021-11-09 31346, 2021
piwu has quit
2021-11-09 31346, 2021
Clint has quit
2021-11-09 31346, 2021
kgz has quit
2021-11-09 31346, 2021
alastairp has quit
2021-11-09 31346, 2021
Zhele has quit
2021-11-09 31347, 2021
piwu8 is now known as piwu
2021-11-09 31347, 2021
alastairp_ is now known as alastairp
2021-11-09 31358, 2021
reosarevok
Ok. Well, hopefully it won't happen often
2021-11-09 31314, 2021
reosarevok
I just worried about us accidentally putting two tables in one page that call the same manifest
