Lst week on the LB side I worked on the year in music PR
2021-12-06 34029, 2021
monkey
Making some good headway there
2021-12-06 34048, 2021
monkey
Also reviewed and helped in a few PRs
2021-12-06 34037, 2021
monkey
On the BookBrainz side I onboarded new contributors, and with their help found and fixed some issues with local development setup and docker image building
2021-12-06 34056, 2021
monkey
I also moved our CI setup to use Github actions
2021-12-06 34004, 2021
monkey
Bye bye Travis !
2021-12-06 34018, 2021
alastairp
is that the last travis app we had?
2021-12-06 34019, 2021
ruaok
dont the door hit you in the ass on the way out.
2021-12-06 34025, 2021
monkey
I also reviewed many PRs from said new contributors
2021-12-06 34031, 2021
monkey
All the activity is nice to see :)
2021-12-06 34033, 2021
alastairp
!m new contributors
2021-12-06 34033, 2021
BrainzBot
You're doing good work, new contributors!
2021-12-06 34005, 2021
monkey
And some well needed cleanup of the BB repo, issues, dependencies, etc.
2021-12-06 34021, 2021
monkey
That's it for me ! O'yvanzo go !
2021-12-06 34043, 2021
yvanzo
Hi!
2021-12-06 34003, 2021
Freso
(People still up: akshaaatt, ruaok, Freso – last call for anyone else who may want to give review!)
Last week I mostly coded and deployed a patch to lower the I/O load due to MB dump builders.
2021-12-06 34053, 2021
yvanzo
But no significant improvement has been observed on Saturday, so that failed.
2021-12-06 34004, 2021
yvanzo
(The only positive outcome is it allows for more flexibility in deployment.)
2021-12-06 34018, 2021
yvanzo
zas: It seems that offloading may be the only solution.
2021-12-06 34032, 2021
yvanzo
Otherwise I reviewed a few pull requests.
2021-12-06 34033, 2021
zas
I think the issue is what bitmap said: pg + dumps on same machine, using slow disks
2021-12-06 34000, 2021
yvanzo nods
2021-12-06 34016, 2021
yvanzo
Also fixed another small bug in MBS deployment script.
2021-12-06 34025, 2021
yvanzo
Updated BrainzGit to the latest version of irccat.
2021-12-06 34041, 2021
yvanzo
Finally, I planned to update Jira server this week.
2021-12-06 34052, 2021
yvanzo
Go akshaaatt!
2021-12-06 34057, 2021
akshaaatt
Hi everyone
2021-12-06 34025, 2021
akshaaatt
My week started really strong with work on the brainzplayer, lb redesign stuff and year in music
2021-12-06 34048, 2021
akshaaatt
I also made quite some progress resolving issues with my mb PRs
2021-12-06 34022, 2021
akshaaatt
Last part of the week was not so good due to some medical reasons at home.
2021-12-06 34049, 2021
akshaaatt
Hopefully things get better and my work goes as I've planned this month! Excited for the work upcoming
2021-12-06 34059, 2021
akshaaatt
That's it for me. ruaok next?
2021-12-06 34002, 2021
ruaok
hiya
2021-12-06 34017, 2021
ruaok
last week was the usual MeB stuff and paying people...
2021-12-06 34055, 2021
ruaok
I also finished my playlists for YIM, but I still need to delivery the previews to the YIM datastore on the LB server, but I hope to finish that tomorrow.
2021-12-06 34026, 2021
ruaok
I spent a lot of time making troi improvements -- I've now written a lot of the core functions needed to build this playlist tool.
2021-12-06 34049, 2021
ruaok
so I spent 2 days trying to work with the annoy indexes in AB, but it didn't work out so well.
2021-12-06 34008, 2021
ruaok
there is one more thing I can try, but I am not that hopeful at this point.
2021-12-06 34023, 2021
ruaok
what disturbed me the most were my realizations about AB.
2021-12-06 34041, 2021
ruaok
we knew the high level data was crap and that we needed to run all that data once the algs were updated.
2021-12-06 34050, 2021
ruaok
fine. not a good place, but recoverable.
2021-12-06 34014, 2021
ruaok
then we found last week that the BPM code is rather quite unreliable. it was promised to be reliable.
2021-12-06 34041, 2021
ruaok
and then digging deeper into AB with the annoy stuff, I strongly suspect that the low level data we have in AB is worthless.
2021-12-06 34052, 2021
ruaok
which is a really sad note to end the week with.
2021-12-06 34020, 2021
ruaok
not sure how to proceed with that yet, looking forward to a chat with alastairp this week.
2021-12-06 34036, 2021
ruaok
that is for me. fin. Freso?
2021-12-06 34040, 2021
Freso
🙋
2021-12-06 34029, 2021
alastairp
personally, I think it's not the end of the world, but clear that the continual improvements that we wanted to do originally are something that we need to look in to
2021-12-06 34026, 2021
Freso
On less sad news, it _looks_ like theless has gone away? Or taking a break at least. I spent some time dealing with them last week, including one day where we happened to be online at the same time, so I spent a few hours whacking their mole accounts as they popped up.
2021-12-06 34058, 2021
ruaok
Freso: great.
2021-12-06 34049, 2021
Freso
Other than that, looking at general flags/reports and had my brain eaten by reosarevok about the edit note editing.
2021-12-06 34003, 2021
CatQuest
loi reozombie!
2021-12-06 34040, 2021
Freso
And being around/about-ish. :)
2021-12-06 34041, 2021
Freso
fin.
2021-12-06 34056, 2021
Freso
No more people up for reviews, and (!!) no more items on the agenda.
2021-12-06 34008, 2021
Freso
Good job everyone getting tickets made from the summit notes. :)
xxxhttps? that must be the new pr0n HTTP protocol I've heard about
2021-12-06 34045, 2021
Freso
Which might be why they’ve been used together so much. :p
2021-12-06 34052, 2021
yvanzo
reosarevok: Thanks, will look at it after food.
2021-12-06 34054, 2021
ruaok
Freso: pretty much. was good for its day. but it couldn't hang on. not necessarily due to its own faults.
2021-12-06 34057, 2021
alastairp
like many things, mysql was in the right place at the right time
2021-12-06 34004, 2021
ruaok nods
2021-12-06 34015, 2021
yvanzo
ruaok: "MySQL is a pretty poor database, and you should strongly consider using Postgres instead", open secret really :D
2021-12-06 34037, 2021
reosarevok
yvanzo, bitmap: I think I'll call it quits for the day, and release beta tomorrow morning :)
2021-12-06 34038, 2021
reosarevok
Or actually
2021-12-06 34046, 2021
reosarevok
I might release a beta now, then another tomorrow evening?
2021-12-06 34050, 2021
alastairp
I still remember how annoyed I was at how the default postgres (7-ish?) auth setup worked, way more complex compared to mysql's simple 'create user'
2021-12-06 34051, 2021
ruaok
yvanzo: you should tell that to the people who can't use MB because they are a "mysql shop"
2021-12-06 34052, 2021
reosarevok
(if we merge a bunch of this stuff)
2021-12-06 34053, 2021
lucifer
i think most people do agree that postgres is better than mysql as a single node db. i have heard many say that mysql clusters are easy to manage for a distributed db than pg but never handled that myself so don't know.
2021-12-06 34058, 2021
reosarevok
Or even Wed morning
2021-12-06 34000, 2021
ruaok
I have to explain this all the time to prospective customers
2021-12-06 34018, 2021
ruaok
alastairp: yep. "\q" bugged me the most, lol.
2021-12-06 34041, 2021
Freso
ruaok: I would have probably still been using MySQL/MariaDB for my pet projects if it wasn’t because of MB. Thank you. :)
2021-12-06 34003, 2021
alastairp
that being said, mysql's commandline is terrible. I frequently have to use it, and it doesn't do readline :(
2021-12-06 34005, 2021
yvanzo
ruaok: Now you can use this citation from Steinar H. Gunderson, former Oracle software engineer working on MySQL.
2021-12-06 34029, 2021
lucifer
"Don't believe for a second that MariaDB is any better. Monty and his merry men left because they were unhappy about the new governance, not because they suddenly woke up one day and realized what a royal mess they had created in the code." XD
2021-12-06 34037, 2021
alastairp
and much like php, people still just assume that [mysql, postgres, anything else here] is still as terrible as it was when they first learned that it was terrible
2021-12-06 34053, 2021
alastairp
php, mysql _and_ postgres are a lot better than they were 10 years ago
2021-12-06 34054, 2021
lucifer
but php is still that terrible!!
2021-12-06 34003, 2021
lucifer
i didn't write php 10 years ago though so i guess it might have been even more terrible then :D
2021-12-06 34023, 2021
Freso
For sure. And a lot of the problem with PHP is more that most prominent projects in PHP are terribly written more so than the language itself. I did not like working with PHP when I did some hacking on phpBB or Wordpress, but PHP was perfectly fine when I worked on Drupal.
yvanzo, bitmap: I'll actually release two betas, I think :)I
2021-12-06 34031, 2021
reosarevok
Since we have a few merged bugfixes
2021-12-06 34044, 2021
lucifer
ruaok: monkey: lmk the method you discussed last week when you remember it :)
2021-12-06 34045, 2021
yvanzo
reosarevok: thanks :)
2021-12-06 34054, 2021
monkey
I can't really remember. We talked about mapping incoming listen_now faster to be able to have rec_mbids available when we send them to the front-end
2021-12-06 34004, 2021
yvanzo
I don’t know about MySQL’s potential design issues, but things have been worse for MySQL since Oracle acquired it.
2021-12-06 34009, 2021
monkey
We also talked about liking a track using artist and track name, and resolving that to an MBID in the endpoint itself , but maybe I'm misremembering. Ring any bell ruaok ?
2021-12-06 34004, 2021
lucifer
yeah that artist and track name way is the proposed solution in the currently open PR too. but the current msid dict considers many other fields as well so the endpoint will need to accept those optionally as well.
2021-12-06 34033, 2021
v6lur joined the channel
2021-12-06 34000, 2021
zas
Wright's plane wasn't that bad if one considers it was a necessary step to modern airplanes (but it was an awful plane by today's standards). I think of PHP & MySQL somehow the same, they were a necessary step towards 21th century web. Time to move on, but it makes no sense to say they are/were "bad".
2021-12-06 34040, 2021
zas
And don't worry, your favorite technology of today will get old too, and likely follow the same road ;)
2021-12-06 34025, 2021
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #735 (03master…dependabot/npm_and_yarn/core-js-3.19.3): chore(deps): bump core-js from 3.19.2 to 3.19.3 https://github.com/bookbrainz/bookbrainz-site/pul…
2021-12-06 34037, 2021
BrainzGit
[bookbrainz-site] 14dependabot[bot] opened pull request #736 (03master…dependabot/npm_and_yarn/clean-webpack-plugin-4.0.0): chore(deps-dev): bump clean-webpack-plugin from 3.0.0 to 4.0.0 https://github.com/bookbrainz/bookbrainz-site/pul…
2021-12-06 34013, 2021
Zastai
(small aside, seeing these BrainzGit messages - are there any plans on switching the main branch to 'main' instead of 'master'?)
2021-12-06 34003, 2021
reosarevok
Not that I know - I don't see the point either, "master" is not connected to slavery here at all AFAICT, but to master copies, no? So it'd be a bit like changing "master of arts" or whatever
2021-12-06 34015, 2021
reosarevok
I understand github made the change for new repos, but it still makes no sense to me
2021-12-06 34046, 2021
wargreen has quit
2021-12-06 34040, 2021
Zastai
i have no dog in the race either, but I figure it's a small enough change (rename is trivial on GH, and people with clones only need to run 4 or 5 commands, once)
LB-1023: Consider replacing the broken heart emoji as the "hate" icon
2021-12-06 34013, 2021
CatQuest
*why* do we need to replace it?
2021-12-06 34051, 2021
CatQuest
ag
2021-12-06 34054, 2021
CatQuest rolls out
2021-12-06 34057, 2021
CatQuest
sleeep
2021-12-06 34032, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, upcoming meeting(s) (Freso)
2021-12-06 34031, 2021
CatQuest
oh man, I'd be fine with 20 being off since it's so close to jul
2021-12-06 34032, 2021
rdswift
Because saying, "This song breaks my heart" doesn't necessarily mean that you hate it. You may love the song, but it breaks your heart for sentimental reasons.
2021-12-06 34046, 2021
CatQuest
who says anything abou breaking heart?
2021-12-06 34058, 2021
CatQuest
it's more like "this isn't totest not love"
2021-12-06 34006, 2021
rdswift
That's what the "broken heart" emoji says.
2021-12-06 34011, 2021
CatQuest
i guess i see the emoji differently
2021-12-06 34027, 2021
CatQuest
anyway I'm tired and going to bed. natta everyone
2021-12-06 34038, 2021
rdswift
I only raised it because it wasn't intuitive that this meant that you hated the song. The broken heart concept just didn't make sense to me in that context.
2021-12-06 34006, 2021
CatQuest
hm
2021-12-06 34027, 2021
CatQuest
i think tis is one of those things where an user prefrence woudl be really neat
2021-12-06 34037, 2021
PopperBruda has quit
2021-12-06 34017, 2021
PopperBruda joined the channel
2021-12-06 34000, 2021
Zastai has quit
2021-12-06 34046, 2021
ruaok
> We also talked about liking a track using artist and track name, and resolving that to an MBID in the endpoint itself , but maybe I'm misremembering. Ring any bell ruaok ?
2021-12-06 34052, 2021
ruaok
that was it, monkey, thanks!
2021-12-06 34056, 2021
ruaok
lucifer: what monkey said -- I think when we receive a now listen, we should do a lookup in the mbid_mapping_meta table, but not do a full MBID lookup. if that fails, don't show the heart button.
2021-12-06 34003, 2021
wargreen joined the channel
2021-12-06 34003, 2021
ruaok
that should scale acceptably.
2021-12-06 34052, 2021
lucifer
ruaok: lookup for an exact match of the artist name and track name in the mapping table?
2021-12-06 34008, 2021
ruaok
yes
2021-12-06 34021, 2021
lucifer
i see. do we still keep feedback on msid?
2021-12-06 34049, 2021
lucifer
i mean allow feedback for msids that could not be mapped to a mbid.
2021-12-06 34051, 2021
ruaok
I have a feeling it would be good to keep that for a while.
2021-12-06 34011, 2021
ruaok
in other words, support mbid or msid for a piece of feedback
2021-12-06 34025, 2021
lucifer
makes sense.
2021-12-06 34003, 2021
lucifer
as a stopgap, i think that is fine. but if we want to support msid forever then might as well, do a msid lookup for feedback.
