#metabrainz

Interesting, thanks! Looks a bit more complicated/overkill than I need though. I'll probably just end up writing what I want as a shell script and a patch to the player I'm using, if I can figure out a little C++. Some day or another. :)

[listenbrainz-server] 14srichter opened pull request #1774 (03master…LB-1033-fix_doc_comment): LB-1033: Fix doc comment for listenbrainz.webserver.views.api_tools.MAX_LISTEN_SIZE https://github.com/metabrainz/listenbrainz-serv...

what's the current state of "deleting all listens resets stats"? hard to tell what i should be expecting based on open/closed issues. i deleted all of my listens about 5 days ago and my charts still show old data and the total listen count shows ~5,000

lucifer: ^

nbin: takes 15 days for deletes to affect stats. the listen count thing is probably a bug, it should reset immediately.

stats being reports + charts?

yes

gotcha. i've deleted my listens a few times and the listen count has never reset

it decreases, but always stays around 5,000

i see. what's your username?

can i pm it to you?

huh, interesting i tried to manually fix it but it climbed back up again 🤔

went from 4587->872 on my end

yeah that was me resetting listen count for your user so that it gets recalculated.

should have been 0.

those 872 songs are just big earworms i guess

weird stuff, i checked the db and it has no listens for you. so the delete worked fine not sure how its counting 872 listens.

That's what happens when you make a deal with lucifer. Strange things.

(sorry, you know I have to)

i can assure these are glitches, the vast majority of deals go fine ;)

ok i think i figured it partially.

mayhem: do you know when it listen_count_30day updated? only during regular cron run daily or continously or some other periodic run.

nvm found it https://github.com/metabrainz/listenbrainz-serv...

nbin: it can take upto a day for the listen count to become accurate again. if isn't zero tommorrow then there is another bug somewhere and i'll relook.

sounds good, thanks

mayhem: also, i looked into the mapping issue you were seeing yesterday. here's what i found: https://musicbrainz.org/release/a4be0448-accc-4... is missing from the mapping.mbid_mapping! fun stuff ;D

digged more, its missing from the mapping index because its missing from mapping.tmp_mbid_mapping_releases table and its missing there because of the joins here https://github.com/metabrainz/listenbrainz-serv...

the medium format for this release is NULL.

fwiw I think QuodLibet is a pretty good player. you can configure it to view on any tag really (but i'm not clever enough o make it work perfectly for me)

peopel used to this sort of thing would be very good at it though

yvanzo: no answer from https://github.com/metabrainz/musicbrainz-serve... - should we just close?

They can reopen if needed

moooin!

!m lucifer

You're doing good work, lucifer!

I got as far as seeing that the release wasn't in the mapping and I decided it was time to go to bed.

reosarevok: > the medium format for this release is NULL.

is that a legal state of things in the MB db or is that something that needs cleaning up?

format INTEGER, -- references medium_format.id

Nothing says it shouldn't be null

So it seems fine

oh. SQL page slap.

well done.

Hi monkey!

I'd suggest having https://github.com/metabrainz/musicbrainz-serve... always at hand

shit, I have to touch that fucking query again

It keeps proving useful :)

lol, I do. and I have gotten an open source award for that attitude, before. if you recall.

I do not, but that does mean I'm getting an award?

Yay :P

no the schema is documented now. lol.

I should find that video. my prize was a clown nose

Oh. Sad.

Oh, I'm already a clown, no props needed

So I'm ok I guess

lol

oh, it was all in good fun. R0ml picked me because he knew I would take it in stride

lucifer: ^^

many releases there!

I'll fix that before I rematch all of 2021. it should bring some more matches for us.

yeah.

but I can't work on that yet. I gotta finish the changes to troi.

I'm contemplating that all of the YIM playlists will be nothing more than one single troi script.

can i help?

(which will run for hours and hours)

if you want to try and fix that query to accurately include NULL medium formats, go for it.

yeah single script running for users one after the other sounds right.

bono should be well setup to run that. there are rudimentary mapping test that can be run to ensure the mapping doesn't get borked by the changes in the query.

LEFT JOIN should include NULL formats but what about ordering. how should null formats be ordererd/

this is literally at the heart of the mapping.

what's the purpose of the ordering?

so that albums are preferred over other formats.

but that means that all formats need to be sorted somehow. and given that we have no idea what format it is, put them at the end the of the collation order, I would say.

i see, so NULLS LAST should make sense?

yes

which will prefer all other formats, but not exclude releases for which we only have one NULL format.

👍, i'll update the query and then ask about how to run this on bono.

great. I'm happy you understand this mapping. very very good to have a second person.

I love how people are slowing coming and asking questions. its great to find holes here and there -- would be impossible without more eyes

indeed :D

but I deffo need to spend some more time on other mapping improvements very soon.

in particular I need to work out a rematch schedule.

yes makes sense.

mayhem: this is what it looks like after the left join and nulls last (its actually default for asc order but specifying nayway for clarity)

(type is primary type, id is secondary type)

should work.

wanna make a branch? I can run it on bono and we'll see

sure pushing now

[listenbrainz-server] 14amCap1712 opened pull request #1775 (03master…mapping-format-null): Use LEFT JOINs for medium format in mapping because it can be NULL https://github.com/metabrainz/listenbrainz-serv...

😆

I ran the tiny dataset test (3 tests only) and they all passed. good first sign.

now building the full set.

lucifer: I think we should rebase your mapping-format-null branch over add-mbid-mapping-explain since that is what is running in prod right now.

I've looked at your comments and I dont see a lot of fixes (other than docs) that are needed for that PR.

this improvements you suggest should come in a later PR.

ah right, i'll rebase.

O’Moin

if the larger tests pass, Im happy to merge your mini branch and then deploy again.

moin yvanzo

👍

rebased and pushed

the next thing to implement is a multiplexer element that combines output of the for loop back into one single stream which can be used to add YIM data to LB DB

moin yvanzo :)

community is down, doing an upgrade, that went bad

CatQuest: I agree regarding Quod Libet but unfortunately it seems to be barely maintained

Hi akshaaatt

Wanted to give some updates monkey. I made some PRs to BookBrainz and will contribute more next week. Other than that I was making some updates to YIM.

What's your schedule for this week like?

I wanted to ask regarding yim that should we move the 2021 graphic we use to the left and the user details to the right? So that in mobile version the graphic comes first and then we have the details

I saw the PRs for BookBrainz, thanks ! :) Good to see more cross-polination

That footer is going to look nice and consistent !

Yusss

The rest of the week I was to be working on YIM mainly. Good suggestion for the graphic, I'll move that over (going to start work on YIM right now)

community is back, this upgrade took longer than expected

Thanks zas

Great! I'm looking to fix the UI for the Your top recordings/artists/albums which I think is a bit tricky

Happy to discuss with you if it helps

is YIM live anywhere?

tandy1000: a bit early still. not all the data has been collected yet.

ok, il be more patient :)

monkey I'm looking to add album coverarts in that component. Would that be easy to do?

!m lucifer

You're doing good work, lucifer!

!m lucifer

You're doing good work, lucifer!

[listenbrainz-server] 14mayhem merged pull request #1775 (03add-mbid-mapping-explain…mapping-format-null): Use LEFT JOINs for medium format in mapping because it can be NULL https://github.com/metabrainz/listenbrainz-serv...

akshaaatt: Well… For recordings and releases, provided we have release MBIDs attached, piece of cake. There's code for that in the ListenCard. However for artists we don't really have any resources

And it falls out of the scope of the Cover art archive