Interesting, thanks! Looks a bit more complicated/overkill than I need though. I'll probably just end up writing what I want as a shell script and a patch to the player I'm using, if I can figure out a little C++. Some day or another. :)
2021-12-08 34223, 2021
abdulocracy1 has quit
2021-12-08 34249, 2021
MRiddickW joined the channel
2021-12-08 34234, 2021
abdulocracy1 joined the channel
2021-12-08 34258, 2021
Lotheric_ joined the channel
2021-12-08 34241, 2021
Lotheric has quit
2021-12-08 34206, 2021
gcrkrause has quit
2021-12-08 34259, 2021
gcrkrause joined the channel
2021-12-08 34250, 2021
SothoTalKer_ joined the channel
2021-12-08 34240, 2021
SothoTalKer has quit
2021-12-08 34244, 2021
SothoTalKer_ is now known as SothoTalKer
2021-12-08 34258, 2021
BrainzGit
[listenbrainz-server] 14srichter opened pull request #1774 (03master…LB-1033-fix_doc_comment): LB-1033: Fix doc comment for listenbrainz.webserver.views.api_tools.MAX_LISTEN_SIZE https://github.com/metabrainz/listenbrainz-server…
2021-12-08 34201, 2021
nbin
what's the current state of "deleting all listens resets stats"? hard to tell what i should be expecting based on open/closed issues. i deleted all of my listens about 5 days ago and my charts still show old data and the total listen count shows ~5,000
2021-12-08 34229, 2021
reosarevok
lucifer: ^
2021-12-08 34253, 2021
lucifer
nbin: takes 15 days for deletes to affect stats. the listen count thing is probably a bug, it should reset immediately.
2021-12-08 34255, 2021
nbin
stats being reports + charts?
2021-12-08 34201, 2021
lucifer
yes
2021-12-08 34207, 2021
nbin
gotcha. i've deleted my listens a few times and the listen count has never reset
2021-12-08 34217, 2021
nbin
it decreases, but always stays around 5,000
2021-12-08 34231, 2021
lucifer
i see. what's your username?
2021-12-08 34211, 2021
nbin
can i pm it to you?
2021-12-08 34239, 2021
lucifer
sure
2021-12-08 34232, 2021
lucifer
huh, interesting i tried to manually fix it but it climbed back up again 🤔
2021-12-08 34205, 2021
nbin
went from 4587->872 on my end
2021-12-08 34234, 2021
lucifer
yeah that was me resetting listen count for your user so that it gets recalculated.
2021-12-08 34210, 2021
lucifer
should have been 0.
2021-12-08 34216, 2021
nbin
those 872 songs are just big earworms i guess
2021-12-08 34240, 2021
lucifer
weird stuff, i checked the db and it has no listens for you. so the delete worked fine not sure how its counting 872 listens.
2021-12-08 34248, 2021
reosarevok
That's what happens when you make a deal with lucifer. Strange things.
2021-12-08 34213, 2021
reosarevok
(sorry, you know I have to)
2021-12-08 34229, 2021
lucifer
i can assure these are glitches, the vast majority of deals go fine ;)
2021-12-08 34212, 2021
lucifer
ok i think i figured it partially.
2021-12-08 34207, 2021
lucifer
mayhem: do you know when it listen_count_30day updated? only during regular cron run daily or continously or some other periodic run.
nbin: it can take upto a day for the listen count to become accurate again. if isn't zero tommorrow then there is another bug somewhere and i'll relook.
digged more, its missing from the mapping index because its missing from mapping.tmp_mbid_mapping_releases table and its missing there because of the joins here https://github.com/metabrainz/listenbrainz-server…
2021-12-08 34234, 2021
lucifer
the medium format for this release is NULL.
2021-12-08 34209, 2021
petitminion joined the channel
2021-12-08 34234, 2021
petitminion has quit
2021-12-08 34247, 2021
CatQuest joined the channel
2021-12-08 34206, 2021
CatQuest
fwiw I think QuodLibet is a pretty good player. you can configure it to view on any tag really (but i'm not clever enough o make it work perfectly for me)
2021-12-08 34218, 2021
CatQuest
peopel used to this sort of thing would be very good at it though
I'll fix that before I rematch all of 2021. it should bring some more matches for us.
2021-12-08 34203, 2021
mayhem
yeah.
2021-12-08 34221, 2021
mayhem
but I can't work on that yet. I gotta finish the changes to troi.
2021-12-08 34241, 2021
mayhem
I'm contemplating that all of the YIM playlists will be nothing more than one single troi script.
2021-12-08 34244, 2021
lucifer
can i help?
2021-12-08 34248, 2021
mayhem
(which will run for hours and hours)
2021-12-08 34225, 2021
mayhem
if you want to try and fix that query to accurately include NULL medium formats, go for it.
2021-12-08 34229, 2021
lucifer
yeah single script running for users one after the other sounds right.
2021-12-08 34209, 2021
mayhem
bono should be well setup to run that. there are rudimentary mapping test that can be run to ensure the mapping doesn't get borked by the changes in the query.
2021-12-08 34212, 2021
lucifer
LEFT JOIN should include NULL formats but what about ordering. how should null formats be ordererd/
2021-12-08 34218, 2021
mayhem examines the query
2021-12-08 34226, 2021
mayhem
this is literally at the heart of the mapping.
2021-12-08 34247, 2021
lucifer
what's the purpose of the ordering?
2021-12-08 34216, 2021
mayhem
so that albums are preferred over other formats.
2021-12-08 34251, 2021
mayhem
but that means that all formats need to be sorted somehow. and given that we have no idea what format it is, put them at the end the of the collation order, I would say.
2021-12-08 34253, 2021
lucifer
i see, so NULLS LAST should make sense?
2021-12-08 34257, 2021
mayhem
yes
2021-12-08 34221, 2021
mayhem
which will prefer all other formats, but not exclude releases for which we only have one NULL format.
2021-12-08 34244, 2021
lucifer
👍, i'll update the query and then ask about how to run this on bono.
2021-12-08 34206, 2021
mayhem
great. I'm happy you understand this mapping. very very good to have a second person.
2021-12-08 34200, 2021
mayhem
I love how people are slowing coming and asking questions. its great to find holes here and there -- would be impossible without more eyes
2021-12-08 34230, 2021
lucifer
indeed :D
2021-12-08 34250, 2021
mayhem
but I deffo need to spend some more time on other mapping improvements very soon.
2021-12-08 34203, 2021
mayhem
in particular I need to work out a rematch schedule.
mayhem: this is what it looks like after the left join and nulls last (its actually default for asc order but specifying nayway for clarity)
2021-12-08 34209, 2021
lucifer
(type is primary type, id is secondary type)
2021-12-08 34214, 2021
mayhem
should work.
2021-12-08 34225, 2021
mayhem
wanna make a branch? I can run it on bono and we'll see
2021-12-08 34232, 2021
lucifer
sure pushing now
2021-12-08 34200, 2021
BrainzGit
[listenbrainz-server] 14amCap1712 opened pull request #1775 (03master…mapping-format-null): Use LEFT JOINs for medium format in mapping because it can be NULL https://github.com/metabrainz/listenbrainz-server…
2021-12-08 34218, 2021
lucifer
😆
2021-12-08 34217, 2021
mayhem
I ran the tiny dataset test (3 tests only) and they all passed. good first sign.
2021-12-08 34252, 2021
mayhem
now building the full set.
2021-12-08 34244, 2021
piwu85 has quit
2021-12-08 34213, 2021
mayhem
lucifer: I think we should rebase your mapping-format-null branch over add-mbid-mapping-explain since that is what is running in prod right now.
2021-12-08 34238, 2021
mayhem
I've looked at your comments and I dont see a lot of fixes (other than docs) that are needed for that PR.
2021-12-08 34246, 2021
mayhem
this improvements you suggest should come in a later PR.
2021-12-08 34209, 2021
piwu85 joined the channel
2021-12-08 34214, 2021
lucifer
ah right, i'll rebase.
2021-12-08 34239, 2021
yvanzo
O’Moin
2021-12-08 34241, 2021
mayhem
if the larger tests pass, Im happy to merge your mini branch and then deploy again.
2021-12-08 34245, 2021
mayhem
moin yvanzo
2021-12-08 34200, 2021
lucifer
👍
2021-12-08 34203, 2021
lucifer
rebased and pushed
2021-12-08 34210, 2021
mayhem returns to make troi to mind bending stuff
2021-12-08 34247, 2021
mayhem
the next thing to implement is a multiplexer element that combines output of the for loop back into one single stream which can be used to add YIM data to LB DB
2021-12-08 34227, 2021
reosarevok
moin yvanzo :)
2021-12-08 34237, 2021
zas
community is down, doing an upgrade, that went bad
2021-12-08 34209, 2021
atj
CatQuest: I agree regarding Quod Libet but unfortunately it seems to be barely maintained
2021-12-08 34201, 2021
monkey
Hi akshaaatt
2021-12-08 34212, 2021
akshaaatt
Wanted to give some updates monkey. I made some PRs to BookBrainz and will contribute more next week. Other than that I was making some updates to YIM.
2021-12-08 34229, 2021
akshaaatt
What's your schedule for this week like?
2021-12-08 34226, 2021
akshaaatt
I wanted to ask regarding yim that should we move the 2021 graphic we use to the left and the user details to the right? So that in mobile version the graphic comes first and then we have the details
2021-12-08 34215, 2021
monkey
I saw the PRs for BookBrainz, thanks ! :) Good to see more cross-polination
2021-12-08 34229, 2021
monkey
That footer is going to look nice and consistent !
2021-12-08 34236, 2021
akshaaatt
Yusss
2021-12-08 34225, 2021
monkey
The rest of the week I was to be working on YIM mainly. Good suggestion for the graphic, I'll move that over (going to start work on YIM right now)
2021-12-08 34247, 2021
zas
community is back, this upgrade took longer than expected
2021-12-08 34240, 2021
monkey
Thanks zas
2021-12-08 34208, 2021
akshaaatt
Great! I'm looking to fix the UI for the Your top recordings/artists/albums which I think is a bit tricky
2021-12-08 34245, 2021
monkey
Happy to discuss with you if it helps
2021-12-08 34220, 2021
tandy1000
is YIM live anywhere?
2021-12-08 34240, 2021
mayhem
tandy1000: a bit early still. not all the data has been collected yet.
2021-12-08 34245, 2021
tandy1000
ok, il be more patient :)
2021-12-08 34245, 2021
akshaaatt
monkey I'm looking to add album coverarts in that component. Would that be easy to do?
[listenbrainz-server] 14mayhem merged pull request #1775 (03add-mbid-mapping-explain…mapping-format-null): Use LEFT JOINs for medium format in mapping because it can be NULL https://github.com/metabrainz/listenbrainz-server…
2021-12-08 34211, 2021
monkey
akshaaatt: Well… For recordings and releases, provided we have release MBIDs attached, piece of cake. There's code for that in the ListenCard. However for artists we don't really have any resources
2021-12-08 34233, 2021
monkey
And it falls out of the scope of the Cover art archive
