had an interesting discussion with mayhem about future of AB/how we can make it more useful. some things to think about there, more news in the new year we hope
on Friday I helped lucifer mitigate the log4j exploit in the MB search cluster
2 days of holiday in spain last week, so I took some time off too
fin. yvanzo?
yvanzo
Hi!
Also helped with mitigating CVE-2021-44228 in MB Solr on production and for mirrors.
Reviewed some MBS PRs.
Jira server update is still going on.
Fin. Go lucifer
lucifer
hi all!
Freso
(Still up for review: bitmap, akshaaatt, zas, monkey, Freso – anyone else who wants to give review, let me know ASAP.)
CatQuest waves
lucifer
last week, i had did some work on YI stuff to add total listen counts/listen count per day and top stats.
helped in debugging some mapping edge cases (LEFT JOINs say hello), debugged listen counts issues (continues to be a pain)
also helped in optimizing top missing tracks query and in the process discovered an awesome website for pg explains https://explain.depesz.com/
alastairp
oh no! have we not shown that page to you before? :(
mayhem
I had even forgotten about it
lucifer
towards the end of the week, the log4j RCE was disclosed. initially, we thought we were unaffected but in some time realised we run several Java based services. (SOLR, ES, Spark and JIRA). helped others with patching and investigating impact.
that's it for me.
bitmap: next?
bitmap
hey
lucifer
CatQuest: lol
bitmap
last week I worked on some functions/triggers for the *_tag_raw tables to keep the tag.ref_count and aggregate count columns in sync
alastairp
🎉
thanks bitmap!
bitmap
those are pretty much done. I'm writing the upgrade script to fix the existing counts today and then I'll add some pgtap tests, hopefully.
fyi tag.ref_count is a count of how many times the tag is references at all, but the aggregrate counts on e.g. artist_tag.count is a sum of the votes (downvotes being negative)
other than that I worked a little bit more on React-ifying events/actions in the release editor
fin. go monkey
alastairp
is a downvote a reference to a tag?
monkey
Hi everyone !
bitmap
alastairp: yes
CatQuest
alastairp: i also have thoguhts on that
monkey
The biggest chunk for me last week was continuing the year in music page, which is pretty close to finished now.
I also reviewed PRs on LB and BB, and continued finishing up some old PRs on LB
Helped new contributors with some local development issues, and helped them navigate the codebase, answered questions, etc.
In short, some new contributor onboarding
following the log4j report, I read some documentation for upgrading ElasticSearch. It's not currently vulnerable, but BB is using an old unsupported version that needs updating
That's it on my side,akshaaatt go !
akshaaatt
Hi everyone!
Freso
(Only zas and myself (Freso) left for reviews – last call for anyone else who wants to chime in!)
akshaaatt
Last week I resolved over a million Eslint issues in my MB PR which is good to be reviewed and finalized soon!
Also, I read a few posts on the community forum that mb isn't showing up on Google searches, one reason being the mobile support and hence I'm pumped to get the revamp going on full throttle!
I connected with aerozol a bit as he mtivated me to design even more mb pages!
I'm badically going to refactor a lot of code this month across projects this month!
Had some lb work going as well including year in music and cleanup stuff
That's it for me. Go zas!
zas
Last week, I upgraded discourse (it fails, I had to fix it quickly)
I also upgraded our grafana instances (security issue)
I worked on Picard upcoming release, mainly French translation (a lot of strings to translate)
plus usual stuff and help on LOG4J issue
fin. Freso?
Freso
🙋
Editor we’ve been dealing with for the last few weeks popped up once, so spent some time looking for other activity from them.
Reviewed/feedbacked some PRs.
Dealt with some spam profiles on MB and forums.
Oh, and I helped mayhem get the "mayhem" nick on this network. :)
CatQuest
:D
Freso
I think that’s about it.
mayhem
thanks!
Freso
CatQuest: Are you around?
CatQuest
yes
Freso
cat: gravatar (MD5 adresses)
Go then. :)
CatQuest
ok so, recently chaban pointed out on MBS-9725 that the MD5 email address hashes were cracked
and I agree with them that it is about hightime we really remove gravatar.
I also know that it hasn't been done because a lot of other stuff needed doing anyway" (which is fine)
but now with this issue, maybe we should expedition the solution of MBS-9725 a bit?
yes?
mayhem
reosarevok: bitmap yvanzo : how much work is this?
bitmap
can we remove gravatar before adding the the discouse replacement?
discourse*
CatQuest
hope so
bitmap
removing gravatar isn't a lot of work, so if we can do without avatars for a bit, let's do that
reosarevok
I think that'd be ok
CatQuest
yep
i have them turned off/blocked anyway
bitmap
I looked into syncing the discourse ones a while ago an it's not super trivial
Freso
So… I guess that’s decided?
Next topic?
yvanzo
yup
mayhem
who is going to do this work?
CatQuest
yay!
yea! who
bitmap
I'll submit a PR to remove gravatar today
CatQuest
<3 bitmap
mayhem
perfect, thanks.
Freso
👍
CatQuest agree
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MB team ignoring telegram (ruaok), upcoming meeting(s) (Freso)
ruaok: MB team ignoring telegram
mayhem: ^
CatQuest
oh no
mayhem
so, it happened again today. last time we left it at "we'll turn notifications back on", but that clearly didn't fix it.
bitmap: how can we improve this?
bitmap
that's my fault... I have family visiting until thursday so my attention has been diverted for a bit
well, I saw some notifications an hour ago but thought they might be due to the MBS release
mayhem
I think it might be time to setup time slices where certain team members are responsible for watching things/
yvanzo
I would do something if I knew what to do: for example, I react to SIR alerts.
mayhem
yvanzo: then its time for more cross training.
reosarevok
For this one, all I did once I noticed it is docker logs --tail 500 -f musicbrainz-website-prod in burnside
That made the issue obvious enough
mayhem
everyone on the team should have a basic idea on how to do diagnostics.
reosarevok
That said, if that had *not* made the issue obvious enough, I would have probably been kinda stuck
mayhem
and if someone doesn't know how, but sees the alerts, then this person should rouse others to help.
but sitting by and doing nothing, simply isn't acceptable anymore.
kinda stuck and paying attention to things is far far better than "not my problem".
and not everything can be bitmap's problem. that isn't fair to bitmap.
yvanzo
This is not what happened, I didn’t think it was a big issue.
mayhem
so, I'm giving a concrete assignment to the three of you, yvanzo, bitmap and reosarevok.
I want a plan for how this get improved. I want a plan to addresses who is responsible at a certain time of day and I want a cross training plan.
this is due for the first meeting in the new year, ok?
bitmap
ok with me
mayhem
yvanzo? reosarevok ?
please ack this assignment.
reosarevok
Sure I guess?
Freso
yvanzo: Ping?
reosarevok
I don't know what's the source of the being dickish about it instead of asking nicely way of dealing with it, but the request seems sensible enoug
*enough
So sure, whatever
yvanzo
thanks reosarevok
CatQuest
:/ pls no fighting :/
mayhem
I'm angry because this is the third time I've asked for a concrete plan, but I keep getting blown off.
yvanzo?
reosarevok
IIRC you just asked us to not ignore the alerts, not for a specific plan :) But anyway, not against a specific plan
yvanzo
Yes, and improving alerts was part of the plan. Anyhow, I want to improve the current situation.
mayhem
thank you.
Freso: lets figure out meetings then./.
Freso
Alright… and speaking of next meeting!
Or first meeting in next year, rather.
Freso: upcoming meeting(s)
CatQuest
personally I'm happy if the next meeting is cancelled
Freso
So. Next Monday is a few days before Christmas, after that is between Christmas and New Year’s, and then after that is just after New Year’s. Any of these we want to cancel? (I assume the one on the 27th is off, we usually don’t do the Monday in between Christmas and NY.)
reosarevok
I'm semi-away Dec 20 to Jan 12 but I guess I can be around for at least meetings (and probably discussion of stuff like the alerts thing)
mayhem
I'll be flying for the next meeting.
Freso
But do we want the 20th and/or the 3rd off as well?
CatQuest
kinda wanna be afk for atleast before new years
alastairp
I don't be back until the 10th. I don't have a problem having a meething next week
*I won't be back
reosarevok
20th I'm traveling, I should be done by meeting time, but :) not sure
CatQuest wil lbe afk
mayhem
lets cancel both, so that the MB team has another week for the deadline.
Freso
I’m personally leaning towards calling off the next three Mondays. Have a bit more of a relaxed Holiday Season and have time to recover for those doing things on/around Christmas and NY. :)
CatQuest
+1 to that
Freso
So next meeting will be January 10th!
monkey
Same as Alastair, I'm here for next meeting but away until the 9th.
