#metabrainz

/

      • MrClon joined the channel
      • MrClon has quit
      • MrClon joined the channel
      • darkstarx has quit
      • darkstardevx joined the channel
      • darkstardevx has quit
      • darkstardevx joined the channel
      • darkstardevx has quit
      • gcrkrause has quit
      • gcrkrause joined the channel
      • darkstardevx joined the channel
      • darkstardevx has quit
      • darkstardevx joined the channel
      • darkstardevx has quit
      • akshaaatt
        Hi monkey!
      • darkstardevx joined the channel
      • darkstardevx has quit
      • darkstardevx joined the channel
      • darkstardevx has quit
      • monkey I went through tons of carousels but only found the one implemented currently to be suitable for us.
      • I have fixed everything else and things seem to be ready with some updates from your side.
      • darkstardevx joined the channel
      • darkstardevx has quit
      • darkstardevx joined the channel
      • darkstardevx has quit
      • Clint has quit
      • Clint joined the channel
      • lucifer
        mayhem: should we send text/html email or text/plain? it seems that its possible to send both parts in a single email and the email client can decide which version to show. html is preferred if available otherwise it fall backs to plain text.
      • CatQuest
        lucifer: my import is still going strong. now on 2018. so it'll finish some time today
      • lucifer
        ah nice.
      • CatQuest
        honestly i think something went weird with the bit that made emails mandatory to submit listens (whne was that released?)
      • lucifer
        1 Nov, 2021.
      • oh! that might be it actually.
      • CatQuest
        I was logged in and hadn't been logged out since before thne i assume
      • probably everyone should be force logged out and so they need to log back in
      • lucifer
        iirc we did that.
      • CatQuest
        i wasn't iirc
      • lucifer
        did you have an email in MB previously?
      • CatQuest
        ah, i didn't know you coudl reset the timestamp at wil. i'd have asked yo uto reset it to like 20th october instead :D
      • i've had it for ages
      • validated in.. idk 2018 or osmething
      • lucifer
        its possible to reset the timestamp but i have to do it manually in the db. i had set it to 1st oct when i pinged yesterday.
      • CatQuest
        yes
      • i wishi had logged out and bakc in first. well no matter
      • i didn't know you coudl do that :D
      • it's on page 24869 of 32673 now so
      • might be healty to reimport everything
      • lucifer
        interesting, i think users who do not have an email may have an issue. i'll try to confirm that but if you have an email then regardless of login/logout it should work.
      • CatQuest
        yes
      • i think the import still "works" but gives an error in network
      • so you keep trying withouth actually getting the 401 error with its very descriptive error
      • *explanation*
      • it was ind eed tihs errormessage that made me go "but what, i have an email, it's go ot bel inked to that whne logging in!" ok, let's try logging in and tne out
      • and that seems o have fixed it
      • lucifer
        yes its possible that some network error is unhandled which then causes the importer to misbehave.
      • CatQuest
        I'll ask if you can all wait with the yim thing until after my import finishes XD
      • lucifer
        we import new to back iirc? so your 2021 listens shoudl already be in
      • CatQuest
        from scratch seems not to be liek that. it started on like 2008 and is now on 2018
      • lucifer
        we'll probably need another ~8 hrs at least anyways.
      • CatQuest
        oh, it'll b in by then!
      • :D
      • lucifer
        if we want to do full dumps and import those. import latest mb data etc.
      • CatQuest
        🙏 😙
      • CatQuest goes of to open advent calendars/make breakfast
      • good news lucifer
      • mayhem
        Let's do both, I'd say.
      • lucifer
        sounds good. looking at BU send mail, we'll probably need to update it to handle both parts or write a new send_mail in LB
      • mayhem
        moooin!
      • I have generated the base data for the playlists shortly after midnight CET, so that should be done. time to make some playlists.
      • lucifer
        mayhem: what should be the message for timeline event?
      • mayhem
        "Our family has been farming musical bits for your family for weeks. Come get your copy before Santa comes and steals them all. #confused"
      • mayhem thinks that should do it.
      • lucifer
        👍, hyperlink copy to year in music page?
      • mayhem
        yep!
      • mayhem starts crafting something more serious
      • akshaaatt
        Do we want to keep analytics as to how many people opened our email or had their YIM generated?
      • mayhem
        "ListenBrainz' very own retrospective on 2021 has just dropped: Check out your own Year in Music now!"
      • lucifer
        imo no need for analytics.
      • mayhem
        akshaaatt: we should limit that to checking the logs on who accesses their YIM. other things would be against our privacy policy.
      • akshaaatt
        Okieee
      • I am looking to work on improving the homepage for ListenBrainz after YIM is done so I think such stats would look good their
      • There*
      • lucifer
        how many users had their YIM generated is a count of db rows so need of analytics for that.
      • akshaaatt
        Yuss
      • lucifer
        what stats do you have in mind?
      • akshaaatt
        How successful YIM was, the basic user stats and listens submitted(which we already have) and maybe adding some sorta stat as to how connected lb is to mb would be good
      • lucifer
        all except the first sound good. for how successful YIM was i don't think users opening email/page cannot be considered a success anyways?
      • akshaaatt
        Yeah right
      • mayhem
        it would be nice to see how many people open their YIM.
      • akshaaatt
        I think we need to prioritise all the features available on ListenBrainz and club them in a section in the homepage
      • Example pins, recommendations, huesound, yim, listens, etc all should be told to the users that they exist
      • mayhem
        hi!
      • I wasn't proposing that we let users upload the content to us -- that is overall not a good idea.
      • akshaaatt
        Okay!
      • mayhem
        something we can think about in more detail next year.
      • akshaaatt
        Amazing!
      • lucifer
        mayhem: first cut, https://github.com/metabrainz/listenbrainz-serv... will try sending this to me and see how it renders and then figure out adding the plaintext part.
      • akshaaatt: monkey: ideas about this? https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        looks good, lucifer !
      • lucifer
        i think the first error will go away with a supress. not sure about the second.
      • akshaaatt
        I'm not sure about the second error of the import lucifer
      • We need to finalize things for yim. I'm waiting for monkey to appear :)
      • lucifer
        i see. its missing type declarations likely so it suggests to add @types/react-coverflow. npm doesn't have that package so will probably need some magic LB side.
      • akshaaatt
        That library is also caduing some issues which I want to discuss. But it seems like our best shot at things rn
      • lucifer
        is it fine if i comment this stuff for some time to try out the email stuff?
      • akshaaatt
        Sure lucifer! Go ahead
      • lucifer
        👍 thanks
      • akshaaatt
        !m lucifer
      • BrainzBot
        You're doing good work, lucifer!
      • monkey
        I'm having some issues with my computer, but I'm around (on my phone at least)
      • mayhem
        lemme know if you'd like my to bring my old lappy to the office, monkey
      • alastairp
        monkey: oh no!
      • monkey
        That sounded more alarming than was due. Nothing drastic, compy still works
      • mayhem
        ok
      • monkey
        But thanks for the offer
      • alastairp
        OK, I'm here for the next 2 days! let me read yesterday's chatlog and get up to date on where we are
      • talk about emails sounds exciting
      • lucifer
      • alastairp
        sure looks like html
      • lucifer
        i did kinda see that coming, so yeah need to update BU send_email.
      • alastairp
        no multipart support?
      • lucifer
        don't think it supports that, but here the content type is also incorrect
      • alastairp
        ah, I see. it does multipart for attachments, but no html/text email
      • lucifer: given how short mail.py is, it might be just as easy to import something into LB for now
      • even go for something like https://pythonhosted.org/Flask-Mail/
      • `The message can contain a body and/or HTML:`
      • lucifer
        yeah that's the intent, add to LB for now. faster to reiterate. later update as needed.
      • i see. let me look into that
      • alastairp
        iterate, not reiterate :)
      • lucifer
        ah right!
      • alastairp
        I reiterate, we should iterate more
      • lucifer
        lol
      • monkey
        Heading to OfficeBrainz
      • lucifer
        alastairp: Flask-Mail looks like hasn't been updated in years and the github repo is missing too. https://pypi.org/project/Flask-Mail/
      • alastairp
        lucifer: right, not an ideal option then
      • maybe there's another lib that does html/text mime messages nicely. Doesn't need to be flask related
      • tbf, I've not even looked at the email library in python, perhaps it's really simple to do
      • lucifer
        there's an example available here, https://docs.python.org/3.8/library/email.examp...
      • doesn't look hard
      • alastairp
        msg.add_alternative(..., subtype='html')
      • mayhem
        monkey: I'll be there for lunch -- I have a couple of things to take care of around 13:30.
      • alastairp
        cool. no need for special libraries to make that work
      • I have lunch with me, so won't be going out, unless for a walk around the block
      • lucifer: Do you know anything about how to make a custom bit of text turn up in the gmail message preview? when the email is listed in the inbox
      • lucifer
        alastairp: no don't know. will see if i can find something
      • alastairp
        not important, I assume it just takes it from the first part, or something
      • lucifer
      • yup looks like it
      • alastairp
        I often receive full HTML emails, where the preview text isn't anything related to the html
      • akshaaatt
        Hola monkey!