17:50 PM
lucifer
monkey would know
17:50 PM
mayhem
the twitter card doesn't seem to work for svg files.
17:51 PM
monkey
I can generate another format
17:51 PM
What do you need?
17:51 PM
mayhem
png or jpg, I'd guess.
17:51 PM
monkey
OK
17:54 PM
alastairp
lucifer: can I help with any testing?
17:54 PM
monkey
17:55 PM
alastairp
if nothing immediate, I think I'll go home and will be back in 30-40 mins
17:55 PM
lucifer
alastairp: need to deploy a image off your branch to spark reader. waiting to see if it builds on github.
17:55 PM
alastairp
nice
17:55 PM
lucifer
i think nothing to do immidietaley
17:55 PM
alastairp
cool. back soon
17:56 PM
lucifer
*immediately
18:01 PM
mayhem
18:01 PM
hmmm.
18:01 PM
should I add margin to that so it fits?
18:02 PM
monkey
Yes
18:02 PM
Generating square image
18:02 PM
lucifer
mayhem: with that Year in Music 3 times in the card looks repetitive
18:02 PM
mayhem
hmmmm
18:03 PM
monkey
18:07 PM
mayhem
18:07 PM
rdswift
With the extra whitespace available on the square image, is there any desire to include "ListenBrainz" in it somehow?
18:08 PM
mayhem
I'm about ready to call it good. :)
18:09 PM
monkey
I'll prepare an image with LB logo for tomorrow
18:09 PM
rdswift
BTW, I think the image with the ribbon is AWESOME.
18:09 PM
ssam has quit
18:09 PM
!m monkey
18:09 PM
BrainzBot
You're doing good work, monkey!
18:09 PM
monkey
nice :)
18:13 PM
18:13 PM
mayhem
18:13 PM
might want to make the listenbrainz logo bigger.
18:14 PM
monkey
18:20 PM
mayhem
I think twitter is caching images.
18:20 PM
18:20 PM
18:20 PM
maybe you get something different?
18:21 PM
lucifer: commited the twitter card to yim-email.
18:23 PM
lucifer
mayhem: unable to upload a screenshot but new logo is showing up now
18:24 PM
irccloud is acting up not letting me post an image
18:24 PM
18:24 PM
worked now :)
18:25 PM
mayhem
Puurfect.
18:29 PM
akshaaatt
!m LB team
18:29 PM
BrainzBot
You're doing good work, LB team!
18:30 PM
monkey
I second that, good effort from everyone today
18:31 PM
lucifer
18:40 PM
alastairp
lucifer: ah, interesting. I can fix that. where do you want it?
18:41 PM
lucifer
alastairp: i pushed a bandaid fix, and an image. just about to request another batch. can you take a look at it?
18:41 PM
18:42 PM
just added the if here, i think that should be fine but not sure that's what you'd expect or not.
18:42 PM
alastairp
lucifer: I mean, that sure looks like a correct fix, rather than a bandaid!
18:42 PM
lucifer
ah ok 👍
18:43 PM
alastairp
similar bug in the first 3 queries if there end up being no release mbids
18:43 PM
lucifer
requesting another batch.
18:43 PM
yup right i saw that, but i figured it might less likely so didn't fix that yet
18:49 PM
stats are coming in. artists reduced to 50 so that seems to be working
18:50 PM
CatQuest
wait, the 2021 with a ribbon was designed by monkey ???
18:50 PM
WOW
18:50 PM
👏 👏 👏
18:50 PM
!m monkey
18:50 PM
BrainzBot
You're doing good work, monkey!
18:50 PM
alastairp
lucifer: artists reduced to 50, or releases?
18:51 PM
lucifer
all stats, 50 each that was the plan no?
18:51 PM
monkey
Yes
18:51 PM
lucifer
50 artists, 50 recordings, 50 releases
18:51 PM
monkey
Thanks CatQuest
18:51 PM
alastairp
yes
18:51 PM
monkey
Yes
18:51 PM
alastairp
yes
18:51 PM
lucifer
its artists stats, recordings stats and then releases stats
18:52 PM
releases will come last
18:52 PM
yes
18:52 PM
alastairp
lucifer: how long does stats take to import normally?
18:52 PM
CatQuest
what is tripfolk klabb? :D
18:52 PM
sounds like some dodgy genre
18:52 PM
alastairp
CatQuest: it's very good
18:52 PM
monkey
*Etnika forever !
18:52 PM
lucifer
alastairp: 8 hrs for entire batch or all ranges and types! but this one should take ~15-25 mins i gues
18:53 PM
CatQuest
alastairp & monkey you cna post bandcamp or youtube links to KassOtsimine
18:53 PM
(if you wnna show some to this)
18:53 PM
:D
18:53 PM
monkey
Search for *Etnika (that's a band)
18:53 PM
CatQuest
oic
18:53 PM
sounds a bit like sillyname with te * :D
18:54 PM
lucifer
ok spark is all done now. messages piling up in queue so only import goes on now.
18:54 PM
CatQuest
monkey: i won't remember this at all (i'm off to the kitchen (sigh) again now)
18:55 PM
is it on bandcamp?
18:55 PM
alastairp
18:55 PM
that genre isn't dodgy
18:55 PM
għana!
18:55 PM
lucifer
18:55 PM
alastairp
18:55 PM
CatQuest
alastairp: best if you pm it
18:56 PM
alastairp
lucifer: those are messages going to spark, or from?
18:56 PM
CatQuest
KassOtsimine is my phone, I'll look into things posted there
18:56 PM
wait now i'm interested
18:56 PM
lucifer
alastairp: spark cluster to LB spark reader (getting imported)
18:56 PM
CatQuest
neat għana
18:56 PM
18:56 PM
lucifer
00:16 was when i requested the batch. till 00:22 import was caught up with production (probably artists and recordings) and the releases are going on now.
18:57 PM
CatQuest
thanks monkey
18:57 PM
alastairp
lucifer: great. as I mentioned before, my gut feel for computation time is that it may another 30-60 minutes to total import time
18:57 PM
CatQuest
and alastairp
18:57 PM
lucifer
all messages are of similar size and insert queries are same so only factor slowing things after 00:22 should be cover art lookup.
18:57 PM
yup sounds good
18:57 PM
CatQuest
oh man, i've been awake 10 hours and am exausted. seems liek i did nothing today
18:58 PM
alastairp
so, if it's working on releases now.. I'll be around until it finishes or crashes :)
18:58 PM
but prefer not to stay up any longer past that
18:58 PM
lucifer
crashed
18:58 PM
18:59 PM
alastairp
haha, that was fast
18:59 PM
lucifer
oh well the other two :)
18:59 PM
reader stopped.
19:00 PM
there are 5K messages in queue still so enough for us to make sure it works without requesting another batch.
19:00 PM
alastairp
oh interesting... so what's the case there, no top releases (for some reason?) (or, no releases with MBIDs)
19:00 PM
monkey
Updating test.LB
19:00 PM
alastairp
lucifer: do you want to patch it?
19:00 PM
lucifer
sure will do
19:01 PM
looks like no releases with mbids.
19:02 PM
monkey
19:02 PM
alastairp
monkey: that's a special case that maybe we should also consider with the carousel
19:03 PM
monkey
What's that? no MBID at all?
19:03 PM
alastairp
yeah, no releases have mbid
19:03 PM
monkey
19:03 PM
Which isn't the end of the world
19:03 PM
alastairp
yeah
19:04 PM
monkey
19:05 PM
alastairp
hey
19:05 PM
zero judgement zone here
19:05 PM
monkey
I would never
19:06 PM
(Although there's a glaring lack of Deep Purple in your classic rock playlists)
19:06 PM
alastairp
it's OK, there's a recommendation engine that told me to listen to more
19:06 PM
I like to think of my entire collection as a test bed for edge-cases
19:07 PM
lucifer
uhh did someone bring up spark reader?
19:08 PM
monkey
I just updated test.LB, is it possibly that the update-services.sh script starts it?
19:08 PM
lucifer
oh yeah, that must be it.
19:08 PM
monkey
Sorry, that was not intended
19:08 PM
lucifer
i'll request a new batch
19:08 PM
no worries
19:08 PM
monkey
Gonna have to take a closer look at that script pronto
19:09 PM
lucifer
19:09 PM
alastairp
lucifer: exactly what I would do
19:09 PM
lucifer
:D
19:13 PM
19:14 PM
alastairp
sure looks like coverarts
19:14 PM
lucifer
yup
19:14 PM
mayhem
!m alastairp