#metabrainz

/

      • alastairp
        so that if something goes wrong later on we have a record?
      • 2021-12-16 35014, 2021

      • lucifer
        sure, print to log and save that?
      • 2021-12-16 35017, 2021

      • mayhem
      • 2021-12-16 35027, 2021

      • reosarevok
        bitmap: actually, apparently for some reason our only call to tag_cloud passed a 200 tags limit, despite our having 100 as the default
      • 2021-12-16 35032, 2021

      • reosarevok
        So I'll just make 200 the default :p
      • 2021-12-16 35037, 2021

      • reosarevok
        And maybe 50 for others then
      • 2021-12-16 35053, 2021

      • CatQuest
        +1 reosarevok
      • 2021-12-16 35054, 2021

      • alastairp
        lucifer: sure, anything that makes it easy to get this list in the future.
      • 2021-12-16 35021, 2021

      • reosarevok
        CatQuest: still no sillyname though, you need more thousands :p
      • 2021-12-16 35028, 2021

      • CatQuest
        oh no :(
      • 2021-12-16 35030, 2021

      • reosarevok
        But alastairp's "soundtrack." does make the cut!
      • 2021-12-16 35039, 2021

      • CatQuest
        ಠ_ಠ
      • 2021-12-16 35047, 2021

      • CatQuest
        wait he makes thme with a dot jsut casue?
      • 2021-12-16 35048, 2021

      • CatQuest
        U
      • 2021-12-16 35050, 2021

      • reosarevok
        A bug
      • 2021-12-16 35053, 2021

      • CatQuest
        oic
      • 2021-12-16 35006, 2021

      • alastairp
        haha
      • 2021-12-16 35016, 2021

      • alastairp
        that's what happens when you bulk submit 6000 instances of that tag
      • 2021-12-16 35022, 2021

      • reosarevok
      • 2021-12-16 35029, 2021

      • CatQuest
        and the "edit tag" thing isn't in yet
      • 2021-12-16 35030, 2021

      • CatQuest
        hm
      • 2021-12-16 35038, 2021

      • alastairp
        CatQuest: it's OK, I know which ones I added it to, it will be easy to fix them
      • 2021-12-16 35046, 2021

      • CatQuest
        that other tags thing will become more usefull after genresget aliases
      • 2021-12-16 35007, 2021

      • CatQuest
        alastairp: once we cna rename tags it'll be a cakewalk
      • 2021-12-16 35009, 2021

      • CatQuest
        mm cake
      • 2021-12-16 35051, 2021

      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2373 (03master…MBS-11655): MBS-11655: Separate tag cloud into genre and non-genre tags https://github.com/metabrainz/musicbrainz-server/…
      • 2021-12-16 35004, 2021

      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1785 (03master…fix-yim-email): Fix YIM email sending bug https://github.com/metabrainz/listenbrainz-server…
      • 2021-12-16 35028, 2021

      • lucifer
        alastairp: ^
      • 2021-12-16 35017, 2021

      • alastairp
        lucifer: is to_name the username?
      • 2021-12-16 35039, 2021

      • lucifer
        alastairp: yes
      • 2021-12-16 35046, 2021

      • lucifer
      • 2021-12-16 35046, 2021

      • alastairp
        one other comment
      • 2021-12-16 35037, 2021

      • lucifer
        alastairp, Sentry will capture local variable so user_name will be available in sentry to identify it.
      • 2021-12-16 35049, 2021

      • alastairp
        lucifer: right, I guess it depends on how many errors we might see
      • 2021-12-16 35006, 2021

      • alastairp
        if there are 100 for example, we'd have to click through each event in sentry to get the username.
      • 2021-12-16 35021, 2021

      • alastairp
        so we could log it: Could not send YIM email to %username
      • 2021-12-16 35031, 2021

      • alastairp
        then we can just copy/paste the output and parse it
      • 2021-12-16 35032, 2021

      • lucifer
        i can add the user_name to the meesage but then it might treat each event separate
      • 2021-12-16 35055, 2021

      • alastairp
        ah, good point. we should learn how to do this in sentry
      • 2021-12-16 35055, 2021

      • lucifer
        ah i see :+!
      • 2021-12-16 35016, 2021

      • alastairp
        because personally I think it's a common thing that we might want to do
      • 2021-12-16 35030, 2021

      • alastairp
        I don't mind 100 separate errors in sentry in this case
      • 2021-12-16 35045, 2021

      • alastairp
        I'd much rather have the readable list of usernames in the log file
      • 2021-12-16 35052, 2021

      • lucifer
        indeed, i have been cutting on placeholders in error messages to avoid sentry duplicates but would be nice to keep both.
      • 2021-12-16 35054, 2021

      • lucifer
        agreed.
      • 2021-12-16 35000, 2021

      • lucifer
        PR updated
      • 2021-12-16 35019, 2021

      • alastairp
        if to_email is None:
      • 2021-12-16 35025, 2021

      • alastairp
        are we sure that None is the only case here?
      • 2021-12-16 35029, 2021

      • alastairp
        what if it's ""?
      • 2021-12-16 35036, 2021

      • alastairp
        `if not to_email` ?
      • 2021-12-16 35013, 2021

      • lucifer
        its mostly a best effort fix, because invalid email will also fail. liek abc@
      • 2021-12-16 35020, 2021

      • alastairp
        approved
      • 2021-12-16 35027, 2021

      • alastairp
        yeah, we have the try/catch anyway
      • 2021-12-16 35029, 2021

      • lucifer
        but changing to not is fine, doing
      • 2021-12-16 35028, 2021

      • lucifer
        done
      • 2021-12-16 35032, 2021

      • lucifer
        thanks!
      • 2021-12-16 35000, 2021

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1785 (03master…fix-yim-email): Fix YIM email sending bug https://github.com/metabrainz/listenbrainz-server…
      • 2021-12-16 35018, 2021

      • BrainzGit
        [listenbrainz-server] release 03v-2021-12-17.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2021-12-16 35018, 2021

      • lucifer
        alastairp: mayhem: emails sent!
      • 2021-12-16 35022, 2021

      • mayhem
        great!
      • 2021-12-16 35023, 2021

      • lucifer
        5 emails failed due to invalid address.
      • 2021-12-16 35041, 2021

      • reosarevok
        Is there supposed to be any left and right arrows in Your top albums of 2021 ?
      • 2021-12-16 35043, 2021

      • lucifer
        mayhem, posted to HN and reddit?
      • 2021-12-16 35004, 2021

      • lucifer
        reosarevok: yes those are transparent currently though, monkey or akshaaatt will fix that tomorrow.
      • 2021-12-16 35010, 2021

      • mayhem
        neither so far, but good ideas.
      • 2021-12-16 35033, 2021

      • lucifer
        lol i didn't get an email.
      • 2021-12-16 35034, 2021

      • mayhem
        lets craft the ever import HN headline.
      • 2021-12-16 35039, 2021

      • mayhem
        I haven't either.
      • 2021-12-16 35004, 2021

      • mayhem
        this would be "Show HN", no?
      • 2021-12-16 35005, 2021

      • lucifer
        i guess the meb smtp server is busy sending 5000 emails
      • 2021-12-16 35007, 2021

      • lucifer
        yes
      • 2021-12-16 35031, 2021

      • reosarevok
      • 2021-12-16 35039, 2021

      • reosarevok
        I quite liked that single, but that seems excessive
      • 2021-12-16 35021, 2021

      • mayhem
        "Show HN: Small open source project releases more detailed user listening report than big streaming service."
      • 2021-12-16 35021, 2021

      • reosarevok
        All in all though this looks very nice, thanks!
      • 2021-12-16 35030, 2021

      • mayhem
        reosarevok: <3
      • 2021-12-16 35027, 2021

      • lucifer
        epic!
      • 2021-12-16 35038, 2021

      • reosarevok
        lucifer: any idea about the repeated new album though? :)
      • 2021-12-16 35019, 2021

      • lucifer
        reosarevok: uh no actually. i'll need to dig deeper i think i forgot to filter out various release versions of a release.
      • 2021-12-16 35036, 2021

      • mayhem
        reosarevok: how did you play that track?
      • 2021-12-16 35043, 2021

      • mayhem
        its a mappping issue, very likely.
      • 2021-12-16 35049, 2021

      • reosarevok
        mayhem: spotify
      • 2021-12-16 35059, 2021

      • mayhem
        lucifer: was epic directed at my HN headline?
      • 2021-12-16 35059, 2021

      • lucifer
        afk for a bit
      • 2021-12-16 35003, 2021

      • lucifer
        mayhem: yes
      • 2021-12-16 35008, 2021

      • reosarevok
        lucifer: only 1 version in MB, so maybe mapping as mayhem said? Dunno
      • 2021-12-16 35012, 2021

      • mayhem
        ok, I'll go post that then/
      • 2021-12-16 35024, 2021

      • alastairp
        mayhem: maybe just post the blog post?
      • 2021-12-16 35028, 2021

      • mayhem
        reosarevok: if you add that to the mapping roll up ticket in LB, I can have a look in the new year.
      • 2021-12-16 35038, 2021

      • alastairp
        to me it doesn't feel like a show hn
      • 2021-12-16 35039, 2021

      • mayhem
        alastairp: for the HN link?
      • 2021-12-16 35014, 2021

      • alastairp
        yeah, just regular post -> blog -> automatic title
      • 2021-12-16 35014, 2021

      • reosarevok
        Ok :)
      • 2021-12-16 35036, 2021

      • reosarevok
        That headline seems a bit like, it'd be cool if someone else posted it, but someone from the dev team posting it seems very braggy :p
      • 2021-12-16 35052, 2021

      • mayhem
        open for suggestions on how to fix it.
      • 2021-12-16 35021, 2021

      • mayhem
        a "let the blog headline be the HN headline" approach is 100% not going to work.
      • 2021-12-16 35043, 2021

      • alastairp
      • 2021-12-16 35054, 2021

      • alastairp
        yeah, but the HN rules are "use the page title"
      • 2021-12-16 35005, 2021

      • alastairp
        and so doing something different isn't going to work either
      • 2021-12-16 35028, 2021

      • mayhem
        yeah, doesn't fit the show HN rules.
      • 2021-12-16 35057, 2021

      • mayhem
        ok, I'll leave the HN post to you alastairp.
      • 2021-12-16 35039, 2021

      • mayhem
      • 2021-12-16 35010, 2021

      • alastairp
        lucifer: how are emails?
      • 2021-12-16 35002, 2021

      • alastairp
      • 2021-12-16 35025, 2021

      • mayhem upvotes.
      • 2021-12-16 35037, 2021

      • lucifer
        alastairp: emails were sent fine by LB. 5 failed due to invalid email. however at least i and mayhem haven't received one.
      • 2021-12-16 35002, 2021

      • mayhem
        still nuthing.
      • 2021-12-16 35010, 2021

      • mayhem
        not very encouraging.
      • 2021-12-16 35011, 2021

      • lucifer
        my guess is either gmail blocked us and will send slowly or the meb smtp server is throttling.
      • 2021-12-16 35034, 2021

      • rdswift
        Nothing here yet either.
      • 2021-12-16 35040, 2021

      • alastairp
        nothing here either, I'm not sure about how this works
      • 2021-12-16 35004, 2021

      • lucifer
        zas can we find if the emails are blocked somewhere?
      • 2021-12-16 35038, 2021

      • mayhem is checking the google apps console
      • 2021-12-16 35053, 2021

      • zas
        from where those emails are sent? did you check smtp relay logs?
      • 2021-12-16 35010, 2021

      • lucifer
        LB web container.
      • 2021-12-16 35024, 2021

      • lucifer
        where can i find the relay logs?
      • 2021-12-16 35029, 2021

      • zas
        which smtp relay does it use?
      • 2021-12-16 35047, 2021

      • mayhem
        there are not notifications for us in google apps.
      • 2021-12-16 35019, 2021

      • alastairp
      • 2021-12-16 35029, 2021

      • lucifer
        zas: 10.2.2.45
      • 2021-12-16 35001, 2021

      • lucifer
        ah! forgot about that container
      • 2021-12-16 35051, 2021

      • zas
        log is full of "SMTP connection from dockgw17 [172.17.0.1] lost"
      • 2021-12-16 35016, 2021

      • reosarevok
      • 2021-12-16 35018, 2021

      • zas
        have a look at mainlog & rejectlog in /var/log/exim4 (inside the container)
      • 2021-12-16 35025, 2021

      • reosarevok
        CatQuest's suggestion finds weird broken shit again!
      • 2021-12-16 35038, 2021

      • reosarevok
        bitmap: any idea why the hell we have 74k uses of tag '' ?
      • 2021-12-16 35044, 2021

      • reosarevok
        And more importantly, how? :D
      • 2021-12-16 35052, 2021

      • zas
        mails are relayed apparently
      • 2021-12-16 35037, 2021

      • alastairp
      • 2021-12-16 35039, 2021

      • rdswift
        Mine just showed up.
      • 2021-12-16 35043, 2021

      • lucifer
        i received an email just now
      • 2021-12-16 35046, 2021

      • alastairp
        so maybe it's just taking its time
      • 2021-12-16 35004, 2021

      • alastairp
        yeah, it's going down
      • 2021-12-16 35024, 2021

      • alastairp
        (3 lines of output per message, there aren't 9k messages waiting)
      • 2021-12-16 35020, 2021

      • reosarevok
        Got mine too, yeah
      • 2021-12-16 35033, 2021

      • alastairp
        it's like christmas came early
      • 2021-12-16 35033, 2021

      • reosarevok
        bitmap: tag id 80586, if you wanna take a quick look later
      • 2021-12-16 35024, 2021

      • bitmap
        reosarevok: looks like a validation failure on our part. they're almost all entered by the tags-lastfm user, is that alastairp?
      • 2021-12-16 35042, 2021

      • alastairp
        yep, that's me. sorry!
      • 2021-12-16 35049, 2021

      • alastairp
        will find the bug and delete the tags
      • 2021-12-16 35006, 2021

      • bitmap
        np, I'll fix the issue on the MBS side
      • 2021-12-16 35052, 2021

      • alastairp
        I got many http400s on tag submission, but don't know which tags were causing the issue, so there's definitely _some_ validation going on!
      • 2021-12-16 35016, 2021

      • alastairp
        though I don't know what tags were failing the validation
      • 2021-12-16 35054, 2021

      • reosarevok
        Yay
      • 2021-12-16 35007, 2021

      • reosarevok
        For it being fixed
      • 2021-12-16 35017, 2021

      • alastairp
        mayhem: office telegram bot just opened the door for a command I sent it at 10am
      • 2021-12-16 35058, 2021

      • mayhem
        Because I just restarted the bot. Got stuck on reboot
      • 2021-12-16 35046, 2021

      • alastairp
        ah, nice 👍
      • 2021-12-16 35024, 2021

      • lucifer
        mayhem: any subreddits in mind we should crosspost yim to?
      • 2021-12-16 35000, 2021

      • alastairp
        /r/music maybe?