#metabrainz

so that if something goes wrong later on we have a record?

sure, print to log and save that?

bitmap: actually, apparently for some reason our only call to tag_cloud passed a 200 tags limit, despite our having 100 as the default

So I'll just make 200 the default :p

And maybe 50 for others then

+1 reosarevok

lucifer: sure, anything that makes it easy to get this list in the future.

CatQuest: still no sillyname though, you need more thousands :p

oh no :(

But alastairp's "soundtrack." does make the cut!

ಠ_ಠ

wait he makes thme with a dot jsut casue?

U

A bug

oic

haha

that's what happens when you bulk submit 6000 instances of that tag

and the "edit tag" thing isn't in yet

hm

CatQuest: it's OK, I know which ones I added it to, it will be easy to fix them

that other tags thing will become more usefull after genresget aliases

alastairp: once we cna rename tags it'll be a cakewalk

mm cake

[musicbrainz-server] 14reosarevok opened pull request #2373 (03master…MBS-11655): MBS-11655: Separate tag cloud into genre and non-genre tags https://github.com/metabrainz/musicbrainz-serve...

[listenbrainz-server] 14amCap1712 opened pull request #1785 (03master…fix-yim-email): Fix YIM email sending bug https://github.com/metabrainz/listenbrainz-serv...

alastairp: ^

lucifer: is to_name the username?

alastairp: yes

one other comment

alastairp, Sentry will capture local variable so user_name will be available in sentry to identify it.

lucifer: right, I guess it depends on how many errors we might see

if there are 100 for example, we'd have to click through each event in sentry to get the username.

so we could log it: Could not send YIM email to %username

then we can just copy/paste the output and parse it

i can add the user_name to the meesage but then it might treat each event separate

ah, good point. we should learn how to do this in sentry

ah i see :+!

because personally I think it's a common thing that we might want to do

I don't mind 100 separate errors in sentry in this case

I'd much rather have the readable list of usernames in the log file

indeed, i have been cutting on placeholders in error messages to avoid sentry duplicates but would be nice to keep both.

agreed.

PR updated

if to_email is None:

are we sure that None is the only case here?

what if it's ""?

`if not to_email` ?

its mostly a best effort fix, because invalid email will also fail. liek abc@

approved

yeah, we have the try/catch anyway

but changing to not is fine, doing

done

thanks!

[listenbrainz-server] 14amCap1712 merged pull request #1785 (03master…fix-yim-email): Fix YIM email sending bug https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release 03v-2021-12-17.1 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

alastairp: mayhem: emails sent!

great!

5 emails failed due to invalid address.

Is there supposed to be any left and right arrows in Your top albums of 2021 ?

mayhem, posted to HN and reddit?

reosarevok: yes those are transparent currently though, monkey or akshaaatt will fix that tomorrow.

neither so far, but good ideas.

lol i didn't get an email.

lets craft the ever import HN headline.

I haven't either.

this would be "Show HN", no?

i guess the meb smtp server is busy sending 5000 emails

yes

I quite liked that single, but that seems excessive

"Show HN: Small open source project releases more detailed user listening report than big streaming service."

All in all though this looks very nice, thanks!

reosarevok: <3

epic!

lucifer: any idea about the repeated new album though? :)

reosarevok: uh no actually. i'll need to dig deeper i think i forgot to filter out various release versions of a release.

reosarevok: how did you play that track?

its a mappping issue, very likely.

mayhem: spotify

lucifer: was epic directed at my HN headline?

afk for a bit

mayhem: yes

lucifer: only 1 version in MB, so maybe mapping as mayhem said? Dunno

ok, I'll go post that then/

mayhem: maybe just post the blog post?

reosarevok: if you add that to the mapping roll up ticket in LB, I can have a look in the new year.

to me it doesn't feel like a show hn

alastairp: for the HN link?

yeah, just regular post -> blog -> automatic title

Ok :)

That headline seems a bit like, it'd be cool if someone else posted it, but someone from the dev team posting it seems very braggy :p

open for suggestions on how to fix it.

a "let the blog headline be the HN headline" approach is 100% not going to work.

yeah, but the HN rules are "use the page title"

and so doing something different isn't going to work either

yeah, doesn't fit the show HN rules.

ok, I'll leave the HN post to you alastairp.

lucifer: how are emails?

alastairp: emails were sent fine by LB. 5 failed due to invalid email. however at least i and mayhem haven't received one.

still nuthing.

not very encouraging.

my guess is either gmail blocked us and will send slowly or the meb smtp server is throttling.

Nothing here yet either.

nothing here either, I'm not sure about how this works

zas can we find if the emails are blocked somewhere?

from where those emails are sent? did you check smtp relay logs?

LB web container.

where can i find the relay logs?

which smtp relay does it use?

there are not notifications for us in google apps.

zas: kiss exim-relay-listenbrainz.org

zas: 10.2.2.45

ah! forgot about that container

log is full of "SMTP connection from dockgw17 [172.17.0.1] lost"

have a look at mainlog & rejectlog in /var/log/exim4 (inside the container)

CatQuest's suggestion finds weird broken shit again!

bitmap: any idea why the hell we have 74k uses of tag '' ?

And more importantly, how? :D

mails are relayed apparently

Mine just showed up.

i received an email just now

so maybe it's just taking its time

yeah, it's going down

(3 lines of output per message, there aren't 9k messages waiting)

it's like christmas came early

bitmap: tag id 80586, if you wanna take a quick look later

reosarevok: looks like a validation failure on our part. they're almost all entered by the tags-lastfm user, is that alastairp?

yep, that's me. sorry!

will find the bug and delete the tags

np, I'll fix the issue on the MBS side

I got many http400s on tag submission, but don't know which tags were causing the issue, so there's definitely _some_ validation going on!

though I don't know what tags were failing the validation

Yay

For it being fixed

mayhem: office telegram bot just opened the door for a command I sent it at 10am

Because I just restarted the bot. Got stuck on reboot

ah, nice 👍

mayhem: any subreddits in mind we should crosspost yim to?

/r/music maybe?