thoughts on how that should be done? 1) redirect -> about if not logged in else user page 2) render about page without changing url but redirect for user page.
2022-02-17 04802, 2022
monkey
We could keep the index page as is, visible to users not logged in, and duplicate or include the contents of the index page at the top of the about page
monkey: i just saw multiple `invalid request block size: 18387 (max 8192)...skip` in web prod logs. any endpoint comes to mind that could cause this issue?
ah no, i actually meant monkey because he had found this issue with feedback endpoint some time ago.
2022-02-17 04856, 2022
mayhem
sounds like a UWSGI issue.
2022-02-17 04800, 2022
lucifer
mayhem, right. that's what i meant any endpoint that could cause so much large url.
2022-02-17 04823, 2022
mayhem
the instant playlists could.
2022-02-17 04826, 2022
monkey
Ah, thanks for context. Well it could be that someone is requesting feeback for too many listens at a time?
2022-02-17 04849, 2022
lucifer
we recently doubled the buffer size from 4096 to 8192 to accomodate upto 100 mbids in feedback endpoint.
2022-02-17 04822, 2022
mayhem
37 characters per recording mbid. Sending about 220 tracks could trigger this.
2022-02-17 04824, 2022
lucifer
oh, i was under the impression that we also added chunking in requesting feedback.
2022-02-17 04849, 2022
lucifer
*chunking on api calls from frontend.
2022-02-17 04816, 2022
monkey
I doubt it's from the front-end, we don't show that many listens on any page afaik
2022-02-17 04826, 2022
lucifer
i see.
2022-02-17 04839, 2022
mayhem
it could be the data set hoster.
2022-02-17 04845, 2022
monkey
Although… let me look at code real quick
2022-02-17 04846, 2022
mayhem
let me see if I can reproduce
2022-02-17 04859, 2022
lucifer
let me look in nginx logs then. since these requests never reach flask, sentry won't be helpful.
2022-02-17 04829, 2022
akshaaatt
monkey, I'm thinking of pausing any UI changes in LB to be carried out until we have introduced the sidebar because that could double our work and isn't worth it at the moment.
2022-02-17 04805, 2022
monkey
I think that's wise akshaaatt, some of the issues we're trying to fix will be gone after redesigning
2022-02-17 04811, 2022
akshaaatt
Yuss
2022-02-17 04835, 2022
akshaaatt
Also, I tried working on bumping bootstrap but it's gonna be a huge PR the way I'm thinking
2022-02-17 04850, 2022
akshaaatt
How do you suggest we minimize the work?
2022-02-17 04802, 2022
monkey
What makes it huge?
2022-02-17 04810, 2022
monkey
(and how huge?)
2022-02-17 04823, 2022
monkey
We may not be able to break that one down
2022-02-17 04852, 2022
akshaaatt
Introducing design system and then potentially fixing the entire front end because of the changes made to the latest versions
2022-02-17 04854, 2022
monkey
Actually we could, making PRs to be merged in a separate branch
2022-02-17 04826, 2022
monkey
Right, we have stuff like `className="col-md-8"` everywhere, don't we.
This just replaces stuff but breaks down the entire frontend
2022-02-17 04835, 2022
akshaaatt
I can't think of merging this anywhere. The only thing comes to my mind is fixing everything and then merging
2022-02-17 04856, 2022
akshaaatt
But then the PR would get chunky
2022-02-17 04810, 2022
monkey
I think if we want to make separate PRs, (which will be easier to review) we're going to have to break everything and go page by page (for example) while the rest of the website is broken. Hence a separate branch
2022-02-17 04844, 2022
akshaaatt
That sounds doable but we would have to focus on getting this done soon
2022-02-17 04850, 2022
monkey
So for example merge this initial PR into a new branch, then open PRs for each page
2022-02-17 04854, 2022
akshaaatt
Because the longer it takes, the messier it will be
2022-02-17 04858, 2022
monkey
Yep
2022-02-17 04820, 2022
akshaaatt
Okay then, I can plan on focusing on this
2022-02-17 04843, 2022
monkey
I wonder if it's worth moving to using react-bootstrap if we're in there reworking the layout
2022-02-17 04829, 2022
akshaaatt
I could go with it but in MusicBrainz we have decided to go ahead with normal bootstrap
2022-02-17 04839, 2022
akshaaatt
So it could spin my mind a little
2022-02-17 04842, 2022
mayhem
lucifer: did you get the error again just now?
2022-02-17 04844, 2022
mayhem
twice?
2022-02-17 04848, 2022
monkey
Looking at our react pages, it shouldn't be that much work so maybe we can do initial PR and then a PR for all the front-end pages
[bookbrainz-site] 14MonkeyDo closed pull request #597 (03master…trishna): Improve[UI]: Responsive footer, overlapping of footer and div in contribute page and buttons spacing on collection page for better UI https://github.com/metabrainz/bookbrainz-site/pul…
2022-02-17 04817, 2022
lucifer
tandy1000: validate-token fix released.
2022-02-17 04809, 2022
mayhem
huh. a URL length of 3749 still gives a 502. :(
2022-02-17 04848, 2022
mayhem
does the error say anything different now, lucifer ?
2022-02-17 04831, 2022
lucifer
mayhem: invalid request block size: 8633 (max 8192)...skip . i still see this in error logs.
2022-02-17 04855, 2022
mayhem
which logs are you tailing?
2022-02-17 04822, 2022
lucifer
listenbrainz-web-prod
2022-02-17 04839, 2022
mayhem
huh, so the request does hit the back end.
2022-02-17 04852, 2022
lucifer
it reaches till uwsgi, which errors and does not forward to flask.
"This is my absolute favorite thing about humanity, the fact that ten thousand years of history and innovation all led up to a dozen-odd people who have never met coming to make an absolutely fantastic song together over the sound of a strangely rhythmic cat meowing, all put together by yet another person that none of us have met, purely for the enjoyment of the few thousand people that happen to find it
