Hello everyone , due to college reopening I couldn't get much time to interact here and contribute . I tried working on the Search feature in music brainz- android, I tried a few things . From the observations , I saw if we can somehow relate the paging source nextKey , or the offset on which it depends, to a button , can fix the issue of too many requests.
akshaaatt: lucifer can we do something like passing null as the nextKey , and on pressing our " load more results " button , we continue the search with the new offset value
2022-02-23 05413, 2022
yellowhatpro
Also , a random doubt , I have heard jcenter repo is deprecated now. Is it something to worry about??
2022-02-23 05444, 2022
akshaaatt
Hi yellowhatpro !
2022-02-23 05436, 2022
akshaaatt
Regarding jcenter, I feel we should migrate to maven central but some of our dependencies like for the barcode scanning don't allow us to do so
2022-02-23 05436, 2022
akshaaatt
yellowHatpro I think the paging library has inbuilt support for the footer to show the loading state but our use case is different. From UI perspective, I think this looks good if we custom make it and do what do you suggest regarding the nextKey
... by finding a minor issue in the mbid mapping ...
2022-02-23 05417, 2022
lucifer
mayhem: ^ with added text. thoughts?
2022-02-23 05422, 2022
mayhem
🤦
2022-02-23 05423, 2022
lucifer
oh!!
2022-02-23 05427, 2022
atj
welcome aerozol :)
2022-02-23 05451, 2022
mayhem
the artist_mbids sort order is not stable across different entries in the mapping.
2022-02-23 05406, 2022
mayhem
sorting on artist_mbids before using it removed that wobble.
2022-02-23 05418, 2022
monkey
Welcome aerozol !
2022-02-23 05434, 2022
lucifer
hmm interesting...
2022-02-23 05441, 2022
akshaaatt
Welcome aerozol 🔥💯
2022-02-23 05421, 2022
lucifer
i tried to handle that case in spark side by exploding after checking artist_credit_id so i don't think it should be an issue there but could be wrong.
2022-02-23 05412, 2022
mayhem
quite likely yes.
2022-02-23 05432, 2022
mayhem
I am also moving away from a sliding window approach to a grouping approach.
2022-02-23 05413, 2022
mayhem
right now it is very primitive. every 2 hours is a session and all tracks in a session get one similarity score against all the other tracks in the group.
when the alg starts it uses the first listened_at as the marker for the start of a session.
2022-02-23 05429, 2022
mayhem
and when a listen is encountered that is more than 2 hours from that start, close the previous session, index it and then start a new session.
2022-02-23 05430, 2022
aerozol
thanks all!!
2022-02-23 05455, 2022
aerozol
soo happy to be joining the dream team :)
2022-02-23 05406, 2022
mayhem
let me finish the announcements and then I'll poke at the results that just ran
2022-02-23 05407, 2022
aerozol
and hitting you all with the design stick
2022-02-23 05418, 2022
aerozol
(gently)\
2022-02-23 05421, 2022
mayhem
I love the tone in your bio.
2022-02-23 05431, 2022
mayhem
complaining in an official capacity. brilliant.
2022-02-23 05419, 2022
mayhem
do you have a twitter handle, aerozol ?
2022-02-23 05455, 2022
aerozol
not one that I use
2022-02-23 05458, 2022
mayhem
ok
2022-02-23 05420, 2022
aerozol
(twitter hasn't really caught on in nz)
2022-02-23 05407, 2022
atj
we have a good spread of timezones now
2022-02-23 05439, 2022
mayhem
"I'm pleased to announce that designer Simon Hartman (Aerozol) has joined our team as a part time designer! We've been working towards this goal for years and are excited to be improving the UX of our sites. Welcome! https://blog.metabrainz.org/2022/02/23/stepping-u… -rk"
2022-02-23 05442, 2022
mayhem
how does that sound?
2022-02-23 05403, 2022
mayhem
atj: yeah, but 12 hours time difference is really challenging to work with.
2022-02-23 05435, 2022
mayhem
aerozol: ^^
2022-02-23 05406, 2022
mayhem
aerozol: what should your @metabrainz.org email be? aerozol@ ?
by the way akshaaatt I forgot to say yesterday: I deployed the brainzplayer PR on test.listenbrainz.org
2022-02-23 05400, 2022
monkey
If you ant to test it out
2022-02-23 05413, 2022
akshaaatt
Wonderful monkey!!
2022-02-23 05419, 2022
mayhem
sexy player at the bottom!
2022-02-23 05400, 2022
akshaaatt
ListenBrainz will beat everything out there with the help of MusicBrainz :)
2022-02-23 05449, 2022
CatQuest
..... can we *also* please also have an option to have the palyer on the side as before please?
2022-02-23 05415, 2022
CatQuest
ok i'mma gonne be frank: the current beta7prod design on https://test.listenbrainz.org/user/CatCat/ works well, it shows the listens and has enough space there and there is not an issue with verticla space
the issue is this: vertical space is now very limited. very limited
2022-02-23 05435, 2022
CatQuest
while the horizontal palne is jsut streached and harder to read
2022-02-23 05457, 2022
CatQuest
title of song is al lthe way to the left and actionable buttons are alll the way to the right
2022-02-23 05408, 2022
CatQuest
very easy to clik the wrong button whne you man another one
2022-02-23 05443, 2022
CatQuest
esp since it isn't as in f.ex mb where each and other line is coloured
2022-02-23 05449, 2022
CatQuest
making it *somewhat* easier to tell thme apart
2022-02-23 05454, 2022
aerozol
mayhem: yup that's good re. metabrainz email
2022-02-23 05400, 2022
CatQuest
please don't ignore me becasue i'm annoying. lsiten to me please
2022-02-23 05435, 2022
CatQuest
this is *exactly *thr sort of design that works well for mobile but is a *noghtmare* for desctop we need ot be able to cater ot both
2022-02-23 05448, 2022
CatQuest
perhasp rectionary. so that if the screen is narrow do this, and if not do it te old way?
2022-02-23 05410, 2022
CatQuest
fuck all these damn typoes
2022-02-23 05413, 2022
CatQuest
sigh
2022-02-23 05426, 2022
monkey
CatQuest: Yep, too wide a page at the moment. That's not expected to be the final look. We're just working on the player at the moment
2022-02-23 05429, 2022
aerozol
Love the player at the bottom, CatQuest may have a point about width, on my screen anyway :P
2022-02-23 05446, 2022
CatQuest
i rather prefer having a side palyer tbh :P
2022-02-23 05451, 2022
mayhem
aerozol: check your email. you should have an invite to your meb account.
2022-02-23 05404, 2022
mayhem
aerozol: how about the tweet text I posted above?
2022-02-23 05417, 2022
CatQuest
to be clear: i'm not *against* the idea of a player that cna dock to the bottom. really
2022-02-23 05429, 2022
CatQuest
i'm about the flexibility
2022-02-23 05440, 2022
CatQuest
what about a player that coudl litterally be dragged around. lmao
2022-02-23 05442, 2022
monkey
CatQuest: heard. Honestly that player has been a PITA to use as it is, and is definitely incompatible with the technical changes that are coming in the future.
2022-02-23 05458, 2022
CatQuest
.. you mena the code background right?
2022-02-23 05403, 2022
aerozol
mayhem: great - you can @aerozol2 if you want but there's not much there
2022-02-23 05413, 2022
CatQuest
becase there shoudl be no such reason as to why it has to be bottom locket
2022-02-23 05416, 2022
CatQuest
locked*
2022-02-23 05424, 2022
monkey
Yes, code-related changes
2022-02-23 05443, 2022
CatQuest
like, rewrite the player by all means to make it better. that's great :D
tbh, i dislike bottom docking players. they're eating up massive verticla screen estate wich you know i don't have allverden of
2022-02-23 05435, 2022
monkey
I've been thinking about having a widget mode for the player, just as you say to be able to move it around the page. but it's not a priority at the moment
2022-02-23 05439, 2022
CatQuest
but on mobile this is like, the beesknees and i'd want that myself
2022-02-23 05451, 2022
CatQuest
yea widget sounds cool!
2022-02-23 05416, 2022
CatQuest
well rewriting the whole thing would be the priority i assume
as someone who never used the player I like it at the bottom, for what it's worth (doesn't often get results for me, so was dead screen space - I'm not linked into a Spotify account)
2022-02-23 05443, 2022
mayhem
the results look more... realistic. and perhaps more stable.
2022-02-23 05420, 2022
CatQuest
huh. i'm not linked ot spotify either, but i do tend to get hists on like youube
2022-02-23 05444, 2022
CatQuest
.. what is this
2022-02-23 05454, 2022
CatQuest
huh. i'm not linked to spotify either, but i do tend to get hits on like youube
2022-02-23 05429, 2022
CatQuest
T__T why can't I manage to type like a regular human being without fucking typing so really slow
2022-02-23 05442, 2022
aerozol
I think I just listen to bad music. But also I mainly look at my own page at the moment. When LB is more social I might start playing things off other peoples pages
2022-02-23 05403, 2022
aerozol
If I'm on my own page I obviously don't need to play something, I just did after all :P
2022-02-23 05410, 2022
CatQuest
ha
2022-02-23 05417, 2022
CatQuest
there is the "feed" page thinger
2022-02-23 05427, 2022
monkey
Which reminds me, the ratio of metalheads in the team just increased !
2022-02-23 05429, 2022
CatQuest
you cna follwo people. so i followed people i know here, my friends, reosarevok and freso
