#metabrainz

not yet, will do soon

no rush.

yvanzo: AFAICT the last change to that was the 2021-12 one this goes on top of :)

(looking at master)

Ok, sorry, my bad!

No problems :)

[musicbrainz-server] 14reosarevok merged pull request #2429 (03master…MBS-12213): MBS-12213: Allow VGMDb artist links on places https://github.com/metabrainz/musicbrainz-serve...

yvanzo: are you still reviewing stuff or should I put beta out after merging all this¿

Also, I guess maybe new annotation edits entered in beta will actually ISE in prod... hopefully not, but if so, it's a short beta

(I forget if issues are caused by a new thing being *added* to the edit data)

lucifer, mayhem: so, when are you writing a wordle but with music similarity?

lucifer: when you get around to artist sim stuff, the two tables are artist_similarity_user_id and .._user_name

"find the artist we're thinking of based on similarity with the minimum amount of guesses"

reosarevok: wordle. gah, so tired of that

Heh. I was checking https://semantle.novalis.org/ and it talks about doing that with imdb

Which is why I was wondering

reosarevok: Last review for the day: #2345

reosarevok: Tested loading new annotation edits locally with production branch: No ISE but “An error occurred while loading this edit.” is displayed under “Changes” instead. A warning is issued in server log. It doesn’t even affect the rest of the page.

So it’s fine to push to beta.

monkey: https://critiquebrainz.org/review/e6f0a38e-3eda...

mayhem: just looked at it. 🤯 some entries are exact matches but others are extremely different.

some top results in 1 case entirely missing in the other.

Oh yeah, that's a nice UUID indeed: https://critiquebrainz.org/release-group/cccccc...

looks legit

lucifer: yeah, exactly. I am going return to figuring out why they are different. I just can't leave this be.

makes sense

not even a valid uuid at that

[musicbrainz-server] 14reosarevok merged pull request #2413 (03master…document-tests-2): Improve test documentation (II): Controller::CDStub / Controller::CDTOC https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #2424 (03master…document-tests-4): Improve test documentation (IV): Controller::Edit https://github.com/metabrainz/musicbrainz-serve...

Updating test.LB

mayhem: i gave the delete listen queries another thought but don't think its possible to further simplify the queries currently. maybe moving some parts to python does but that is probably just moving around complexity because all the cases will still need to be handled.

ah no, don't worry about it.

when you've done the docs on the PR, I'll review it one more time just to make sure I understand the nuances.

👍

[musicbrainz-server] 14reosarevok merged pull request #2430 (03master…MBS-12214): MBS-12214: Allow BBC /events links as otherDBs for events https://github.com/metabrainz/musicbrainz-serve...

yvanzo: when back, do let me know what you think of bitmap's proposal on https://github.com/metabrainz/musicbrainz-serve... :)

reosarevok: :+1

yvanzo: pushed to https://github.com/metabrainz/musicbrainz-serve... then

mayhem: PR updated.

alastairp: Mōrena! Another kiwi, what??

Thank you for the welcome everyone. Let's see how much damage I can do with 3 hours /week :P

[musicbrainz-server] 14reosarevok merged pull request #2345 (03master…MBS-7912): MBS-7912: Add edit search option "edit [not] in subscriptions" https://github.com/metabrainz/musicbrainz-serve...

yvanzo: thanks!

bitmap: if around, is https://github.com/metabrainz/musicbrainz-serve... ready now or is the discussion still open?

looks ready to me, I'll merge

[musicbrainz-server] 14mwiencek merged pull request #2394 (03master…prod-access-log-middleware): Enable Plack::Middleware::AccessLog in production https://github.com/metabrainz/musicbrainz-serve...

Thanks to you reosarevok, and happy holidays.