#metabrainz

/

      • lucifer
        not yet, will do soon

        • 2022-02-23 05458, 2022

      • mayhem
        no rush.

        • 2022-02-23 05446, 2022

      • reosarevok
        yvanzo: AFAICT the last change to that was the 2021-12 one this goes on top of :)

        • 2022-02-23 05456, 2022

      • reosarevok
        (looking at master)

        • 2022-02-23 05450, 2022

      • yvanzo
        Ok, sorry, my bad!

        • 2022-02-23 05412, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #1996 (03master…MBS-10847): MBS-10847 (I): Improve search help box on edit listings https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05420, 2022

      • reosarevok
        No problems :)

        • 2022-02-23 05412, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2429 (03master…MBS-12213): MBS-12213: Allow VGMDb artist links on places https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05428, 2022

      • reosarevok
        yvanzo: are you still reviewing stuff or should I put beta out after merging all this¿

        • 2022-02-23 05457, 2022

      • reosarevok
        Also, I guess maybe new annotation edits entered in beta will actually ISE in prod... hopefully not, but if so, it's a short beta

        • 2022-02-23 05414, 2022

      • reosarevok
        (I forget if issues are caused by a new thing being *added* to the edit data)

        • 2022-02-23 05402, 2022

      • reosarevok
        lucifer, mayhem: so, when are you writing a wordle but with music similarity?

        • 2022-02-23 05418, 2022

      • mayhem
        lucifer: when you get around to artist sim stuff, the two tables are artist_similarity_user_id and .._user_name

        • 2022-02-23 05424, 2022

      • reosarevok
        "find the artist we're thinking of based on similarity with the minimum amount of guesses"

        • 2022-02-23 05441, 2022

      • mayhem
        reosarevok: wordle. gah, so tired of that

        • 2022-02-23 05402, 2022

      • reosarevok
        Heh. I was checking https://semantle.novalis.org/ and it talks about doing that with imdb

        • 2022-02-23 05407, 2022

      • reosarevok
        Which is why I was wondering

        • 2022-02-23 05401, 2022

      • yvanzo
        reosarevok: Last review for the day: #2345

        • 2022-02-23 05435, 2022

      • yvanzo
        reosarevok: Tested loading new annotation edits locally with production branch: No ISE but “An error occurred while loading this edit.” is displayed under “Changes” instead. A warning is issued in server log. It doesn’t even affect the rest of the page.

        • 2022-02-23 05439, 2022

      • yvanzo
        So it’s fine to push to beta.

        • 2022-02-23 05402, 2022

      • alastairp
        monkey: https://critiquebrainz.org/review/e6f0a38e-3eda-4…

        • 2022-02-23 05412, 2022

      • lucifer
        mayhem: just looked at it. 🤯 some entries are exact matches but others are extremely different.

        • 2022-02-23 05427, 2022

      • lucifer
        some top results in 1 case entirely missing in the other.

        • 2022-02-23 05431, 2022

      • monkey
        Oh yeah, that's a nice UUID indeed: https://critiquebrainz.org/release-group/cccccccc…

        • 2022-02-23 05443, 2022

      • mayhem
        looks legit

        • 2022-02-23 05404, 2022

      • mayhem
        lucifer: yeah, exactly. I am going return to figuring out why they are different. I just can't leave this be.

        • 2022-02-23 05407, 2022

      • lucifer
        makes sense

        • 2022-02-23 05405, 2022

      • alastairp
        not even a valid uuid at that

        • 2022-02-23 05440, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2413 (03master…document-tests-2): Improve test documentation (II): Controller::CDStub / Controller::CDTOC https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05427, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2424 (03master…document-tests-4): Improve test documentation (IV): Controller::Edit https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05436, 2022

      • MRiddickW has quit

        • 2022-02-23 05446, 2022

      • monkey
        Updating test.LB

        • 2022-02-23 05425, 2022

      • lucifer
        mayhem: i gave the delete listen queries another thought but don't think its possible to further simplify the queries currently. maybe moving some parts to python does but that is probably just moving around complexity because all the cases will still need to be handled.

        • 2022-02-23 05447, 2022

      • mayhem
        ah no, don't worry about it.

        • 2022-02-23 05412, 2022

      • mayhem
        when you've done the docs on the PR, I'll review it one more time just to make sure I understand the nuances.

        • 2022-02-23 05432, 2022

      • lucifer
        👍

        • 2022-02-23 05421, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2430 (03master…MBS-12214): MBS-12214: Allow BBC /events links as otherDBs for events https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05439, 2022

      • reosarevok
        yvanzo: when back, do let me know what you think of bitmap's proposal on https://github.com/metabrainz/musicbrainz-server/… :)

        • 2022-02-23 05452, 2022

      • yvanzo
        reosarevok: :+1

        • 2022-02-23 05445, 2022

      • ssam has quit

        • 2022-02-23 05436, 2022

      • Shubh has quit

        • 2022-02-23 05411, 2022

      • reosarevok
        yvanzo: pushed to https://github.com/metabrainz/musicbrainz-server/… then

        • 2022-02-23 05448, 2022

      • ssam joined the channel

        • 2022-02-23 05449, 2022

      • ssam has quit

        • 2022-02-23 05411, 2022

      • ssam joined the channel

        • 2022-02-23 05429, 2022

      • lucifer
        mayhem: PR updated.

        • 2022-02-23 05431, 2022

      • ssam has quit

        • 2022-02-23 05427, 2022

      • ssam joined the channel

        • 2022-02-23 05401, 2022

      • aerozol
        alastairp: Mōrena! Another kiwi, what??

        • 2022-02-23 05406, 2022

      • ssam has quit

        • 2022-02-23 05434, 2022

      • aerozol
        Thank you for the welcome everyone. Let's see how much damage I can do with 3 hours /week :P

        • 2022-02-23 05403, 2022

      • ssam joined the channel

        • 2022-02-23 05433, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2345 (03master…MBS-7912): MBS-7912: Add edit search option "edit [not] in subscriptions" https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05453, 2022

      • ssam has quit

        • 2022-02-23 05400, 2022

      • reosarevok
        yvanzo: thanks!

        • 2022-02-23 05423, 2022

      • reosarevok
        bitmap: if around, is https://github.com/metabrainz/musicbrainz-server/… ready now or is the discussion still open?

        • 2022-02-23 05404, 2022

      • bitmap
        looks ready to me, I'll merge

        • 2022-02-23 05437, 2022

      • BrainzGit
        [musicbrainz-server] 14mwiencek merged pull request #2394 (03master…prod-access-log-middleware): Enable Plack::Middleware::AccessLog in production https://github.com/metabrainz/musicbrainz-server/…

        • 2022-02-23 05420, 2022

      • ssam joined the channel

        • 2022-02-23 05405, 2022

      • nawcom has quit

        • 2022-02-23 05432, 2022

      • yvanzo
        Thanks to you reosarevok, and happy holidays.

        • 2022-02-23 05428, 2022

      • nawcom joined the channel