akshaaatt: Hi! Just letting you know I've deployed the changes we talked about (apart from Recent page) for the empty column on test.LB for easy testing of the associated PR https://github.com/metabrainz/listenbrainz-server…
2022-03-04 06333, 2022
akshaaatt
Thanks monkey!
2022-03-04 06322, 2022
akshaaatt
monkey I think the mobile version should hide the followers, etc
yvanzo or bitmap: ^ let's make sure we merge this for next beta. zas: thanks!
2022-03-04 06339, 2022
monkey
Makes sense
2022-03-04 06355, 2022
trolley has quit
2022-03-04 06329, 2022
trolley joined the channel
2022-03-04 06330, 2022
monkey
akshaaatt: I pushed that change but haven't updated test.LB yet
2022-03-04 06328, 2022
ROpdebee2 joined the channel
2022-03-04 06301, 2022
}8]- joined the channel
2022-03-04 06327, 2022
dseomn_ joined the channel
2022-03-04 06306, 2022
trolley_ joined the channel
2022-03-04 06306, 2022
gcrkrause2 joined the channel
2022-03-04 06348, 2022
rdrg109_ joined the channel
2022-03-04 06352, 2022
trolley has quit
2022-03-04 06352, 2022
gcrkrause1 has quit
2022-03-04 06352, 2022
dseomn has quit
2022-03-04 06352, 2022
uZer has quit
2022-03-04 06352, 2022
ssam has quit
2022-03-04 06352, 2022
ROpdebee has quit
2022-03-04 06352, 2022
}8] has quit
2022-03-04 06352, 2022
rdrg109 has quit
2022-03-04 06353, 2022
ROpdebee2 is now known as ROpdebee
2022-03-04 06354, 2022
dseomn_ is now known as dseomn
2022-03-04 06357, 2022
}8]- is now known as }8]
2022-03-04 06350, 2022
uZer joined the channel
2022-03-04 06317, 2022
Lotheric has quit
2022-03-04 06348, 2022
akshaaatt
Hi monkey! Approved the PR 💯
2022-03-04 06318, 2022
akshaaatt
Also, are we only supposed to let the author merge the PR or the reviewers could merge it as well?
2022-03-04 06309, 2022
monkey
I think letting their authors merge is probably the safest, considering I might have found a last minute bug or something and didn't mark the PR as not ready
monkey I think we can also merge the bp redesign branch to master now?
2022-03-04 06311, 2022
akshaaatt
A prod release would be good as well :)
2022-03-04 06314, 2022
monkey
I have another PR on the way to deal with the Recent page (we wanted to add some sitewide stats), which has a medium-sized refactor rolled into it. But next week we can merge and deploy the new BP without there being a hole left anywhere :)
looking at the steps, we did a barman backup a few hours before, and then once traffic was stopped we did a local backup of the data dir
2022-03-04 06345, 2022
bitmap
the barman backup was sufficient since it continues to save any subsequent wal files that are generated, but the local backup was just to allow restoring much faster than over ssh
2022-03-04 06330, 2022
alastairp
and the idea is that an in-place upgrade is always going to be faster than a re-import?
2022-03-04 06305, 2022
alastairp
has MB ever had a problem with an in-place upgrade? last time I checked, the official explanation from pg was "it works well, but we don't guarantee anything"
2022-03-04 06333, 2022
bitmap
hmm, well there was one weird bug related to the cube or earthdistance extensions which we had to workaround, but we did that before the upgrade
I didn't get that impression (that it may be less stable) from their documentation at least
2022-03-04 06315, 2022
BrainzGit
[bookbrainz-site] 14the-good-boy opened pull request #793 (03master…collectionWorkTableFix): fix(Collection): conditionally render author name column in the Work Table component https://github.com/metabrainz/bookbrainz-site/pul…
2022-03-04 06358, 2022
alastairp
hmm, right.
2022-03-04 06314, 2022
alastairp
maybe it was something like this that I remember seeing: https://www.postgresql.org/docs/9.1/pgupgrade.html "If a future major release ever changes the data storage format in a way that makes the old data format unreadable, pg_upgrade will not be usable for such upgrades."
2022-03-04 06350, 2022
bitmap
makes sense
2022-03-04 06304, 2022
bitmap
there are also some warnings about your old cluster being unusable once you use --link
2022-03-04 06310, 2022
bitmap
apparently --clone doesn't have that issue but is only supported with btrfs and xfs
link uses a hardlink for the data files in the new directory?
2022-03-04 06345, 2022
monkey
^That's the PR I was talking about akshaaatt, splitting RecentListens into two components, one for user's listens and one for the "Recent" page. sitewide stats in Recent will be in a follow-up PR.
this says you can still recover the old one (by moving a file) as long as you didn't start the new one yet
2022-03-04 06308, 2022
alastairp
cool, so we should check the compatibility of timescale with this, but it seems like it's something we could use for an upgrade
2022-03-04 06311, 2022
lucifer
bitmap: the script and doc are useful. thanks!
2022-03-04 06318, 2022
bitmap
in floyd's case (or was it bowie back then) I think I used pg_dumpall with --schema-only on the prod cluster to get an exact copy of the prod schema, then I was able to quickly test the upgrade locally
2022-03-04 06351, 2022
bitmap
but eventually we made a complete clone of the prod cluster onto williams and tested the upgrade there too
2022-03-04 06317, 2022
zas
bitmap: early next week, we'll upgrade burnside, there are instances of redis (and few more stuff) running on yehudi I wish we move to the new server (burnside2), in order to retire yehudi. Can you have a quick look and tell what it implies? I think those redis instances are used by mb.
2022-03-04 06343, 2022
zas
there's also musicbrainz-sitemaps
2022-03-04 06303, 2022
bitmap
the sitemaps and redis cache containers should be trivial to move at least
2022-03-04 06329, 2022
bitmap
there is also redis-store which contains sessions, those will have to be backed up & restored on the new server, but not too difficult
2022-03-04 06343, 2022
zas
ok, thanks, so nothing too hard to move to the new server. We'll have some time to proceed, but I want to cut costs related to yehudi as soon as possible. We'll try to keep that slot free to ease server moves in the future.
2022-03-04 06334, 2022
zas
btw, burnside is an AX50, it will be replaced by AX51 which are much more powerful (more cores mainly)
2022-03-04 06353, 2022
zas
I increased the weight of aphex for mb web & ws, it handles more queries than any other server, without much load (under 4 atm)
2022-03-04 06344, 2022
BrainzGit
[bookbrainz-site] 14MonkeyDo merged pull request #793 (03master…collectionWorkTableFix): fix(Collection): conditionally render author name column in the Work Table component https://github.com/metabrainz/bookbrainz-site/pul…
monkey: to confirm RecentListens.tsx in the PR is listenbrainz.org/recent ? and Listens.tsx in the user listens page.
2022-03-04 06329, 2022
monkey
That is correct
2022-03-04 06337, 2022
lucifer
👍
2022-03-04 06300, 2022
monkey
The name was always a bit confusing 😅
2022-03-04 06353, 2022
monkey
PR #1891 (RecentListens refactor) deployed to test.LB
2022-03-04 06315, 2022
monkey
Updating BB prod
2022-03-04 06338, 2022
yellowhatpro
Hello everyone. Hope you all are doing good.
2022-03-04 06338, 2022
yellowhatpro
So I was working on the Search Implementation in MusicBrainz , I had a doubt in one of the implementations
2022-03-04 06321, 2022
Shubh has quit
2022-03-04 06319, 2022
yellowhatpro
I was trying to implement a menu that shows pages and lets us select one of them, in the Search Activity. For that purpose, I need the responseObject count, or the size of the data list. This I can get from SearchPagingSource, but I am concerned about how can I use this variable from SearchPagingSource class in SearchActivity.
2022-03-04 06331, 2022
yellowhatpro
Given, the variable we are getting is from the API request's response.
2022-03-04 06308, 2022
yellowhatpro
akshaaatt: how should I approach this poblem , like what should be the generic method to tackle such problems?
