#metabrainz

zas, skelly37: yes to a meeting in general, but today I'm unavailable. Something on Sunday or next Tuesday would work for me

I can't on Sunday, so Tuesday for me

monkey: yup makes sense 👍

same as zas, Tuesday then.

outsidecontext: at which time? anything between 10am CET and 11pm CET fits me

welcome all new people who want to work with us!

lucifer: I'm deploying #1899 to beta.LB as we discussed (fixed the merge issues)

sounds good

zas, outsidecontext: I'll be available since 5:30PM, because I have to attend classes until the end of April. So, besides weekends, I'm currently available evenings

Ah, will have to do that locally I think, can't use the GH action to push a PR I think

UTC +1, forgot to mention

monkey: dev image action?

https://github.com/metabrainz/listenbrainz-serv... from BP-resign branch should work ?

Ah, well yeah the branch and the PR are the same

duh

+41,566 −34,825 whoa!

!m monkey & akshaaatt

You're doing good work, monkey & akshaaatt!

Hence the longer beta period ;)

I'll make a forum post to introduce the new player

awesome!

Get some beta feedback

zas, skelly37: 5:30 would actually work for me. If that's to early something after 19:30 would be ok, too. Just not let it get too late :)

And we are all three same time zone, that should make things not too difficult :)

ok, that's another ansible role repo sorted, with GitHub CI working

turns out you can install Docker inside Docker

metadocker :P

it's docker all the way down!

lucifer: I’ve raised a PR for CB-416. I had a query. In case a user has username which is a uuid, and another person without an MB linked account has a same uuid. Then which user should we identify?

CB-416: Identify users by musicbrainz username, not uuid https://tickets.metabrainz.org/browse/CB-416

hmm, good question. i am unsure. alastairp thoughts?

while the chance of such a conflict is rare, we could probably use different path of the url for uuid and username?

Ansh: great question!

If we neglect this case, both the username and uuid works great in a single path.

I would consider this so rare that we don't need to worry about it. If it's a uuid, always check user uuid, and if not then check if it's a username

Ansh: I'm just finishing up a meeting, but then I'll send a review for this PR that you opened

sounds good

Ok, then I'll have to change some existing tests, where they are setting a username as uuid.

Ansh: I only wanted to comment 2 things: 1) we reuse this pattern of "check uuid, load user, otherwise if invalid then load username" - it'd be good to move this to a helper function so that we can reuse it everywhere

[musicbrainz-server] 14reosarevok opened pull request #2452 (03master…MBS-12246): MBS-12246: Enable Genius links for Labels as "lyrics" and Places as "other databases" https://github.com/metabrainz/musicbrainz-serve...

and 2) make sure that there are some basic tests - maybe the user page, we can load it with a uuid, a username, and also if the user is logged in and the page is for a different user (I think you have a different code path there that we should also test)

but I had a quick look at the PR last night and it looks great, well done!

Thanks :)

!m Ansh

You're doing good work, Ansh!

outsidecontext: ok for 17:30

Updating beta.LB

zas, skelly37: ok, Tuesday 17:30 then?

Agreed

!m lucifer

You're doing good work, lucifer!

Posted: https://community.metabrainz.org/t/introducing-...

https://observatory.mozilla.org/analyze/listenb... -> F

wow, harsh.

that page looks great monkey

Neat, thanks !

Yeah, I agree

[bookbrainz-site] 14payyup opened pull request #803 (03master…identifier-editor): feat(editor): Move the identifier editing to be part of the main editing flow https://github.com/metabrainz/bookbrainz-site/p...

monkey re: the redirect PR, I'm unsure of how the current homepage would be visible for a logged in user. A menu item in nav?

monkey: oh that's one thing i know about. (learnt about it while fixing artist map counts) can do that if you want? :)

I remember discussing with you saying that we'll hault any UX changes after BP redesign to LB until the sidenav

mayhem: oh well. lol. i guess we can add 1-2 line description to the page at lb.org/recent to make such confusion less likely.

Also regarding the bp redesign, we need to get rid of the extra footer bottom margin for pages that don't have the BP

looks great! I think "See profile on" should be "See your profile on"

"View your profile on" might be better

atj: good point but we use the "See profile on" wording for other user's profile page as well. So if you visit their profile then also the term is valid

akshaaatt: it doesn't really make sense at the moment, I think you need two different wordings for the user vs. another user in that case

we could probably word acc. to logged in user.

yeah that ^

akshaaatt: Ah my bad, I have patchy memory.

also, I have a pointless scrollbar on the sidebar: https://i.ibb.co/v4T4dkt/Screenshot-2022-03-11-...

due to my lack of follows

lucifer: Sure, if you want to throw that in be my guest :)

*followers

👍

Thanks atj

Thanks for the feedback atj. I think we should make these updates

and the shadows between elements without whitespace makes it a bit incoherent

sorry, I'm being picky

could the right hand column follow as you scroll down the page?

I think that'll be good

I'd have to see if that works OK for mobile devices

But the thought did occur

mayhem: reosarevok Freso I'm planning to keep our LinkedIn page active because I've noticed that a lot of people prefer it these days and it'll be a great way to share about social updates to the organization. In order to start with the posts, I'm thinking that a GSoC 2022 acceptance post can be a good first post there. Any thoughts?

Huh, I'm getting 502s from the spotify API when BrainzPlayer hits their search endpoint

monkey: oops, i was wrong. d3 always defaults to en-US locale. apparently the artist map fix worked fine in all locales because the format specifier used was like that. for listen count, this will result in wrong locale. :(

oh but maybe i can do without d3.

monkey: i noticed something weird, ListenCountCard isn't used anywhere it seems :/ . the listens page isn't using it but rendering the count directly. is that correct?

lucifer: Oh huh, didn't know we had a ListenCountCard.

ah!

For the decimal separator, I think simply `number.toLocaleString()` should be enough

(and well supported in browsers)

i see, sounds good.

Yeah, I see the component, not sure when we last used that, i don't remember it at all

Aug 2020

i was earlier thinking in terms of d3 because that's what is used by nivo charts. 🤦 toLocaleString should work

let's remove this component then?

I guess? Although it looks better than what I put on the listens page: https://user-images.githubusercontent.com/33172...

oh that does look better. how about starting to use this component ?

maybe also add a case to show better text when no listens instead you have listened to 0 listens.

Yes to all that. I'd rather do it in a separate PR though, that one's big enough as it is :p

cool, i'll open a separate PR

based on BP redesign.

👍 thanks

Freso: could you have a look at the hyperlinks to mentors at https://wiki.musicbrainz.org/Development/Summer... because all links seem to be redundant for me

Ah I see that the endpoints have changed

[Warning] One or more build-args [GIT_COMMIT_SHA] were not consumed

oh lol, how many times will we fix this

[listenbrainz-server] 14amCap1712 opened pull request #1900 (03brainzplayer-redesign…format-listen-count): Use ListenCountCard component https://github.com/metabrainz/listenbrainz-serv...

lucifer: alastairp monkey : https://bono.metabrainz.org/acr-lookup-trgm?art...

coooool. is it fast?

I think I am going extend it to run both exact and non-exact queries at the same time....

... so I can figure out if it is fast enough.

it gets slower the lower the threshold is set.

understandable

.1 and it chugs for quite some time.

.5 seems ok.