zas, skelly37: yes to a meeting in general, but today I'm unavailable. Something on Sunday or next Tuesday would work for me
2022-03-11 07059, 2022
zas
I can't on Sunday, so Tuesday for me
2022-03-11 07001, 2022
lucifer
monkey: yup makes sense š
2022-03-11 07010, 2022
skelly37
same as zas, Tuesday then.
2022-03-11 07034, 2022
zas
outsidecontext: at which time? anything between 10am CET and 11pm CET fits me
2022-03-11 07006, 2022
alastairp
welcome all new people who want to work with us!
2022-03-11 07013, 2022
monkey
lucifer: I'm deploying #1899 to beta.LB as we discussed (fixed the merge issues)
2022-03-11 07021, 2022
lucifer
sounds good
2022-03-11 07059, 2022
skelly37
zas, outsidecontext: I'll be available since 5:30PM, because I have to attend classes until the end of April. So, besides weekends, I'm currently available evenings
2022-03-11 07005, 2022
monkey
Ah, will have to do that locally I think, can't use the GH action to push a PR I think
I'll make a forum post to introduce the new player
2022-03-11 07044, 2022
lucifer
awesome!
2022-03-11 07045, 2022
monkey
Get some beta feedback
2022-03-11 07014, 2022
agatzk joined the channel
2022-03-11 07022, 2022
outsidecontext
zas, skelly37: 5:30 would actually work for me. If that's to early something after 19:30 would be ok, too. Just not let it get too late :)
2022-03-11 07004, 2022
outsidecontext
And we are all three same time zone, that should make things not too difficult :)
2022-03-11 07020, 2022
atj
ok, that's another ansible role repo sorted, with GitHub CI working
2022-03-11 07030, 2022
atj
turns out you can install Docker inside Docker
2022-03-11 07033, 2022
lucifer
metadocker :P
2022-03-11 07043, 2022
atj
it's docker all the way down!
2022-03-11 07019, 2022
Ansh
lucifer: Iāve raised a PR for CB-416. I had a query. In case a user has username which is a uuid, and another person without an MB linked account has a same uuid. Then which user should we identify?
hmm, good question. i am unsure. alastairp thoughts?
2022-03-11 07034, 2022
lucifer
while the chance of such a conflict is rare, we could probably use different path of the url for uuid and username?
2022-03-11 07053, 2022
alastairp
Ansh: great question!
2022-03-11 07020, 2022
Ansh
If we neglect this case, both the username and uuid works great in a single path.
2022-03-11 07032, 2022
alastairp
I would consider this so rare that we don't need to worry about it. If it's a uuid, always check user uuid, and if not then check if it's a username
2022-03-11 07016, 2022
alastairp
Ansh: I'm just finishing up a meeting, but then I'll send a review for this PR that you opened
2022-03-11 07020, 2022
lucifer
sounds good
2022-03-11 07031, 2022
Ansh
Ok, then I'll have to change some existing tests, where they are setting a username as uuid.
2022-03-11 07004, 2022
alastairp
Ansh: I only wanted to comment 2 things: 1) we reuse this pattern of "check uuid, load user, otherwise if invalid then load username" - it'd be good to move this to a helper function so that we can reuse it everywhere
2022-03-11 07010, 2022
BrainzGit
[musicbrainz-server] 14reosarevok opened pull request #2452 (03masterā¦MBS-12246): MBS-12246: Enable Genius links for Labels as "lyrics" and Places as "other databases" https://github.com/metabrainz/musicbrainz-server/ā¦
2022-03-11 07042, 2022
alastairp
and 2) make sure that there are some basic tests - maybe the user page, we can load it with a uuid, a username, and also if the user is logged in and the page is for a different user (I think you have a different code path there that we should also test)
2022-03-11 07000, 2022
alastairp
but I had a quick look at the PR last night and it looks great, well done!
mayhem just wants a thousands , separator in listen count
2022-03-11 07040, 2022
monkey
Yeah, I agree
2022-03-11 07055, 2022
monkey brushes up on decimal separators and locales
2022-03-11 07045, 2022
BrainzGit
[bookbrainz-site] 14payyup opened pull request #803 (03masterā¦identifier-editor): feat(editor): Move the identifier editing to be part of the main editing flow https://github.com/metabrainz/bookbrainz-site/pulā¦
2022-03-11 07051, 2022
akshaaatt
monkey re: the redirect PR, I'm unsure of how the current homepage would be visible for a logged in user. A menu item in nav?
2022-03-11 07039, 2022
lucifer
monkey: oh that's one thing i know about. (learnt about it while fixing artist map counts) can do that if you want? :)
2022-03-11 07045, 2022
akshaaatt
I remember discussing with you saying that we'll hault any UX changes after BP redesign to LB until the sidenav
2022-03-11 07019, 2022
lucifer
mayhem: oh well. lol. i guess we can add 1-2 line description to the page at lb.org/recent to make such confusion less likely.
2022-03-11 07011, 2022
akshaaatt
Also regarding the bp redesign, we need to get rid of the extra footer bottom margin for pages that don't have the BP
2022-03-11 07021, 2022
atj
looks great! I think "See profile on" should be "See your profile on"
2022-03-11 07047, 2022
atj
"View your profile on" might be better
2022-03-11 07006, 2022
agatzk has quit
2022-03-11 07026, 2022
akshaaatt
atj: good point but we use the "See profile on" wording for other user's profile page as well. So if you visit their profile then also the term is valid
2022-03-11 07038, 2022
atj
akshaaatt: it doesn't really make sense at the moment, I think you need two different wordings for the user vs. another user in that case
lucifer: Sure, if you want to throw that in be my guest :)
2022-03-11 07023, 2022
atj
*followers
2022-03-11 07033, 2022
lucifer
š
2022-03-11 07011, 2022
monkey
Thanks atj
2022-03-11 07018, 2022
akshaaatt
Thanks for the feedback atj. I think we should make these updates
2022-03-11 07020, 2022
atj
and the shadows between elements without whitespace makes it a bit incoherent
2022-03-11 07028, 2022
atj
sorry, I'm being picky
2022-03-11 07054, 2022
atj
could the right hand column follow as you scroll down the page?
2022-03-11 07003, 2022
akshaaatt
++
2022-03-11 07025, 2022
akshaaatt
I think that'll be good
2022-03-11 07001, 2022
agatzk has quit
2022-03-11 07032, 2022
agatzk joined the channel
2022-03-11 07043, 2022
monkey
I'd have to see if that works OK for mobile devices
2022-03-11 07058, 2022
monkey
But the thought did occur
2022-03-11 07012, 2022
agatzk has quit
2022-03-11 07020, 2022
akshaaatt
mayhem: reosarevok Freso I'm planning to keep our LinkedIn page active because I've noticed that a lot of people prefer it these days and it'll be a great way to share about social updates to the organization. In order to start with the posts, I'm thinking that a GSoC 2022 acceptance post can be a good first post there. Any thoughts?
2022-03-11 07000, 2022
monkey
Huh, I'm getting 502s from the spotify API when BrainzPlayer hits their search endpoint
2022-03-11 07050, 2022
agatzk joined the channel
2022-03-11 07048, 2022
lucifer
monkey: oops, i was wrong. d3 always defaults to en-US locale. apparently the artist map fix worked fine in all locales because the format specifier used was like that. for listen count, this will result in wrong locale. :(
2022-03-11 07021, 2022
lucifer
oh but maybe i can do without d3.
2022-03-11 07030, 2022
lucifer
monkey: i noticed something weird, ListenCountCard isn't used anywhere it seems :/ . the listens page isn't using it but rendering the count directly. is that correct?
2022-03-11 07020, 2022
monkey
lucifer: Oh huh, didn't know we had a ListenCountCard.
