I have six tickets assigned to me, which looks correct (I expected 5 but there's two for amazon cover art)
right now I'm updating the descriptions or leaving comments to summarize the schema changes and how they affect mirrors - let's do that for any tickets we're assigned
reosarevok: yvanzo: are there any schema changes we need to discuss that were decision-required? whether in or outside of that fix version
reosarevok
I added the moods bit to that schema change fix version
yvanzo
bitmap: About AC MBIDs, it seems pretty clear except the merge. It can be discussed later on thought, mostly implementation details.
reosarevok
The main decision needed there is "should moods be its own entity just like genres are, or a hardcoded list of tags without MBIDs"
The only reason to go for the latter is because I understand mayhem and monkey are expecting a much smaller list that is controlled by MeB and without user requests, so avoiding the whole new-entity thing might be easier
That said, literally copying genre might still be easier just because of the less thinking required... :)
bitmap
yvanzo: ok, let's discuss merging at some point
CatQuest
bitmap: thnaks, it is mostly copy-pasta of your comments in the great "create tickets of stuff from the summit" doc tho :D
yvanzo
bitmap, reosarevok: aliases MBIDs should be dropped for now, until clarified.
reosarevok
I'm ok with that
bitmap
reosarevok: hard to say -- I feel like a hard-coded list would be easier until we're sure how the entities should work
yvanzo
(removed it)
bitmap
CatQuest: good copy-pasta then :D
reosarevok
bitmap: well, it'd just copy the genre code anyway, so it would work in the same way :)
I'm just not sure whether that's overkill or not
CatQuest
I think I also asked reo for a link to your presnetation since I remember you had made one
bitmap
I assume mbids and aliases would be useful to moods then?
monkey
Yes :)
Certainly aliases at least
reosarevok
Speaking of aliases, one thing we did talk about was adding edit support for genres
bitmap: any reason *not* to add an edit_genre table, even if we don't yet use it, which can later be used for edits adding genres and genre aliases?
CatQuest
oh there isn't an actual interface
yea that shoudl be in, makes it easier for reo to add these faster
reosarevok
CatQuest: adding a genre now works like adding a medium format type or whatever, there's an edit interface but it doesn't create an edit
(so no edit history / notes / whatnot)
CatQuest
huh
yvanzo
Is there a design document about moods? or a state of the art? or anything?
CatQuest didn't know that (sicne can't edit those :D)
CatQuest
I'm for creating edits of these tho
all these
bitmap
reosarevok: we should definitely add edit_genre before the edits are implemented
reosarevok
bitmap: sure, just making sure that implementing edits seems sensible and that there's no harm done in just adding edit_genre now so we can work on that without another schema change
Can you check the schema for a sec and make sure that I'm right that'd be the only needed addition?
If so, I'll make a ticket
bitmap
just the table + index and FKs should be enough
monkey
yvanzo: Not really, just a lot of notes I made. But I could assemble a document
reosarevok
monkey: it wouldn't hurt, for when I work on it, although I expect it won't change much of the MBS implementation
bitmap: Ok. I see a few of the edit_$entity have a materialized status column, but most do not. Do you know why?
bitmap
it would added to improve the performance of those but I'm not sure how relevant it is in our postgres anymore
right. for SEARCH, at least the series ordering_attribute, moods, and artist credit mbids
zas
atj: new server is up and ready, named rudi
CatQuest
:O
zas
bitmap: I noticed incorrect partition sizes on rakim (my fault), for now, not much an issue, but I'd like to resize them at some point, we'll need to move stuff from it elsewhere, we can use new server rudi for that (it's the one half of the future gateways), it is perhaps time to move to keydb and have some redundancy for those redis instances
CatQuest: rudi is first half of new gateways, second half will be rex ;)
bitmap
heh, ok :) I can perhaps look into setting up a keydb cluster this week
CatQuest
i noticed that
cool
:D
Revenant has quit
zas
bitmap: great, I can give you an hand on this, as I configured redundant instances for gateways
one thing I didn't solve is dockerized haproxy + keepalived, which are used to provide automatic failover. I fall back on deploying them on host directly, don't remember what was the issue exactly though. We can have a look at this too.
bitmap
sounds good, I'll ping you when I start looking at it
reosarevok
bitmap: so, we'll want an update that adds edit_genre, pk and index for all, and one that adds the fks for standalone, right?
bitmap
reosarevok: yup
reosarevok
bitmap: oh! I remembered the other thing that I wanted to add for genres. rel tables, so we can at least relate them to urls
I guess I would need to add the whole set just in case though, not just l_genre_url
bitmap
ah okay. if you can create a ticket and commit to working on that then it sounds fine
skelly37 joined the channel
reosarevok
Sure
bitmap
and we do have l_url_url so I think you are right, heh
reosarevok
bitmap: MBS-11599 also mentions annotations, while I'm not sure how useful those are rn, I guess we might as well do that too - that would bring genre tables mostly to parity with other entities, I think
No mailed in reviews, so people up: zas, monkey, atj, lucifer, yvanzo, akshaaatt, reosarevok, alastairp, bitmap, mayhem, CatQuest, Freso – anyone else who wish to give review, let me know ASAP!
zas: Go!
zas
Hey
Sophist-UK joined the channel
Apart usual Picard PR reviews, edits, general maintenance and user support, I configured new server rakim
aerozol
Moin!
zas
and ordered another one to replace yehudi, we just received it
CatQuest
aw
morena aerozol
zas
yehudi is now retired, and new server was configured, welcome to rudi
fin. monkey ?
monkey
hi!
Last week was quite busy, with more refactoring on LB and deploying/ announcing the new BrainzPlayer on beta
