bitmap, yvanzo: should put a beta out today but we have only 3 tickets to release, I'll wait for the evening I guess in case we can review and merge some more things :)
I requested the export again now, by previous estimates we'll be able to see the data in ~a week.
2022-04-04 09417, 2022
mayhem
ok, good job moving goliath, lucifer !
2022-04-04 09419, 2022
lucifer
hehe :D
2022-04-04 09452, 2022
reosarevok
Ooh
2022-04-04 09453, 2022
reosarevok
Sweet
2022-04-04 09450, 2022
alastairp
morning
2022-04-04 09405, 2022
alastairp
welcome back PrathameshG[m], congratulations on finishing your exams
2022-04-04 09405, 2022
lucifer
morning!
2022-04-04 09440, 2022
alastairp
aerozol: no, there are no guidelines for how to moderate CB, and I don't think there has been much moderation applied so far. You're welcome to give it a go and come up with your own guide (if in fact we do get notifications, I had a quick look and there are very few)
2022-04-04 09452, 2022
Ansh
alastairp: For connecting BB db to CB and fetching data, do I need to create a model for the BB database and then fetch the data like we do with BU, or simple SQL queries would work ?
2022-04-04 09446, 2022
alastairp
Ansh: great question. traditionally, most metabrainz projects use sql queries. There is one exception in the musicbrainz_db package in brainzutils, which uses a set of models and the sqlalchemy ORM
2022-04-04 09413, 2022
alastairp
in my opinion, ORMs are useful if you have to do very basic create/get queries. I'm not familiar with the BB schema, so I don't know how complex it is. I know that monkey uses a JS-based ORM for database access in BB
2022-04-04 09427, 2022
Ansh
Got it
2022-04-04 09440, 2022
Ansh
Also I found that some Authors, Work, Editions for BB have an associated MBID. So when the user reviews the author, should they review against the BBID or the MBID or both ?
2022-04-04 09453, 2022
alastairp
:) another amazing question
2022-04-04 09450, 2022
alastairp
we've had this discussion before within the context of the bookbrainz database and how it integrates with musicbrainz. I don't think there's a clear answer yet. For this project I think it would be easiest to consider the two databases separate, so you can review either the BB author or the MB composer
2022-04-04 09439, 2022
alastairp
however, maybe over the next few months we can have a discussion with monkey and see if it's possible to integrate BB and MB more in this regard. (it could be as simple as another field in the BB database that says a particular entity is the same as an MB entity)
2022-04-04 09459, 2022
PrathameshG[m]
<alastairp> "welcome back PrathameshG..." <- Thanks!
being directly able to use the column name for reseting values seems useful.
2022-04-04 09407, 2022
alastairp
right, without knowing the name of the sequence?
2022-04-04 09408, 2022
lucifer
creating a new sequence on create table like may be problematic for the atomic table swap trick we use. those tables aren't meant to be inserted in directly but if ever want to there'll be conflicts.
2022-04-04 09412, 2022
lucifer
yes
2022-04-04 09452, 2022
alastairp
for the main metadata cache table we removed the sequence anyway, because of the same problem
2022-04-04 09402, 2022
lucifer
ah i see
2022-04-04 09455, 2022
alastairp
so you're saying if we insert into a table with an id column (and it automatically goes and updates the counter), and then we rename the column and then try and insert into the renamed column, then... ?
2022-04-04 09405, 2022
lucifer
but in that case the sequence would be shared so this problem shouldn't have occurred anyway? or were the sequence values were being inserted manually from python.
2022-04-04 09429, 2022
alastairp
yeah, in the initial version the id value was generated in python and directly inserted
2022-04-04 09453, 2022
lucifer
>so you're saying if we insert into a table with an id column (and it automatically goes and updates the counter), and then we rename the column and then try and insert into the renamed column, then... ?
2022-04-04 09421, 2022
lucifer
is this about being able to insert without knowing seq name or about the table insertion issue?
2022-04-04 09446, 2022
alastairp
I guess about table insertion
2022-04-04 09404, 2022
alastairp
you said that it might be problematic for the table swap trick, but I'm not 100% sure what you are saying the problem is
2022-04-04 09410, 2022
lucifer
ah column rename isn't an issue iiuc. we rename tables though.
2022-04-04 09439, 2022
alastairp
I did notice that I got into some situation where the sequence was named differently for the table
2022-04-04 09456, 2022
alastairp
as mentioned in the 2ndquadrant link:
2022-04-04 09457, 2022
alastairp
> Here, of course, it appears in the error message, and it is easy to guess, but sometimes a slightly different name is chosen, and then your deployment scripts will fail.
2022-04-04 09448, 2022
lucifer
CREATE TABLE test_foo (id SERIAL). it creates test_foo_id_seq, now we do CREATE TABLE foo (LIKE test_foo). continues to use test_foo_id_seq. if we had inserted 10k rows in test_foo, insertion in foo will start from 10001.
2022-04-04 09449, 2022
alastairp
because we rename the table and the indexes, but not the sequence. so in the case where we do need an id field, an identity would be better than a serial because it wouldn't be lying around with a wrong name
2022-04-04 09400, 2022
alastairp
ah! I didn't know that
2022-04-04 09406, 2022
lucifer
but if its identity coulmn, it restarts from 1.
2022-04-04 09427, 2022
alastairp
we don't use LIKE in the metadata cache table, but I recall that it's used somewhere else
Hi bitmap! I tried hydrating https://github.com/metabrainz/musicbrainz-server/… please check the latest commit and let me know how it could be corrected :) Other than that we have one selenium test failing, so after fixing that this PR should be good to go according to me
2022-04-04 09450, 2022
lucifer
but we don't have a SERIAL there so fine there too.
2022-04-04 09413, 2022
alastairp
lucifer: do you know how identity columns work when you are restoring dumps?
2022-04-04 09429, 2022
alastairp
To fix the error, you can use the OVERRIDING SYSTEM VALUE clause as follows:
Hi reosarevok! We wanted you to review the wordings for https://github.com/metabrainz/musicbrainz-server/… after that we can look to merge :) You did review another PR so just wanted to check whether the two were mixed up :)
2022-04-04 09401, 2022
lucifer
it appears pg dump handles that automatically but for the copy_table stuff we use probably need to handle manually
2022-04-04 09404, 2022
reosarevok
I'll take a look :) I try not to work weekends, so I had left this for Monday
2022-04-04 09411, 2022
alastairp
lucifer: and will an identity field solve the problem we had when swapping pg primary when the id skipped?
2022-04-04 09414, 2022
akshaaatt
Amazing, thanks!
2022-04-04 09415, 2022
reosarevok
Let me see
2022-04-04 09437, 2022
lucifer
alastairp: unfortunately no. identity columns can have gaps too. same behaviour as serial in that case.
2022-04-04 09442, 2022
alastairp
right
2022-04-04 09409, 2022
PrathameshG[m]
<alastairp> "welcome back PrathameshG..." <- thanks ^_^
