#metabrainz

[listenbrainz-server] 14dependabot[bot] opened pull request #1973 (03master…dependabot/npm_and_yarn/cross-fetch-3.1.5): Bump cross-fetch from 3.0.5 to 3.1.5 https://github.com/metabrainz/listenbrainz-serv...

aerozol:

please reply https://beta.musicbrainz.org/edit/89055419

akshaaatt: I don't know if there's a downside to having logo-specific guidelines in the logo folder readme as well?

My concern is that people will link directly to the logo folder

And if they're looking for logos they wont stop to read the readme for the Design System, especially if it's way down the list

Maybe add a file, but it is a "see X"?

(as in, a link to the main guidelines' logo section)

My preference would probably be: split up the readme's in a very practical manner, give people a PDF if we want them to read the whole lot

I was just going through the ten related tickets to see if I could find where you were in there :D

akshaaatt: what's your opinion on using constraintlayout in compose??

I tried using it in profile-feature, but I feel it adds extra lines of code, while I am able to simply achieve the same task using compose in-built features.

So I was thinking of removing any kind of constraint layout in compose

Also regarding configuration changes from landscape to portrait, I was thinking of keeping stuff simple as per now, and using simple LazyColumns

We can also use Window Size classes as mentioned in :

* We can also use Window Size classes as mentioned in :

reosarevok: That seems tricky, but I'll have a look.

mooooin!

reosarevok: Add some comments, hopefully they can help you understand it.

moin!! Happy Friday night everyone :D

bon dia aerozol !

Hi aerozol! Alright, makes sense. I'll get to fixing it. Thanks reosarevok also for the suggestion.

Hi yellowhatpro! We can look to avoid the constraint layout if our things work well without it. I think the in built features are the best.

akshaaatt: there's no rush with the readme's anyway, let's get the guidelines agreed upon first

Sorry about the mess with the pull request, are you okay to remove these for me? I don't have the permissions (it seems) to just close them

I added the tidying I wanted to do to the ticket akshaaatt, if you don't mind doing that? MEB-136

MEB-136: Merge Logo repo into Design repo https://tickets.metabrainz.org/browse/MEB-136

Otherwise I can try making a branch and doing it without breaking anything :P

aerozol: iirc akshaaatt was unable to update your PR the other day, you need allow edits by maintainers enabled for that.

aerozol: https://girliemac.com/blog/2017/12/26/git-purr/ just got linked to this ;)

Or the easier method is providing me access aerozol as lucifer shared

Ooh thanks all! I'm in bed now but I'll give it a shot in the morning!

alastairp: finally language I can UNDERSTAND yay

mayhem: lol lfm support. noice ;D

atj: hi, if you have time I wouldn't mind picking your mind about a sysadmin/site performance issue that I'm having on freesound, another site that I run. we're having periodic outages and I'm unsure about what to try and measure/change next

alastairp: sure, what's the stack?

PM me if you want

[19:47] <lucifer> yup lots of fun stuff possible with it.

dude. remember ho we where going to let people import their lastfm tag radios?

now is the time to try to let people do that (i had so many things tagged wich i'd *love* to be able to import into lb now)

... maybe that was iliekcomputers actually

CatQuest: i am not sure what is lfm tag radios but will look into it.

i had started work on imported loved tracks from lfm last year but it had some dependencies which were only recently resolved. work on that feature can too be restarted soon.

aerozol: I wasn't here anymore :D

But: a basic "paste and it gets copied" bit is done, I haven't implemented the "this could be several dates, pick one" bit yet though

Not sure what's the best way (and whether the way the script does it is good or not)

yellowhatpro: I believe it might be worthwhile for you to cleanup the commits in your profile feature PR.

Ah, i see. Since we made a new branch, that branch is not updated to master yet, hence the extra commits.

Hello akshaaatt, what should I do??

Great! I fixed it yellowhatpro

The PR looks much better now

Ohh I see some changes in the lines of codes

What did you do sir. I mean how is it done??

Also yellowhatpro, the new assets which you've added, `ic_downvote`, etc were they picked directly from the musicbrainz website?

Else we might have to provide credit to the makers

ohh wait let me check once

No actually I took it from android studio vector assets

ic_editor_image was taken from mb site

yeah the rest 2 from android studio vector assets

^ I was trying to add a book on BookBrainz, and I couldn't find a way to add an ISBN identifier

Can someone kindly help me with it?

monkey: ^

(or CatQuest)

reosarevok: the way the script does it is good. really

PrathameshG[m]: hey!

what type of entity are you on?

ISB can only b added to "edition" type entity

ISBN*

CatQuest: Hello, I've been trying to add a new book to an artist's profile

Ooh right

I'll check it out

yes. but are yo uadding a work or an edition

work can not have isbn :)

TBH I am not clear with the difference between the 2

The scenario is as follows:

It's a manga volume written as a part of a series

is like releases/recordings vs works on mb

Hmmm that makes sense

aahh

looking at https://libera.ems.host/_matrix/media/r0/downlo... I can see the problem: yo uare adding it to a work

So just to be clear, Edition = recording right?

work cna not have isbn. finish adding the work thne create an edition. on the edition you wil lbe able to add an isbn

basically

CatQuest: yes, that's exactly what happened :)

can I add an edition first tho?

sure. but not via author. yo umsut use the dropdown

it's better to add work first

that way you cna ink the author easierier too

sorry. :)

ask monkey for more info

PrathameshG[m]: Have a look at these pages for a better description of the entities in BookBrainz: https://bookbrainz.org/help and https://bookbrainz-dev-docs.readthedocs.io/en/l...

<CatQuest> "that way you cna ink the..." <- okiee

monkey: Thanks, that helps 👍️

Nice :)

lucifer: This ISE has been reported by a third-party player; submitting love/hate feedback using MBID seems to work all right, but retrieving using only the MBID = ISE: LB-1099

LB-1099: Internal serverr error opening Love/Hate tab in Webinterface https://tickets.metabrainz.org/browse/LB-1099

monkey: oh well, i had thought, we could get away with it. https://github.com/metabrainz/listenbrainz-serv...

i have a fix in mind, fetch data from MB. will work on that

meanwhile, i'll update the code to ignore such items.

Right, complicated edge case. The player in question has access to MBIDs and they rightfully use that; but there's no telling the MBID exists in the mapping at the time of feedback submission

indeed

What I don't get is the relation between love/hate feedback and the mapping

the love/hate feedback only stores the mbid, not the track or artist name. to get that it has to lookup the mbid in the mapping

Ahhh, I see.

monkey: that error linked above is a warning for us to know that this case is being triggered and we need to fix it. but the issue is something else, https://sentry.metabrainz.org/organizations/met...

it says msid `fe035e8a-7ebc-4532-b418-0fc47ed27598` but its actually a mbid.

i am not sure if this issue was on player side or LB side, regardless LB shouldn't ISE.

There's also another MBID in that sentry error (in breadcrumbs): Couldn't find data for item in mapping and item doesn't have msid: recording_msid=None recording_mbid='7187a276-bde8-4587-9a35-8f13ada3f7e3'

yup that's a coincidence i think.

that error is only logged as a warning, shouldn't cause an ISE.

I see

[musicbrainz-android] 14akshaaatt merged pull request #115 (03profile…profile-section): Profile Feature Added https://github.com/metabrainz/musicbrainz-andro...

yellowhatpro: make sure to remind us to continue the work on the profile section post may 16th.

Yussurrr (≧∇≦)ﾉ

$ SSH snaek@wolf.metabrainz.org -L 8888:localhost:8888

```bind [127.0.0.1]:8888: Permission denied

channel_setup_fwd_listener_tcpip: cannot listen to port: 8888

Could not request local forwarding.```