[listenbrainz-server] 14dependabot[bot] opened pull request #1973 (03master…dependabot/npm_and_yarn/cross-fetch-3.1.5): Bump cross-fetch from 3.0.5 to 3.1.5 https://github.com/metabrainz/listenbrainz-server…
akshaaatt: I don't know if there's a downside to having logo-specific guidelines in the logo folder readme as well?
2022-04-29 11943, 2022
aerozol
My concern is that people will link directly to the logo folder
2022-04-29 11909, 2022
aerozol
And if they're looking for logos they wont stop to read the readme for the Design System, especially if it's way down the list
2022-04-29 11940, 2022
reosarevok
Maybe add a file, but it is a "see X"?
2022-04-29 11903, 2022
reosarevok
(as in, a link to the main guidelines' logo section)
2022-04-29 11954, 2022
aerozol
My preference would probably be: split up the readme's in a very practical manner, give people a PDF if we want them to read the whole lot
2022-04-29 11926, 2022
aerozol
Good that you're here Reo! I have some time, I was just going to ask how the paste-a-date stuff is going
2022-04-29 11919, 2022
aerozol
I was just going through the ten related tickets to see if I could find where you were in there :D
2022-04-29 11902, 2022
yellowhatpro
akshaaatt: what's your opinion on using constraintlayout in compose??
2022-04-29 11950, 2022
yellowhatpro
I tried using it in profile-feature, but I feel it adds extra lines of code, while I am able to simply achieve the same task using compose in-built features.
2022-04-29 11913, 2022
yellowhatpro
So I was thinking of removing any kind of constraint layout in compose
2022-04-29 11904, 2022
yellowhatpro
Also regarding configuration changes from landscape to portrait, I was thinking of keeping stuff simple as per now, and using simple LazyColumns
2022-04-29 11909, 2022
yellowhatpro
We can also use Window Size classes as mentioned in :
Or the easier method is providing me access aerozol as lucifer shared
2022-04-29 11943, 2022
aerozol
Ooh thanks all! I'm in bed now but I'll give it a shot in the morning!
2022-04-29 11911, 2022
aerozol
alastairp: finally language I can UNDERSTAND yay
2022-04-29 11928, 2022
lucifer
mayhem: lol lfm support. noice ;D
2022-04-29 11951, 2022
trolley has quit
2022-04-29 11935, 2022
trolley joined the channel
2022-04-29 11947, 2022
alastairp
atj: hi, if you have time I wouldn't mind picking your mind about a sysadmin/site performance issue that I'm having on freesound, another site that I run. we're having periodic outages and I'm unsure about what to try and measure/change next
2022-04-29 11918, 2022
atj
alastairp: sure, what's the stack?
2022-04-29 11932, 2022
atj
PM me if you want
2022-04-29 11906, 2022
hackerman has quit
2022-04-29 11912, 2022
CatQuest
[19:47] <lucifer> yup lots of fun stuff possible with it.
2022-04-29 11912, 2022
CatQuest
dude. remember ho we where going to let people import their lastfm tag radios?
2022-04-29 11912, 2022
CatQuest
now is the time to try to let people do that (i had so many things tagged wich i'd *love* to be able to import into lb now)
2022-04-29 11921, 2022
CatQuest
... maybe that was iliekcomputers actually
2022-04-29 11949, 2022
lucifer
CatQuest: i am not sure what is lfm tag radios but will look into it.
2022-04-29 11948, 2022
lucifer
i had started work on imported loved tracks from lfm last year but it had some dependencies which were only recently resolved. work on that feature can too be restarted soon.
2022-04-29 11921, 2022
reosarevok
aerozol: I wasn't here anymore :D
2022-04-29 11945, 2022
reosarevok
But: a basic "paste and it gets copied" bit is done, I haven't implemented the "this could be several dates, pick one" bit yet though
2022-04-29 11902, 2022
reosarevok
Not sure what's the best way (and whether the way the script does it is good or not)
2022-04-29 11916, 2022
hackerman joined the channel
2022-04-29 11909, 2022
akshaaatt
yellowhatpro: I believe it might be worthwhile for you to cleanup the commits in your profile feature PR.
2022-04-29 11931, 2022
hackerman3 joined the channel
2022-04-29 11956, 2022
akshaaatt
Ah, i see. Since we made a new branch, that branch is not updated to master yet, hence the extra commits.
2022-04-29 11935, 2022
yellowhatpro
Hello akshaaatt, what should I do??
2022-04-29 11904, 2022
akshaaatt
Great! I fixed it yellowhatpro
2022-04-29 11914, 2022
akshaaatt
The PR looks much better now
2022-04-29 11955, 2022
hackerman has quit
2022-04-29 11900, 2022
yellowhatpro
Ohh I see some changes in the lines of codes
2022-04-29 11900, 2022
yellowhatpro
What did you do sir. I mean how is it done??
2022-04-29 11900, 2022
akshaaatt
Also yellowhatpro, the new assets which you've added, `ic_downvote`, etc were they picked directly from the musicbrainz website?
2022-04-29 11947, 2022
akshaaatt
Else we might have to provide credit to the makers
2022-04-29 11911, 2022
yellowhatpro
ohh wait let me check once
2022-04-29 11907, 2022
hackerman3 has quit
2022-04-29 11930, 2022
yellowhatpro
No actually I took it from android studio vector assets
2022-04-29 11912, 2022
yellowhatpro
ic_editor_image was taken from mb site
2022-04-29 11931, 2022
yellowhatpro
yeah the rest 2 from android studio vector assets
2022-04-29 11956, 2022
PrathameshG[m] uploaded an image: (32KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/FTrtombgczGdCORXYCZjBTDf/image.png >
2022-04-29 11933, 2022
PrathameshG[m]
^ I was trying to add a book on BookBrainz, and I couldn't find a way to add an ISBN identifier
2022-04-29 11939, 2022
PrathameshG[m]
Can someone kindly help me with it?
2022-04-29 11946, 2022
reosarevok
monkey: ^
2022-04-29 11949, 2022
reosarevok
(or CatQuest)
2022-04-29 11941, 2022
CatQuest
reosarevok: the way the script does it is good. really
2022-04-29 11955, 2022
CatQuest
PrathameshG[m]: hey!
2022-04-29 11904, 2022
CatQuest
what type of entity are you on?
2022-04-29 11935, 2022
CatQuest
ISB can only b added to "edition" type entity
2022-04-29 11938, 2022
CatQuest
ISBN*
2022-04-29 11946, 2022
PrathameshG[m]
CatQuest: Hello, I've been trying to add a new book to an artist's profile
2022-04-29 11958, 2022
PrathameshG[m]
Ooh right
2022-04-29 11959, 2022
PrathameshG[m]
I'll check it out
2022-04-29 11901, 2022
CatQuest
yes. but are yo uadding a work or an edition
2022-04-29 11910, 2022
CatQuest
work can not have isbn :)
2022-04-29 11938, 2022
PrathameshG[m]
TBH I am not clear with the difference between the 2
lucifer: This ISE has been reported by a third-party player; submitting love/hate feedback using MBID seems to work all right, but retrieving using only the MBID = ISE: LB-1099
i have a fix in mind, fetch data from MB. will work on that
2022-04-29 11921, 2022
lucifer
meanwhile, i'll update the code to ignore such items.
2022-04-29 11932, 2022
monkey
Right, complicated edge case. The player in question has access to MBIDs and they rightfully use that; but there's no telling the MBID exists in the mapping at the time of feedback submission
2022-04-29 11925, 2022
lucifer
indeed
2022-04-29 11928, 2022
monkey
What I don't get is the relation between love/hate feedback and the mapping
2022-04-29 11959, 2022
lucifer
the love/hate feedback only stores the mbid, not the track or artist name. to get that it has to lookup the mbid in the mapping
2022-04-29 11950, 2022
monkey
Ahhh, I see.
2022-04-29 11937, 2022
lucifer
monkey: that error linked above is a warning for us to know that this case is being triggered and we need to fix it. but the issue is something else, https://sentry.metabrainz.org/organizations/metab…
2022-04-29 11954, 2022
lucifer
it says msid `fe035e8a-7ebc-4532-b418-0fc47ed27598` but its actually a mbid.
2022-04-29 11925, 2022
lucifer
i am not sure if this issue was on player side or LB side, regardless LB shouldn't ISE.
2022-04-29 11941, 2022
monkey
There's also another MBID in that sentry error (in breadcrumbs): Couldn't find data for item in mapping and item doesn't have msid: recording_msid=None recording_mbid='7187a276-bde8-4587-9a35-8f13ada3f7e3'
2022-04-29 11915, 2022
lucifer
yup that's a coincidence i think.
2022-04-29 11900, 2022
lucifer
that error is only logged as a warning, shouldn't cause an ISE.
