#metabrainz

/

      • Lotheric has quit
      • 2022-05-12 13204, 2022

      • Lotheric joined the channel
      • 2022-05-12 13249, 2022

      • tandy1000 has quit
      • 2022-05-12 13218, 2022

      • yellowhatpro has quit
      • 2022-05-12 13218, 2022

      • occams_katana[m] has quit
      • 2022-05-12 13221, 2022

      • intrnl_[m] has quit
      • 2022-05-12 13221, 2022

      • lnl has quit
      • 2022-05-12 13227, 2022

      • riksucks has quit
      • 2022-05-12 13232, 2022

      • yyoung[m] has quit
      • 2022-05-12 13250, 2022

      • PrathameshG[m] has quit
      • 2022-05-12 13250, 2022

      • Ansh has quit
      • 2022-05-12 13250, 2022

      • kepstin has quit
      • 2022-05-12 13251, 2022

      • elomatreb[m] has quit
      • 2022-05-12 13202, 2022

      • tandy1000 joined the channel
      • 2022-05-12 13230, 2022

      • yellowhatpro joined the channel
      • 2022-05-12 13216, 2022

      • lnl joined the channel
      • 2022-05-12 13237, 2022

      • intrnl_[m] joined the channel
      • 2022-05-12 13253, 2022

      • agatzk has quit
      • 2022-05-12 13251, 2022

      • occams_katana[m] joined the channel
      • 2022-05-12 13250, 2022

      • riksucks joined the channel
      • 2022-05-12 13230, 2022

      • yyoung[m] joined the channel
      • 2022-05-12 13207, 2022

      • Goldmaster61 has quit
      • 2022-05-12 13218, 2022

      • Goldmaster61 joined the channel
      • 2022-05-12 13232, 2022

      • elomatreb[m] joined the channel
      • 2022-05-12 13251, 2022

      • kepstin joined the channel
      • 2022-05-12 13243, 2022

      • Ansh joined the channel
      • 2022-05-12 13218, 2022

      • PrathameshG[m] joined the channel
      • 2022-05-12 13248, 2022

      • monotux has quit
      • 2022-05-12 13246, 2022

      • monotux joined the channel
      • 2022-05-12 13257, 2022

      • odnes joined the channel
      • 2022-05-12 13221, 2022

      • chrisshepherd has quit
      • 2022-05-12 13241, 2022

      • chrisshepherd joined the channel
      • 2022-05-12 13235, 2022

      • outsidecontext
        zas: good morning. a last small cleanup before we tag the release today: https://github.com/metabrainz/picard/pull/2108
      • 2022-05-12 13212, 2022

      • zas
        outsidecontext: moooin, coffee (first) and I'll have a look
      • 2022-05-12 13233, 2022

      • outsidecontext
        top, coffee is important :D
      • 2022-05-12 13203, 2022

      • hackerman7 joined the channel
      • 2022-05-12 13218, 2022

      • hackerman has quit
      • 2022-05-12 13218, 2022

      • hackerman7 is now known as hackerman
      • 2022-05-12 13251, 2022

      • zas
        outsidecontext: I think you can merge and tag
      • 2022-05-12 13203, 2022

      • lucifer
        yvanzo: i started a full reindex with that branch yesterday night, should complete soon. lets merge after that?
      • 2022-05-12 13201, 2022

      • odnes has quit
      • 2022-05-12 13243, 2022

      • trolley has quit
      • 2022-05-12 13246, 2022

      • trolley joined the channel
      • 2022-05-12 13206, 2022

      • outsidecontext
        zas: will do. we do a rc2, right? And final a week later?
      • 2022-05-12 13226, 2022

      • zas
        yes, it depends on feedback though
      • 2022-05-12 13242, 2022

      • outsidecontext
        +1
      • 2022-05-12 13255, 2022

      • lucifer
        yvanzo: went fine, i'll update the mbdata commit messages and if needed the commit sha in sir and then fine to merge.
      • 2022-05-12 13206, 2022

      • mayhem
        moooin!
      • 2022-05-12 13243, 2022

      • mayhem
        lucifer: did you see the LB support@ email about "Mismatched redirect URI" when logging into LB? Possibly for a new accounts?
      • 2022-05-12 13211, 2022

      • lucifer
        mayhem: yes i did. investigating.
      • 2022-05-12 13210, 2022

      • mayhem
        logins work, I checked that.
      • 2022-05-12 13217, 2022

      • mayhem
        checking sentry logs now. nothing obvious
      • 2022-05-12 13211, 2022

      • zas
        outsidecontext: there are some issues with builds -> https://github.com/metabrainz/picard/runs/6402319…
      • 2022-05-12 13225, 2022

      • CatQuest
        Happy Birthday reosarevok 🎊
      • 2022-05-12 13230, 2022

      • outsidecontext
        zas: fixed it
      • 2022-05-12 13254, 2022

      • lucifer
        mayhem: i just created a new account and it went fine.
      • 2022-05-12 13200, 2022

      • mayhem badly sings reosarevok the typical dreadful spanish happy birthday dirge
      • 2022-05-12 13212, 2022

      • mayhem
        lucifer: I think I will respond and ask for screenshots.
      • 2022-05-12 13254, 2022

      • lucifer
        mayhem: thanks! was going to do the same.
      • 2022-05-12 13210, 2022

      • lucifer
        happy birthday reosarevok, 🎉🎉!
      • 2022-05-12 13231, 2022

      • mayhem
        zas: morning!
      • 2022-05-12 13254, 2022

      • zas
        mayhem: hey
      • 2022-05-12 13258, 2022

      • mayhem
        can you please check the support@ emails -- there is a suspected IP blocked address that might be causing us issues. can you please check to see if that is the case?
      • 2022-05-12 13202, 2022

      • mayhem
        lol, hey!
      • 2022-05-12 13258, 2022

      • reosarevok
        Thanks!
      • 2022-05-12 13243, 2022

      • zas
        which support emails?
      • 2022-05-12 13224, 2022

      • mayhem
        ah, they didn't copy to support@ on their response. sending now.
      • 2022-05-12 13237, 2022

      • zas
        ah thanks
      • 2022-05-12 13228, 2022

      • outsidecontext
      • 2022-05-12 13255, 2022

      • odnes joined the channel
      • 2022-05-12 13243, 2022

      • zas
        mayhem: the email doesn't provide exact IPs, but it doesn't seem any is blocked in the /24 blocks he provided. Also the error says "Mismatched redirect URI" which seems to indicate an OAuth issue. Is there something indicating it may be related to a blocked IP?
      • 2022-05-12 13203, 2022

      • mayhem
        not from our side, no, but the person suggested it might be so. lucifer and I have probed this and we can login just fine and find no errors in the logs for LB.
      • 2022-05-12 13207, 2022

      • lucifer
        mayhem: first screenshot, they are using api.listenbrainz.org instead of listenbrainz.org
      • 2022-05-12 13230, 2022

      • zas
        outsidecontext: did you see the error in https://github.com/metabrainz/picard/runs/6402647… ?
      • 2022-05-12 13238, 2022

      • lucifer
        we should disable webpages except api there to avoid such issues i guess.
      • 2022-05-12 13259, 2022

      • mayhem
        aahhh, well spottted.
      • 2022-05-12 13208, 2022

      • mayhem
        yes, we should do that, for sure.
      • 2022-05-12 13223, 2022

      • mayhem
        I'll respond.
      • 2022-05-12 13230, 2022

      • lucifer
        thanks!
      • 2022-05-12 13252, 2022

      • lucifer
        zas: hi! can you please configure gateways to throw a error when someone tries to access api.listenbrainz.org on a url not prefixed with a number. basically opposite of this check: https://github.com/metabrainz/openresty-gateways/…
      • 2022-05-12 13239, 2022

      • lucifer
        this check is on listenbrainz.org to prevent access of api using it. conversely we want to prevent access of normal webpages on api.listenbrainz.org .
      • 2022-05-12 13216, 2022

      • yvanzo
        O’Moin
      • 2022-05-12 13258, 2022

      • mayhem
        lucifer: yep, that was it.
      • 2022-05-12 13227, 2022

      • lucifer
        ah nice.
      • 2022-05-12 13227, 2022

      • zas
        lucifer: only for api.lb, right? (prod/beta/?)
      • 2022-05-12 13247, 2022

      • lucifer
        zas: api.lb, beta-api.lb, test-api.lb
      • 2022-05-12 13239, 2022

      • lucifer
        yvanzo: sir pr updated with new commit sha of mbdata (with feedback from your review applied). fine to merge now
      • 2022-05-12 13217, 2022

      • reosarevok
        moin yvanzo
      • 2022-05-12 13226, 2022

      • reosarevok
      • 2022-05-12 13225, 2022

      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1987 (03master…timeduration-fix): Removing extra Z from missing MB data API and view https://github.com/metabrainz/listenbrainz-server…
      • 2022-05-12 13218, 2022

      • outsidecontext
        zas: don't know why it failed, retrying this uploaded the file to pypi successfuly
      • 2022-05-12 13245, 2022

      • alastairp
        hullo
      • 2022-05-12 13214, 2022

      • alastairp
        I kind of want to go and buy an ipod now
      • 2022-05-12 13233, 2022

      • outsidecontext
        zas: website I sent a PR. are the files already copied to FTP?
      • 2022-05-12 13252, 2022

      • mayhem
        well, it looks like Napster will beat us to the web3 fun... whatever that might be.
      • 2022-05-12 13253, 2022

      • mayhem
      • 2022-05-12 13206, 2022

      • reosarevok
        Oh no
      • 2022-05-12 13224, 2022

      • Etua joined the channel
      • 2022-05-12 13210, 2022

      • Etua has quit
      • 2022-05-12 13226, 2022

      • monkey
        I can't help but notice that this Napster article isn't an april's fool
      • 2022-05-12 13245, 2022

      • monkey
        (april fools?)
      • 2022-05-12 13257, 2022

      • mayhem
        it will be april fools for them when they realize that they pivoted towards pure bullshit.
      • 2022-05-12 13254, 2022

      • aerozol
        Lollll
      • 2022-05-12 13211, 2022

      • aerozol
        Let's go straight to web8
      • 2022-05-12 13244, 2022

      • alastairp
      • 2022-05-12 13259, 2022

      • alastairp
        not sure if that was in response to the ^ napster article, or just coincidence
      • 2022-05-12 13202, 2022

      • reosarevok
        yvanzo: so, mbdata/sir hopefully ready now?
      • 2022-05-12 13206, 2022

      • reosarevok
        !m lucifer
      • 2022-05-12 13207, 2022

      • BrainzBot
        You're doing good work, lucifer!
      • 2022-05-12 13236, 2022

      • yvanzo
        lucifer: Which kind of database did you use for the full reindex ?
      • 2022-05-12 13236, 2022

      • alastairp
        nice
      • 2022-05-12 13201, 2022

      • lucifer
        yvanzo: the musicbrainz-docker db running on wolf currently
      • 2022-05-12 13201, 2022

      • lucifer
        fwiw, the musicbrainz-docker on wolf is currently still setup that way for further testing if needed. the local sir copy is in /home/musicbrainz/sir
      • 2022-05-12 13251, 2022

      • yvanzo
        lucifer: So it's running with a schema 26 MB database?
      • 2022-05-12 13256, 2022

      • lucifer
        yes
      • 2022-05-12 13203, 2022

      • yvanzo
        lucifer: I opened a PR to your mbdata fork :)
      • 2022-05-12 13231, 2022

      • KevlarNoir has quit
      • 2022-05-12 13238, 2022

      • yvanzo
        lucifer: Is https://github.com/metabrainz/sir/pull/130 ready for merge?
      • 2022-05-12 13200, 2022

      • lucifer
        yvanzo: yup.
      • 2022-05-12 13242, 2022

      • BrainzGit
        [sir] 14yvanzo merged pull request #130 (03master…schema-change-2022-q2): Update SIR for schema change 2022 q2 https://github.com/metabrainz/sir/pull/130
      • 2022-05-12 13223, 2022

      • lucifer
        yvanzo: i can try to setup a schema version 27 db and try an index again if its helpful
      • 2022-05-12 13205, 2022

      • yvanzo
        We can try migrating test.mb.o
      • 2022-05-12 13213, 2022

      • lucifer
        cool, sounds good
      • 2022-05-12 13256, 2022

      • odnes has quit
      • 2022-05-12 13214, 2022

      • reosarevok
        I'd like to try that now, yes
      • 2022-05-12 13219, 2022

      • reosarevok
        I think it's time
      • 2022-05-12 13235, 2022

      • reosarevok
        yvanzo: will you run the migration?
      • 2022-05-12 13244, 2022

      • reosarevok
        I can try too if you prefer, but happy to let you do it
      • 2022-05-12 13234, 2022

      • Etua joined the channel
      • 2022-05-12 13243, 2022

      • yvanzo
        reosarevok, lucifer: Just have to make a few changes to sir's SQL scripts beforehand.
      • 2022-05-12 13202, 2022

      • reosarevok
        Ok :)
      • 2022-05-12 13232, 2022

      • zas
        outsidecontext: yes, files are on FTP
      • 2022-05-12 13247, 2022

      • Ansh
        alastairp: I've updated the failing tests in my BU PR's. Please have a look. If it looks good, I'll open another PR to modify get_release_groups_for_label in a similar way.
      • 2022-05-12 13219, 2022

      • alastairp
        Ansh: I saw the updates, thanks. they look really good so far, I was in fact just doing some final testing on them now, I'll let you know soon
      • 2022-05-12 13243, 2022

      • Etua has quit
      • 2022-05-12 13259, 2022

      • Ansh
        Ok :)
      • 2022-05-12 13223, 2022

      • lucifer
        mayhem: zas has updated gateways with config to block the pages on api sites. i tested it works fine. want to double check?
      • 2022-05-12 13228, 2022

      • lucifer
        !m zas
      • 2022-05-12 13228, 2022

      • BrainzBot
        You're doing good work, zas!
      • 2022-05-12 13237, 2022

      • zas
        I'll need to update some checks though
      • 2022-05-12 13250, 2022

      • alastairp
        oh great
      • 2022-05-12 13256, 2022

      • lucifer
        oh the tg alert!
      • 2022-05-12 13203, 2022

      • zas
        on it
      • 2022-05-12 13210, 2022

      • alastairp
        how does this currently work? both api.lb.org and lb.org on the gateways point to the same instance, right?
      • 2022-05-12 13236, 2022

      • lucifer
        yes afaik.
      • 2022-05-12 13238, 2022

      • lucifer
      • 2022-05-12 13243, 2022

      • alastairp
        ah, just found the openresty commit
      • 2022-05-12 13244, 2022

      • alastairp
        perfect
      • 2022-05-12 13222, 2022

      • alastairp
        yeah, I was just wondering what we would use to identify if a request was API, version number looks good
      • 2022-05-12 13243, 2022

      • alastairp
        do we have the opposite in place too? (https://listenbrainz.org/1/whatever) ?