I don't think we actually remove spammers' tags when the spammers are not deleted but just marked as spam, but maybe we should do something about that. Freso can think about it eventually
2022-05-15 13551, 2022
CatQuest
hmm actually, I dunno how useful for spambrainz that sort of co-ordinated tagging and rating spam is
2022-05-15 13558, 2022
CatQuest
as a modal
2022-05-15 13509, 2022
CatQuest
for learning
2022-05-15 13540, 2022
reosarevok
Well, dunno if that specific case is going to be marked as spam or deleted or what
2022-05-15 13502, 2022
reosarevok
But a spammer that tagged stuff with their shop's URL or something might need hand-deleting the tags
2022-05-15 13508, 2022
CatQuest
this inflated score has been in the db long enough imho
yellowhatpro: the app looks bomb to me now. We can go ahead and start implementing lots of LB features like like/hate, holding the listen card to delete the listen, leverage websockets to keep the list updated at all times, etc!
2022-05-15 13524, 2022
CatQuest
holding the listen card to delete the listen, <-- ehh sounds like an recepie for accidentally deleting listens a lot tbh
2022-05-15 13542, 2022
akshaaatt
Once we welcome BrainzPlayer properly to the app, I'm expecting the app to go viral. Seriously this app does wonders about music. It'll be the best music related app ever.
2022-05-15 13545, 2022
yellowhatpro
yeah cant wait... still downloading dependencies... gotta have a look
2022-05-15 13503, 2022
akshaaatt
CatQuest: good point! We'll show an alert dialog before deleting then
2022-05-15 13501, 2022
akshaaatt
Ironically while working on the app part, I learnt a lot about ListenBrainz also and how the workflow is handled there!
2022-05-15 13552, 2022
lucifer
akshaaatt: please remember not to tag a release before the flavors etc is setup otherwise f-droid builds will pick up a violating version.
2022-05-15 13530, 2022
akshaaatt
Yuss lucifer! That is why I manually did a play store release today :)
2022-05-15 13542, 2022
lucifer
great thanks!
2022-05-15 13549, 2022
akshaaatt
💯
2022-05-15 13540, 2022
reosarevok
bitmap: heh, just remembered I still have a PR open for renaming / deleting a tag
2022-05-15 13551, 2022
reosarevok
I guess that'd also cause potentially big issues
2022-05-15 13542, 2022
riksucks
akshaaatt: downloaded the app, its rad man
2022-05-15 13526, 2022
akshaaatt
Great riksucks! If you've downloaded from the play store, I'm expecting the LB features to show up in an hour or so when playstore passes the review
bitmap: I tested adding 100k release tags to my user in test (via DB query) and adding the rows to release_tag too, then deleting my user
2022-05-15 13553, 2022
reosarevok
It consistently times out
2022-05-15 13559, 2022
reosarevok
So this doesn't seem to be a *new* problem
2022-05-15 13510, 2022
reosarevok
I mean, fair, that's not as fast a DB server as prod, but
2022-05-15 13526, 2022
reosarevok
Given that, I'd consider releasing as-is unless we can tell it's significantly worse
2022-05-15 13527, 2022
bitmap
I think you are right, since it's mostly performing the same work as the triggers, other than updating tag.ref_count
2022-05-15 13549, 2022
reosarevok
I can see what happens with 15k or whatever it was the top user had
2022-05-15 13507, 2022
reosarevok
To compare that
2022-05-15 13541, 2022
bitmap
with that in mind I'm okay with releasing it, but we might want to consider keeping tags around when a user deletes their account and cleaning them up via hourly cron job
2022-05-15 13504, 2022
reosarevok
So, small schema change for that too?
2022-05-15 13529, 2022
bitmap
it wouldn't be a schema change, would it?
2022-05-15 13548, 2022
reosarevok
Oh, I guess the deletion of tags is not automated by a trigger rn?
2022-05-15 13554, 2022
reosarevok
In that case, I guess not
2022-05-15 13520, 2022
bitmap
the raw tag deletion is done by perl still
2022-05-15 13528, 2022
reosarevok
Then sure
2022-05-15 13542, 2022
bitmap
since we don't actually delete the editor row
2022-05-15 13545, 2022
reosarevok
We don't even need to rush that change, as long as no huge editors try to delete their account
2022-05-15 13504, 2022
reosarevok
I'd suggest pushing a small addition to delete user saying it can take a long time if they have a lot of tags tho
2022-05-15 13518, 2022
reosarevok
With a TODO to revert it on implementing that
2022-05-15 13519, 2022
bitmap
I'm also not sure how much a pending update table would help, and it'd make things a lot more complicated
2022-05-15 13525, 2022
bitmap
sure. rn I'm just trying to reproduce that dbmirror2 warning locally
2022-05-15 13510, 2022
reosarevok
bitmap: 44s on deleting that user with 15k rows
2022-05-15 13527, 2022
reosarevok
Fair enough that test is slower, but I think that shows the new code doesn't make things particularly worse
2022-05-15 13545, 2022
reosarevok
I'll put a PR up for that warning and write a ticket, you check dbmirror2
[musicbrainz-server] 14mwiencek merged pull request #2526 (03master…check-schema-migration-improvements): Improvements to t/script/CheckSchemaMigration.sh and some documentation https://github.com/metabrainz/musicbrainz-server/…
yvanzo: I pushed master to test and rebuilt test containers and am deploying those now. they should have a new DBDefs that use the rakim DB. (I doubt the amqp broker table is set up properly, though.)
2022-05-15 13542, 2022
bitmap
rebuilt test images*
2022-05-15 13501, 2022
yvanzo
Ok
2022-05-15 13514, 2022
bitmap
reosarevok: for when you're up ^ test is running the schema change branch and pointed to the rakim DB now, if you want to do some light testing
2022-05-15 13555, 2022
Frikandel has quit
2022-05-15 13503, 2022
yvanzo
bitmap: Created amqp extension and set the broker.
2022-05-15 13513, 2022
jesus2099 joined the channel
2022-05-15 13516, 2022
bitmap
thanks!
2022-05-15 13518, 2022
yvanzo
bitmap: there is no pgbouncer for sir-test to connect to postgres-mb-schema-change-test?
2022-05-15 13521, 2022
bitmap
there should be, on port 65401
2022-05-15 13509, 2022
yvanzo
Ok, opened a PR.
2022-05-15 13539, 2022
yvanzo
bitmap: I guess all test containers would actually better fit rakim than aretha, especially for a full reindex.
2022-05-15 13530, 2022
bitmap
this is true, if you feel like moving them (not sure a full reindex on aretha would complete in time?)
2022-05-15 13546, 2022
yvanzo
will do
2022-05-15 13525, 2022
jesus2099 has quit
2022-05-15 13503, 2022
yvanzo
Copying Solr test data to rakim.
2022-05-15 13547, 2022
aerozol
akshaaatt, catquest: hold and swipe away to delete I reckon! Looks amazing btw! (except IRCcloud sucks at loading video for me it turns out)
2022-05-15 13529, 2022
yvanzo
Rebuilding sir image.
2022-05-15 13559, 2022
yvanzo
bitmap: Successfully tested live indexing for test.mb.o.
