akshaaatt: It would be good to have all the importable BS5 files in the bootstrap-generic.scss file and comment them out if we don't want to import them.
2022-06-01 15223, 2022
monkey
The first thing I did was look in that file to see if I had to uncomment a line, but didn't even think that there were some imports missing
2022-06-01 15233, 2022
monkey
Good find though, that's an easy fix
2022-06-01 15259, 2022
akshaaatt
Makes sense monkey
2022-06-01 15231, 2022
monkey
I'm going to review #2005 now anyway since I can just define that one class manually.
chinmay: auto-formatting z lot of files sounds about right for prettier. I guess that's what its job is :) You can probably configure it to not auto-fix files and instead report issues it finds (but that's less useful IMO)
2022-06-01 15223, 2022
chinmay
mayhem: lmao
2022-06-01 15231, 2022
chinmay
monkey: THANK YOU!
2022-06-01 15248, 2022
reosarevok
jesus2099: hmm. Maybe bitmap can check if there's a thing we can do about that. hydrate did change
reosarevok: no problem but do you remind where you saw these errors on your side, although they are supposed to be only local errors in my javascript console?
2022-06-01 15230, 2022
jesus2099
So I mention it in the ticket
2022-06-01 15233, 2022
reosarevok
In sentry
2022-06-01 15240, 2022
monkey
Err… DS#77 I meant
2022-06-01 15243, 2022
akshaaatt
Noi monkey
2022-06-01 15205, 2022
akshaaatt
There's some problem with keeping `**` in the ignore files
2022-06-01 15216, 2022
jesus2099
reosarevok: sentry! Thanks
2022-06-01 15227, 2022
monkey
I was waiting for it to be fixed before reviewing :)
2022-06-01 15237, 2022
monkey
Want me to have a go at it?
2022-06-01 15252, 2022
chinmay
and someone please tell me `listenbrainz/webserver/static/css/theme/"BOOSTRAP"` was an accident
2022-06-01 15200, 2022
monkey
BrainzBot: GH:DS=design-system
2022-06-01 15200, 2022
BrainzBot
Successfully stored the repo design-system as DS for Github lookups
alastairp: flobot (new server) is ready, it is syncing md raid for next 3 hours, so it will be slow until it finished, but otherwise you can start to play with it
So, first of all, I just wanted to say I'm pretty excited about the project :)
2022-06-01 15228, 2022
ansh
I am also very exited
2022-06-01 15239, 2022
monkey
Talking with alastairp and looking at your project timeline in detail, we agree with how it is currently laid out.
2022-06-01 15259, 2022
monkey
To recap, the project breaks down into three main parts. As we discussed before, we think it would be best to add all the functionality for one BB entity first (Edition Groups):
2022-06-01 15206, 2022
monkey
First part: implement the EditionGroup entity in CB (BB database connection, ORM model, review interface, API endpoint)
2022-06-01 15223, 2022
ansh
Yes
2022-06-01 15226, 2022
monkey
Second part: implement CB support In BB (A. reading: fetch reviews from CB API, display reviews on entity page; B. writing: login to CB Oauth, front-end interface for writing and submitting reviews)
2022-06-01 15246, 2022
monkey
Third part: extend the work above to other BB entities as defined in your proposal. Based on the project being a full length project now, and the speed at which you are working ;) , we think this should be part of the project proper rather than an extended goal. Does that seem reasonable to you?
2022-06-01 15200, 2022
ansh
yes
2022-06-01 15215, 2022
monkey
OK, that's it for the broad overview then :)
2022-06-01 15220, 2022
monkey
Do you have any questions or doubts about the project or the timeline that you’d like to discuss now?
2022-06-01 15239, 2022
ansh
I have started working with the project. Just have some questions
2022-06-01 15246, 2022
monkey
Shoot !
2022-06-01 15206, 2022
odnes_ joined the channel
2022-06-01 15209, 2022
ansh
what if the BBID is equal to MBID. In this case, a user won’t be able to write reviews. Either we create another column in our reviews table to check if review is for MB or BB?
2022-06-01 15228, 2022
monkey
UUID collision should not really happen, in theory
2022-06-01 15241, 2022
alastairp
if it does, the internet is going to have a _really_ bad day
2022-06-01 15247, 2022
monkey
Let's say the chances are small enough that I think we can ignore the problem
2022-06-01 15258, 2022
ansh
Okay
2022-06-01 15223, 2022
odnes has quit
2022-06-01 15243, 2022
ansh
For edition group page we should show the series, So, I’ll also have to fetch series, from the db, and show it. And also allowing reviewing its entities.
2022-06-01 15237, 2022
ansh
So should I skip series temporary? Or should I also do it parallelly?
