#metabrainz

Hi monkey!We have decided to use the two colour variant logos for projects now in places like footer, nav, etc. https://github.com/metabrainz/design-system/pul... Just wanted to keep you in loop

So I'll be making the same changes in LB as well now

I think that's reasonable. I think it would be good to show the full logo *somewhere* at least once for each project (I guess on the homepage makes sense)

Right

DS is becoming very convenient now. Looks so good

[design-system] 14akshaaatt merged pull request #79 (03master…publish-logos): Publish logos https://github.com/metabrainz/design-system/pul...

+1 fro publishing logos from the DS, that's exactly the sort of use case it's made for

um reosarevok *how* to irename something

rename tags i mean

You don't yet :) The code is ready (finally) but it still needs to be reviewed and released

ack

But before the schema change tags were so messy this would be a lot harder, so yay

i opened up a buttload of tags page to be albe to do this now

right

Oh, sorry :)

well !reo for fixing it anyway

no worry :D

Just follow the ticket, we'll let you know

i hink i already.. link again?

Oh, yes, you're a voter

yea

[design-system] 14akshaaatt merged pull request #70 (03master…components): Add Guidelines for components https://github.com/metabrainz/design-system/pul...

[design-system] release 031.1.0 has been published by 14akshaaatt: https://github.com/metabrainz/design-system/rel...

[listenbrainz-server] 14amCap1712 opened pull request #2031 (03master…fix-validator): Improve validation in MsidMbidModel https://github.com/metabrainz/listenbrainz-serv...

monkey: akshaaatt:

Working on adding stylelint in LB. I'm out of town so I'm working on it in spare time.

monkey: can you please review LB#2026 ?

Add feedback to recent listens page: https://github.com/metabrainz/listenbrainz-serv...

I'm also thinking of adding lint-staged https://www.npmjs.com/package/lint-staged

monkey: i added the validation fixes in LB#2031. can you please review it ?

Improve validation in MsidMbidModel: https://github.com/metabrainz/listenbrainz-serv...

uh that was for alastairp ^

you've got me for 4 more minutes, good timing!

lucifer: looks ok, though a test would be nice

mayhem: daily jams needed another fix to work. LB#2029. i ran recs again and one has now been generated.

Fix daily jams: https://github.com/metabrainz/listenbrainz-serv...

alastairp: makes sense, will add.

is it fine i merge and do a release afterwards?

yes, fine

great, thanks

the daily jams one - is that testing flag no longer needed?

If we want to run it in prod

yes testing is always set to False in prod so I am assuming it was for tests which are not working without it as well. so not needed imo

Thanks Lucifer!

or for running in a dev environment so that we can quickly submit a few things?

but I guess that's DEBUG?

the test had return_values instead of return_value which might be why it wasn't working properly without that flag.

ah right - a few different things

Ohhhh, the daily jam looks good!

I see the earlier TESTING guard too

lucifer: so it looks like this completely removes the `users_to_process = ["mr_monkey", "rob", "akshaaatt", "Damselfish", "lucifer", "alastairp", "CatCat", "atj"]`

oh no, I missed like 24/25

those are used for the other recs playlists

like->line

mayhem: is there indoor bike parking space? (I guess there's no furniture, so...)

i'll remove the other testing bit as well from that method and put it in a mock instead.

mayhem: to confirm those TESTING guards in the run troi function are for tests only?

Alastairp: yes, plenty

lucifer: fyi I think he's quite busy with guests for the rest of the night, maybe better tomorrow or next week for the important questions :)

ah right 👍

What Alastairp said.

:-)

[sir] 14yvanzo opened pull request #135 (03master…search-452-all-url-rels): SEARCH-452, SEARCH-677: Index all URL relationships and fix indexing disambiguation comments https://github.com/metabrainz/sir/pull/135

[listenbrainz-server] 14amCap1712 merged pull request #2031 (03master…fix-validator): Improve validation in MsidMbidModel https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release 03v-2022-06-03.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

[design-system] 14akshaaatt closed pull request #71 (03master…master): MEB-132: Added MetaBrainz and MusicBrainz guidelines to discuss https://github.com/metabrainz/design-system/pul...

Hi aerozol! Could you provide me write access to your repo at https://github.com/Aerozol/design-system ?