#metabrainz

for first we need sql.Identifier, other two sql.SQL probably.

and because copy_expert quotes everything, it's trying to quote the function calls and then not finding a "column" with that name?

yes

and if we actually make a specific type, it'll do the right thing?

we can either change the str to correct type in the definition dicts linked above. or add an if/else for in the list comprehension in the code linked above

yes

that seems nice. what's the other option? disable quoting in this case, knowing that the first 4 are valid column names that we control?

yup skip all quoting

the first option sounds a bit better. can we do sql.Identifier(col) if col is a string, otherwise copy it as defined in the dict?

yes that's possible.

but since its one time thing i don't mind specifying all columns as identifier as needed.

and do we also use sql.Identifier in the import?

Thanks alastairp!

np. thanks for valuing my input :)

bitmap, lucifer: I opened tickets to track documenting RabbitMQ usage in our projects (CAA, LB, SIR): https://tickets.metabrainz.org/issues/?jql=labe...

i changed the imports so that we only have to write Identifier and not sql.Identifier

I'm not a huge fan of adding `Identifier` to all 200 definition lines, but I'm not hugely worried either way. If you think it's easier to follow by adding it to all column definitions then that sounds fine

(fixed a broken link)

bitmap, lucifer: Even though the guidelines are not just about documentation but also implementation, a first step would be to simply document current deviations from the recommended implementation.

alastairp: makes sense

yvanzo: thanks, yes makes sense to do that.

alastairp: any other PRs to merge for CB release?

lucifer: one sec, just opening one now ;-)

ah cool

[critiquebrainz] 14alastair merged pull request #421 (03master…py-310-flask-upgrade): Upgrade python version and dependencies https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] 14alastair opened pull request #435 (03master…mismatch-oauth-url): Provide a user-friendly error if oauth params are incorrect https://github.com/metabrainz/critiquebrainz/pu...

lucifer: would be great to get that one in. tests are passing for me, but we can also release to beta and try some invalid params

alastairp: beta first sounds good.

yvanzo: is it intentional that https://github.com/metabrainz/musicbrainz-serve... has "check syswiki" for how to deploy prod, but lists the command for deploying beta?

On checking it again, it kinda seems that either the beta command should be moved to syswiki, or the "Deploy webservice and website" bit of syswiki to RELEASING

Releasing updated beta

[critiquebrainz] 14alastair merged pull request #435 (03master…mismatch-oauth-url): Provide a user-friendly error if oauth params are incorrect https://github.com/metabrainz/critiquebrainz/pu...

[listenbrainz-server] release 03v-2022-06-07.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

Releasing prod

lucifer: beta updated

https://beta.critiquebrainz.org/oauth/authorize... correctly fails now (400 instead of 500)

LB prod updated

looks good, alastairp!

release URL should redirect to a releasegroup: https://beta.critiquebrainz.org/release/9d4c260...

and that seems to be fine

curl dump headers shows `location: /release-group/a106e33b-e440-3ff3-9250-c6408ed73e60` (location now relative to the current host)

makes sense

reosarevok: Yes, especially the notes. But if more details have to be added about hosts and containers, it can be added to syswiki instead.

cool, I'll go ahead with prod release then

great, thanks!

[critiquebrainz] release 03v-2022-06-07.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/critiquebrainz/re...

i'll put the flask update PR for LB on beta for now. it seems ready so we can try to release that tommorrow

I'll keep an eye on CB cron dumps tomorrow, so we can check if they're working

sounds good

something seems a bit funny with docker caching on github actions, I've had to build this image 3 times this evening

oh, do we not have a critiqubrainz/cache image setup?

I thought we did

yeah we have it https://github.com/metabrainz/critiquebrainz/bl...

although I don't see it at https://github.com/metabrainz/critiquebrainz/bl...

oh right

oh, is this different to satackey/action-docker-layer-caching ?

yes

right, that'll be the reason then (as we have the base python image upgrade, so everything is invalidated)

this metabrainz/critiquebrainz:cache is a docker buildx cache in docker hub. that other action caches image layers in actions cache.

yup, plus tests/dev uses separate dockerfile

yeah right. my recollection was that we used the satackey one for both caches, but I was wrong

oh yeah, I still have an open ticket for that :)

we used to have that. but the satackey caches often get invalidated by test runs so we switched it for prod images.

got it

CB released

thanks lucifer, see you tomorrow

thanks you too!

[critiquebrainz] 14anshg1214 opened pull request #436 (03master…add_bb_entity): Allow CB to review Edition Group https://github.com/metabrainz/critiquebrainz/pu...

well that was fast ;)

alastairp: https://github.com/metabrainz/critiquebrainz/pu... is ready for review.

yvanzo: blog draft ready for review

I closed it and all, hopefully it won't whine :p

yvanzo: noted re: caa rabbitmq docs. though I'd also like to focus on deploying https://github.com/metabrainz/artwork-indexer soon, which will no longer use rabbitmq at all

bitmap: can you take a look at the blog post? :)

(would like to finish releasing soon)

sure

bitmap: doesn’t it depend on dbmirror2?

nope, it just stores the index 'events' in pg

I closed the ticket as won't do then.

okay, I will still need to document maintenance steps for artwork-indexer more throroughly, but can create tickets for that when needed

reosarevok: the blog post looks good, I think

Thanks!

Oh, I see yvanzo made a small change, thanks too

I’m just fixing tickets’ title

Ok

I'll wait

But the editor is too slow for me.

Just wordpress things

reosarevok: done

Thanks!

[musicbrainz-docker] release 03v-2022-06-07 has been published by 14yvanzo: https://github.com/metabrainz/musicbrainz-docke...

bitmap: About service usage: I added MBS-12440 to relax requiring Redis only when needed.

MBS-12440: Do not require Redis to mirror the database https://tickets.metabrainz.org/browse/MBS-12440

yvanzo: makes sense. thanks

[musicbrainz-server] 14reosarevok merged pull request #2491 (03master…MBS-12312): MBS-12312: Convert annotation templates to React https://github.com/metabrainz/musicbrainz-serve...

bitmap, yvanzo: rebased all the stuff in https://github.com/metabrainz/musicbrainz-serve...