#metabrainz

/

      • lucifer
        for first we need sql.Identifier, other two sql.SQL probably.

        • 2022-06-07 15837, 2022

      • alastairp
        and because copy_expert quotes everything, it's trying to quote the function calls and then not finding a "column" with that name?

        • 2022-06-07 15843, 2022

      • lucifer
        yes

        • 2022-06-07 15803, 2022

      • alastairp
        and if we actually make a specific type, it'll do the right thing?

        • 2022-06-07 15821, 2022

      • lucifer
        we can either change the str to correct type in the definition dicts linked above. or add an if/else for in the list comprehension in the code linked above

        • 2022-06-07 15822, 2022

      • lucifer
        yes

        • 2022-06-07 15848, 2022

      • alastairp
        that seems nice. what's the other option? disable quoting in this case, knowing that the first 4 are valid column names that we control?

        • 2022-06-07 15809, 2022

      • lucifer
        yup skip all quoting

        • 2022-06-07 15802, 2022

      • alastairp
        the first option sounds a bit better. can we do sql.Identifier(col) if col is a string, otherwise copy it as defined in the dict?

        • 2022-06-07 15830, 2022

      • lucifer
        yes that's possible.

        • 2022-06-07 15853, 2022

      • lucifer
        but since its one time thing i don't mind specifying all columns as identifier as needed.

        • 2022-06-07 15805, 2022

      • alastairp
        and do we also use sql.Identifier in the import?

        • 2022-06-07 15809, 2022

      • yvanzo
        Thanks alastairp!

        • 2022-06-07 15828, 2022

      • alastairp
        np. thanks for valuing my input :)

        • 2022-06-07 15854, 2022

      • yvanzo
        bitmap, lucifer: I opened tickets to track documenting RabbitMQ usage in our projects (CAA, LB, SIR): https://tickets.metabrainz.org/issues/?jql=labels…

        • 2022-06-07 15858, 2022

      • lucifer
        i changed the imports so that we only have to write Identifier and not sql.Identifier

        • 2022-06-07 15828, 2022

      • alastairp
        I'm not a huge fan of adding `Identifier` to all 200 definition lines, but I'm not hugely worried either way. If you think it's easier to follow by adding it to all column definitions then that sounds fine

        • 2022-06-07 15800, 2022

      • yvanzo
        (fixed a broken link)

        • 2022-06-07 15801, 2022

      • yvanzo
        bitmap, lucifer: Even though the guidelines are not just about documentation but also implementation, a first step would be to simply document current deviations from the recommended implementation.

        • 2022-06-07 15846, 2022

      • skelly37 joined the channel

        • 2022-06-07 15844, 2022

      • lucifer
        alastairp: makes sense

        • 2022-06-07 15800, 2022

      • lucifer
        yvanzo: thanks, yes makes sense to do that.

        • 2022-06-07 15838, 2022

      • lucifer
        alastairp: any other PRs to merge for CB release?

        • 2022-06-07 15800, 2022

      • alastairp
        lucifer: one sec, just opening one now ;-)

        • 2022-06-07 15807, 2022

      • lucifer
        ah cool

        • 2022-06-07 15827, 2022

      • BrainzGit
        [critiquebrainz] 14alastair merged pull request #421 (03master…py-310-flask-upgrade): Upgrade python version and dependencies https://github.com/metabrainz/critiquebrainz/pull…

        • 2022-06-07 15829, 2022

      • BrainzGit
        [critiquebrainz] 14alastair opened pull request #435 (03master…mismatch-oauth-url): Provide a user-friendly error if oauth params are incorrect https://github.com/metabrainz/critiquebrainz/pull…

        • 2022-06-07 15850, 2022

      • alastairp
        lucifer: would be great to get that one in. tests are passing for me, but we can also release to beta and try some invalid params

        • 2022-06-07 15820, 2022

      • lucifer
        alastairp: beta first sounds good.

        • 2022-06-07 15827, 2022

      • reosarevok
        yvanzo: is it intentional that https://github.com/metabrainz/musicbrainz-server/… has "check syswiki" for how to deploy prod, but lists the command for deploying beta?

        • 2022-06-07 15851, 2022

      • reosarevok
        On checking it again, it kinda seems that either the beta command should be moved to syswiki, or the "Deploy webservice and website" bit of syswiki to RELEASING

        • 2022-06-07 15826, 2022

      • reosarevok
        Releasing updated beta

        • 2022-06-07 15835, 2022

      • BrainzGit
        [critiquebrainz] 14alastair merged pull request #435 (03master…mismatch-oauth-url): Provide a user-friendly error if oauth params are incorrect https://github.com/metabrainz/critiquebrainz/pull…

        • 2022-06-07 15857, 2022

      • BrainzGit
        [listenbrainz-server] release 03v-2022-06-07.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-server…

        • 2022-06-07 15835, 2022

      • reosarevok
        Releasing prod

        • 2022-06-07 15845, 2022

      • alastairp
        lucifer: beta updated

        • 2022-06-07 15854, 2022

      • alastairp
        https://beta.critiquebrainz.org/oauth/authorize?r… correctly fails now (400 instead of 500)

        • 2022-06-07 15859, 2022

      • lucifer
        LB prod updated

        • 2022-06-07 15833, 2022

      • lucifer
        looks good, alastairp!

        • 2022-06-07 15851, 2022

      • alastairp
        release URL should redirect to a releasegroup: https://beta.critiquebrainz.org/release/9d4c2605-…

        • 2022-06-07 15854, 2022

      • alastairp
        and that seems to be fine

        • 2022-06-07 15818, 2022

      • alastairp
        curl dump headers shows `location: /release-group/a106e33b-e440-3ff3-9250-c6408ed73e60` (location now relative to the current host)

        • 2022-06-07 15845, 2022

      • lucifer
        makes sense

        • 2022-06-07 15849, 2022

      • yvanzo
        reosarevok: Yes, especially the notes. But if more details have to be added about hosts and containers, it can be added to syswiki instead.

        • 2022-06-07 15813, 2022

      • alastairp
        cool, I'll go ahead with prod release then

        • 2022-06-07 15822, 2022

      • lucifer
        great, thanks!

        • 2022-06-07 15853, 2022

      • BrainzGit
        [critiquebrainz] release 03v-2022-06-07.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/critiquebrainz/rele…

        • 2022-06-07 15827, 2022

      • lucifer
        i'll put the flask update PR for LB on beta for now. it seems ready so we can try to release that tommorrow

        • 2022-06-07 15810, 2022

      • alastairp
        I'll keep an eye on CB cron dumps tomorrow, so we can check if they're working

        • 2022-06-07 15821, 2022

      • lucifer
        sounds good

        • 2022-06-07 15853, 2022

      • alastairp
        something seems a bit funny with docker caching on github actions, I've had to build this image 3 times this evening

        • 2022-06-07 15840, 2022

      • lucifer
        oh, do we not have a critiqubrainz/cache image setup?

        • 2022-06-07 15813, 2022

      • alastairp
        I thought we did

        • 2022-06-07 15841, 2022

      • lucifer
        yeah we have it https://github.com/metabrainz/critiquebrainz/blob…

        • 2022-06-07 15841, 2022

      • alastairp
        although I don't see it at https://github.com/metabrainz/critiquebrainz/blob…

        • 2022-06-07 15806, 2022

      • alastairp
        oh right

        • 2022-06-07 15830, 2022

      • alastairp
        oh, is this different to satackey/action-docker-layer-caching ?

        • 2022-06-07 15826, 2022

      • lucifer
        yes

        • 2022-06-07 15848, 2022

      • alastairp
        right, that'll be the reason then (as we have the base python image upgrade, so everything is invalidated)

        • 2022-06-07 15810, 2022

      • lucifer
        this metabrainz/critiquebrainz:cache is a docker buildx cache in docker hub. that other action caches image layers in actions cache.

        • 2022-06-07 15831, 2022

      • lucifer
        yup, plus tests/dev uses separate dockerfile

        • 2022-06-07 15842, 2022

      • alastairp
        yeah right. my recollection was that we used the satackey one for both caches, but I was wrong

        • 2022-06-07 15851, 2022

      • alastairp
        oh yeah, I still have an open ticket for that :)

        • 2022-06-07 15838, 2022

      • lucifer
        we used to have that. but the satackey caches often get invalidated by test runs so we switched it for prod images.

        • 2022-06-07 15849, 2022

      • alastairp
        got it

        • 2022-06-07 15826, 2022

      • alastairp
        CB released

        • 2022-06-07 15831, 2022

      • alastairp
        thanks lucifer, see you tomorrow

        • 2022-06-07 15841, 2022

      • lucifer
        thanks you too!

        • 2022-06-07 15827, 2022

      • BrainzGit
        [critiquebrainz] 14anshg1214 opened pull request #436 (03master…add_bb_entity): Allow CB to review Edition Group https://github.com/metabrainz/critiquebrainz/pull…

        • 2022-06-07 15837, 2022

      • alastairp
        well that was fast ;)

        • 2022-06-07 15809, 2022

      • ansh
        alastairp: https://github.com/metabrainz/critiquebrainz/pull… is ready for review.

        • 2022-06-07 15852, 2022

      • KevlarNoir joined the channel

        • 2022-06-07 15820, 2022

      • reosarevok
        yvanzo: blog draft ready for review

        • 2022-06-07 15833, 2022

      • reosarevok
        I closed it and all, hopefully it won't whine :p

        • 2022-06-07 15802, 2022

      • bitmap
        yvanzo: noted re: caa rabbitmq docs. though I'd also like to focus on deploying https://github.com/metabrainz/artwork-indexer soon, which will no longer use rabbitmq at all

        • 2022-06-07 15810, 2022

      • reosarevok
        bitmap: can you take a look at the blog post? :)

        • 2022-06-07 15816, 2022

      • reosarevok
        (would like to finish releasing soon)

        • 2022-06-07 15825, 2022

      • bitmap
        sure

        • 2022-06-07 15833, 2022

      • yvanzo
        bitmap: doesn’t it depend on dbmirror2?

        • 2022-06-07 15829, 2022

      • bitmap
        nope, it just stores the index 'events' in pg

        • 2022-06-07 15814, 2022

      • yvanzo
        I closed the ticket as won't do then.

        • 2022-06-07 15812, 2022

      • PrathameshG_ joined the channel

        • 2022-06-07 15848, 2022

      • Leftmost_ joined the channel

        • 2022-06-07 15850, 2022

      • monkey_ joined the channel

        • 2022-06-07 15821, 2022

      • bitmap
        okay, I will still need to document maintenance steps for artwork-indexer more throroughly, but can create tickets for that when needed

        • 2022-06-07 15808, 2022

      • Arsen_ joined the channel

        • 2022-06-07 15830, 2022

      • chrisshepherd_ joined the channel

        • 2022-06-07 15846, 2022

      • bitmap
        reosarevok: the blog post looks good, I think

        • 2022-06-07 15857, 2022

      • reosarevok
        Thanks!

        • 2022-06-07 15817, 2022

      • atj1 joined the channel

        • 2022-06-07 15807, 2022

      • reosarevok
        Oh, I see yvanzo made a small change, thanks too

        • 2022-06-07 15819, 2022

      • yvanzo
        I’m just fixing tickets’ title

        • 2022-06-07 15824, 2022

      • reosarevok
        Ok

        • 2022-06-07 15828, 2022

      • reosarevok
        I'll wait

        • 2022-06-07 15836, 2022

      • yvanzo
        But the editor is too slow for me.

        • 2022-06-07 15843, 2022

      • PrathameshG has quit

        • 2022-06-07 15843, 2022

      • Leftmost has quit

        • 2022-06-07 15844, 2022

      • santiagofn has quit

        • 2022-06-07 15844, 2022

      • ephemer0l has quit

        • 2022-06-07 15844, 2022

      • atj has quit

        • 2022-06-07 15844, 2022

      • chrisshepherd has quit

        • 2022-06-07 15844, 2022

      • monkey has quit

        • 2022-06-07 15845, 2022

      • Arsen has quit

        • 2022-06-07 15845, 2022

      • Leftmost_ is now known as Leftmost

        • 2022-06-07 15845, 2022

      • monkey_ is now known as monkey

        • 2022-06-07 15845, 2022

      • PrathameshG_ is now known as PrathameshG

        • 2022-06-07 15819, 2022

      • qookie has quit

        • 2022-06-07 15820, 2022

      • Arsen_ has quit

        • 2022-06-07 15855, 2022

      • qookie joined the channel

        • 2022-06-07 15858, 2022

      • Arsen joined the channel

        • 2022-06-07 15838, 2022

      • reosarevok
        Just wordpress things

        • 2022-06-07 15827, 2022

      • yvanzo
        reosarevok: done

        • 2022-06-07 15834, 2022

      • reosarevok
        Thanks!

        • 2022-06-07 15812, 2022

      • BrainzGit
        [musicbrainz-docker] release 03v-2022-06-07 has been published by 14yvanzo: https://github.com/metabrainz/musicbrainz-docker/…

        • 2022-06-07 15828, 2022

      • yvanzo
        bitmap: About service usage: I added MBS-12440 to relax requiring Redis only when needed.

        • 2022-06-07 15829, 2022

      • BrainzBot
        MBS-12440: Do not require Redis to mirror the database https://tickets.metabrainz.org/browse/MBS-12440

        • 2022-06-07 15823, 2022

      • santiagofn joined the channel

        • 2022-06-07 15807, 2022

      • bitmap
        yvanzo: makes sense. thanks

        • 2022-06-07 15854, 2022

      • atj1 is now known as atj

        • 2022-06-07 15854, 2022

      • vardan joined the channel

        • 2022-06-07 15831, 2022

      • BrainzGit
        [musicbrainz-server] 14reosarevok merged pull request #2491 (03master…MBS-12312): MBS-12312: Convert annotation templates to React https://github.com/metabrainz/musicbrainz-server/…

        • 2022-06-07 15854, 2022

      • reosarevok
        bitmap, yvanzo: rebased all the stuff in https://github.com/metabrainz/musicbrainz-server/…

        • 2022-06-07 15845, 2022

      • skelly37 has quit

        • 2022-06-07 15808, 2022

      • ephemer0l joined the channel

        • 2022-06-07 15858, 2022

      • qookie has quit

        • 2022-06-07 15806, 2022

      • qookie joined the channel

        • 2022-06-07 15811, 2022

      • qookie has quit

        • 2022-06-07 15820, 2022

      • qookie joined the channel

        • 2022-06-07 15857, 2022

      • odnes has quit

        • 2022-06-07 15850, 2022

      • vardan has quit

        • 2022-06-07 15852, 2022

      • strider has quit

        • 2022-06-07 15846, 2022

      • strider joined the channel

        • 2022-06-07 15820, 2022

      • strider has quit

        • 2022-06-07 15818, 2022

      • strider joined the channel