No, they didn’t extend it, it was supposed to be renewable until Feb 2024.
2022-06-13 16450, 2022
reosarevok
I still prefer sticking to jira unless it's a really really bad idea and/or migrating is really easy
2022-06-13 16410, 2022
alastairp
reosarevok: the problem with post-2024 is that we can't self-host it any more
2022-06-13 16411, 2022
FishQuest
same
2022-06-13 16416, 2022
FishQuest
wat
2022-06-13 16419, 2022
reosarevok
alastairp: sure, I get that
2022-06-13 16419, 2022
mayhem
still, the question stands. what are we migrating to. so in the interest of time I would like us to start thinking about it now. given that migrating away could be a major time sink for us.
2022-06-13 16422, 2022
alastairp
which has user privacy/data issues
2022-06-13 16431, 2022
FishQuest
that doesnt make anysense at all
2022-06-13 16434, 2022
yvanzo
mayhem: right
2022-06-13 16434, 2022
alastairp
reosarevok: sure, just making sure you were aware
2022-06-13 16457, 2022
mayhem
so, I have nothing more concrete to say right now.
2022-06-13 16403, 2022
yvanzo
Jira Cloud is still an option in my opinion, until we find a big issue.
2022-06-13 16403, 2022
alastairp
I've not used any other self-hosted bug trackers since MB used trac
2022-06-13 16411, 2022
mayhem
let us all think about this, knowing that there is a deadline off in the distance.
2022-06-13 16419, 2022
alastairp
not sure what the situation is like these days
2022-06-13 16434, 2022
yvanzo
Maybe even the SSO can be preserved.
2022-06-13 16456, 2022
mayhem
privacy issues remain, however.
2022-06-13 16413, 2022
Freso
Alright, that sounds like this item wrapped up?
2022-06-13 16421, 2022
mayhem
yeah
2022-06-13 16428, 2022
Freso
If so, let’s go back to reviews for skelly37 before un-banging. :)
2022-06-13 16430, 2022
Freso
skelly37: Go!
2022-06-13 16409, 2022
Freso
skelly37: Ping?
2022-06-13 16422, 2022
skelly37
Hello everyone :) Basically I've finished and received good reviews for my pipe logic
2022-06-13 16424, 2022
yellowhatpro
Freso: can I give my last week's review as well? couldnt resist
2022-06-13 16427, 2022
skelly37
So now I'm writing tests
2022-06-13 16405, 2022
skelly37
I have a few things to think over but all the issues are named as TODOs and the project goes smoothly for now
2022-06-13 16413, 2022
skelly37
I think that's all
2022-06-13 16424, 2022
FishQuest
yellowhatpro
2022-06-13 16429, 2022
yvanzo
Thanks everyone!
2022-06-13 16444, 2022
Freso
yellowhatpro:
2022-06-13 16446, 2022
Freso
Go.
2022-06-13 16403, 2022
yellowhatpro
Hello everyone!!
2022-06-13 16403, 2022
yellowhatpro
So last week I got my hands dirty with brainz player integration, read documentations and sample codes for the media player libraries.
2022-06-13 16403, 2022
yellowhatpro
Worked on the music service + notification required for the playback.
2022-06-13 16403, 2022
yellowhatpro
Updated the cb integration pr as well
2022-06-13 16419, 2022
yellowhatpro
Thanks Freso
2022-06-13 16422, 2022
yvanzo
(Oops. Too soon!)
2022-06-13 16430, 2022
yvanzo
Thanks yellowhatpro :)
2022-06-13 16433, 2022
Freso
yellowhatpro: That’s fin? :)
2022-06-13 16450, 2022
yellowhatpro
Yeah that's it for now
2022-06-13 16455, 2022
Freso
Alright!
2022-06-13 16408, 2022
yvanzo
mayhem: I confirm that SSO would still work with Jira Cloud. (The add-on we are currently using is available on Jira Cloud too.)
2022-06-13 16424, 2022
yvanzo
But the privacy issues remain.
2022-06-13 16426, 2022
Freso
That’s that for today’s meeting then. Thank you all for your time! Remember to stay hydrated, wear sunscreen, and wear your mask!
2022-06-13 16430, 2022
Freso
</BANG>
2022-06-13 16434, 2022
zas
I wonder if there are many tools (open source preferably) around that can match most of the features of Jira, so we don't lose too much if we migrate. Also the existence of tools to actually import from Jira would be a good thing... Perhaps we should start to list "must-have" features, it would help to restrict options.
2022-06-13 16432, 2022
FishQuest
at this point we could just concede we should mke ticketbrainz...
zas: yes, knowing what features we use is a good idea. for example, I know that in CB and LB I believe that we don't use very many advanced workflow features, I suspect that something almost as simple as GH issues would be OK for this, but for other projects maybe not
2022-06-13 16436, 2022
alastairp
zas: https://test.acousticbrainz.org/ is working with nginx-proxy. I'm currently testing `pg_dump | ssh flobot psql` as a method of dumping the database, it works but I need to benchmark transfer time.
yvanzo: I'll wait for that review, then release, I think :)
2022-06-13 16415, 2022
yvanzo
reosarevok: I don’t really see why instrumental and karaoke would have to be exclusive to each other.
2022-06-13 16450, 2022
skelly37 has quit
2022-06-13 16458, 2022
reosarevok
Because the way we define instrumental for the attribute since the beginning is "lyrics are not relevant for this recording"
2022-06-13 16407, 2022
yvanzo
It seems that the recordings that would be listed by this report are missing a “karaoke” performance relationship to the work, but the “instrumental” performance relationship doesn’t necessarily have to be deleted.
2022-06-13 16429, 2022
yvanzo
reosarevok: Indeed, the way it is defined in MusicBrainz seems to be problematic.
2022-06-13 16402, 2022
reosarevok
The whole point was to have a way to indicate to data users "you can ignore lyrics-related stuff for this recording"
2022-06-13 16435, 2022
FishQuest
karaoke is something that usually has lyrics but here we havea version witotuh while insturmntal never had lyrics
2022-06-13 16444, 2022
reosarevok
The only reason we added karaoke separately for recording-work was to have a separate option for karaoke :)
2022-06-13 16452, 2022
FishQuest
karaoke always is a version of something that has lyrics
2022-06-13 16457, 2022
reosarevok
So that when the lyrics *are* wanted but it's instrumental, we can use it
2022-06-13 16411, 2022
reosarevok
FishQuest: "instrumental" as a recording-work attribute is also only for stuff with lyrics, really
2022-06-13 16422, 2022
reosarevok
(otherwise there's no use for it, since it's instrumental by definition)
2022-06-13 16428, 2022
FishQuest
hmm
2022-06-13 16452, 2022
reosarevok
The difference is "karaoke" -> the recording is instrumental, but we care about lyrics data, "instrumental" -> the recording is instrumental and we do *not* care about lyrics data
2022-06-13 16402, 2022
FishQuest
yes
2022-06-13 16453, 2022
reosarevok
So they're explicitly meant to be mutually exclusive by design :)
2022-06-13 16401, 2022
FishQuest
yea
2022-06-13 16449, 2022
reosarevok
(both of these are only meant to be used with works that have lyrics to begin with, since if not they're already [no lyrics])
2022-06-13 16408, 2022
yvanzo
If you were to allow both at the same time, you could have “instrumental”-only to still be what it currently is, “karaoke”-only to be karaoke recordings that have some vocals but still allows you to sing on top of it, and “karaoke”+“instrumental” to have no vocals and allow you to sing on top of it. It would require to adjust the definitions.
2022-06-13 16444, 2022
reosarevok
Maybe so, but nobody who deals with karaoke has ever asked for the distinction, really :)
2022-06-13 16459, 2022
reosarevok
So it seems like a lot of effort for no big gain. If that changes, we could consider it
2022-06-13 16410, 2022
skelly37 joined the channel
2022-06-13 16442, 2022
FishQuest
yea that doesnt make sense to me
2022-06-13 16413, 2022
yvanzo
The benefit is not this distinction, it is to have a definition of “instrumental” that is closer to the common meaning: no vocals.
2022-06-13 16457, 2022
reosarevok
But then we'd also expect to set it for every [no lyrics] work :)
2022-06-13 16429, 2022
FishQuest
except that karaoke *can *have some lyrics, but it doesnt make sense for karaoke to separate *completely no lyrics*and *some lyrics*
2022-06-13 16435, 2022
reosarevok
I mean, we could rename the attribute if you have a better idea, tbh
2022-06-13 16447, 2022
reosarevok
I just don't, but I feel it's useful to have a "ignore lyrics" attribute :)
2022-06-13 16432, 2022
FishQuest
+1
2022-06-13 16447, 2022
reosarevok
(or well, other people who asked for it feel it's useful :D I don't care too much myself, but I can see the usefulness)
2022-06-13 16452, 2022
reosarevok
I totally understand the "the name as written is a bit confusing" angle though :) It's similar with "recording" which is not literally a 1:1 map with things that are recorded
2022-06-13 16400, 2022
reosarevok
It's just I don't have a better name
2022-06-13 16433, 2022
yvanzo
Is there any issue with the proposed solution?
2022-06-13 16454, 2022
reosarevok
You'd have to ask the karaoke people :)
2022-06-13 16423, 2022
reosarevok
If you want to start a discussion about it and get opinions, we can postpone merging this
2022-06-13 16456, 2022
reosarevok
It's not really urgent anyway, so :)
2022-06-13 16433, 2022
yvanzo
Indexed search doesn’t allow to filter by relationship attribute, that would not cause a regression here at least.
2022-06-13 16456, 2022
reosarevok
The main issue I can see from my side is that if someone is currently operating under the assumption (with their app or whatever) that instrumental -> automatically ignore lyrics, we would break that by having some which have instrumental but should not get lyrics ignored
2022-06-13 16423, 2022
yvanzo
Yes
2022-06-13 16428, 2022
reosarevok
But not sure if there's an issue from the actual understanding / style POW, not without asking the people who use instrumental and karaoke often :)
2022-06-13 16459, 2022
FishQuest
I know *I* don't want a conflation of the two
2022-06-13 16401, 2022
yvanzo
reosarevok: Made a comment, let’s postpone merging it.
alastairp: mayhem: fyi, my laptop is having display issues again. while waiting for the display to be replaced (probably this entire week), i am on a spare machine. don't have ssh keys on this one so currently don't have access to MeB infra.
2022-06-13 16432, 2022
lucifer
if needed, i can create a new key and someone can add it to servers till the situation is resolved.
2022-06-13 16444, 2022
alastairp
lucifer: ok, ping me if you need me to do anything for you
2022-06-13 16438, 2022
lucifer
thanks, will do!
2022-06-13 16427, 2022
mayhem
Ok, I'm around so should be ok.
2022-06-13 16445, 2022
BrainzGit
[listenbrainz-server] 14chinmaykunkikar opened pull request #2039 (03master…listens-page-updates): Add useful messages and call to actions for empty states on listens page https://github.com/metabrainz/listenbrainz-server…